FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 151 |
34 |
0 |
53 |
fr.paris.lutece.plugins.suggest.business.Category
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.business.Category defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
103 |
Medium |
fr.paris.lutece.plugins.suggest.business.CommentSubmit
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.business.CommentSubmit.getDateComment() may expose internal representation by returning CommentSubmit._tDateComment |
MALICIOUS_CODE |
EI_EXPOSE_REP |
118 |
Medium |
| fr.paris.lutece.plugins.suggest.business.CommentSubmit.getDateModify() may expose internal representation by returning CommentSubmit._tDateModify |
MALICIOUS_CODE |
EI_EXPOSE_REP |
251 |
Medium |
| fr.paris.lutece.plugins.suggest.business.CommentSubmit.setDateComment(Timestamp) may expose internal representation by storing an externally mutable object into CommentSubmit._tDateComment |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
129 |
Medium |
| fr.paris.lutece.plugins.suggest.business.CommentSubmit.setDateModify(Timestamp) may expose internal representation by storing an externally mutable object into CommentSubmit._tDateModify |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
262 |
Medium |
fr.paris.lutece.plugins.suggest.business.ExportFormat
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.business.ExportFormat.getXsl() may expose internal representation by returning ExportFormat._xsl |
MALICIOUS_CODE |
EI_EXPOSE_REP |
118 |
Medium |
| fr.paris.lutece.plugins.suggest.business.ExportFormat.setXsl(byte[]) may expose internal representation by storing an externally mutable object into ExportFormat._xsl |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
129 |
Medium |
fr.paris.lutece.plugins.suggest.business.ReportedMessage
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.business.ReportedMessage.getDateReported() may expose internal representation by returning ReportedMessage._tDateReported |
MALICIOUS_CODE |
EI_EXPOSE_REP |
77 |
Medium |
| fr.paris.lutece.plugins.suggest.business.ReportedMessage.setDateReported(Timestamp) may expose internal representation by storing an externally mutable object into ReportedMessage._tDateReported |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
88 |
Medium |
fr.paris.lutece.plugins.suggest.business.SubmitFilter
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.business.SubmitFilter.getDateFirst() may expose internal representation by returning SubmitFilter._tDateFirst |
MALICIOUS_CODE |
EI_EXPOSE_REP |
239 |
Medium |
| fr.paris.lutece.plugins.suggest.business.SubmitFilter.getDateLast() may expose internal representation by returning SubmitFilter._tDateLast |
MALICIOUS_CODE |
EI_EXPOSE_REP |
268 |
Medium |
| fr.paris.lutece.plugins.suggest.business.SubmitFilter.setDateFirst(Timestamp) may expose internal representation by storing an externally mutable object into SubmitFilter._tDateFirst |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
250 |
Medium |
| fr.paris.lutece.plugins.suggest.business.SubmitFilter.setDateLast(Timestamp) may expose internal representation by storing an externally mutable object into SubmitFilter._tDateLast |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
279 |
Medium |
fr.paris.lutece.plugins.suggest.business.Suggest
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.business.Suggest.getDateCreation() may expose internal representation by returning Suggest._tDateCreation |
MALICIOUS_CODE |
EI_EXPOSE_REP |
385 |
Medium |
| fr.paris.lutece.plugins.suggest.business.Suggest.setDateCreation(Timestamp) may expose internal representation by storing an externally mutable object into Suggest._tDateCreation |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
396 |
Medium |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.suggest.business.Suggest._listenerRegularExpression in fr.paris.lutece.plugins.suggest.business.Suggest.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
166-168 |
Medium |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.suggest.business.Suggest._listenerRole in fr.paris.lutece.plugins.suggest.business.Suggest.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
172-174 |
Medium |
| Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.suggest.business.Suggest._listenerWorkgroup in fr.paris.lutece.plugins.suggest.business.Suggest.init() |
MT_CORRECTNESS |
LI_LAZY_INIT_UPDATE_STATIC |
160-162 |
Medium |
fr.paris.lutece.plugins.suggest.business.SuggestSubmit
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getDateResponse() may expose internal representation by returning SuggestSubmit._tDateResponse |
MALICIOUS_CODE |
EI_EXPOSE_REP |
197 |
Medium |
| fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setDateResponse(Timestamp) may expose internal representation by storing an externally mutable object into SuggestSubmit._tDateResponse |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
208 |
Medium |
fr.paris.lutece.plugins.suggest.business.SuggestSubmitType
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.business.SuggestSubmitType defines equals but not hashCode |
BAD_PRACTICE |
HE_EQUALS_NO_HASHCODE |
188 |
Medium |
fr.paris.lutece.plugins.suggest.business.VideoType
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.business.VideoType.getVideo() may expose internal representation by returning VideoType._video |
MALICIOUS_CODE |
EI_EXPOSE_REP |
119 |
Medium |
| fr.paris.lutece.plugins.suggest.business.VideoType.setVideo(byte[]) may expose internal representation by storing an externally mutable object into VideoType._video |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
111 |
Medium |
fr.paris.lutece.plugins.suggest.business.VoteButton
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.business.VoteButton.getIconContent() may expose internal representation by returning VoteButton._byIconContent |
MALICIOUS_CODE |
EI_EXPOSE_REP |
135 |
Medium |
| fr.paris.lutece.plugins.suggest.business.VoteButton.setIconContent(byte[]) may expose internal representation by storing an externally mutable object into VoteButton._byIconContent |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
146 |
Medium |
fr.paris.lutece.plugins.suggest.service.search.SuggestIndexer
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.suggest.service.search.SuggestIndexer.getDocument(SuggestSubmit, String): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
260 |
High |
fr.paris.lutece.plugins.suggest.service.subscription.SuggestSubscriptionProviderService
| Bug |
Category |
Details |
Line |
Priority |
| There is an apparent infinite recursive loop in fr.paris.lutece.plugins.suggest.service.subscription.SuggestSubscriptionProviderService.getSubscriptionHtmlDescriptionBis(LuteceUser, String, String, Locale, String) |
CORRECTNESS |
IL_INFINITE_RECURSIVE_LOOP |
375 |
High |
| Incorrect lazy initialization of static field fr.paris.lutece.plugins.suggest.service.subscription.SuggestSubscriptionProviderService._instance in fr.paris.lutece.plugins.suggest.service.subscription.SuggestSubscriptionProviderService.getService() |
MT_CORRECTNESS |
LI_LAZY_INIT_STATIC |
82-86 |
Medium |
fr.paris.lutece.plugins.suggest.service.suggestsearch.SuggestLuceneSearchEngine
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in fr.paris.lutece.plugins.suggest.service.suggestsearch.SuggestLuceneSearchEngine.getSearchResults(String, SubmitFilter) |
STYLE |
REC_CATCH_EXCEPTION |
135 |
Medium |
fr.paris.lutece.plugins.suggest.web.ResourceValueObject
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.suggest.web.ResourceValueObject.getContent() may expose internal representation by returning ResourceValueObject._content |
MALICIOUS_CODE |
EI_EXPOSE_REP |
75 |
Medium |
| fr.paris.lutece.plugins.suggest.web.ResourceValueObject.setContent(byte[]) may expose internal representation by storing an externally mutable object into ResourceValueObject._content |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
86 |
Medium |
fr.paris.lutece.plugins.suggest.web.SuggestApp
| Bug |
Category |
Details |
Line |
Priority |
| Nullcheck of suggest at line 606 of value previously dereferenced in fr.paris.lutece.plugins.suggest.web.SuggestApp.getViewCreateSubComment(XPage, int, HttpServletRequest) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
606 |
Medium |
fr.paris.lutece.plugins.suggest.web.SuggestJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to plugin in fr.paris.lutece.plugins.suggest.web.SuggestJspBean.doRemoveSuggest(HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
2405 |
Medium |
| Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.suggest.web.SuggestJspBean.doSubmitOfficialAnswer(HttpServletRequest) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
1437 |
High |
