The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method 'setIdSuggest' called during object construction | 59 |
| ConstructorCallsOverridableMethod | Overridable method 'setIdSuggestSubmit' called during object construction | 60 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 49–123 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'acceptHTML' doesn't match '_[a-z][a-zA-Z0-9]*' | 75 |
| FieldNamingConventions | The field name 'acceptBBCode' doesn't match '_[a-z][a-zA-Z0-9]*' | 78 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_cache' doesn't match '[A-Z][A-Z_0-9]*' | 60 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'texto' | 118 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'texto' | 118 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'string' | 137 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'content' | 227 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'content' | 227 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'content' | 227 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'content' | 227 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'content' | 248 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'equals(Object)' is missing an @Override annotation. | 101–105 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 101 |
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 112–115 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 122–125 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'selectListByFilter(SubmitFilter, Integer, Plugin)' has an NPath complexity of 2448 | 209–296 |
| CyclomaticComplexity | The method 'selectListByFilter(SubmitFilter, Integer, Plugin)' has a cyclomatic complexity of 13. | 209–296 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 247 |
| CyclomaticComplexity | The method 'selectCountByFilter(SubmitFilter, Plugin)' has a cyclomatic complexity of 10. | 337–396 |
| NPathComplexity | The method 'selectCountByFilter(SubmitFilter, Plugin)' has an NPath complexity of 408 | 337–396 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 448 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 178–181 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 188–191 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getComment()' is missing an @Override annotation. | 111–114 |
| MissingOverride | The method 'getEntryType()' is missing an @Override annotation. | 119–122 |
| MissingOverride | The method 'getHelpMessage()' is missing an @Override annotation. | 127–130 |
| MissingOverride | The method 'getIdEntry()' is missing an @Override annotation. | 135–138 |
| MissingOverride | The method 'getPosition()' is missing an @Override annotation. | 143–146 |
| MissingOverride | The method 'getTitle()' is missing an @Override annotation. | 151–154 |
| MissingOverride | The method 'isMandatory()' is missing an @Override annotation. | 159–162 |
| MissingOverride | The method 'isShowInSuggestSubmitList()' is missing an @Override annotation. | 167–170 |
| MissingOverride | The method 'setComment(String)' is missing an @Override annotation. | 178–181 |
| MissingOverride | The method 'setEntryType(EntryType)' is missing an @Override annotation. | 189–192 |
| MissingOverride | The method 'setHelpMessage(String)' is missing an @Override annotation. | 200–203 |
| MissingOverride | The method 'setIdEntry(int)' is missing an @Override annotation. | 211–214 |
| MissingOverride | The method 'setShowInSuggestSubmitList(boolean)' is missing an @Override annotation. | 222–225 |
| MissingOverride | The method 'setMandatory(boolean)' is missing an @Override annotation. | 233–236 |
| MissingOverride | The method 'setPosition(int)' is missing an @Override annotation. | 244–247 |
| MissingOverride | The method 'setTitle(String)' is missing an @Override annotation. | 255–258 |
| MissingOverride | The method 'getSuggest()' is missing an @Override annotation. | 264–267 |
| MissingOverride | The method 'setSuggest(Suggest)' is missing an @Override annotation. | 275–278 |
| MissingOverride | The method 'getRegularExpressionList()' is missing an @Override annotation. | 284–287 |
| MissingOverride | The method 'setRegularExpressionList(List)' is missing an @Override annotation. | 295–298 |
| MissingOverride | The method 'getDefaultValue()' is missing an @Override annotation. | 304–307 |
| MissingOverride | The method 'setDefaultValue(String)' is missing an @Override annotation. | 315–318 |
| MissingOverride | The method 'getWidth()' is missing an @Override annotation. | 324–327 |
| MissingOverride | The method 'setWidth(int)' is missing an @Override annotation. | 335–338 |
| MissingOverride | The method 'getHeight()' is missing an @Override annotation. | 344–347 |
| MissingOverride | The method 'setHeight(int)' is missing an @Override annotation. | 355–358 |
| MissingOverride | The method 'getMaxSizeEnter()' is missing an @Override annotation. | 364–367 |
| MissingOverride | The method 'setMaxSizeEnter(int)' is missing an @Override annotation. | 375–378 |
| MissingOverride | The method 'getTemplateHtmlCodeForm()' is missing an @Override annotation. | 386–389 |
| MissingOverride | The method 'getTemplateHtmlCodeResponse()' is missing an @Override annotation. | 396–399 |
| MissingOverride | The method 'getRequestData(HttpServletRequest, Locale)' is missing an @Override annotation. | 410–413 |
| MissingOverride | The method 'getResponseData(HttpServletRequest, List, Locale)' is missing an @Override annotation. | 426–429 |
| MissingOverride | The method 'getResponseData(int, HttpServletRequest, List, Locale, Plugin)' is missing an @Override annotation. | 446–449 |
| MissingOverride | The method 'getTemplateCreate()' is missing an @Override annotation. | 456–459 |
| MissingOverride | The method 'getTemplateModify()' is missing an @Override annotation. | 466–469 |
| MissingOverride | The method 'getPaginator(int, String, String, String)' is missing an @Override annotation. | 484–487 |
| MissingOverride | The method 'getReferenceListRegularExpression(IEntry, Plugin)' is missing an @Override annotation. | 498–501 |
| MissingOverride | The method 'getEntryAdditionalAttributeList()' is missing an @Override annotation. | 507–510 |
| MissingOverride | The method 'setEntryAdditionalAttributeList(List)' is missing an @Override annotation. | 518–521 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(EntryAdditionalAttribute, Plugin)' is missing an @Override annotation. | 61–71 |
| MissingOverride | The method 'selectEntryAdditionalAttributeList(int, Plugin)' is missing an @Override annotation. | 82–102 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 112–119 |
| MissingOverride | The method 'store(EntryAdditionalAttribute, Plugin)' is missing an @Override annotation. | 129–139 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 47–481 |
| MissingOverride | The method 'insert(IEntry, Plugin)' is missing an @Override annotation. | 136–160 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 171–224 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 234–241 |
| MissingOverride | The method 'store(IEntry, Plugin)' is missing an @Override annotation. | 251–272 |
| MissingOverride | The method 'selectEntryListByFilter(EntryFilter, Plugin)' is missing an @Override annotation. | 283–347 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 291 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 293 |
| MissingOverride | The method 'selectNumberEntryByFilter(EntryFilter, Plugin)' is missing an @Override annotation. | 358–386 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 362 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 364 |
| MissingOverride | The method 'deleteVerifyBy(int, int, Plugin)' is missing an @Override annotation. | 398–406 |
| MissingOverride | The method 'insertVerifyBy(int, int, Plugin)' is missing an @Override annotation. | 418–426 |
| MissingOverride | The method 'selectListRegularExpressionKeyByIdEntry(int, Plugin)' is missing an @Override annotation. | 437–453 |
| MissingOverride | The method 'isRegularExpressionIsUse(int, Plugin)' is missing an @Override annotation. | 464–480 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 172–175 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 61–80 |
| MissingOverride | The method 'select(Plugin)' is missing an @Override annotation. | 89–110 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 71–74 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 88–163 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 91 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 92 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 93 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 94 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 95 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 96 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 97 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 99 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 100 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 213–231 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 85–163 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 90 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 91 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 93 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 94 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 96 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 97 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has an NPath complexity of 336 | 83–169 |
| CyclomaticComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has a cyclomatic complexity of 13. | 83–169 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 86 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 87 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 92 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 93 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 95 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 96 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 97 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 85–163 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 90 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 91 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 93 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 94 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 96 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 97 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveMethodLength | Avoid really long methods. | 96–204 |
| NcssCount | The method 'getRequestData(HttpServletRequest, Locale)' has a NCSS line count of 64. | 96–204 |
| CyclomaticComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 96–204 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 99 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 100 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 101 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 102 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 103 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 104 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 105 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 106 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 107 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 108 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 109 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 110 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 112 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 113 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 256–334 |
| AvoidDuplicateLiterals | The String literal "');" appears 6 times in this file; the first occurrence is on line 300 | 300 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 306 |
| Rule | Violation | Line |
|---|---|---|
| MethodReturnsInternalArray | Returning '_xsl' may expose an internal array. | 118 |
| ArrayIsStoredDirectly | The user-supplied array 'donnees' is stored directly. | 127 |
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 137–140 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 147–150 |
| AddEmptyString | Do not add empty strings | 149 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 91–103 |
| MissingOverride | The method 'insert(ExportFormat, Plugin)' is missing an @Override annotation. | 91–103 |
| Rule | Violation | Line |
|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The getter 'getXml' should not return void linguistically | 359 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 52–65 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 42–171 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 104–111 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 221–228 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 256 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 257 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 258 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–118 |
| CommentRequired | Public method and constructor comments are required | 49–52 |
| CommentRequired | Public method and constructor comments are required | 54–57 |
| CommentRequired | Public method and constructor comments are required | 59–62 |
| CommentRequired | Public method and constructor comments are required | 64–67 |
| CommentRequired | Public method and constructor comments are required | 69–72 |
| CommentRequired | Public method and constructor comments are required | 74–77 |
| CommentRequired | Public method and constructor comments are required | 79–82 |
| CommentRequired | Public method and constructor comments are required | 84–87 |
| CommentRequired | Public method and constructor comments are required | 89–92 |
| CommentRequired | Public method and constructor comments are required | 94–97 |
| CommentRequired | Public method and constructor comments are required | 99–102 |
| CommentRequired | Public method and constructor comments are required | 104–107 |
| CommentRequired | Public method and constructor comments are required | 109–112 |
| CommentRequired | Public method and constructor comments are required | 114–117 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–581 |
| TooManyFields | Too many fields | 47–581 |
| GodClass | Possible God Class (WMC=55, ATFD=6, TCC=9.224%) | 47–581 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 48–581 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_strLuteceUserKey' | 83 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–1532 |
| TooManyFields | Too many fields | 59–1532 |
| CyclomaticComplexity | The class 'Suggest' has a total cyclomatic complexity of 136 (highest 4). | 59–1532 |
| ExcessiveClassLength | Avoid really long classes. | 59–1532 |
| NonThreadSafeSingleton | Singleton is not thread safe | 160–164 |
| NonThreadSafeSingleton | Singleton is not thread safe | 166–170 |
| NonThreadSafeSingleton | Singleton is not thread safe | 172–176 |
| MissingOverride | The method 'getWorkgroup()' is missing an @Override annotation. | 303–306 |
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 404–407 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 414–417 |
| AddEmptyString | Do not add empty strings | 416 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getPermission()' is missing an @Override annotation. | 186–189 |
| MissingOverride | The method 'setLocale(Locale)' is missing an @Override annotation. | 208–211 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'selectActionsBySuggestState(int, Plugin)' is missing an @Override annotation. | 59–82 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'selectSuggestList(SuggestFilter, Plugin)' has an NPath complexity of 528 | 374–492 |
| NcssCount | The method 'selectSuggestList(SuggestFilter, Plugin)' has a NCSS line count of 81. | 374–492 |
| CyclomaticComplexity | The method 'selectSuggestList(SuggestFilter, Plugin)' has a cyclomatic complexity of 10. | 374–492 |
| ExcessiveMethodLength | Avoid really long methods. | 374–492 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 525 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'entry' | 112 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 147–154 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 58–68 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 79–83 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 58–76 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 70–73 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 87–91 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–748 |
| TooManyFields | Too many fields | 56–748 |
| GodClass | Possible God Class (WMC=63, ATFD=9, TCC=1.633%) | 56–748 |
| CyclomaticComplexity | The method 'getXml(HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 442–501 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 450–451 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 452–453 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 156–163 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 173–180 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 187–194 |
| MissingOverride | The method 'store(SuggestSubmit, Plugin)' is missing an @Override annotation. | 257–312 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 267–274 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 284–291 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 298–305 |
| NcssCount | The method 'selectListByFilter(SubmitFilter, Plugin)' has a NCSS line count of 65. | 324–469 |
| ExcessiveMethodLength | Avoid really long methods. | 324–469 |
| CyclomaticComplexity | The method 'selectListByFilter(SubmitFilter, Plugin)' has a cyclomatic complexity of 25. | 324–469 |
| NPathComplexity | The method 'selectListByFilter(SubmitFilter, Plugin)' has an NPath complexity of 12589056 | 324–469 |
| CyclomaticComplexity | The method 'selectIdListByFilter(SubmitFilter, Plugin)' has a cyclomatic complexity of 27. | 481–633 |
| NcssCount | The method 'selectIdListByFilter(SubmitFilter, Plugin)' has a NCSS line count of 69. | 481–633 |
| NPathComplexity | The method 'selectIdListByFilter(SubmitFilter, Plugin)' has an NPath complexity of 50343936 | 481–633 |
| ExcessiveMethodLength | Avoid really long methods. | 481–633 |
| NPathComplexity | The method 'selectCountByFilter(SubmitFilter, Plugin)' has an NPath complexity of 25171968 | 645–791 |
| CyclomaticComplexity | The method 'selectCountByFilter(SubmitFilter, Plugin)' has a cyclomatic complexity of 26. | 645–791 |
| ExcessiveMethodLength | Avoid really long methods. | 645–791 |
| NcssCount | The method 'selectCountByFilter(SubmitFilter, Plugin)' has a NCSS line count of 66. | 645–791 |
| CyclomaticComplexity | The method 'getOrderBy(List)' has a cyclomatic complexity of 17. | 800–890 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 877 |
| MissingOverride | The method 'storeSuggestSubmitOrder(int, int, Plugin)' is missing an @Override annotation. | 905–913 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 148–151 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 158–161 |
| AddEmptyString | Do not add empty strings | 160 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 186 |
| MissingOverride | The method 'equals(Object)' is missing an @Override annotation. | 186–189 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(SuggestSubmitType, Plugin)' is missing an @Override annotation. | 100–125 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 112–119 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 136–152 |
| MissingOverride | The method 'selectList(Plugin)' is missing an @Override annotation. | 161–176 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 186–193 |
| MissingOverride | The method 'store(SuggestSubmitType, Plugin)' is missing an @Override annotation. | 203–225 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 212–219 |
| MissingOverride | The method 'selectListByIdSuggest(int, Plugin)' is missing an @Override annotation. | 259–275 |
| MissingOverride | The method 'isAssociateToSuggest(int, Plugin)' is missing an @Override annotation. | 286–295 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 99–106 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–154 |
| CommentRequired | Public method and constructor comments are required | 47–50 |
| CommentRequired | Public method and constructor comments are required | 52–55 |
| CommentRequired | Public method and constructor comments are required | 57–60 |
| CommentRequired | Public method and constructor comments are required | 62–65 |
| CommentRequired | Public method and constructor comments are required | 67–70 |
| CommentRequired | Public method and constructor comments are required | 72–75 |
| CommentRequired | Public method and constructor comments are required | 77–80 |
| CommentRequired | Public method and constructor comments are required | 82–85 |
| CommentRequired | Public method and constructor comments are required | 87–90 |
| CommentRequired | Public method and constructor comments are required | 92–95 |
| CommentRequired | Public method and constructor comments are required | 97–100 |
| CommentRequired | Public method and constructor comments are required | 102–105 |
| MissingOverride | The method 'toString()' is missing an @Override annotation. | 150–153 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 39–133 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 58–71 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 82–86 |
| Rule | Violation | Line |
|---|---|---|
| ArrayIsStoredDirectly | The user-supplied array 'video' is stored directly. | 109 |
| MethodReturnsInternalArray | Returning '_video' may expose an internal array. | 119 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(VideoType, Plugin)' is missing an @Override annotation. | 64–85 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 77 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 79 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 96–117 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 127–134 |
| MissingOverride | The method 'store(VideoType, Plugin)' is missing an @Override annotation. | 144–155 |
| Rule | Violation | Line |
|---|---|---|
| MethodReturnsInternalArray | Returning '_byIconContent' may expose an internal array. | 135 |
| ArrayIsStoredDirectly | The user-supplied array 'iconContent' is stored directly. | 144 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(Vote, Plugin)' is missing an @Override annotation. | 65–73 |
| MissingOverride | The method 'selectVoteByIdSuggestSubmit(int, Plugin)' is missing an @Override annotation. | 84–106 |
| MissingOverride | The method 'selectCountVoteByIdSuggestSubmitAndLuteceUserKey(int, String, Plugin)' is missing an @Override annotation. | 119–136 |
| MissingOverride | The method 'selectCountVoteByIdSuggestSubmit(int, Plugin)' is missing an @Override annotation. | 147–163 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 67–89 |
| MissingOverride | The method 'select(Plugin)' is missing an @Override annotation. | 98–121 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 56–75 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 58 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 80–93 |
| MissingOverride | The method 'insert(int, String, Object, Plugin)' is missing an @Override annotation. | 80–93 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 88 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 88 |
| MissingOverride | The method 'remove(int, Plugin)' is missing an @Override annotation. | 98–105 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–893 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 317 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 334 |
| AvoidDuplicateLiterals | The String literal "<div[^>]+>" appears 7 times in this file; the first occurrence is on line 347 | 347 |
| AvoidDuplicateLiterals | The String literal "</div>" appears 7 times in this file; the first occurrence is on line 347 | 347 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 374 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 418–427 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 429 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 449–458 |
| NcssCount | The method 'createHtmlRss()' has a NCSS line count of 77. | 472–605 |
| ExcessiveMethodLength | Avoid really long methods. | 472–605 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 519–526 |
| NcssCount | The method 'getFeed()' has a NCSS line count of 99. | 611–803 |
| ExcessiveMethodLength | Avoid really long methods. | 611–803 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 651 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 681 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 683–690 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 767 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 821 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 65–78 |
| MissingOverride | The method 'insert(SuggestResourceRssConfig, Plugin)' is missing an @Override annotation. | 65–78 |
| MissingOverride | The method 'store(SuggestResourceRssConfig, Plugin)' is missing an @Override annotation. | 88–102 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 114–137 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 147–154 |
| MissingOverride | The method 'loadAll(Plugin)' is missing an @Override annotation. | 163–186 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 62–65 |
| MissingOverride | The method 'register()' is missing an @Override annotation. | 70–83 |
| ShortVariable | Avoid variables with short names like rt | 72 |
| ShortVariable | Avoid variables with short names like p | 78 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 92–95 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 106–122 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 45–183 |
| NonThreadSafeSingleton | Singleton is not thread safe | 176–179 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 58–61 |
| MissingOverride | The method 'register()' is missing an @Override annotation. | 66–79 |
| ShortVariable | Avoid variables with short names like rt | 68 |
| ShortVariable | Avoid variables with short names like p | 74 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 88–91 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 102–105 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 61–64 |
| MissingOverride | The method 'register()' is missing an @Override annotation. | 69–82 |
| ShortVariable | Avoid variables with short names like rt | 71 |
| ShortVariable | Avoid variables with short names like p | 77 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 91–94 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 105–121 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'TAG_FILE_RESOURCE'. | 41 |
| UnusedPrivateField | Avoid unused private fields such as 'TAG_DOCUMENT_ID'. | 42 |
| UnusedPrivateField | Avoid unused private fields such as 'TAG_ATTRIBUTE_ID'. | 43 |
| UnusedPrivateField | Avoid unused private fields such as 'TAG_CONTENT_TYPE'. | 44 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getCreateTemplate method if you want a default access modifier | 53–56 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 53–56 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getModifyTemplate method if you want a default access modifier | 63–66 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 63–66 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 73–76 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getCreateParametersTemplate method if you want a default access modifier | 73–76 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 83–86 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getModifyParametersTemplate method if you want a default access modifier | 83–86 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–130 |
| AvoidDuplicateLiterals | The String literal "suggest.transactionManager" appears 7 times in this file; the first occurrence is on line 55 | 55 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 50–297 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 51–297 |
| AvoidDuplicateLiterals | The String literal "suggest.transactionManager" appears 8 times in this file; the first occurrence is on line 63 | 63 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 48–52 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getCreateTemplate method if you want a default access modifier | 49–52 |
| Rule | Violation | Line |
|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the ImageService constructor if you want a default access modifier | 55–58 |
| MissingOverride | The method 'getImageResource(int)' is missing an @Override annotation. | 77–80 |
| MissingOverride | The method 'getResourceTypeId()' is missing an @Override annotation. | 87–90 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 46–49 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getXPageTheme(HttpServletRequest)' is missing an @Override annotation. | 72–76 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 90–93 |
| MissingOverride | The method 'register()' is missing an @Override annotation. | 98–142 |
| ShortVariable | Avoid variables with short names like rt | 100 |
| ShortVariable | Avoid variables with short names like p | 106 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 151–162 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 173–189 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 124–125 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–561 |
| CommentRequired | Header comments are required | 70–561 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 71–561 |
| AvoidDuplicateLiterals | The String literal "suggest.transactionManager" appears 6 times in this file; the first occurrence is on line 79 | 79 |
| CyclomaticComplexity | The method 'updateSuggestSubmitOrder(Integer, Integer, int, boolean, Plugin)' has a cyclomatic complexity of 12. | 203–235 |
| CollapsibleIfStatements | These nested if statements could be combined | 220–224 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 350–365 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 376–393 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 404–419 |
| NonThreadSafeSingleton | Singleton is not thread safe | 441–444 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 555 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 46–49 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 59–62 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'run()' is missing an @Override annotation. | 47–50 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'suggestSubmit' | 103 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–351 |
| MissingOverride | The method 'getDescription()' is missing an @Override annotation. | 105–108 |
| MissingOverride | The method 'indexDocuments()' is missing an @Override annotation. | 120–163 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 148 |
| MissingOverride | The method 'getDocuments(String)' is missing an @Override annotation. | 178–201 |
| ShortVariable | Avoid variables with short names like ft | 222 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 240 |
| ShortVariable | Avoid variables with short names like sb | 269 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 299–302 |
| MissingOverride | The method 'getVersion()' is missing an @Override annotation. | 309–312 |
| MissingOverride | The method 'isEnable()' is missing an @Override annotation. | 319–331 |
| MissingOverride | The method 'getListType()' is missing an @Override annotation. | 336–342 |
| MissingOverride | The method 'getSpecificSearchAppUrl()' is missing an @Override annotation. | 347–350 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–488 |
| NPathComplexity | The method 'run()' has an NPath complexity of 1478 | 88–213 |
| ExcessiveMethodLength | Avoid really long methods. | 88–213 |
| CyclomaticComplexity | The method 'run()' has a cyclomatic complexity of 31. | 88–213 |
| NcssCount | The method 'run()' has a NCSS line count of 61. | 88–213 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 107 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 124–144 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 143 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 161–180 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 187–205 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 348 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 356–357 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 458 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 465–466 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 61–377 |
| NonThreadSafeSingleton | Singleton is not thread safe | 82–88 |
| CyclomaticComplexity | The method 'getSubscriptionHtmlDescription(LuteceUser, String, String, Locale)' has a cyclomatic complexity of 10. | 106–157 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 145–152 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getSearchResults(String, SubmitFilter)' is missing an @Override annotation. | 73–141 |
| ShortVariable | Avoid variables with short names like ir | 80 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 120 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 121 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 122 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 127–133 |
| ShortVariable | Avoid variables with short names like si | 131 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 135 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 65–68 |
| CyclomaticComplexity | The method 'getSearchResults(String, SubmitFilter, Plugin)' has a cyclomatic complexity of 11. | 84–113 |
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for 'acceptHTML' | 75 |
| UnusedPrivateMethod | Avoid unused private methods such as 'replaceAll(String,char,String)'. | 261 |
| ShortVariable | Avoid variables with short names like c | 267 |
| ExcessiveMethodLength | Avoid really long methods. | 300–445 |
| ExcessiveParameterList | Avoid long parameter lists. | 300–302 |
| CyclomaticComplexity | The method 'processNestedTags(StringBuffer, String, String, String, String, String, String, boolean, boolean, boolean)' has a cyclomatic complexity of 23. | 300–445 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 300–302 |
| NcssCount | The method 'processNestedTags(StringBuffer, String, String, String, String, String, String, boolean, boolean, boolean)' has a NCSS line count of 73. | 300–445 |
| NPathComplexity | The method 'processNestedTags(StringBuffer, String, String, String, String, String, String, boolean, boolean, boolean)' has an NPath complexity of 1188 | 300–445 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 319 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 351–381 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 355 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 363–381 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 369 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 369 |
| MissingOverride | The method 'compare(MutableCharSequence, MutableCharSequence)' is missing an @Override annotation. | 391–394 |
| CommentRequired | Public method and constructor comments are required | 391–394 |
| ShortVariable | Avoid variables with short names like o2 | 391 |
| ShortVariable | Avoid variables with short names like o1 | 391 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 393 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 393 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 404 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 408 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 408–415 |
| ShortVariable | Avoid variables with short names like m | 425 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 425 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 425 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 425 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 429 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 432 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 441 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 441 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the MutableCharSequence nested class if you want a default access modifier | 447–531 |
| CommentRequired | Header comments are required | 447–531 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_param' | 459 |
| MissingOverride | The method 'length()' is missing an @Override annotation. | 481–484 |
| MissingOverride | The method 'charAt(int)' is missing an @Override annotation. | 489–492 |
| MissingOverride | The method 'subSequence(int, int)' is missing an @Override annotation. | 497–500 |
| MissingOverride | The method 'toString()' is missing an @Override annotation. | 520–530 |
| ShortVariable | Avoid variables with short names like sb | 522 |
| Rule | Violation | Line |
|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 46–85 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1673 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–1673 |
| ExcessiveClassLength | Avoid really long classes. | 102–1673 |
| GodClass | Possible God Class (WMC=143, ATFD=335, TCC=2.902%) | 102–1673 |
| CyclomaticComplexity | The class 'SuggestUtils' has a total cyclomatic complexity of 143 (highest 11). | 102–1673 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 103–1673 |
| AvoidDuplicateLiterals | The String literal "src='image?" appears 4 times in this file; the first occurrence is on line 202 | 202 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 209 |
| ShortVariable | Avoid variables with short names like t | 214 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 223 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 255 |
| ShortVariable | Avoid variables with short names like t | 259 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 268 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 295 |
| ShortVariable | Avoid variables with short names like t | 300 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 309 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 336 |
| ShortVariable | Avoid variables with short names like t | 341 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 350 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 597 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 598 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 673 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getHtmlFormEntry' should not return void linguistically | 751–760 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 753 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getHtmlResponseEntry' should not return void linguistically | 774–785 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 778 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 803 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 842 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 857 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 957 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 960–969 |
| CyclomaticComplexity | The method 'initSubmitFilterBySort(SubmitFilter, int)' has a cyclomatic complexity of 11. | 1076–1142 |
| AssignmentInOperand | Avoid assignments in operands | 1445 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 1445 |
| ShortVariable | Avoid variables with short names like it | 1477 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 1480 |
| ShortVariable | Avoid variables with short names like ts | 1480 |
| LooseCoupling | Avoid using implementation types like 'ArrayList'; use the interface instead | 1503 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1558 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1659–1667 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 106 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 121 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 155 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 199 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 200 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 201 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 203 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 203 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 244 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 245 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'getDefaultMessageData(HttpServletRequest, DefaultMessage)' has a cyclomatic complexity of 15. | 172–286 |
| NcssCount | The method 'getDefaultMessageData(HttpServletRequest, DefaultMessage)' has a NCSS line count of 64. | 172–286 |
| ExcessiveMethodLength | Avoid really long methods. | 172–286 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 186 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 187 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–543 |
| GodClass | Possible God Class (WMC=50, ATFD=75, TCC=30.909%) | 84–543 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 132 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 147 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 182 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 227 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 228 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 229 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 231 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 231 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 272 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 273 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 341 |
| CyclomaticComplexity | The method 'getExportFormatData(MultipartHttpServletRequest, ExportFormat)' has a cyclomatic complexity of 16. | 378–442 |
| NPathComplexity | The method 'getExportFormatData(MultipartHttpServletRequest, ExportFormat)' has an NPath complexity of 240 | 378–442 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 455 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 456 |
| ShortVariable | Avoid variables with short names like os | 490 |
| LinguisticNaming | Linguistics Antipattern - The method 'isValid' indicates linguistically it returns a boolean, but it returns 'String' | 512–530 |
| ShortVariable | Avoid variables with short names like is | 521 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 524 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 87 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 50–58 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 54 |
| Rule | Violation | Line |
|---|---|---|
| MethodReturnsInternalArray | Returning '_content' may expose an internal array. | 75 |
| ArrayIsStoredDirectly | The user-supplied array 'content' is stored directly. | 84 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–2037 |
| ExcessiveClassLength | Avoid really long classes. | 110–2037 |
| CyclomaticComplexity | The class 'SuggestApp' has a total cyclomatic complexity of 205 (highest 21). | 110–2037 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 111–2037 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 260 |
| ImmutableField | Private field '_suggestSubmitService' could be made final; it is only initialized in the declaration or constructor. | 265 |
| ImmutableField | Private field '_commentSubmitService' could be made final; it is only initialized in the declaration or constructor. | 266 |
| MissingOverride | The method 'getPage(HttpServletRequest, int, Plugin)' is missing an @Override annotation. | 283–387 |
| CyclomaticComplexity | The method 'getPage(HttpServletRequest, int, Plugin)' has a cyclomatic complexity of 18. | 283–387 |
| ExcessiveMethodLength | Avoid really long methods. | 283–387 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 375–383 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 406 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 453 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 515 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 570 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 599 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 619 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 658 |
| CyclomaticComplexity | The method 'doCreateSuggestSubmit(XPage, int, HttpServletRequest)' has a cyclomatic complexity of 20. | 687–769 |
| NPathComplexity | The method 'doCreateSuggestSubmit(XPage, int, HttpServletRequest)' has an NPath complexity of 10368 | 687–769 |
| CollapsibleIfStatements | These nested if statements could be combined | 725–728 |
| CollapsibleIfStatements | These nested if statements could be combined | 734–737 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 758 |
| CyclomaticComplexity | The method 'doCreateComment(XPage, int, HttpServletRequest)' has a cyclomatic complexity of 21. | 958–1040 |
| NPathComplexity | The method 'doCreateComment(XPage, int, HttpServletRequest)' has an NPath complexity of 12960 | 958–1040 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 971 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1028 |
| NPathComplexity | The method 'doReport(XPage, int, HttpServletRequest)' has an NPath complexity of 288 | 1057–1122 |
| CyclomaticComplexity | The method 'doReport(XPage, int, HttpServletRequest)' has a cyclomatic complexity of 13. | 1057–1122 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1113 |
| CyclomaticComplexity | The method 'doVote(XPage, int, HttpServletRequest)' has a cyclomatic complexity of 10. | 1138–1181 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1230 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1240–1241 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1347 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1389 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1403–1404 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1404 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nMode'. | 1431 |
| CyclomaticComplexity | The method 'getHtmlSuggestSubmitDetail(HttpServletRequest, int, Plugin, SuggestSubmit, LuteceUser)' has a cyclomatic complexity of 10. | 1431–1491 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1434 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1435 |
| UnusedFormalParameter | Avoid unused method parameters such as 'plugin'. | 1544 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nMode'. | 1544 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1546 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nMode'. | 1616 |
| CyclomaticComplexity | The method 'doInsertSuggestSubmit(HttpServletRequest, int, Plugin, Suggest, int, int, LuteceUser)' has a cyclomatic complexity of 10. | 1649–1726 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nMode'. | 1649 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 1713 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1751 |
| NPathComplexity | The method 'getSearchFields(HttpServletRequest)' has an NPath complexity of 256 | 1844–1877 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1860–1861 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1862 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1864 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1865 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1866 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1867–1868 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1869 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1871 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–3720 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–3720 |
| NcssCount | The class 'SuggestJspBean' has a NCSS line count of 1751 (Highest = 199). | 145–3720 |
| CyclomaticComplexity | The class 'SuggestJspBean' has a total cyclomatic complexity of 411 (highest 67). | 145–3720 |
| TooManyFields | Too many fields | 145–3720 |
| ExcessiveClassLength | Avoid really long classes. | 145–3720 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 146–3720 |
| ImmutableField | Private field '_searchFields' could be made final; it is only initialized in the declaration or constructor. | 435 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 436 |
| ImmutableField | Private field '_suggestSubmitService' could be made final; it is only initialized in the declaration or constructor. | 456 |
| ImmutableField | Private field '_commentSubmitService' could be made final; it is only initialized in the declaration or constructor. | 457 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 505 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 506–507 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 568 |
| NcssCount | The method 'getManageSuggestSubmit(HttpServletRequest, HttpServletResponse)' has a NCSS line count of 92. | 609–785 |
| CyclomaticComplexity | The method 'getManageSuggestSubmit(HttpServletRequest, HttpServletResponse)' has a cyclomatic complexity of 22. | 609–785 |
| NPathComplexity | The method 'getManageSuggestSubmit(HttpServletRequest, HttpServletResponse)' has an NPath complexity of 29160 | 609–785 |
| ExcessiveMethodLength | Avoid really long methods. | 609–785 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 611 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 612 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 613 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 616 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 616 |
| AvoidDuplicateLiterals | The String literal "Access denied" appears 6 times in this file; the first occurrence is on line 635 | 635 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 642–654 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 678–697 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 702 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 703–704 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 739–749 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 799 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 805 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 805 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 830 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 831–832 |
| CyclomaticComplexity | The method 'doCreateSuggestSubmit(HttpServletRequest)' has a cyclomatic complexity of 15. | 904–990 |
| NPathComplexity | The method 'doCreateSuggestSubmit(HttpServletRequest)' has an NPath complexity of 582 | 904–990 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 919 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 919 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 922 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 923 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 924 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 925 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 926 |
| CollapsibleIfStatements | These nested if statements could be combined | 931–934 |
| CollapsibleIfStatements | These nested if statements could be combined | 940–943 |
| ExcessiveMethodLength | Avoid really long methods. | 1001–1104 |
| CyclomaticComplexity | The method 'getManageCommentSubmit(HttpServletRequest)' has a cyclomatic complexity of 12. | 1001–1104 |
| NPathComplexity | The method 'getManageCommentSubmit(HttpServletRequest)' has an NPath complexity of 324 | 1001–1104 |
| NcssCount | The method 'getManageCommentSubmit(HttpServletRequest)' has a NCSS line count of 61. | 1001–1104 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1004 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1010 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1027 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1039 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1071 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 1072–1073 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1116 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1118 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1159 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1160 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1179–1187 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1205 |
| CyclomaticComplexity | The method 'getConfirmMassChangeSuggestSubmitCategory(HttpServletRequest)' has a cyclomatic complexity of 10. | 1242–1284 |
| CyclomaticComplexity | The method 'doMassChangeSuggestSubmitCategory(HttpServletRequest)' has a cyclomatic complexity of 11. | 1295–1341 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1301 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1354 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1361 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1393–1422 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1397 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1414–1422 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1438 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1441 |
| ExcessiveMethodLength | Avoid really long methods. | 1629–1949 |
| CyclomaticComplexity | The method 'getSuggestData(MultipartHttpServletRequest, Suggest)' has a cyclomatic complexity of 67. | 1629–1949 |
| NcssCount | The method 'getSuggestData(MultipartHttpServletRequest, Suggest)' has a NCSS line count of 199. | 1629–1949 |
| NPathComplexity | The method 'getSuggestData(MultipartHttpServletRequest, Suggest)' has an NPath complexity of 829440000 | 1629–1949 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1632 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1633 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1637 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1639 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1645 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1647 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1648 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1649 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1651 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1652 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1656 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1657 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1658 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1659 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1661 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1663 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1666 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1667 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1668 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1670 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1674 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1675 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1676 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1677 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1678 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1679 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1680 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1683 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1688 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1689 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1690 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1691 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1692 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1693 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1694 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1695 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1696 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1697 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1701 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1902–1909 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1990 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2035 |
| NcssCount | The method 'getModifySuggest(HttpServletRequest)' has a NCSS line count of 86. | 2063–2189 |
| ExcessiveMethodLength | Avoid really long methods. | 2063–2189 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2066 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2067 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2068 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2071 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2072 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2074 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 2094 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 2105–2106 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2151 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2364 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2366 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2405 |
| UnusedLocalVariable | Avoid unused local variables such as 'plugin'. | 2405 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2427 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2428 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2479 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2544 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2549 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2557 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 2648 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3030 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 3068 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 3090 |
| ExcessiveMethodLength | Avoid really long methods. | 3277–3441 |
| NPathComplexity | The method 'getStatistics(HttpServletRequest)' has an NPath complexity of 24576 | 3277–3441 |
| CyclomaticComplexity | The method 'getStatistics(HttpServletRequest)' has a cyclomatic complexity of 21. | 3277–3441 |
| NcssCount | The method 'getStatistics(HttpServletRequest)' has a NCSS line count of 92. | 3277–3441 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3297–3305 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3302 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3315 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3317 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3327 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3329 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3383 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3385 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3386 |
| ShortVariable | Avoid variables with short names like fV | 3391 |
| ShortVariable | Avoid variables with short names like fC | 3392 |
| ShortVariable | Avoid variables with short names like bd | 3394 |
| AvoidDecimalLiteralsInBigDecimalConstructor | Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal | 3394 |
| AvoidDecimalLiteralsInBigDecimalConstructor | Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal | 3397 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3499 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3500 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3502 |
| NPathComplexity | The method 'updateSearchFieldsData(HttpServletRequest)' has an NPath complexity of 4374 | 3538–3589 |
| CyclomaticComplexity | The method 'updateSearchFieldsData(HttpServletRequest)' has a cyclomatic complexity of 16. | 3538–3589 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3613 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3672 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 113 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 128 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 133–134 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 156 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 196 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 197 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 198 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 200 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 200 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 203–219 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 240 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 241 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 245–261 |
| CyclomaticComplexity | The method 'getSuggestSubmitTypeData(MultipartHttpServletRequest, SuggestSubmitType)' has a cyclomatic complexity of 10. | 335–386 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 338 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 343 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 344 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like r | 87 |
| ShortVariable | Avoid variables with short names like r | 137 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–255 |
| ExcessiveMethodLength | Avoid really long methods. | 143–244 |
| CyclomaticComplexity | The method 'process(HttpServletRequest, HttpServletResponse, AdminUser, SuggestAdminSearchFields)' has a cyclomatic complexity of 10. | 143–244 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 147 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 151 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 217 |
| ShortVariable | Avoid variables with short names like os | 229 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 120 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 129–159 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 78–79 |
| CyclomaticComplexity | The method 'process(HttpServletRequest, HttpServletResponse, AdminUser, SuggestAdminSearchFields)' has a cyclomatic complexity of 12. | 112–163 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 115 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 120–158 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 78–79 |
| CyclomaticComplexity | The method 'process(HttpServletRequest, HttpServletResponse, AdminUser, SuggestAdminSearchFields)' has a cyclomatic complexity of 12. | 112–163 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 115 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 120–158 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 78–79 |
| CyclomaticComplexity | The method 'process(HttpServletRequest, HttpServletResponse, AdminUser, SuggestAdminSearchFields)' has a cyclomatic complexity of 12. | 112–167 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 115 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 120–162 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 61–64 |
| CommentRequired | Public method and constructor comments are required | 66–69 |
| CommentRequired | Public method and constructor comments are required | 71–74 |
| CommentRequired | Public method and constructor comments are required | 76–79 |
| CommentRequired | Public method and constructor comments are required | 81–84 |
| CommentRequired | Public method and constructor comments are required | 86–89 |
| CommentRequired | Public method and constructor comments are required | 91–94 |
| CommentRequired | Public method and constructor comments are required | 96–99 |
| CommentRequired | Public method and constructor comments are required | 111–114 |
| CommentRequired | Public method and constructor comments are required | 116–119 |
| CommentRequired | Public method and constructor comments are required | 121–124 |
| CommentRequired | Public method and constructor comments are required | 126–129 |
| CommentRequired | Public method and constructor comments are required | 131–134 |
| CommentRequired | Public method and constructor comments are required | 136–139 |
| CommentRequired | Public method and constructor comments are required | 141–144 |
| CommentRequired | Public method and constructor comments are required | 146–149 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' | 144 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' | 141 |
| Rule | Violation | Line |
|---|---|---|
| ShortClassName | Avoid short class names like Vote | 41–86 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 180 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 196 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 217 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 220 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 220 |
| Rule | Violation | Line |
|---|---|---|
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 83–86 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 100–103 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 261 |
| Rule | Violation | Line |
|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUser' | 36 |
| UnusedImports | Avoid unused imports such as 'java.util.Map' | 40 |
| UnusedImports | Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 42 |
| UnusedImports | Avoid unused imports such as 'javax.servlet.http.HttpServletResponse' | 43 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'equals(Object)' is missing an @Override annotation. | 3 | 101–105 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 101 |
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 3 | 112–115 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 3 | 122–125 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NPathComplexity | The method 'selectListByFilter(SubmitFilter, Integer, Plugin)' has an NPath complexity of 2448 | 3 | 209–296 |
| CyclomaticComplexity | The method 'selectListByFilter(SubmitFilter, Integer, Plugin)' has a cyclomatic complexity of 13. | 3 | 209–296 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 247 |
| CyclomaticComplexity | The method 'selectCountByFilter(SubmitFilter, Plugin)' has a cyclomatic complexity of 10. | 3 | 337–396 |
| NPathComplexity | The method 'selectCountByFilter(SubmitFilter, Plugin)' has an NPath complexity of 408 | 3 | 337–396 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 448 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 3 | 178–181 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 3 | 188–191 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'getComment()' is missing an @Override annotation. | 3 | 111–114 |
| MissingOverride | The method 'getEntryType()' is missing an @Override annotation. | 3 | 119–122 |
| MissingOverride | The method 'getHelpMessage()' is missing an @Override annotation. | 3 | 127–130 |
| MissingOverride | The method 'getIdEntry()' is missing an @Override annotation. | 3 | 135–138 |
| MissingOverride | The method 'getPosition()' is missing an @Override annotation. | 3 | 143–146 |
| MissingOverride | The method 'getTitle()' is missing an @Override annotation. | 3 | 151–154 |
| MissingOverride | The method 'isMandatory()' is missing an @Override annotation. | 3 | 159–162 |
| MissingOverride | The method 'isShowInSuggestSubmitList()' is missing an @Override annotation. | 3 | 167–170 |
| MissingOverride | The method 'setComment(String)' is missing an @Override annotation. | 3 | 178–181 |
| MissingOverride | The method 'setEntryType(EntryType)' is missing an @Override annotation. | 3 | 189–192 |
| MissingOverride | The method 'setHelpMessage(String)' is missing an @Override annotation. | 3 | 200–203 |
| MissingOverride | The method 'setIdEntry(int)' is missing an @Override annotation. | 3 | 211–214 |
| MissingOverride | The method 'setShowInSuggestSubmitList(boolean)' is missing an @Override annotation. | 3 | 222–225 |
| MissingOverride | The method 'setMandatory(boolean)' is missing an @Override annotation. | 3 | 233–236 |
| MissingOverride | The method 'setPosition(int)' is missing an @Override annotation. | 3 | 244–247 |
| MissingOverride | The method 'setTitle(String)' is missing an @Override annotation. | 3 | 255–258 |
| MissingOverride | The method 'getSuggest()' is missing an @Override annotation. | 3 | 264–267 |
| MissingOverride | The method 'setSuggest(Suggest)' is missing an @Override annotation. | 3 | 275–278 |
| MissingOverride | The method 'getRegularExpressionList()' is missing an @Override annotation. | 3 | 284–287 |
| MissingOverride | The method 'setRegularExpressionList(List)' is missing an @Override annotation. | 3 | 295–298 |
| MissingOverride | The method 'getDefaultValue()' is missing an @Override annotation. | 3 | 304–307 |
| MissingOverride | The method 'setDefaultValue(String)' is missing an @Override annotation. | 3 | 315–318 |
| MissingOverride | The method 'getWidth()' is missing an @Override annotation. | 3 | 324–327 |
| MissingOverride | The method 'setWidth(int)' is missing an @Override annotation. | 3 | 335–338 |
| MissingOverride | The method 'getHeight()' is missing an @Override annotation. | 3 | 344–347 |
| MissingOverride | The method 'setHeight(int)' is missing an @Override annotation. | 3 | 355–358 |
| MissingOverride | The method 'getMaxSizeEnter()' is missing an @Override annotation. | 3 | 364–367 |
| MissingOverride | The method 'setMaxSizeEnter(int)' is missing an @Override annotation. | 3 | 375–378 |
| MissingOverride | The method 'getTemplateHtmlCodeForm()' is missing an @Override annotation. | 3 | 386–389 |
| MissingOverride | The method 'getTemplateHtmlCodeResponse()' is missing an @Override annotation. | 3 | 396–399 |
| MissingOverride | The method 'getRequestData(HttpServletRequest, Locale)' is missing an @Override annotation. | 3 | 410–413 |
| MissingOverride | The method 'getResponseData(HttpServletRequest, List, Locale)' is missing an @Override annotation. | 3 | 426–429 |
| MissingOverride | The method 'getResponseData(int, HttpServletRequest, List, Locale, Plugin)' is missing an @Override annotation. | 3 | 446–449 |
| MissingOverride | The method 'getTemplateCreate()' is missing an @Override annotation. | 3 | 456–459 |
| MissingOverride | The method 'getTemplateModify()' is missing an @Override annotation. | 3 | 466–469 |
| MissingOverride | The method 'getPaginator(int, String, String, String)' is missing an @Override annotation. | 3 | 484–487 |
| MissingOverride | The method 'getReferenceListRegularExpression(IEntry, Plugin)' is missing an @Override annotation. | 3 | 498–501 |
| MissingOverride | The method 'getEntryAdditionalAttributeList()' is missing an @Override annotation. | 3 | 507–510 |
| MissingOverride | The method 'setEntryAdditionalAttributeList(List)' is missing an @Override annotation. | 3 | 518–521 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'insert(EntryAdditionalAttribute, Plugin)' is missing an @Override annotation. | 3 | 61–71 |
| MissingOverride | The method 'selectEntryAdditionalAttributeList(int, Plugin)' is missing an @Override annotation. | 3 | 82–102 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 112–119 |
| MissingOverride | The method 'store(EntryAdditionalAttribute, Plugin)' is missing an @Override annotation. | 3 | 129–139 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 47–481 |
| MissingOverride | The method 'insert(IEntry, Plugin)' is missing an @Override annotation. | 3 | 136–160 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 171–224 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 234–241 |
| MissingOverride | The method 'store(IEntry, Plugin)' is missing an @Override annotation. | 3 | 251–272 |
| MissingOverride | The method 'selectEntryListByFilter(EntryFilter, Plugin)' is missing an @Override annotation. | 3 | 283–347 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 291 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 293 |
| MissingOverride | The method 'selectNumberEntryByFilter(EntryFilter, Plugin)' is missing an @Override annotation. | 3 | 358–386 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 362 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 364 |
| MissingOverride | The method 'deleteVerifyBy(int, int, Plugin)' is missing an @Override annotation. | 3 | 398–406 |
| MissingOverride | The method 'insertVerifyBy(int, int, Plugin)' is missing an @Override annotation. | 3 | 418–426 |
| MissingOverride | The method 'selectListRegularExpressionKeyByIdEntry(int, Plugin)' is missing an @Override annotation. | 3 | 437–453 |
| MissingOverride | The method 'isRegularExpressionIsUse(int, Plugin)' is missing an @Override annotation. | 3 | 464–480 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 172–175 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 61–80 |
| MissingOverride | The method 'select(Plugin)' is missing an @Override annotation. | 3 | 89–110 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 71–74 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 3 | 88–163 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 91 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 92 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 93 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 94 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 95 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 96 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 97 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 99 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 100 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 213–231 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 3 | 85–163 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 90 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 91 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 93 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 94 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 96 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 97 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NPathComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has an NPath complexity of 336 | 3 | 83–169 |
| CyclomaticComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has a cyclomatic complexity of 13. | 3 | 83–169 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 86 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 87 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 92 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 93 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 95 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 96 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 97 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 3 | 85–163 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 88 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 89 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 90 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 91 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 93 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 94 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 96 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 97 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveMethodLength | Avoid really long methods. | 3 | 96–204 |
| NcssCount | The method 'getRequestData(HttpServletRequest, Locale)' has a NCSS line count of 64. | 3 | 96–204 |
| CyclomaticComplexity | The method 'getRequestData(HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 3 | 96–204 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 99 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 100 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 101 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 102 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 103 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 104 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 105 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 106 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 107 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 108 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 109 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 110 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 112 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 113 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 256–334 |
| AvoidDuplicateLiterals | The String literal "');" appears 6 times in this file; the first occurrence is on line 300 | 3 | 300 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 306 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodReturnsInternalArray | Returning '_xsl' may expose an internal array. | 3 | 118 |
| ArrayIsStoredDirectly | The user-supplied array 'donnees' is stored directly. | 3 | 127 |
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 3 | 137–140 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 3 | 147–150 |
| AddEmptyString | Do not add empty strings | 3 | 149 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 91–103 |
| MissingOverride | The method 'insert(ExportFormat, Plugin)' is missing an @Override annotation. | 3 | 91–103 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The getter 'getXml' should not return void linguistically | 3 | 359 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 52–65 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 42–171 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 104–111 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 221–228 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 256 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 257 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 258 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–118 |
| CommentRequired | Public method and constructor comments are required | 3 | 49–52 |
| CommentRequired | Public method and constructor comments are required | 3 | 54–57 |
| CommentRequired | Public method and constructor comments are required | 3 | 59–62 |
| CommentRequired | Public method and constructor comments are required | 3 | 64–67 |
| CommentRequired | Public method and constructor comments are required | 3 | 69–72 |
| CommentRequired | Public method and constructor comments are required | 3 | 74–77 |
| CommentRequired | Public method and constructor comments are required | 3 | 79–82 |
| CommentRequired | Public method and constructor comments are required | 3 | 84–87 |
| CommentRequired | Public method and constructor comments are required | 3 | 89–92 |
| CommentRequired | Public method and constructor comments are required | 3 | 94–97 |
| CommentRequired | Public method and constructor comments are required | 3 | 99–102 |
| CommentRequired | Public method and constructor comments are required | 3 | 104–107 |
| CommentRequired | Public method and constructor comments are required | 3 | 109–112 |
| CommentRequired | Public method and constructor comments are required | 3 | 114–117 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–581 |
| TooManyFields | Too many fields | 3 | 47–581 |
| GodClass | Possible God Class (WMC=55, ATFD=6, TCC=9.224%) | 3 | 47–581 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 48–581 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_strLuteceUserKey' | 3 | 83 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–1532 |
| TooManyFields | Too many fields | 3 | 59–1532 |
| CyclomaticComplexity | The class 'Suggest' has a total cyclomatic complexity of 136 (highest 4). | 3 | 59–1532 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 59–1532 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 160–164 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 166–170 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 172–176 |
| MissingOverride | The method 'getWorkgroup()' is missing an @Override annotation. | 3 | 303–306 |
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 3 | 404–407 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 3 | 414–417 |
| AddEmptyString | Do not add empty strings | 3 | 416 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'getPermission()' is missing an @Override annotation. | 3 | 186–189 |
| MissingOverride | The method 'setLocale(Locale)' is missing an @Override annotation. | 3 | 208–211 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'selectActionsBySuggestState(int, Plugin)' is missing an @Override annotation. | 3 | 59–82 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' | 4 | 144 |
| NPathComplexity | The method 'selectSuggestList(SuggestFilter, Plugin)' has an NPath complexity of 528 | 3 | 374–492 |
| NcssCount | The method 'selectSuggestList(SuggestFilter, Plugin)' has a NCSS line count of 81. | 3 | 374–492 |
| CyclomaticComplexity | The method 'selectSuggestList(SuggestFilter, Plugin)' has a cyclomatic complexity of 10. | 3 | 374–492 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 374–492 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 525 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'entry' | 3 | 112 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 147–154 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 3 | 58–68 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 3 | 79–83 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 3 | 58–76 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 3 | 70–73 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 3 | 87–91 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–748 |
| TooManyFields | Too many fields | 3 | 56–748 |
| GodClass | Possible God Class (WMC=63, ATFD=9, TCC=1.633%) | 3 | 56–748 |
| CyclomaticComplexity | The method 'getXml(HttpServletRequest, Locale)' has a cyclomatic complexity of 11. | 3 | 442–501 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 450–451 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 452–453 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'java.sql.Timestamp' due to existing import 'java.sql.Timestamp' | 4 | 141 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 156–163 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 173–180 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 187–194 |
| MissingOverride | The method 'store(SuggestSubmit, Plugin)' is missing an @Override annotation. | 3 | 257–312 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 267–274 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 284–291 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 298–305 |
| NcssCount | The method 'selectListByFilter(SubmitFilter, Plugin)' has a NCSS line count of 65. | 3 | 324–469 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 324–469 |
| CyclomaticComplexity | The method 'selectListByFilter(SubmitFilter, Plugin)' has a cyclomatic complexity of 25. | 3 | 324–469 |
| NPathComplexity | The method 'selectListByFilter(SubmitFilter, Plugin)' has an NPath complexity of 12589056 | 3 | 324–469 |
| CyclomaticComplexity | The method 'selectIdListByFilter(SubmitFilter, Plugin)' has a cyclomatic complexity of 27. | 3 | 481–633 |
| NcssCount | The method 'selectIdListByFilter(SubmitFilter, Plugin)' has a NCSS line count of 69. | 3 | 481–633 |
| NPathComplexity | The method 'selectIdListByFilter(SubmitFilter, Plugin)' has an NPath complexity of 50343936 | 3 | 481–633 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 481–633 |
| NPathComplexity | The method 'selectCountByFilter(SubmitFilter, Plugin)' has an NPath complexity of 25171968 | 3 | 645–791 |
| CyclomaticComplexity | The method 'selectCountByFilter(SubmitFilter, Plugin)' has a cyclomatic complexity of 26. | 3 | 645–791 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 645–791 |
| NcssCount | The method 'selectCountByFilter(SubmitFilter, Plugin)' has a NCSS line count of 66. | 3 | 645–791 |
| CyclomaticComplexity | The method 'getOrderBy(List)' has a cyclomatic complexity of 17. | 3 | 800–890 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 3 | 877 |
| MissingOverride | The method 'storeSuggestSubmitOrder(int, int, Plugin)' is missing an @Override annotation. | 3 | 905–913 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 3 | 148–151 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 3 | 158–161 |
| AddEmptyString | Do not add empty strings | 3 | 160 |
| OverrideBothEqualsAndHashcode | Ensure you override both equals() and hashCode() | 3 | 186 |
| MissingOverride | The method 'equals(Object)' is missing an @Override annotation. | 3 | 186–189 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'insert(SuggestSubmitType, Plugin)' is missing an @Override annotation. | 3 | 100–125 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 112–119 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 136–152 |
| MissingOverride | The method 'selectList(Plugin)' is missing an @Override annotation. | 3 | 161–176 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 186–193 |
| MissingOverride | The method 'store(SuggestSubmitType, Plugin)' is missing an @Override annotation. | 3 | 203–225 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 212–219 |
| MissingOverride | The method 'selectListByIdSuggest(int, Plugin)' is missing an @Override annotation. | 3 | 259–275 |
| MissingOverride | The method 'isAssociateToSuggest(int, Plugin)' is missing an @Override annotation. | 3 | 286–295 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 99–106 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 38–154 |
| CommentRequired | Public method and constructor comments are required | 3 | 47–50 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–55 |
| CommentRequired | Public method and constructor comments are required | 3 | 57–60 |
| CommentRequired | Public method and constructor comments are required | 3 | 62–65 |
| CommentRequired | Public method and constructor comments are required | 3 | 67–70 |
| CommentRequired | Public method and constructor comments are required | 3 | 72–75 |
| CommentRequired | Public method and constructor comments are required | 3 | 77–80 |
| CommentRequired | Public method and constructor comments are required | 3 | 82–85 |
| CommentRequired | Public method and constructor comments are required | 3 | 87–90 |
| CommentRequired | Public method and constructor comments are required | 3 | 92–95 |
| CommentRequired | Public method and constructor comments are required | 3 | 97–100 |
| CommentRequired | Public method and constructor comments are required | 3 | 102–105 |
| MissingOverride | The method 'toString()' is missing an @Override annotation. | 3 | 150–153 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 39–133 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 3 | 58–71 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 3 | 82–86 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ArrayIsStoredDirectly | The user-supplied array 'video' is stored directly. | 3 | 109 |
| MethodReturnsInternalArray | Returning '_video' may expose an internal array. | 3 | 119 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'insert(VideoType, Plugin)' is missing an @Override annotation. | 3 | 64–85 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 77 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 3 | 79 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 96–117 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 127–134 |
| MissingOverride | The method 'store(VideoType, Plugin)' is missing an @Override annotation. | 3 | 144–155 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ShortClassName | Avoid short class names like Vote | 4 | 41–86 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodReturnsInternalArray | Returning '_byIconContent' may expose an internal array. | 3 | 135 |
| ArrayIsStoredDirectly | The user-supplied array 'iconContent' is stored directly. | 3 | 144 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'insert(Vote, Plugin)' is missing an @Override annotation. | 3 | 65–73 |
| MissingOverride | The method 'selectVoteByIdSuggestSubmit(int, Plugin)' is missing an @Override annotation. | 3 | 84–106 |
| MissingOverride | The method 'selectCountVoteByIdSuggestSubmitAndLuteceUserKey(int, String, Plugin)' is missing an @Override annotation. | 3 | 119–136 |
| MissingOverride | The method 'selectCountVoteByIdSuggestSubmit(int, Plugin)' is missing an @Override annotation. | 3 | 147–163 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 67–89 |
| MissingOverride | The method 'select(Plugin)' is missing an @Override annotation. | 3 | 98–121 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 56–75 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 58 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 80–93 |
| MissingOverride | The method 'insert(int, String, Object, Plugin)' is missing an @Override annotation. | 3 | 80–93 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 88 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 88 |
| MissingOverride | The method 'remove(int, Plugin)' is missing an @Override annotation. | 3 | 98–105 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–893 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 317 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 3 | 334 |
| AvoidDuplicateLiterals | The String literal "<div[^>]+>" appears 7 times in this file; the first occurrence is on line 347 | 3 | 347 |
| AvoidDuplicateLiterals | The String literal "</div>" appears 7 times in this file; the first occurrence is on line 347 | 3 | 347 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 374 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 418–427 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 429 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 449–458 |
| NcssCount | The method 'createHtmlRss()' has a NCSS line count of 77. | 3 | 472–605 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 472–605 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 519–526 |
| NcssCount | The method 'getFeed()' has a NCSS line count of 99. | 3 | 611–803 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 611–803 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 651 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 681 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 683–690 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 767 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 821 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 3 | 65–78 |
| MissingOverride | The method 'insert(SuggestResourceRssConfig, Plugin)' is missing an @Override annotation. | 3 | 65–78 |
| MissingOverride | The method 'store(SuggestResourceRssConfig, Plugin)' is missing an @Override annotation. | 3 | 88–102 |
| MissingOverride | The method 'load(int, Plugin)' is missing an @Override annotation. | 3 | 114–137 |
| MissingOverride | The method 'delete(int, Plugin)' is missing an @Override annotation. | 3 | 147–154 |
| MissingOverride | The method 'loadAll(Plugin)' is missing an @Override annotation. | 3 | 163–186 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 62–65 |
| MissingOverride | The method 'register()' is missing an @Override annotation. | 3 | 70–83 |
| ShortVariable | Avoid variables with short names like rt | 3 | 72 |
| ShortVariable | Avoid variables with short names like p | 3 | 78 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 3 | 92–95 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 3 | 106–122 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 45–183 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 176–179 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 58–61 |
| MissingOverride | The method 'register()' is missing an @Override annotation. | 3 | 66–79 |
| ShortVariable | Avoid variables with short names like rt | 3 | 68 |
| ShortVariable | Avoid variables with short names like p | 3 | 74 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 3 | 88–91 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 3 | 102–105 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 61–64 |
| MissingOverride | The method 'register()' is missing an @Override annotation. | 3 | 69–82 |
| ShortVariable | Avoid variables with short names like rt | 3 | 71 |
| ShortVariable | Avoid variables with short names like p | 3 | 77 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 3 | 91–94 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 3 | 105–121 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'TAG_FILE_RESOURCE'. | 3 | 41 |
| UnusedPrivateField | Avoid unused private fields such as 'TAG_DOCUMENT_ID'. | 3 | 42 |
| UnusedPrivateField | Avoid unused private fields such as 'TAG_ATTRIBUTE_ID'. | 3 | 43 |
| UnusedPrivateField | Avoid unused private fields such as 'TAG_CONTENT_TYPE'. | 3 | 44 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getCreateTemplate method if you want a default access modifier | 3 | 53–56 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 53–56 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getModifyTemplate method if you want a default access modifier | 3 | 63–66 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 63–66 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 73–76 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getCreateParametersTemplate method if you want a default access modifier | 3 | 73–76 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 83–86 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getModifyParametersTemplate method if you want a default access modifier | 3 | 83–86 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–130 |
| AvoidDuplicateLiterals | The String literal "suggest.transactionManager" appears 7 times in this file; the first occurrence is on line 55 | 3 | 55 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 50–297 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 51–297 |
| AvoidDuplicateLiterals | The String literal "suggest.transactionManager" appears 8 times in this file; the first occurrence is on line 63 | 3 | 63 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 48–52 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getCreateTemplate method if you want a default access modifier | 3 | 49–52 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the ImageService constructor if you want a default access modifier | 3 | 55–58 |
| MissingOverride | The method 'getImageResource(int)' is missing an @Override annotation. | 3 | 77–80 |
| MissingOverride | The method 'getResourceTypeId()' is missing an @Override annotation. | 3 | 87–90 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 46–49 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'getXPageTheme(HttpServletRequest)' is missing an @Override annotation. | 3 | 72–76 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 90–93 |
| MissingOverride | The method 'register()' is missing an @Override annotation. | 3 | 98–142 |
| ShortVariable | Avoid variables with short names like rt | 3 | 100 |
| ShortVariable | Avoid variables with short names like p | 3 | 106 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 3 | 151–162 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 3 | 173–189 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 124–125 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–561 |
| CommentRequired | Header comments are required | 3 | 70–561 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 71–561 |
| AvoidDuplicateLiterals | The String literal "suggest.transactionManager" appears 6 times in this file; the first occurrence is on line 79 | 3 | 79 |
| CyclomaticComplexity | The method 'updateSuggestSubmitOrder(Integer, Integer, int, boolean, Plugin)' has a cyclomatic complexity of 12. | 3 | 203–235 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 220–224 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 350–365 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 376–393 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 404–419 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 441–444 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 555 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 46–49 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 59–62 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'run()' is missing an @Override annotation. | 3 | 47–50 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'suggestSubmit' | 3 | 103 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–351 |
| MissingOverride | The method 'getDescription()' is missing an @Override annotation. | 3 | 105–108 |
| MissingOverride | The method 'indexDocuments()' is missing an @Override annotation. | 3 | 120–163 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 148 |
| MissingOverride | The method 'getDocuments(String)' is missing an @Override annotation. | 3 | 178–201 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 4 | 180 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 4 | 196 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 4 | 217 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 4 | 220 |
| UnnecessaryFullyQualifiedName | Unnecessary use of fully qualified name 'org.apache.lucene.document.Document' due to existing import 'org.apache.lucene.document.Document' | 4 | 220 |
| ShortVariable | Avoid variables with short names like ft | 3 | 222 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 3 | 240 |
| ShortVariable | Avoid variables with short names like sb | 3 | 269 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 3 | 299–302 |
| MissingOverride | The method 'getVersion()' is missing an @Override annotation. | 3 | 309–312 |
| MissingOverride | The method 'isEnable()' is missing an @Override annotation. | 3 | 319–331 |
| MissingOverride | The method 'getListType()' is missing an @Override annotation. | 3 | 336–342 |
| MissingOverride | The method 'getSpecificSearchAppUrl()' is missing an @Override annotation. | 3 | 347–350 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–488 |
| NPathComplexity | The method 'run()' has an NPath complexity of 1478 | 3 | 88–213 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 88–213 |
| CyclomaticComplexity | The method 'run()' has a cyclomatic complexity of 31. | 3 | 88–213 |
| NcssCount | The method 'run()' has a NCSS line count of 61. | 3 | 88–213 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 107 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 124–144 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 143 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 161–180 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 187–205 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 348 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 356–357 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 458 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 465–466 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 61–377 |
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 82–88 |
| CyclomaticComplexity | The method 'getSubscriptionHtmlDescription(LuteceUser, String, String, Locale)' has a cyclomatic complexity of 10. | 3 | 106–157 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 3 | 145–152 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingOverride | The method 'getSearchResults(String, SubmitFilter)' is missing an @Override annotation. | 3 | 73–141 |
| ShortVariable | Avoid variables with short names like ir | 3 | 80 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 3 | 120 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 3 | 121 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 3 | 122 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 127–133 |
| ShortVariable | Avoid variables with short names like si | 3 | 131 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 135 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method 'setIdSuggest' called during object construction | 1 | 59 |
| ConstructorCallsOverridableMethod | Overridable method 'setIdSuggestSubmit' called during object construction | 1 | 60 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 3 | 65–68 |
| CyclomaticComplexity | The method 'getSearchResults(String, SubmitFilter, Plugin)' has a cyclomatic complexity of 11. | 3 | 84–113 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 49–123 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The field name 'acceptHTML' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 75 |
| RedundantFieldInitializer | Avoid using redundant field initializer for 'acceptHTML' | 3 | 75 |
| FieldNamingConventions | The field name 'acceptBBCode' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 78 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 83–86 |
| BooleanGetMethodName | A getX() method which returns a boolean should be named isX() | 4 | 100–103 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'texto' | 2 | 118 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'texto' | 2 | 118 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'string' | 2 | 137 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'content' | 2 | 227 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'content' | 2 | 227 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'content' | 2 | 227 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'content' | 2 | 227 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'content' | 2 | 248 |
| UnusedPrivateMethod | Avoid unused private methods such as 'replaceAll(String,char,String)'. | 3 | 261 |
| UseVarargs | Consider using varargs for methods or constructors which take an array the last parameter. | 4 | 261 |
| ShortVariable | Avoid variables with short names like c | 3 | 267 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 300–445 |
| ExcessiveParameterList | Avoid long parameter lists. | 3 | 300–302 |
| CyclomaticComplexity | The method 'processNestedTags(StringBuffer, String, String, String, String, String, String, boolean, boolean, boolean)' has a cyclomatic complexity of 23. | 3 | 300–445 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 3 | 300–302 |
| NcssCount | The method 'processNestedTags(StringBuffer, String, String, String, String, String, String, boolean, boolean, boolean)' has a NCSS line count of 73. | 3 | 300–445 |
| NPathComplexity | The method 'processNestedTags(StringBuffer, String, String, String, String, String, String, boolean, boolean, boolean)' has an NPath complexity of 1188 | 3 | 300–445 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 3 | 319 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 351–381 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 355 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 363–381 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 369 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 369 |
| MissingOverride | The method 'compare(MutableCharSequence, MutableCharSequence)' is missing an @Override annotation. | 3 | 391–394 |
| CommentRequired | Public method and constructor comments are required | 3 | 391–394 |
| ShortVariable | Avoid variables with short names like o2 | 3 | 391 |
| ShortVariable | Avoid variables with short names like o1 | 3 | 391 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 393 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 393 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 404 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 408 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 408–415 |
| ShortVariable | Avoid variables with short names like m | 3 | 425 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 425 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 425 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 425 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 429 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 432 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 441 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 3 | 441 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the MutableCharSequence nested class if you want a default access modifier | 3 | 447–531 |
| CommentRequired | Header comments are required | 3 | 447–531 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_param' | 3 | 459 |
| MissingOverride | The method 'length()' is missing an @Override annotation. | 3 | 481–484 |
| MissingOverride | The method 'charAt(int)' is missing an @Override annotation. | 3 | 489–492 |
| MissingOverride | The method 'subSequence(int, int)' is missing an @Override annotation. | 3 | 497–500 |
| MissingOverride | The method 'toString()' is missing an @Override annotation. | 3 | 520–530 |
| ShortVariable | Avoid variables with short names like sb | 3 | 522 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 46–85 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–1673 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–1673 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 102–1673 |
| GodClass | Possible God Class (WMC=143, ATFD=335, TCC=2.902%) | 3 | 102–1673 |
| CyclomaticComplexity | The class 'SuggestUtils' has a total cyclomatic complexity of 143 (highest 11). | 3 | 102–1673 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 103–1673 |
| AvoidDuplicateLiterals | The String literal "src='image?" appears 4 times in this file; the first occurrence is on line 202 | 3 | 202 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 209 |
| ShortVariable | Avoid variables with short names like t | 3 | 214 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 223 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 255 |
| ShortVariable | Avoid variables with short names like t | 3 | 259 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 268 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 295 |
| ShortVariable | Avoid variables with short names like t | 3 | 300 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 309 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 336 |
| ShortVariable | Avoid variables with short names like t | 3 | 341 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 350 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 597 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 598 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 673 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getHtmlFormEntry' should not return void linguistically | 3 | 751–760 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 753 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getHtmlResponseEntry' should not return void linguistically | 3 | 774–785 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 778 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 803 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 842 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 857 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 957 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 960–969 |
| CyclomaticComplexity | The method 'initSubmitFilterBySort(SubmitFilter, int)' has a cyclomatic complexity of 11. | 3 | 1076–1142 |
| AssignmentInOperand | Avoid assignments in operands | 3 | 1445 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 1445 |
| ShortVariable | Avoid variables with short names like it | 3 | 1477 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 1480 |
| ShortVariable | Avoid variables with short names like ts | 3 | 1480 |
| LooseCoupling | Avoid using implementation types like 'ArrayList'; use the interface instead | 3 | 1503 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1558 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1659–1667 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 3 | 106 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 121 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 155 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 199 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 200 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 201 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 203 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 203 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 244 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 245 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CyclomaticComplexity | The method 'getDefaultMessageData(HttpServletRequest, DefaultMessage)' has a cyclomatic complexity of 15. | 3 | 172–286 |
| NcssCount | The method 'getDefaultMessageData(HttpServletRequest, DefaultMessage)' has a NCSS line count of 64. | 3 | 172–286 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 172–286 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 186 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 187 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–543 |
| GodClass | Possible God Class (WMC=50, ATFD=75, TCC=30.909%) | 3 | 84–543 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 3 | 132 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 147 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 182 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 227 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 228 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 229 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 231 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 231 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 272 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 273 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 341 |
| CyclomaticComplexity | The method 'getExportFormatData(MultipartHttpServletRequest, ExportFormat)' has a cyclomatic complexity of 16. | 3 | 378–442 |
| NPathComplexity | The method 'getExportFormatData(MultipartHttpServletRequest, ExportFormat)' has an NPath complexity of 240 | 3 | 378–442 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 455 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 456 |
| ShortVariable | Avoid variables with short names like os | 3 | 490 |
| LinguisticNaming | Linguistics Antipattern - The method 'isValid' indicates linguistically it returns a boolean, but it returns 'String' | 3 | 512–530 |
| ShortVariable | Avoid variables with short names like is | 3 | 521 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 524 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 87 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 3 | 50–58 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 3 | 54 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MethodReturnsInternalArray | Returning '_content' may expose an internal array. | 3 | 75 |
| ArrayIsStoredDirectly | The user-supplied array 'content' is stored directly. | 3 | 84 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–2037 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 110–2037 |
| CyclomaticComplexity | The class 'SuggestApp' has a total cyclomatic complexity of 205 (highest 21). | 3 | 110–2037 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 111–2037 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 3 | 260 |
| ImmutableField | Private field '_suggestSubmitService' could be made final; it is only initialized in the declaration or constructor. | 3 | 265 |
| ImmutableField | Private field '_commentSubmitService' could be made final; it is only initialized in the declaration or constructor. | 3 | 266 |
| MissingOverride | The method 'getPage(HttpServletRequest, int, Plugin)' is missing an @Override annotation. | 3 | 283–387 |
| CyclomaticComplexity | The method 'getPage(HttpServletRequest, int, Plugin)' has a cyclomatic complexity of 18. | 3 | 283–387 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 283–387 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 375–383 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 406 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 453 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 515 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 570 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 599 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 619 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 658 |
| CyclomaticComplexity | The method 'doCreateSuggestSubmit(XPage, int, HttpServletRequest)' has a cyclomatic complexity of 20. | 3 | 687–769 |
| NPathComplexity | The method 'doCreateSuggestSubmit(XPage, int, HttpServletRequest)' has an NPath complexity of 10368 | 3 | 687–769 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 725–728 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 734–737 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 758 |
| CyclomaticComplexity | The method 'doCreateComment(XPage, int, HttpServletRequest)' has a cyclomatic complexity of 21. | 3 | 958–1040 |
| NPathComplexity | The method 'doCreateComment(XPage, int, HttpServletRequest)' has an NPath complexity of 12960 | 3 | 958–1040 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 971 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1028 |
| NPathComplexity | The method 'doReport(XPage, int, HttpServletRequest)' has an NPath complexity of 288 | 3 | 1057–1122 |
| CyclomaticComplexity | The method 'doReport(XPage, int, HttpServletRequest)' has a cyclomatic complexity of 13. | 3 | 1057–1122 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1113 |
| CyclomaticComplexity | The method 'doVote(XPage, int, HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 1138–1181 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1230 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1240–1241 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1347 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1389 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1403–1404 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 1404 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nMode'. | 3 | 1431 |
| CyclomaticComplexity | The method 'getHtmlSuggestSubmitDetail(HttpServletRequest, int, Plugin, SuggestSubmit, LuteceUser)' has a cyclomatic complexity of 10. | 3 | 1431–1491 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1434 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1435 |
| UnusedFormalParameter | Avoid unused method parameters such as 'plugin'. | 3 | 1544 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nMode'. | 3 | 1544 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1546 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nMode'. | 3 | 1616 |
| CyclomaticComplexity | The method 'doInsertSuggestSubmit(HttpServletRequest, int, Plugin, Suggest, int, int, LuteceUser)' has a cyclomatic complexity of 10. | 3 | 1649–1726 |
| UnusedFormalParameter | Avoid unused method parameters such as 'nMode'. | 3 | 1649 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 1713 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1751 |
| NPathComplexity | The method 'getSearchFields(HttpServletRequest)' has an NPath complexity of 256 | 3 | 1844–1877 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1860–1861 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1862 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1864 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1865 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1866 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1867–1868 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1869 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1871 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–3720 |
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 3 | 34–3720 |
| NcssCount | The class 'SuggestJspBean' has a NCSS line count of 1751 (Highest = 199). | 3 | 145–3720 |
| CyclomaticComplexity | The class 'SuggestJspBean' has a total cyclomatic complexity of 411 (highest 67). | 3 | 145–3720 |
| TooManyFields | Too many fields | 3 | 145–3720 |
| ExcessiveClassLength | Avoid really long classes. | 3 | 145–3720 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 146–3720 |
| ImmutableField | Private field '_searchFields' could be made final; it is only initialized in the declaration or constructor. | 3 | 435 |
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 3 | 436 |
| ImmutableField | Private field '_suggestSubmitService' could be made final; it is only initialized in the declaration or constructor. | 3 | 456 |
| ImmutableField | Private field '_commentSubmitService' could be made final; it is only initialized in the declaration or constructor. | 3 | 457 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 505 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 506–507 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 568 |
| NcssCount | The method 'getManageSuggestSubmit(HttpServletRequest, HttpServletResponse)' has a NCSS line count of 92. | 3 | 609–785 |
| CyclomaticComplexity | The method 'getManageSuggestSubmit(HttpServletRequest, HttpServletResponse)' has a cyclomatic complexity of 22. | 3 | 609–785 |
| NPathComplexity | The method 'getManageSuggestSubmit(HttpServletRequest, HttpServletResponse)' has an NPath complexity of 29160 | 3 | 609–785 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 609–785 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 611 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 612 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 613 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 616 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 616 |
| AvoidDuplicateLiterals | The String literal "Access denied" appears 6 times in this file; the first occurrence is on line 635 | 3 | 635 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 642–654 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 678–697 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 702 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 703–704 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 739–749 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 799 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 805 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 805 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 830 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 831–832 |
| CyclomaticComplexity | The method 'doCreateSuggestSubmit(HttpServletRequest)' has a cyclomatic complexity of 15. | 3 | 904–990 |
| NPathComplexity | The method 'doCreateSuggestSubmit(HttpServletRequest)' has an NPath complexity of 582 | 3 | 904–990 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 919 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 919 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 922 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 923 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 924 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 925 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 926 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 931–934 |
| CollapsibleIfStatements | These nested if statements could be combined | 3 | 940–943 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 1001–1104 |
| CyclomaticComplexity | The method 'getManageCommentSubmit(HttpServletRequest)' has a cyclomatic complexity of 12. | 3 | 1001–1104 |
| NPathComplexity | The method 'getManageCommentSubmit(HttpServletRequest)' has an NPath complexity of 324 | 3 | 1001–1104 |
| NcssCount | The method 'getManageCommentSubmit(HttpServletRequest)' has a NCSS line count of 61. | 3 | 1001–1104 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1004 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1010 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1027 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1039 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1071 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 1072–1073 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1116 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1118 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1159 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1160 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1179–1187 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1205 |
| CyclomaticComplexity | The method 'getConfirmMassChangeSuggestSubmitCategory(HttpServletRequest)' has a cyclomatic complexity of 10. | 3 | 1242–1284 |
| CyclomaticComplexity | The method 'doMassChangeSuggestSubmitCategory(HttpServletRequest)' has a cyclomatic complexity of 11. | 3 | 1295–1341 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1301 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1302 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1354 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1361 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1393–1422 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1397 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1414–1422 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1438 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1441 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 1629–1949 |
| CyclomaticComplexity | The method 'getSuggestData(MultipartHttpServletRequest, Suggest)' has a cyclomatic complexity of 67. | 3 | 1629–1949 |
| NcssCount | The method 'getSuggestData(MultipartHttpServletRequest, Suggest)' has a NCSS line count of 199. | 3 | 1629–1949 |
| NPathComplexity | The method 'getSuggestData(MultipartHttpServletRequest, Suggest)' has an NPath complexity of 829440000 | 3 | 1629–1949 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1632 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1633 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1637 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1639 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1645 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1647 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1648 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1649 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1651 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1652 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1656 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1657 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1658 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1659 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1661 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1663 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1666 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1667 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1668 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1670 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1674 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1675 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1676 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1677 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1678 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1679 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1680 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1683 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1688 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1689 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1690 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1691 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1692 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1693 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1694 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1695 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1696 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1697 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 1701 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 1902–1909 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 1990 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2035 |
| NcssCount | The method 'getModifySuggest(HttpServletRequest)' has a NCSS line count of 86. | 3 | 2063–2189 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 2063–2189 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2066 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2067 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2068 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2071 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2072 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2074 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 2094 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 2105–2106 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 2151 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2364 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2366 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2405 |
| UnusedLocalVariable | Avoid unused local variables such as 'plugin'. | 3 | 2405 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2427 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2428 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 2479 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2544 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2549 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 2557 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 2648 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 3030 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 3 | 3068 |
| UnusedFormalParameter | Avoid unused method parameters such as 'locale'. | 3 | 3090 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 3277–3441 |
| NPathComplexity | The method 'getStatistics(HttpServletRequest)' has an NPath complexity of 24576 | 3 | 3277–3441 |
| CyclomaticComplexity | The method 'getStatistics(HttpServletRequest)' has a cyclomatic complexity of 21. | 3 | 3277–3441 |
| NcssCount | The method 'getStatistics(HttpServletRequest)' has a NCSS line count of 92. | 3 | 3277–3441 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 3297–3305 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 3 | 3302 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 3315 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 3317 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 3327 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 3329 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 3383 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 3385 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 3386 |
| ShortVariable | Avoid variables with short names like fV | 3 | 3391 |
| ShortVariable | Avoid variables with short names like fC | 3 | 3392 |
| ShortVariable | Avoid variables with short names like bd | 3 | 3394 |
| AvoidDecimalLiteralsInBigDecimalConstructor | Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal | 3 | 3394 |
| AvoidDecimalLiteralsInBigDecimalConstructor | Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal | 3 | 3397 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 3499 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 3500 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 3502 |
| NPathComplexity | The method 'updateSearchFieldsData(HttpServletRequest)' has an NPath complexity of 4374 | 3 | 3538–3589 |
| CyclomaticComplexity | The method 'updateSearchFieldsData(HttpServletRequest)' has a cyclomatic complexity of 16. | 3 | 3538–3589 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 3613 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 3672 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ImmutableField | Private field '_nDefaultItemsPerPage' could be made final; it is only initialized in the declaration or constructor. | 3 | 113 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 128 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 133–134 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 156 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 196 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 197 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 198 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 200 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 200 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 203–219 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 240 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 241 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 245–261 |
| CyclomaticComplexity | The method 'getSuggestSubmitTypeData(MultipartHttpServletRequest, SuggestSubmitType)' has a cyclomatic complexity of 10. | 3 | 335–386 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 338 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 343 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 344 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FieldNamingConventions | The constant name '_cache' doesn't match '[A-Z][A-Z_0-9]*' | 1 | 60 |
| ShortVariable | Avoid variables with short names like r | 3 | 87 |
| ShortVariable | Avoid variables with short names like r | 3 | 137 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 3 | 34–255 |
| ExcessiveMethodLength | Avoid really long methods. | 3 | 143–244 |
| CyclomaticComplexity | The method 'process(HttpServletRequest, HttpServletResponse, AdminUser, SuggestAdminSearchFields)' has a cyclomatic complexity of 10. | 3 | 143–244 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 147 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 151 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 217 |
| ShortVariable | Avoid variables with short names like os | 3 | 229 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedImports | Avoid unused imports such as 'fr.paris.lutece.portal.business.user.AdminUser' | 4 | 36 |
| UnusedImports | Avoid unused imports such as 'java.util.Map' | 4 | 40 |
| UnusedImports | Avoid unused imports such as 'javax.servlet.http.HttpServletRequest' | 4 | 42 |
| UnusedImports | Avoid unused imports such as 'javax.servlet.http.HttpServletResponse' | 4 | 43 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 120 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 129–159 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 78–79 |
| CyclomaticComplexity | The method 'process(HttpServletRequest, HttpServletResponse, AdminUser, SuggestAdminSearchFields)' has a cyclomatic complexity of 12. | 3 | 112–163 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 115 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 120–158 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 78–79 |
| CyclomaticComplexity | The method 'process(HttpServletRequest, HttpServletResponse, AdminUser, SuggestAdminSearchFields)' has a cyclomatic complexity of 12. | 3 | 112–163 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 115 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 120–158 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 3 | 78–79 |
| CyclomaticComplexity | The method 'process(HttpServletRequest, HttpServletResponse, AdminUser, SuggestAdminSearchFields)' has a cyclomatic complexity of 12. | 3 | 112–167 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 115 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 120–162 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Public method and constructor comments are required | 3 | 61–64 |
| CommentRequired | Public method and constructor comments are required | 3 | 66–69 |
| CommentRequired | Public method and constructor comments are required | 3 | 71–74 |
| CommentRequired | Public method and constructor comments are required | 3 | 76–79 |
| CommentRequired | Public method and constructor comments are required | 3 | 81–84 |
| CommentRequired | Public method and constructor comments are required | 3 | 86–89 |
| CommentRequired | Public method and constructor comments are required | 3 | 91–94 |
| CommentRequired | Public method and constructor comments are required | 3 | 96–99 |
| CommentRequired | Public method and constructor comments are required | 3 | 111–114 |
| CommentRequired | Public method and constructor comments are required | 3 | 116–119 |
| CommentRequired | Public method and constructor comments are required | 3 | 121–124 |
| CommentRequired | Public method and constructor comments are required | 3 | 126–129 |
| CommentRequired | Public method and constructor comments are required | 3 | 131–134 |
| CommentRequired | Public method and constructor comments are required | 3 | 136–139 |
| CommentRequired | Public method and constructor comments are required | 3 | 141–144 |
| CommentRequired | Public method and constructor comments are required | 3 | 146–149 |
