Lutece suggest plugin – SpotBugs Bug Detector Report

SpotBugs Bug Detector Report

The following document contains the results of SpotBugs

SpotBugs Version is 4.5.3

Threshold is medium

Effort is default

Summary

Classes	Bugs	Errors	Missing Classes
151	105	0	0

Files

Class	Bugs
fr.paris.lutece.plugins.suggest.business.Category	1
fr.paris.lutece.plugins.suggest.business.CommentSubmit	8
fr.paris.lutece.plugins.suggest.business.Entry	8
fr.paris.lutece.plugins.suggest.business.ExportFormat	2
fr.paris.lutece.plugins.suggest.business.ReportedMessage	4
fr.paris.lutece.plugins.suggest.business.Response	6
fr.paris.lutece.plugins.suggest.business.SubmitFilter	6
fr.paris.lutece.plugins.suggest.business.Suggest	19
fr.paris.lutece.plugins.suggest.business.SuggestSubmit	20
fr.paris.lutece.plugins.suggest.business.SuggestSubmitType	3
fr.paris.lutece.plugins.suggest.business.VideoType	2
fr.paris.lutece.plugins.suggest.business.VoteButton	2
fr.paris.lutece.plugins.suggest.business.VoteType	2
fr.paris.lutece.plugins.suggest.service.CommentSubmitService	1
fr.paris.lutece.plugins.suggest.service.SuggestSubmitService	1
fr.paris.lutece.plugins.suggest.service.search.SuggestIndexer	1
fr.paris.lutece.plugins.suggest.service.subscription.SuggestSubscriptionProviderService	3
fr.paris.lutece.plugins.suggest.service.suggestsearch.SuggestLuceneSearchEngine	1
fr.paris.lutece.plugins.suggest.web.ResourceValueObject	2
fr.paris.lutece.plugins.suggest.web.SuggestApp	7
fr.paris.lutece.plugins.suggest.web.SuggestJspBean	4
fr.paris.lutece.plugins.suggest.web.action.SuggestAdminSearchFields	2

fr.paris.lutece.plugins.suggest.business.Category

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.Category defines equals and uses Object.hashCode()	BAD_PRACTICE	HE_EQUALS_USE_HASHCODE	103	High

fr.paris.lutece.plugins.suggest.business.CommentSubmit

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.CommentSubmit.getComments() may expose internal representation by returning CommentSubmit._listComments	MALICIOUS_CODE	EI_EXPOSE_REP	224	Medium
fr.paris.lutece.plugins.suggest.business.CommentSubmit.getDateComment() may expose internal representation by returning CommentSubmit._tDateComment	MALICIOUS_CODE	EI_EXPOSE_REP	118	Medium
fr.paris.lutece.plugins.suggest.business.CommentSubmit.getDateModify() may expose internal representation by returning CommentSubmit._tDateModify	MALICIOUS_CODE	EI_EXPOSE_REP	251	Medium
fr.paris.lutece.plugins.suggest.business.CommentSubmit.getSuggestSubmit() may expose internal representation by returning CommentSubmit._suggestSubmit	MALICIOUS_CODE	EI_EXPOSE_REP	97	Medium
fr.paris.lutece.plugins.suggest.business.CommentSubmit.setComments(List) may expose internal representation by storing an externally mutable object into CommentSubmit._listComments	MALICIOUS_CODE	EI_EXPOSE_REP2	216	Medium
fr.paris.lutece.plugins.suggest.business.CommentSubmit.setDateComment(Timestamp) may expose internal representation by storing an externally mutable object into CommentSubmit._tDateComment	MALICIOUS_CODE	EI_EXPOSE_REP2	129	Medium
fr.paris.lutece.plugins.suggest.business.CommentSubmit.setDateModify(Timestamp) may expose internal representation by storing an externally mutable object into CommentSubmit._tDateModify	MALICIOUS_CODE	EI_EXPOSE_REP2	262	Medium
fr.paris.lutece.plugins.suggest.business.CommentSubmit.setSuggestSubmit(SuggestSubmit) may expose internal representation by storing an externally mutable object into CommentSubmit._suggestSubmit	MALICIOUS_CODE	EI_EXPOSE_REP2	108	Medium

fr.paris.lutece.plugins.suggest.business.Entry

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.Entry.getEntryAdditionalAttributeList() may expose internal representation by returning Entry._listEntryAdditionalAttribute	MALICIOUS_CODE	EI_EXPOSE_REP	509	Medium
fr.paris.lutece.plugins.suggest.business.Entry.getEntryType() may expose internal representation by returning Entry._entryType	MALICIOUS_CODE	EI_EXPOSE_REP	121	Medium
fr.paris.lutece.plugins.suggest.business.Entry.getRegularExpressionList() may expose internal representation by returning Entry._listRegularExpressionList	MALICIOUS_CODE	EI_EXPOSE_REP	286	Medium
fr.paris.lutece.plugins.suggest.business.Entry.getSuggest() may expose internal representation by returning Entry._suggest	MALICIOUS_CODE	EI_EXPOSE_REP	266	Medium
fr.paris.lutece.plugins.suggest.business.Entry.setEntryAdditionalAttributeList(List) may expose internal representation by storing an externally mutable object into Entry._listEntryAdditionalAttribute	MALICIOUS_CODE	EI_EXPOSE_REP2	520	Medium
fr.paris.lutece.plugins.suggest.business.Entry.setEntryType(EntryType) may expose internal representation by storing an externally mutable object into Entry._entryType	MALICIOUS_CODE	EI_EXPOSE_REP2	191	Medium
fr.paris.lutece.plugins.suggest.business.Entry.setRegularExpressionList(List) may expose internal representation by storing an externally mutable object into Entry._listRegularExpressionList	MALICIOUS_CODE	EI_EXPOSE_REP2	297	Medium
fr.paris.lutece.plugins.suggest.business.Entry.setSuggest(Suggest) may expose internal representation by storing an externally mutable object into Entry._suggest	MALICIOUS_CODE	EI_EXPOSE_REP2	277	Medium

fr.paris.lutece.plugins.suggest.business.ExportFormat

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.ExportFormat.getXsl() may expose internal representation by returning ExportFormat._xsl	MALICIOUS_CODE	EI_EXPOSE_REP	118	Medium
fr.paris.lutece.plugins.suggest.business.ExportFormat.setXsl(byte[]) may expose internal representation by storing an externally mutable object into ExportFormat._xsl	MALICIOUS_CODE	EI_EXPOSE_REP2	129	Medium

fr.paris.lutece.plugins.suggest.business.ReportedMessage

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.ReportedMessage.getDateReported() may expose internal representation by returning ReportedMessage._tDateReported	MALICIOUS_CODE	EI_EXPOSE_REP	77	Medium
fr.paris.lutece.plugins.suggest.business.ReportedMessage.getSuggestSubmit() may expose internal representation by returning ReportedMessage._suggestSubmit	MALICIOUS_CODE	EI_EXPOSE_REP	56	Medium
fr.paris.lutece.plugins.suggest.business.ReportedMessage.setDateReported(Timestamp) may expose internal representation by storing an externally mutable object into ReportedMessage._tDateReported	MALICIOUS_CODE	EI_EXPOSE_REP2	88	Medium
fr.paris.lutece.plugins.suggest.business.ReportedMessage.setSuggestSubmit(SuggestSubmit) may expose internal representation by storing an externally mutable object into ReportedMessage._suggestSubmit	MALICIOUS_CODE	EI_EXPOSE_REP2	67	Medium

fr.paris.lutece.plugins.suggest.business.Response

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.Response.getEntry() may expose internal representation by returning Response._entry	MALICIOUS_CODE	EI_EXPOSE_REP	85	Medium
fr.paris.lutece.plugins.suggest.business.Response.getImage() may expose internal representation by returning Response._image	MALICIOUS_CODE	EI_EXPOSE_REP	146	Medium
fr.paris.lutece.plugins.suggest.business.Response.getSuggestSubmit() may expose internal representation by returning Response._suggestSubmit	MALICIOUS_CODE	EI_EXPOSE_REP	65	Medium
fr.paris.lutece.plugins.suggest.business.Response.setEntry(IEntry) may expose internal representation by storing an externally mutable object into Response._entry	MALICIOUS_CODE	EI_EXPOSE_REP2	96	Medium
fr.paris.lutece.plugins.suggest.business.Response.setImage(ImageResource) may expose internal representation by storing an externally mutable object into Response._image	MALICIOUS_CODE	EI_EXPOSE_REP2	157	Medium
fr.paris.lutece.plugins.suggest.business.Response.setSuggestSubmit(SuggestSubmit) may expose internal representation by storing an externally mutable object into Response._suggestSubmit	MALICIOUS_CODE	EI_EXPOSE_REP2	76	Medium

fr.paris.lutece.plugins.suggest.business.SubmitFilter

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.SubmitFilter.getDateFirst() may expose internal representation by returning SubmitFilter._tDateFirst	MALICIOUS_CODE	EI_EXPOSE_REP	239	Medium
fr.paris.lutece.plugins.suggest.business.SubmitFilter.getDateLast() may expose internal representation by returning SubmitFilter._tDateLast	MALICIOUS_CODE	EI_EXPOSE_REP	268	Medium
fr.paris.lutece.plugins.suggest.business.SubmitFilter.getSortBy() may expose internal representation by returning SubmitFilter._listSortBy	MALICIOUS_CODE	EI_EXPOSE_REP	298	Medium
fr.paris.lutece.plugins.suggest.business.SubmitFilter.setDateFirst(Timestamp) may expose internal representation by storing an externally mutable object into SubmitFilter._tDateFirst	MALICIOUS_CODE	EI_EXPOSE_REP2	250	Medium
fr.paris.lutece.plugins.suggest.business.SubmitFilter.setDateLast(Timestamp) may expose internal representation by storing an externally mutable object into SubmitFilter._tDateLast	MALICIOUS_CODE	EI_EXPOSE_REP2	279	Medium
fr.paris.lutece.plugins.suggest.business.SubmitFilter.setSortBy(List) may expose internal representation by storing an externally mutable object into SubmitFilter._listSortBy	MALICIOUS_CODE	EI_EXPOSE_REP2	309	Medium

fr.paris.lutece.plugins.suggest.business.Suggest

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.Suggest.getActions() may expose internal representation by returning Suggest._listActions	MALICIOUS_CODE	EI_EXPOSE_REP	425	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.getCategories() may expose internal representation by returning Suggest._listCategories	MALICIOUS_CODE	EI_EXPOSE_REP	628	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.getDateCreation() may expose internal representation by returning Suggest._tDateCreation	MALICIOUS_CODE	EI_EXPOSE_REP	385	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.getEntries() may expose internal representation by returning Suggest._listEntries	MALICIOUS_CODE	EI_EXPOSE_REP	608	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.getImage() may expose internal representation by returning Suggest._image	MALICIOUS_CODE	EI_EXPOSE_REP	1358	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.getSuggestSubmitTypes() may expose internal representation by returning Suggest._listSuggestSubmitTypes	MALICIOUS_CODE	EI_EXPOSE_REP	1238	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.getSuggestsSubmit() may expose internal representation by returning Suggest._listSuggestsSubmit	MALICIOUS_CODE	EI_EXPOSE_REP	853	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.getVoteType() may expose internal representation by returning Suggest._voteType	MALICIOUS_CODE	EI_EXPOSE_REP	648	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.setActions(List) may expose internal representation by storing an externally mutable object into Suggest._listActions	MALICIOUS_CODE	EI_EXPOSE_REP2	436	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.setCategories(List) may expose internal representation by storing an externally mutable object into Suggest._listCategories	MALICIOUS_CODE	EI_EXPOSE_REP2	639	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.setDateCreation(Timestamp) may expose internal representation by storing an externally mutable object into Suggest._tDateCreation	MALICIOUS_CODE	EI_EXPOSE_REP2	396	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.setEntries(List) may expose internal representation by storing an externally mutable object into Suggest._listEntries	MALICIOUS_CODE	EI_EXPOSE_REP2	619	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.setImage(ImageResource) may expose internal representation by storing an externally mutable object into Suggest._image	MALICIOUS_CODE	EI_EXPOSE_REP2	1369	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.setSuggestSubmiTypes(List) may expose internal representation by storing an externally mutable object into Suggest._listSuggestSubmitTypes	MALICIOUS_CODE	EI_EXPOSE_REP2	1249	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.setSuggestsSubmit(List) may expose internal representation by storing an externally mutable object into Suggest._listSuggestsSubmit	MALICIOUS_CODE	EI_EXPOSE_REP2	864	Medium
fr.paris.lutece.plugins.suggest.business.Suggest.setVoteType(VoteType) may expose internal representation by storing an externally mutable object into Suggest._voteType	MALICIOUS_CODE	EI_EXPOSE_REP2	659	Medium
Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.suggest.business.Suggest._listenerRegularExpression in fr.paris.lutece.plugins.suggest.business.Suggest.init()	MT_CORRECTNESS	LI_LAZY_INIT_UPDATE_STATIC	166-168	Medium
Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.suggest.business.Suggest._listenerRole in fr.paris.lutece.plugins.suggest.business.Suggest.init()	MT_CORRECTNESS	LI_LAZY_INIT_UPDATE_STATIC	172-174	Medium
Incorrect lazy initialization and update of static field fr.paris.lutece.plugins.suggest.business.Suggest._listenerWorkgroup in fr.paris.lutece.plugins.suggest.business.Suggest.init()	MT_CORRECTNESS	LI_LAZY_INIT_UPDATE_STATIC	160-162	Medium

fr.paris.lutece.plugins.suggest.business.SuggestSubmit

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getCategory() may expose internal representation by returning SuggestSubmit._category	MALICIOUS_CODE	EI_EXPOSE_REP	257	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getComments() may expose internal representation by returning SuggestSubmit._listComments	MALICIOUS_CODE	EI_EXPOSE_REP	517	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getDateResponse() may expose internal representation by returning SuggestSubmit._tDateResponse	MALICIOUS_CODE	EI_EXPOSE_REP	197	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getListWorkflowActions() may expose internal representation by returning SuggestSubmit._listWorkflowActions	MALICIOUS_CODE	EI_EXPOSE_REP	714	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getReportedMessages() may expose internal representation by returning SuggestSubmit._listReportedMessages	MALICIOUS_CODE	EI_EXPOSE_REP	619	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getResponses() may expose internal representation by returning SuggestSubmit._listResponse	MALICIOUS_CODE	EI_EXPOSE_REP	217	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getState() may expose internal representation by returning SuggestSubmit._state	MALICIOUS_CODE	EI_EXPOSE_REP	735	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getSuggest() may expose internal representation by returning SuggestSubmit._suggest	MALICIOUS_CODE	EI_EXPOSE_REP	154	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getSuggestSubmitState() may expose internal representation by returning SuggestSubmit._suggestSubmitState	MALICIOUS_CODE	EI_EXPOSE_REP	237	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.getSuggestSubmitType() may expose internal representation by returning SuggestSubmit._suggestSubmitType	MALICIOUS_CODE	EI_EXPOSE_REP	551	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setCategory(Category) may expose internal representation by storing an externally mutable object into SuggestSubmit._category	MALICIOUS_CODE	EI_EXPOSE_REP2	268	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setComments(List) may expose internal representation by storing an externally mutable object into SuggestSubmit._listComments	MALICIOUS_CODE	EI_EXPOSE_REP2	509	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setDateResponse(Timestamp) may expose internal representation by storing an externally mutable object into SuggestSubmit._tDateResponse	MALICIOUS_CODE	EI_EXPOSE_REP2	208	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setListWorkflowActions(Collection) may expose internal representation by storing an externally mutable object into SuggestSubmit._listWorkflowActions	MALICIOUS_CODE	EI_EXPOSE_REP2	725	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setReportedMessages(List) may expose internal representation by storing an externally mutable object into SuggestSubmit._listReportedMessages	MALICIOUS_CODE	EI_EXPOSE_REP2	630	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setResponses(List) may expose internal representation by storing an externally mutable object into SuggestSubmit._listResponse	MALICIOUS_CODE	EI_EXPOSE_REP2	228	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setState(State) may expose internal representation by storing an externally mutable object into SuggestSubmit._state	MALICIOUS_CODE	EI_EXPOSE_REP2	746	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setSuggest(Suggest) may expose internal representation by storing an externally mutable object into SuggestSubmit._suggest	MALICIOUS_CODE	EI_EXPOSE_REP2	166	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setSuggestSubmitState(SuggestSubmitState) may expose internal representation by storing an externally mutable object into SuggestSubmit._suggestSubmitState	MALICIOUS_CODE	EI_EXPOSE_REP2	248	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmit.setSuggestSubmitType(SuggestSubmitType) may expose internal representation by storing an externally mutable object into SuggestSubmit._suggestSubmitType	MALICIOUS_CODE	EI_EXPOSE_REP2	543	Medium

fr.paris.lutece.plugins.suggest.business.SuggestSubmitType

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.SuggestSubmitType.getPictogram() may expose internal representation by returning SuggestSubmitType._imgPictogram	MALICIOUS_CODE	EI_EXPOSE_REP	123	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmitType.setPictogram(ImageResource) may expose internal representation by storing an externally mutable object into SuggestSubmitType._imgPictogram	MALICIOUS_CODE	EI_EXPOSE_REP2	115	Medium
fr.paris.lutece.plugins.suggest.business.SuggestSubmitType defines equals and uses Object.hashCode()	BAD_PRACTICE	HE_EQUALS_USE_HASHCODE	188	High

fr.paris.lutece.plugins.suggest.business.VideoType

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.VideoType.getVideo() may expose internal representation by returning VideoType._video	MALICIOUS_CODE	EI_EXPOSE_REP	119	Medium
fr.paris.lutece.plugins.suggest.business.VideoType.setVideo(byte[]) may expose internal representation by storing an externally mutable object into VideoType._video	MALICIOUS_CODE	EI_EXPOSE_REP2	111	Medium

fr.paris.lutece.plugins.suggest.business.VoteButton

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.VoteButton.getIconContent() may expose internal representation by returning VoteButton._byIconContent	MALICIOUS_CODE	EI_EXPOSE_REP	135	Medium
fr.paris.lutece.plugins.suggest.business.VoteButton.setIconContent(byte[]) may expose internal representation by storing an externally mutable object into VoteButton._byIconContent	MALICIOUS_CODE	EI_EXPOSE_REP2	146	Medium

fr.paris.lutece.plugins.suggest.business.VoteType

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.business.VoteType.getVoteButtons() may expose internal representation by returning VoteType._listVoteButtons	MALICIOUS_CODE	EI_EXPOSE_REP	96	Medium
fr.paris.lutece.plugins.suggest.business.VoteType.setVoteButtons(List) may expose internal representation by storing an externally mutable object into VoteType._listVoteButtons	MALICIOUS_CODE	EI_EXPOSE_REP2	107	Medium

fr.paris.lutece.plugins.suggest.service.CommentSubmitService

Bug	Category	Details	Line	Priority
Public static fr.paris.lutece.plugins.suggest.service.CommentSubmitService.getService() may expose internal representation by returning CommentSubmitService._singleton	MALICIOUS_CODE	MS_EXPOSE_REP	181	Medium

fr.paris.lutece.plugins.suggest.service.SuggestSubmitService

Bug	Category	Details	Line	Priority
Public static fr.paris.lutece.plugins.suggest.service.SuggestSubmitService.getService() may expose internal representation by returning SuggestSubmitService._singleton	MALICIOUS_CODE	MS_EXPOSE_REP	446	Medium

fr.paris.lutece.plugins.suggest.service.search.SuggestIndexer

Bug	Category	Details	Line	Priority
Found reliance on default encoding in fr.paris.lutece.plugins.suggest.service.search.SuggestIndexer.getDocument(SuggestSubmit, String): String.getBytes()	I18N	DM_DEFAULT_ENCODING	260	High

fr.paris.lutece.plugins.suggest.service.subscription.SuggestSubscriptionProviderService

Bug	Category	Details	Line	Priority
There is an apparent infinite recursive loop in fr.paris.lutece.plugins.suggest.service.subscription.SuggestSubscriptionProviderService.getSubscriptionHtmlDescriptionBis(LuteceUser, String, String, Locale, String)	CORRECTNESS	IL_INFINITE_RECURSIVE_LOOP	375	High
Incorrect lazy initialization of static field fr.paris.lutece.plugins.suggest.service.subscription.SuggestSubscriptionProviderService._instance in fr.paris.lutece.plugins.suggest.service.subscription.SuggestSubscriptionProviderService.getService()	MT_CORRECTNESS	LI_LAZY_INIT_STATIC	82-86	Medium
Public static fr.paris.lutece.plugins.suggest.service.subscription.SuggestSubscriptionProviderService.getService() may expose internal representation by returning SuggestSubscriptionProviderService._instance	MALICIOUS_CODE	MS_EXPOSE_REP	90	Medium

fr.paris.lutece.plugins.suggest.service.suggestsearch.SuggestLuceneSearchEngine

Bug	Category	Details	Line	Priority
Exception is caught when Exception is not thrown in fr.paris.lutece.plugins.suggest.service.suggestsearch.SuggestLuceneSearchEngine.getSearchResults(String, SubmitFilter)	STYLE	REC_CATCH_EXCEPTION	135	Medium

fr.paris.lutece.plugins.suggest.web.ResourceValueObject

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.web.ResourceValueObject.getContent() may expose internal representation by returning ResourceValueObject._content	MALICIOUS_CODE	EI_EXPOSE_REP	75	Medium
fr.paris.lutece.plugins.suggest.web.ResourceValueObject.setContent(byte[]) may expose internal representation by storing an externally mutable object into ResourceValueObject._content	MALICIOUS_CODE	EI_EXPOSE_REP2	86	Medium

fr.paris.lutece.plugins.suggest.web.SuggestApp

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.web.SuggestApp.init(HttpServletRequest, Plugin) may expose internal representation by storing an externally mutable object into SuggestApp._plugin	MALICIOUS_CODE	EI_EXPOSE_REP2	1810	Medium
Nullcheck of suggest at line 606 of value previously dereferenced in fr.paris.lutece.plugins.suggest.web.SuggestApp.getViewCreateSubComment(XPage, int, HttpServletRequest)	CORRECTNESS	RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE	606	Medium
Class fr.paris.lutece.plugins.suggest.web.SuggestApp defines non-transient non-serializable instance field _commentSubmitService	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium
Class fr.paris.lutece.plugins.suggest.web.SuggestApp defines non-transient non-serializable instance field _plugin	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium
Class fr.paris.lutece.plugins.suggest.web.SuggestApp defines non-transient non-serializable instance field _suggestSubmitService	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium
Class fr.paris.lutece.plugins.suggest.web.SuggestApp defines non-transient non-serializable instance field _urlSuggestXpageHome	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium
Useless object stored in variable model of method fr.paris.lutece.plugins.suggest.web.SuggestApp.getViewSuggestList(XPage, int, HttpServletRequest)	STYLE	UC_USELESS_OBJECT	406	Medium

fr.paris.lutece.plugins.suggest.web.SuggestJspBean

Bug	Category	Details	Line	Priority
Dead store to plugin in fr.paris.lutece.plugins.suggest.web.SuggestJspBean.doRemoveSuggest(HttpServletRequest)	STYLE	DLS_DEAD_LOCAL_STORE	2405	Medium
Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.suggest.web.SuggestJspBean.doSubmitOfficialAnswer(HttpServletRequest)	PERFORMANCE	DM_BOXED_PRIMITIVE_FOR_PARSING	1437	High
Class fr.paris.lutece.plugins.suggest.web.SuggestJspBean defines non-transient non-serializable instance field _commentSubmitService	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium
Class fr.paris.lutece.plugins.suggest.web.SuggestJspBean defines non-transient non-serializable instance field _suggestSubmitService	BAD_PRACTICE	SE_BAD_FIELD	Not available	Medium

fr.paris.lutece.plugins.suggest.web.action.SuggestAdminSearchFields

Bug	Category	Details	Line	Priority
fr.paris.lutece.plugins.suggest.web.action.SuggestAdminSearchFields.getSelectedSuggestSubmit() may expose internal representation by returning SuggestAdminSearchFields._selectedSuggestSubmit	MALICIOUS_CODE	EI_EXPOSE_REP	103	Medium
fr.paris.lutece.plugins.suggest.web.action.SuggestAdminSearchFields.setSelectedSuggestSubmit(List) may expose internal representation by storing an externally mutable object into SuggestAdminSearchFields._selectedSuggestSubmit	MALICIOUS_CODE	EI_EXPOSE_REP2	108	Medium