Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/plugins/termofservice/business/EntryDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 256

fr/paris/lutece/plugins/termofservice/business/IEntryDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 106
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 114

fr/paris/lutece/plugins/termofservice/business/IUserAcceptedDAO.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 114

fr/paris/lutece/plugins/termofservice/rs/Constants.java

Rule Violation Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3980

fr/paris/lutece/plugins/termofservice/rs/UserAcceptedRest.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name 'header_security' doesn't match '[a-z][a-zA-Z0-9]*' 86
FormalParameterNamingConventions The method parameter name 'id_entry_tos' doesn't match '[a-z][a-zA-Z0-9]*' 142
FormalParameterNamingConventions The method parameter name 'header_security' doesn't match '[a-z][a-zA-Z0-9]*' 144
FormalParameterNamingConventions The method parameter name 'fk_id_entry' doesn't match '[a-z][a-zA-Z0-9]*' 170

fr/paris/lutece/plugins/termofservice/rs/dto/UserDTO.java

Rule Violation Line
FieldNamingConventions The field name 'nIdTermOfService' doesn't match '_[a-z][a-zA-Z0-9]*' 47
FieldNamingConventions The field name 'strGuid' doesn't match '_[a-z][a-zA-Z0-9]*' 48
FieldNamingConventions The field name 'nId' doesn't match '_[a-z][a-zA-Z0-9]*' 49

fr/paris/lutece/plugins/termofservice/service/ClientRS.java

Rule Violation Line
ClassNamingConventions The utility class name 'ClientRS' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 51114

Priority 3

fr/paris/lutece/plugins/termofservice/business/EntryDAO.java

Rule Violation Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 219221

fr/paris/lutece/plugins/termofservice/business/UserAcceptedDAO.java

Rule Violation Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 227229

fr/paris/lutece/plugins/termofservice/rs/Constants.java

Rule Violation Line
ShortVariable Avoid variables with short names like ID 46

fr/paris/lutece/plugins/termofservice/rs/UserAcceptedRest.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 194

fr/paris/lutece/plugins/termofservice/rs/dto/UserDTO.java

Rule Violation Line
CommentRequired Header comments are required 4480
CommentRequired Public method and constructor comments are required 5254
CommentRequired Public method and constructor comments are required 5658
CommentRequired Public method and constructor comments are required 6062
CommentRequired Public method and constructor comments are required 6466
CommentRequired Public method and constructor comments are required 6870
CommentRequired Public method and constructor comments are required 7274

fr/paris/lutece/plugins/termofservice/service/ClientRS.java

Rule Violation Line
CommentRequired Header comments are required 51114
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 51114
CommentRequired Public method and constructor comments are required 5580
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 63
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 63
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'user' 72
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 74
CommentRequired Public method and constructor comments are required 82112
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 88
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 92
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'user' 104
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 106

fr/paris/lutece/plugins/termofservice/web/AbstractManageTOSJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 50110
DefaultPackage Use explicit scoping instead of the default package private level 109
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 109

fr/paris/lutece/plugins/termofservice/web/EntryJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 63299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 121
DefaultPackage Use explicit scoping instead of the default package private level 138147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 139147
ConfusingTernary Avoid if (x != y) ..; else ..; 166

fr/paris/lutece/plugins/termofservice/web/EntryXPage.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 72221
ConfusingTernary Avoid if (x != y) ..; else ..; 114
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 188

fr/paris/lutece/plugins/termofservice/web/TOSPredicate.java

Rule Violation Line
CommentRequired Header comments are required 4772
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _biPredicate field if you want a default access modifier 49
DefaultPackage Use explicit scoping instead of the default package private level 49
CommentRequired Public method and constructor comments are required 5164
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 5562

Priority 4

fr/paris/lutece/plugins/termofservice/business/Entry.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'javax.validation.constraints.Size' 36

fr/paris/lutece/plugins/termofservice/web/TOSPredicate.java

Rule Violation Line
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 39

Files

fr/paris/lutece/plugins/termofservice/business/Entry.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'javax.validation.constraints.Size' 4 36

fr/paris/lutece/plugins/termofservice/business/EntryDAO.java

Rule Violation Priority Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 219221
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 256

fr/paris/lutece/plugins/termofservice/business/IEntryDAO.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 106
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 114

fr/paris/lutece/plugins/termofservice/business/IUserAcceptedDAO.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' 1 114

fr/paris/lutece/plugins/termofservice/business/UserAcceptedDAO.java

Rule Violation Priority Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 3 227229

fr/paris/lutece/plugins/termofservice/rs/Constants.java

Rule Violation Priority Line
ClassNamingConventions The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 3980
ShortVariable Avoid variables with short names like ID 3 46

fr/paris/lutece/plugins/termofservice/rs/UserAcceptedRest.java

Rule Violation Priority Line
FormalParameterNamingConventions The method parameter name 'header_security' doesn't match '[a-z][a-zA-Z0-9]*' 1 86
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 116
FormalParameterNamingConventions The method parameter name 'id_entry_tos' doesn't match '[a-z][a-zA-Z0-9]*' 1 142
FormalParameterNamingConventions The method parameter name 'header_security' doesn't match '[a-z][a-zA-Z0-9]*' 1 144
FormalParameterNamingConventions The method parameter name 'fk_id_entry' doesn't match '[a-z][a-zA-Z0-9]*' 1 170
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 194

fr/paris/lutece/plugins/termofservice/rs/dto/UserDTO.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 4480
FieldNamingConventions The field name 'nIdTermOfService' doesn't match '_[a-z][a-zA-Z0-9]*' 1 47
FieldNamingConventions The field name 'strGuid' doesn't match '_[a-z][a-zA-Z0-9]*' 1 48
FieldNamingConventions The field name 'nId' doesn't match '_[a-z][a-zA-Z0-9]*' 1 49
CommentRequired Public method and constructor comments are required 3 5254
CommentRequired Public method and constructor comments are required 3 5658
CommentRequired Public method and constructor comments are required 3 6062
CommentRequired Public method and constructor comments are required 3 6466
CommentRequired Public method and constructor comments are required 3 6870
CommentRequired Public method and constructor comments are required 3 7274

fr/paris/lutece/plugins/termofservice/service/ClientRS.java

Rule Violation Priority Line
CommentRequired Header comments are required 3 51114
UseUtilityClass All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 3 51114
ClassNamingConventions The utility class name 'ClientRS' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 1 51114
CommentRequired Public method and constructor comments are required 3 5580
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 63
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 63
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'user' 3 72
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 74
CommentRequired Public method and constructor comments are required 3 82112
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 88
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 3 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 3 92
UnnecessaryLocalBeforeReturn Consider simply returning the value vs storing it in local variable 'user' 3 104
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 3 106

fr/paris/lutece/plugins/termofservice/web/AbstractManageTOSJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 50110
DefaultPackage Use explicit scoping instead of the default package private level 3 109
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 109

fr/paris/lutece/plugins/termofservice/web/EntryJspBean.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 63299
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 3 121
DefaultPackage Use explicit scoping instead of the default package private level 3 138147
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier 3 139147
ConfusingTernary Avoid if (x != y) ..; else ..; 3 166

fr/paris/lutece/plugins/termofservice/web/EntryXPage.java

Rule Violation Priority Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 3 72221
ConfusingTernary Avoid if (x != y) ..; else ..; 3 114
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 3 188

fr/paris/lutece/plugins/termofservice/web/TOSPredicate.java

Rule Violation Priority Line
UnusedImports Avoid unused imports such as 'org.apache.commons.lang3.StringUtils' 4 39
CommentRequired Header comments are required 3 4772
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the _biPredicate field if you want a default access modifier 3 49
DefaultPackage Use explicit scoping instead of the default package private level 3 49
CommentRequired Public method and constructor comments are required 3 5164
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 3 5562