The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 269 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 119 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 127 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 124 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–80 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'header_security' doesn't match '[a-z][a-zA-Z0-9]*' | 86 |
| FormalParameterNamingConventions | The method parameter name 'id_entry_tos' doesn't match '[a-z][a-zA-Z0-9]*' | 142 |
| FormalParameterNamingConventions | The method parameter name 'header_security' doesn't match '[a-z][a-zA-Z0-9]*' | 144 |
| FormalParameterNamingConventions | The method parameter name 'fk_id_entry' doesn't match '[a-z][a-zA-Z0-9]*' | 170 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The field name 'nIdTermOfService' doesn't match '_[a-z][a-zA-Z0-9]*' | 47 |
| FieldNamingConventions | The field name 'strGuid' doesn't match '_[a-z][a-zA-Z0-9]*' | 48 |
| FieldNamingConventions | The field name 'nId' doesn't match '_[a-z][a-zA-Z0-9]*' | 49 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ClientRS' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 51–114 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 51–126 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 43–56 |
| ClassNamingConventions | The utility class name 'TOSConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 43–56 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 51–334 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 230–232 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 46–137 |
| Rule | Violation | Line |
|---|---|---|
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 228–230 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like ID | 46 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 116 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 194 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 44–80 |
| CommentRequired | Public method and constructor comments are required | 52–54 |
| CommentRequired | Public method and constructor comments are required | 56–58 |
| CommentRequired | Public method and constructor comments are required | 60–62 |
| CommentRequired | Public method and constructor comments are required | 64–66 |
| CommentRequired | Public method and constructor comments are required | 68–70 |
| CommentRequired | Public method and constructor comments are required | 72–74 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 51–114 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 51–114 |
| CommentRequired | Public method and constructor comments are required | 55–80 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 63 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 63 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'user' | 72 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 74 |
| CommentRequired | Public method and constructor comments are required | 82–112 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 88 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 92 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 92 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'user' | 104 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 106 |
| Rule | Violation | Line |
|---|---|---|
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 54 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 50–110 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 109 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 109 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 67–328 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 129 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 147–156 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 148–156 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 175 |
| CommentRequired | Public method and constructor comments are required | 311–327 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 73–228 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 117 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 133 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 195 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 43–59 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 45 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _biPredicate field if you want a default access modifier | 45 |
| CommentRequired | Public method and constructor comments are required | 47–51 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 51–334 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 230–232 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 269 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 3 | 46–137 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 119 |
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 127 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_plugin' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 124 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 3 | 228–230 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'Constants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 39–80 |
| ShortVariable | Avoid variables with short names like ID | 3 | 46 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'header_security' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 86 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 116 |
| FormalParameterNamingConventions | The method parameter name 'id_entry_tos' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 142 |
| FormalParameterNamingConventions | The method parameter name 'header_security' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 144 |
| FormalParameterNamingConventions | The method parameter name 'fk_id_entry' doesn't match '[a-z][a-zA-Z0-9]*' | 1 | 170 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 194 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 44–80 |
| FieldNamingConventions | The field name 'nIdTermOfService' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 47 |
| FieldNamingConventions | The field name 'strGuid' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 48 |
| FieldNamingConventions | The field name 'nId' doesn't match '_[a-z][a-zA-Z0-9]*' | 1 | 49 |
| CommentRequired | Public method and constructor comments are required | 3 | 52–54 |
| CommentRequired | Public method and constructor comments are required | 3 | 56–58 |
| CommentRequired | Public method and constructor comments are required | 3 | 60–62 |
| CommentRequired | Public method and constructor comments are required | 3 | 64–66 |
| CommentRequired | Public method and constructor comments are required | 3 | 68–70 |
| CommentRequired | Public method and constructor comments are required | 3 | 72–74 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassNamingConventions | The utility class name 'ClientRS' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 51–114 |
| CommentRequired | Header comments are required | 3 | 51–114 |
| UseUtilityClass | All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 3 | 51–114 |
| CommentRequired | Public method and constructor comments are required | 3 | 55–80 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 63 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 63 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'user' | 3 | 72 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 74 |
| CommentRequired | Public method and constructor comments are required | 3 | 82–112 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 88 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 3 | 92 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 3 | 92 |
| UnnecessaryLocalBeforeReturn | Consider simply returning the value vs storing it in local variable 'user' | 3 | 104 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 3 | 106 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 51–126 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 1 | 43–56 |
| ClassNamingConventions | The utility class name 'TOSConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 1 | 43–56 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 3 | 54 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 50–110 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 109 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 109 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 67–328 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 3 | 129 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 147–156 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getItemsFromIds method if you want a default access modifier | 3 | 148–156 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 175 |
| CommentRequired | Public method and constructor comments are required | 3 | 311–327 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 3 | 73–228 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 3 | 117 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 3 | 133 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 3 | 195 |
| Rule | Violation | Priority | Line |
|---|---|---|---|
| CommentRequired | Header comments are required | 3 | 43–59 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 3 | 45 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the _biPredicate field if you want a default access modifier | 3 | 45 |
| CommentRequired | Public method and constructor comments are required | 3 | 47–51 |
