SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.5.3
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 143 |
34 |
0 |
0 |
fr.paris.lutece.plugins.workflow.modules.archive.web.ArchiveTaskComponent
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.workflow.modules.archive.web.ArchiveTaskComponent.doSaveConfig(HttpServletRequest, Locale, ITask) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
167 |
High |
fr.paris.lutece.plugins.workflow.modules.assignment.business.TaskAssignmentConfig
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.workflow.modules.assignment.business.TaskAssignmentConfig.getWorkgroups() may expose internal representation by returning TaskAssignmentConfig._workgroups |
MALICIOUS_CODE |
EI_EXPOSE_REP |
150 |
Medium |
| fr.paris.lutece.plugins.workflow.modules.assignment.business.TaskAssignmentConfig.setWorkgroups(List) may expose internal representation by storing an externally mutable object into TaskAssignmentConfig._workgroups |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
161 |
Medium |
fr.paris.lutece.plugins.workflow.modules.comment.web.CommentJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.workflow.modules.comment.web.CommentJspBean defines non-transient non-serializable instance field _commentValueService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.modules.comment.web.CommentJspBean defines non-transient non-serializable instance field _resourceHistoryService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.modules.comment.web.CommentJspBean defines non-transient non-serializable instance field _taskComponentManager |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.modules.comment.web.CommentJspBean defines non-transient non-serializable instance field _taskService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.workflow.modules.comment.web.CommentTaskComponent
| Bug |
Category |
Details |
Line |
Priority |
| new fr.paris.lutece.plugins.workflow.modules.comment.web.CommentTaskComponent(List) may expose internal representation by storing an externally mutable object into CommentTaskComponent._listContentPostProcessors |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
107 |
Medium |
fr.paris.lutece.plugins.workflow.service.WorkflowActionRegistry
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.workflow.service.WorkflowActionRegistry.getAllActionsByScope() may expose internal representation by returning WorkflowActionRegistry.actionsByScope |
MALICIOUS_CODE |
EI_EXPOSE_REP |
25 |
Medium |
fr.paris.lutece.plugins.workflow.service.WorkflowRBACService
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to actionsByScope in fr.paris.lutece.plugins.workflow.service.WorkflowRBACService.getAuthorizedActionsCollection(User, int) |
STYLE |
DLS_DEAD_LOCAL_STORE |
49 |
Medium |
fr.paris.lutece.plugins.workflow.service.json.WorkflowJsonData
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.workflow.service.json.WorkflowJsonData.getWorkflow() may expose internal representation by returning WorkflowJsonData._workflow |
MALICIOUS_CODE |
EI_EXPOSE_REP |
63 |
Medium |
| fr.paris.lutece.plugins.workflow.service.json.WorkflowJsonData.setWorkflow(Workflow) may expose internal representation by storing an externally mutable object into WorkflowJsonData._workflow |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
72 |
Medium |
fr.paris.lutece.plugins.workflow.service.json.WorkflowJsonService
| Bug |
Category |
Details |
Line |
Priority |
| Comparison of String objects using == or != in fr.paris.lutece.plugins.workflow.service.json.WorkflowJsonService.lambda$importTasks$5(ITask, ITaskType) |
BAD_PRACTICE |
ES_COMPARING_STRINGS_WITH_EQ |
340 |
Medium |
| Comparison of String objects using == or != in fr.paris.lutece.plugins.workflow.service.json.WorkflowJsonService.lambda$importTasks$6(ITask, ITaskType) |
BAD_PRACTICE |
ES_COMPARING_STRINGS_WITH_EQ |
342 |
Medium |
fr.paris.lutece.plugins.workflow.service.provider.MarkerProviderService
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.workflow.service.provider.MarkerProviderService.getMarkerProviders() may expose internal representation by returning MarkerProviderService._listMarkerProviders |
MALICIOUS_CODE |
EI_EXPOSE_REP |
80 |
Medium |
fr.paris.lutece.plugins.workflow.service.taskinfo.AbstractTaskInfoProvider
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.workflow.service.taskinfo.AbstractTaskInfoProvider.getTaskType() may expose internal representation by returning AbstractTaskInfoProvider._taskType |
MALICIOUS_CODE |
EI_EXPOSE_REP |
62 |
Medium |
| fr.paris.lutece.plugins.workflow.service.taskinfo.AbstractTaskInfoProvider.setTaskType(ITaskType) may expose internal representation by storing an externally mutable object into AbstractTaskInfoProvider._taskType |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
53 |
Medium |
fr.paris.lutece.plugins.workflow.web.IconJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Class fr.paris.lutece.plugins.workflow.web.IconJspBean defines non-transient non-serializable instance field _actionService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.IconJspBean defines non-transient non-serializable instance field _iconService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.workflow.web.WorkflowJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of workflow in fr.paris.lutece.plugins.workflow.web.WorkflowJspBean.doUpdateActionOrder(HttpServletRequest) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
2847 |
Medium |
| Nullcheck of state at line 1154 of value previously dereferenced in fr.paris.lutece.plugins.workflow.web.WorkflowJspBean.doRemoveState(HttpServletRequest) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
1154 |
High |
| Nullcheck of workflow at line 2849 of value previously dereferenced in fr.paris.lutece.plugins.workflow.web.WorkflowJspBean.doUpdateActionOrder(HttpServletRequest) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
2847 |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.WorkflowJspBean defines non-transient non-serializable instance field _actionService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.WorkflowJspBean defines non-transient non-serializable instance field _iconService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.WorkflowJspBean defines non-transient non-serializable instance field _importWorkflowFile |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.WorkflowJspBean defines non-transient non-serializable instance field _prerequisiteManagementService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.WorkflowJspBean defines non-transient non-serializable instance field _stateService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.WorkflowJspBean defines non-transient non-serializable instance field _taskComponentManager |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.WorkflowJspBean defines non-transient non-serializable instance field _taskFactory |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.WorkflowJspBean defines non-transient non-serializable instance field _taskService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.WorkflowJspBean defines non-transient non-serializable instance field _workflowService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
fr.paris.lutece.plugins.workflow.web.prerequisite.PrerequisiteJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Store of non serializable javax.validation.ConstraintViolation<T> into HttpSession in fr.paris.lutece.plugins.workflow.web.prerequisite.PrerequisiteJspBean.doCreatePrerequisite(HttpServletRequest) |
BAD_PRACTICE |
J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION |
195 |
Medium |
| Store of non serializable javax.validation.ConstraintViolation<T> into HttpSession in fr.paris.lutece.plugins.workflow.web.prerequisite.PrerequisiteJspBean.doModifyPrerequisite(HttpServletRequest) |
BAD_PRACTICE |
J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION |
339 |
Medium |
| Class fr.paris.lutece.plugins.workflow.web.prerequisite.PrerequisiteJspBean defines non-transient non-serializable instance field _prerequisiteManagementService |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |