The following document contains the results of SpotBugs
SpotBugs Version is 4.5.3
Threshold is medium
Effort is default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 19 | 41 | 0 | 0 |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to listFields in fr.paris.lutece.plugins.adminsql.business.DataDAO.findResultOfUserRequest(String, PluginConnectionService) | STYLE | DLS_DEAD_LOCAL_STORE | 322 | High |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.FieldDAO.findFieldKeyIdbyLabel(String, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 606 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.FieldDAO.findFieldKeyLabelbyId(int, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 632 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.FieldDAO.findFieldNullIdbyLabel(String, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 554 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.FieldDAO.findFieldNullLabelbyId(int, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 580 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.FieldDAO.findFieldTypeIdbyLabel(String, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 502 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.FieldDAO.findFieldTypeLabelbyId(int, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 528 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.FieldDAO.selectFieldKeyList(String, Plugin) | STYLE | DLS_DEAD_LOCAL_STORE | 450 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.FieldDAO.selectFieldTypeList(String, Plugin) | STYLE | DLS_DEAD_LOCAL_STORE | 423 | High |
| Dead store to nAddFieldAfterAField in fr.paris.lutece.plugins.adminsql.business.FieldDAO.insert(String, String, Field, Plugin) | STYLE | DLS_DEAD_LOCAL_STORE | 311 | Medium |
| Dead store to nAddFieldBeginningOfTable in fr.paris.lutece.plugins.adminsql.business.FieldDAO.insert(String, String, Field, Plugin) | STYLE | DLS_DEAD_LOCAL_STORE | 310 | Medium |
| Dead store to nAddFieldEndOfTable in fr.paris.lutece.plugins.adminsql.business.FieldDAO.insert(String, String, Field, Plugin) | STYLE | DLS_DEAD_LOCAL_STORE | 309 | Medium |
| Dead store to strFieldLabelKeyValue in fr.paris.lutece.plugins.adminsql.business.FieldDAO.insert(String, String, Field, Plugin) | STYLE | DLS_DEAD_LOCAL_STORE | 284 | Medium |
| Nullcheck of strLengthTypeValue at line 254 of value previously dereferenced in fr.paris.lutece.plugins.adminsql.business.FieldDAO.insert(String, String, Field, Plugin) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 254 | Medium |
| Nullcheck of strLengthTypeValue at line 174 of value previously dereferenced in fr.paris.lutece.plugins.adminsql.business.FieldDAO.store(String, String, Field, String, int, Plugin) | CORRECTNESS | RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE | 174 | Medium |
| Useless object stored in variable tabString of method fr.paris.lutece.plugins.adminsql.business.FieldDAO.load(String, String, String, Plugin) | STYLE | UC_USELESS_OBJECT | 97 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.TableDAO.findFieldKeyIdbyLabel(String, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 460 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.TableDAO.findFieldKeyLabelbyId(int, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 486 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.TableDAO.findFieldNullIdbyLabel(String, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 408 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.TableDAO.findFieldNullLabelbyId(int, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 434 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.TableDAO.findFieldTypeIdbyLabel(String, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 356 | High |
| Dead store to plugin in fr.paris.lutece.plugins.adminsql.business.TableDAO.findFieldTypeLabelbyId(int, Plugin, String) | STYLE | DLS_DEAD_LOCAL_STORE | 382 | High |
| Dead store to strFieldLabelKeyValue in fr.paris.lutece.plugins.adminsql.business.TableDAO.insert(String, Table, Field, Plugin) | STYLE | DLS_DEAD_LOCAL_STORE | 147 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to listFieldsNames in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doDeleteData(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 1323 | High |
| Dead store to DumpCommandslist in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doExportDatabase(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 416 | High |
| Dead store to listRows in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doExportDatabase(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 417 | High |
| Dead store to listConcatFieldNameAndData in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doModifyData(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 1238 | High |
| Dead store to listConcatFieldNameAndOldData in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doModifyData(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 1239 | High |
| Dead store to fieldList in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doExportDatabase(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 420 | Medium |
| Dead store to listData in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doExportDatabase(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 421 | Medium |
| Dead store to tableList in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doExportDatabase(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 419 | Medium |
| Dead store to listRows in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.getManageDataTable(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 1060 | Medium |
| Dead store to nNumberFields in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.getManageDataTable(HttpServletRequest) | STYLE | DLS_DEAD_LOCAL_STORE | 1065 | Medium |
| Call to equals(null) in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doCreateFieldStructure(HttpServletRequest) | CORRECTNESS | EC_NULL_ARG | 825 | Medium |
| Call to equals(null) in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doCreateTable(HttpServletRequest) | CORRECTNESS | EC_NULL_ARG | 610 | Medium |
| Call to equals(null) in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doModifyFieldStructure(HttpServletRequest) | CORRECTNESS | EC_NULL_ARG | 937 | Medium |
| Call to equals(null) in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doModifyTableName(HttpServletRequest) | CORRECTNESS | EC_NULL_ARG | 701 | Medium |
| Call to equals(null) in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doUserRequest(HttpServletRequest) | CORRECTNESS | EC_NULL_ARG | 351 | Medium |
| Comparison of String objects using == or != in fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.doExportDatabase(HttpServletRequest) | BAD_PRACTICE | ES_COMPARING_STRINGS_WITH_EQ | 498 | Medium |
| Useless object stored in variable listInputs of method fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.getManageDataTable(HttpServletRequest) | STYLE | UC_USELESS_OBJECT | 1061 | Medium |
| Useless object stored in variable listNewData of method fr.paris.lutece.plugins.adminsql.web.AdminSqlJspBean.getManageDataTable(HttpServletRequest) | STYLE | UC_USELESS_OBJECT | 1059 | Medium |
