SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.5.3
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 182 |
48 |
0 |
0 |
fr.paris.lutece.plugins.appointment.business.appointment.Appointment
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.appointment.business.appointment.Appointment.getListAppointmentSlot() may expose internal representation by returning Appointment._listAppointmentSlot |
MALICIOUS_CODE |
EI_EXPOSE_REP |
398 |
Medium |
| fr.paris.lutece.plugins.appointment.business.appointment.Appointment.getSlot() may expose internal representation by returning Appointment._listSlot |
MALICIOUS_CODE |
EI_EXPOSE_REP |
328 |
Medium |
| fr.paris.lutece.plugins.appointment.business.appointment.Appointment.getUser() may expose internal representation by returning Appointment._user |
MALICIOUS_CODE |
EI_EXPOSE_REP |
377 |
Medium |
| fr.paris.lutece.plugins.appointment.business.appointment.Appointment.setListAppointmentSlot(List) may expose internal representation by storing an externally mutable object into Appointment._listAppointmentSlot |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
409 |
Medium |
| fr.paris.lutece.plugins.appointment.business.appointment.Appointment.setSlot(List) may expose internal representation by storing an externally mutable object into Appointment._listSlot |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
339 |
Medium |
| fr.paris.lutece.plugins.appointment.business.appointment.Appointment.setUser(User) may expose internal representation by storing an externally mutable object into Appointment._user |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
388 |
Medium |
fr.paris.lutece.plugins.appointment.business.display.Display
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.appointment.business.display.Display.getIcon() may expose internal representation by returning Display._icon |
MALICIOUS_CODE |
EI_EXPOSE_REP |
161 |
Medium |
| fr.paris.lutece.plugins.appointment.business.display.Display.setIcon(ImageResource) may expose internal representation by storing an externally mutable object into Display._icon |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
172 |
Medium |
fr.paris.lutece.plugins.appointment.business.planning.WorkingDay
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.appointment.business.planning.WorkingDay.getListTimeSlot() may expose internal representation by returning WorkingDay._listTimeSlots |
MALICIOUS_CODE |
EI_EXPOSE_REP |
143 |
Medium |
| fr.paris.lutece.plugins.appointment.business.planning.WorkingDay.setListTimeSlot(List) may expose internal representation by storing an externally mutable object into WorkingDay._listTimeSlots |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
154 |
Medium |
fr.paris.lutece.plugins.appointment.business.portlet.AppointmentFormListPortletHome
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.appointment.business.portlet.AppointmentFormListPortletHome.getInstance() may expose internal representation by returning AppointmentFormListPortletHome._singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
72 |
Medium |
fr.paris.lutece.plugins.appointment.business.portlet.AppointmentFormPortletHome
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.appointment.business.portlet.AppointmentFormPortletHome.getInstance() may expose internal representation by returning AppointmentFormPortletHome._singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
72 |
Medium |
fr.paris.lutece.plugins.appointment.business.portlet.AppointmentPortletHome
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.appointment.business.portlet.AppointmentPortletHome.getInstance() may expose internal representation by returning AppointmentPortletHome._singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
72 |
Medium |
fr.paris.lutece.plugins.appointment.business.rule.ReservationRule
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.appointment.business.rule.ReservationRule.getListWorkingDay() may expose internal representation by returning ReservationRule._listWorkingDays |
MALICIOUS_CODE |
EI_EXPOSE_REP |
298 |
Medium |
| fr.paris.lutece.plugins.appointment.business.rule.ReservationRule.setListWorkingDay(List) may expose internal representation by storing an externally mutable object into ReservationRule._listWorkingDays |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
309 |
Medium |
fr.paris.lutece.plugins.appointment.business.user.User
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.appointment.business.user.User.getAppointments() may expose internal representation by returning User._listAppointments |
MALICIOUS_CODE |
EI_EXPOSE_REP |
236 |
Medium |
| fr.paris.lutece.plugins.appointment.business.user.User.setAppointments(List) may expose internal representation by storing an externally mutable object into User._listAppointments |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
247 |
Medium |
fr.paris.lutece.plugins.appointment.service.AppointmentService
| Bug |
Category |
Details |
Line |
Priority |
| Invocation of toString on bytes in fr.paris.lutece.plugins.appointment.service.AppointmentService.getSalt() |
CORRECTNESS |
DMI_INVOKING_TOSTRING_ON_ARRAY |
233 |
High |
| Random object created and used only once in fr.paris.lutece.plugins.appointment.service.AppointmentService.getSalt() |
BAD_PRACTICE |
DMI_RANDOM_USED_ONLY_ONCE |
232 |
High |
fr.paris.lutece.plugins.appointment.service.AppointmentUtilities
| Bug |
Category |
Details |
Line |
Priority |
| Do not catch NullPointerException like in fr.paris.lutece.plugins.appointment.service.AppointmentUtilities.checkAndReturnNbBookedSeats(String, AppointmentFormDTO, AppointmentDTO, Locale, List) |
STYLE |
DCN_NULLPOINTER_EXCEPTION |
505 |
Medium |
| Do not catch NullPointerException like in fr.paris.lutece.plugins.appointment.service.AppointmentUtilities.setAppointmentPhoneNumberValuesFromResponse(AppointmentDTO) |
STYLE |
DCN_NULLPOINTER_EXCEPTION |
1328 |
Medium |
| Store of non serializable java.util.concurrent.ScheduledFuture<V> into HttpSession in fr.paris.lutece.plugins.appointment.service.AppointmentUtilities.putTimerInSession(HttpServletRequest, int, AppointmentDTO, int) |
BAD_PRACTICE |
J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION |
702 |
Medium |
fr.paris.lutece.plugins.appointment.service.EntryService
| Bug |
Category |
Details |
Line |
Priority |
| Useless object stored in variable filter of method fr.paris.lutece.plugins.appointment.service.EntryService.moveDownEntryOrder(int, Entry) |
STYLE |
UC_USELESS_OBJECT |
146 |
Medium |
fr.paris.lutece.plugins.appointment.service.SlotSafeService
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.appointment.service.SlotSafeService.getListSlotInMemory() may expose internal representation by returning SlotSafeService._listSlot |
MALICIOUS_CODE |
MS_EXPOSE_REP |
107 |
Medium |
fr.paris.lutece.plugins.appointment.service.export.AppointmentExportService
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.appointment.service.export.AppointmentExportService.getCustomColumnList(String) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
367 |
High |
fr.paris.lutece.plugins.appointment.web.AppointmentApp
| Bug |
Category |
Details |
Line |
Priority |
| Found reliance on default encoding in fr.paris.lutece.plugins.appointment.web.AppointmentApp.getFormListHtml(Locale, Map): new String(byte[]) |
I18N |
DM_DEFAULT_ENCODING |
1558 |
High |
fr.paris.lutece.plugins.appointment.web.AppointmentJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive fr.paris.lutece.plugins.appointment.web.AppointmentJspBean.doRemoveMassAppointment(HttpServletRequest) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
734 |
High |
| Class fr.paris.lutece.plugins.appointment.web.AppointmentJspBean defines non-transient non-serializable instance field _moduleAppointmentDesk |
BAD_PRACTICE |
SE_BAD_FIELD |
Not available |
Medium |
| Useless object stored in variable stateFilter of method fr.paris.lutece.plugins.appointment.web.AppointmentJspBean.getManageAppointments(HttpServletRequest) |
STYLE |
UC_USELESS_OBJECT |
616 |
Medium |
| Useless object stored in variable stateFilter of method fr.paris.lutece.plugins.appointment.web.AppointmentJspBean.getViewAppointment(HttpServletRequest) |
STYLE |
UC_USELESS_OBJECT |
788 |
Medium |
fr.paris.lutece.plugins.appointment.web.TypicalWeekJspBean
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to listTimeSlotJson in fr.paris.lutece.plugins.appointment.web.TypicalWeekJspBean.doModifyListTimeSlot(HttpServletRequest) |
STYLE |
DLS_DEAD_LOCAL_STORE |
667 |
Medium |
fr.paris.lutece.plugins.appointment.web.dto.AppointmentDTO
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentDTO.getListResponse() may expose internal representation by returning AppointmentDTO._listResponse |
MALICIOUS_CODE |
EI_EXPOSE_REP |
317 |
Medium |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentDTO.getListWorkflowActions() may expose internal representation by returning AppointmentDTO._listWorkflowActions |
MALICIOUS_CODE |
EI_EXPOSE_REP |
401 |
Medium |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentDTO.getMapResponsesByIdEntry() may expose internal representation by returning AppointmentDTO._mapResponsesByIdEntry |
MALICIOUS_CODE |
EI_EXPOSE_REP |
421 |
Medium |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentDTO.getState() may expose internal representation by returning AppointmentDTO._state |
MALICIOUS_CODE |
EI_EXPOSE_REP |
191 |
Medium |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentDTO.setListResponse(List) may expose internal representation by storing an externally mutable object into AppointmentDTO._listResponse |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
328 |
Medium |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentDTO.setListWorkflowActions(Collection) may expose internal representation by storing an externally mutable object into AppointmentDTO._listWorkflowActions |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
411 |
Medium |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentDTO.setMapResponsesByIdEntry(Map) may expose internal representation by storing an externally mutable object into AppointmentDTO._mapResponsesByIdEntry |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
432 |
Medium |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentDTO.setState(State) may expose internal representation by storing an externally mutable object into AppointmentDTO._state |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
202 |
Medium |
fr.paris.lutece.plugins.appointment.web.dto.AppointmentFormDTO
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentFormDTO.getIcon() may expose internal representation by returning AppointmentFormDTO._imageResource |
MALICIOUS_CODE |
EI_EXPOSE_REP |
875 |
Medium |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentFormDTO.setIcon(ImageResource) may expose internal representation by storing an externally mutable object into AppointmentFormDTO._imageResource |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
886 |
Medium |
fr.paris.lutece.plugins.appointment.web.dto.AppointmentPackageDTO
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentPackageDTO.getListAppointmentDTO() may expose internal representation by returning AppointmentPackageDTO._listAppointmentDTO |
MALICIOUS_CODE |
EI_EXPOSE_REP |
81 |
Medium |
| fr.paris.lutece.plugins.appointment.web.dto.AppointmentPackageDTO.setListAppointmentDTO(Set) may expose internal representation by storing an externally mutable object into AppointmentPackageDTO._listAppointmentDTO |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
92 |
Medium |
fr.paris.lutece.plugins.appointment.web.dto.ReservationRuleDTO
| Bug |
Category |
Details |
Line |
Priority |
| fr.paris.lutece.plugins.appointment.web.dto.ReservationRuleDTO.getListWorkingDay() may expose internal representation by returning ReservationRuleDTO._listWorkingDays |
MALICIOUS_CODE |
EI_EXPOSE_REP |
358 |
Medium |
| fr.paris.lutece.plugins.appointment.web.dto.ReservationRuleDTO.setListWorkingDay(List) may expose internal representation by storing an externally mutable object into ReservationRuleDTO._listWorkingDays |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
369 |
Medium |
fr.paris.lutece.plugins.appointment.web.dto.ResponseRecapDTO
| Bug |
Category |
Details |
Line |
Priority |
| new fr.paris.lutece.plugins.appointment.web.dto.ResponseRecapDTO(Response) may expose internal representation by storing an externally mutable object into ResponseRecapDTO._response |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
74 |
Medium |
| new fr.paris.lutece.plugins.appointment.web.dto.ResponseRecapDTO(Response, String) may expose internal representation by storing an externally mutable object into ResponseRecapDTO._response |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
87 |
Medium |
fr.paris.lutece.plugins.appointment.web.file.AppointmentFormIconService
| Bug |
Category |
Details |
Line |
Priority |
| Public static fr.paris.lutece.plugins.appointment.web.file.AppointmentFormIconService.getInstance() may expose internal representation by returning AppointmentFormIconService._singleton |
MALICIOUS_CODE |
MS_EXPOSE_REP |
85 |
Medium |
