The following document contains the results of PMD 6.13.0.
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_nIdResource' doesn't match '[a-z][a-zA-Z0-9]*' | 46 |
| FieldNamingConventions | The final field name '_strTypeResource' doesn't match '[a-z][a-zA-Z0-9]*' | 47 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'AdminDashboardFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 48–105 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'DashboardFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 48–105 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 615–618 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 644–647 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 55–58 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 64–67 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_strSqlSelect' doesn't match '[a-z][a-zA-Z0-9]*' | 47 |
| FieldNamingConventions | The final field name '_strSqlInsert' doesn't match '[a-z][a-zA-Z0-9]*' | 48 |
| FieldNamingConventions | The final field name '_strSqlUpdate' doesn't match '[a-z][a-zA-Z0-9]*' | 49 |
| FieldNamingConventions | The final field name '_strSqlDelete' doesn't match '[a-z][a-zA-Z0-9]*' | 50 |
| FieldNamingConventions | The final field name '_strSqlSelectAll' doesn't match '[a-z][a-zA-Z0-9]*' | 51 |
| FieldNamingConventions | The final field name '_strSqlSelectByValue' doesn't match '[a-z][a-zA-Z0-9]*' | 52 |
| FieldNamingConventions | The final field name '_strSqlDeleteKey' doesn't match '[a-z][a-zA-Z0-9]*' | 53 |
| FieldNamingConventions | The final field name '_strSqlDeleteKeyPrefix' doesn't match '[a-z][a-zA-Z0-9]*' | 54 |
| FieldNamingConventions | The final field name '_strSqlSelectCount' doesn't match '[a-z][a-zA-Z0-9]*' | 55 |
| FieldNamingConventions | The final field name '_strSqlSelectCountPrefValue' doesn't match '[a-z][a-zA-Z0-9]*' | 56 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ResourceEnhancer' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 46–219 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 207–210 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_bDefault' doesn't match '[a-z][a-zA-Z0-9]*' | 149 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The enum name 'PASSWORD_REPRESENTATION' doesn't match '[A-Z][a-zA-Z0-9]*' | 117–121 |
| FieldNamingConventions | The final field name '_iterations' doesn't match '[a-z][a-zA-Z0-9]*' | 147 |
| FieldNamingConventions | The final field name '_salt' doesn't match '[a-z][a-zA-Z0-9]*' | 149 |
| FieldNamingConventions | The final field name '_hash' doesn't match '[a-z][a-zA-Z0-9]*' | 151 |
| FieldNamingConventions | The final field name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' | 421 |
| FieldNamingConventions | The final field name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' | 448 |
| FieldNamingConventions | The final field name '_strAlgorithm' doesn't match '[a-z][a-zA-Z0-9]*' | 450 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_strClass' doesn't match '[a-z][a-zA-Z0-9]*' | 43 |
| FieldNamingConventions | The final field name '_strContent' doesn't match '[a-z][a-zA-Z0-9]*' | 44 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_item' doesn't match '[A-Z][A-Z_0-9]*' | 44 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' | 89 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 312–315 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 321–324 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 330–333 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 339–342 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 348–351 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 357–360 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 284 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 220 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_mapDaemonEntries' doesn't match '[A-Z][A-Z_0-9]*' | 58 |
| FieldNamingConventions | The constant name '_random' doesn't match '[A-Z][A-Z_0-9]*' | 59 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 127–130 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_thread' doesn't match '[a-z][a-zA-Z0-9]*' | 58 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_queue' doesn't match '[a-z][a-zA-Z0-9]*' | 63 |
| FieldNamingConventions | The final field name '_executor' doesn't match '[a-z][a-zA-Z0-9]*' | 64 |
| FieldNamingConventions | The final field name '_coordinatorThread' doesn't match '[a-z][a-zA-Z0-9]*' | 65 |
| FieldNamingConventions | The final field name '_scheduledDaemonsTimer' doesn't match '[a-z][a-zA-Z0-9]*' | 66 |
| FieldNamingConventions | The final field name '_executingDaemons' doesn't match '[a-z][a-zA-Z0-9]*' | 67 |
| FieldNamingConventions | The final field name '_scheduledDaemons' doesn't match '[a-z][a-zA-Z0-9]*' | 68 |
| FieldNamingConventions | The final field name '_entry' doesn't match '[a-z][a-zA-Z0-9]*' | 293 |
| FieldNamingConventions | The final field name '_entry' doesn't match '[a-z][a-zA-Z0-9]*' | 352 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_defaultThreadFactory' doesn't match '[A-Z][A-Z_0-9]*' | 49 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_wrapped' doesn't match '[a-z][a-zA-Z0-9]*' | 61 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name 'user_id' doesn't match '[a-z][a-zA-Z0-9]*' | 72 |
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAnyMethod | No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. | 43–45 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'CoreDataKeys' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–49 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ResourceEventManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 48–112 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 44–172 |
| Rule | Violation | Line |
|---|---|---|
| FormalParameterNamingConventions | The method parameter name '_fileDownloadUrlService' doesn't match '[a-z][a-zA-Z0-9]*' | 83 |
| FormalParameterNamingConventions | The method parameter name '_fileRBACService' doesn't match '[a-z][a-zA-Z0-9]*' | 83 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 48–159 |
| FieldNamingConventions | The constant name '_fileStoreService' doesn't match '[A-Z][A-Z_0-9]*' | 52 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 58–160 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_log' doesn't match '[A-Z][A-Z_0-9]*' | 59 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_override' doesn't match '[a-z][a-zA-Z0-9]*' | 42 |
| FieldNamingConventions | The final field name '_defaults' doesn't match '[a-z][a-zA-Z0-9]*' | 43 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_overrideLoader' doesn't match '[A-Z][A-Z_0-9]*' | 84 |
| FieldNamingConventions | The constant name '_resourceBundleCache' doesn't match '[A-Z][A-Z_0-9]*' | 85 |
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method 'setImage' called during object construction | 53 |
| ConstructorCallsOverridableMethod | Overridable method 'setMimeType' called during object construction | 54 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ImageResourceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 47–123 |
| FieldNamingConventions | The static field name 'IMAGE_SERVLET_BASE_URL' doesn't match '_[a-z][a-zA-Z0-9]*' | 51 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 115 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'AppInfo' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–68 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 316 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 341 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'PostStartUpServiceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 44–75 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ShutdownServiceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 44–75 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'StartUpServiceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 47–109 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'InsertServiceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 47–137 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 1161–1164 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 151 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 304 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'PrefsConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–48 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_strResourceType' doesn't match '[a-z][a-zA-Z0-9]*' | 63 |
| FieldNamingConventions | The final field name '_item' doesn't match '[a-z][a-zA-Z0-9]*' | 64 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ResourceTypeManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 48–148 |
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method 'initLoaders' called during object construction | 70 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_accessLoggerList' doesn't match '[a-z][a-zA-Z0-9]*' | 67 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'AccessLoggerConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–64 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_bEnableCaptcha' doesn't match '[a-z][a-zA-Z0-9]*' | 44 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_strRedirectUrl' doesn't match '[a-z][a-zA-Z0-9]*' | 42 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 492–495 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'SecurityModel' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–70 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 52–141 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_bAddHashToLogs' doesn't match '[a-z][a-zA-Z0-9]*' | 78 |
| FieldNamingConventions | The final field name '_messageFormat' doesn't match '[a-z][a-zA-Z0-9]*' | 79 |
| FieldNamingConventions | The final field name '_messageFormatSeparator' doesn't match '[a-z][a-zA-Z0-9]*' | 80 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 46–230 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' | 73 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_service' doesn't match '[a-z][a-zA-Z0-9]*' | 55 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_itemProviders' doesn't match '[a-z][a-zA-Z0-9]*' | 57 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 187 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'LocalVariables' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 43–102 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Markers' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–66 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Messages' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–64 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'Parameters' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–139 |
| Rule | Violation | Line |
|---|---|---|
| AbstractClassWithoutAnyMethod | No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. | 42–45 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'PluginActionManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 57–133 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'ExtendableResourcePluginActionManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 52–96 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 418 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 497 |
| Rule | Violation | Line |
|---|---|---|
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 301 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_multipartFiles' doesn't match '[a-z][a-zA-Z0-9]*' | 52 |
| FieldNamingConventions | The final field name '_stringParameters' doesn't match '[a-z][a-zA-Z0-9]*' | 53 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 187–190 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'objectMapper' doesn't match '[A-Z][A-Z_0-9]*' | 64 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' | 72 |
| FieldNamingConventions | The constant name '_attributeTypeService' doesn't match '[A-Z][A-Z_0-9]*' | 73 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' | 98 |
| FieldNamingConventions | The constant name '_attributeFieldService' doesn't match '[A-Z][A-Z_0-9]*' | 99 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' | 91 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 81–84 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name 'RSA_KEY_PREFIX' doesn't match '[a-z][a-zA-Z0-9]*' | 60 |
| FieldNamingConventions | The final field name 'MESSAGE_CIPHERED_PROPERTY_SECURITY_EXCEPTION' doesn't match '[a-z][a-zA-Z0-9]*' | 61 |
| AvoidFileStream | Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter | 141 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'UniqueIDGenerator' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 40–68 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The final field name '_db' doesn't match '[a-z][a-zA-Z0-9]*' | 64 |
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method 'setSortUrl' called during object construction | 120 |
| Rule | Violation | Line |
|---|---|---|
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 262–265 |
| EmptyMethodInAbstractClassShouldBeAbstract | An empty method in an abstract class should be abstract instead | 271–274 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The public constant name '_log' doesn't match '[A-Z][A-Z_0-9]*' | 69 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'JPAConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 39–49 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_Log' doesn't match '[A-Z][A-Z_0-9]*' | 62 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name '_log' doesn't match '[A-Z][A-Z_0-9]*' | 57 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 46–78 |
| FieldNamingConventions | The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' | 49 |
| Rule | Violation | Line |
|---|---|---|
| ClassNamingConventions | The utility class name 'LuteceConnectionFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' | 44–75 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 43–99 |
| FieldNamingConventions | The static field name 'RSA_KEY_PROVIDER_BEAN_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' | 46 |
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingShortType | Do not use the short type | 1724 |
| AvoidUsingShortType | Do not use the short type | 3029 |
| AvoidUsingShortType | Do not use the short type | 3052 |
| AvoidUsingShortType | Do not use the short type | 3074 |
| Rule | Violation | Line |
|---|---|---|
| ConstructorCallsOverridableMethod | Overridable method 'beginTransaction' called during object construction | 108 |
| Rule | Violation | Line |
|---|---|---|
| ClassWithOnlyPrivateConstructorsShouldBeFinal | A class which only has private constructors should be final | 43–71 |
| Rule | Violation | Line |
|---|---|---|
| FieldNamingConventions | The constant name 'transformersPoolList' doesn't match '[A-Z][A-Z_0-9]*' | 68 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'listAttributes' | 296 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 58 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 69 |
| Rule | Violation | Line |
|---|---|---|
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 69 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 294 |
| AvoidUsingVolatile | Use of modifier volatile is not recommended. | 295 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 62 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'additionnalData' | 103 |
| AvoidReassigningParameters | Avoid reassigning parameters such as 'additionnalData' | 132 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 50 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 74 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 96 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 109 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 130 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 139 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 144 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 147 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'strPage' | 267 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 84 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 53 |
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 54 |
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 55 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 88 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 59 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 103 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 145 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'response' | 81 |
| Rule | Violation | Line |
|---|---|---|
| AvoidReassigningParameters | Avoid reassigning parameters such as 'resourceURI' | 276 |
| Rule | Violation | Line |
|---|---|---|
| AvoidBranchingStatementAsLastInLoop | Avoid using a branching statement as the last in a loop. | 353–354 |
| Rule | Violation | Line |
|---|---|---|
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 128 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 130 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 131 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 132 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 133 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 134 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 135 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 136 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 137 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 138 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 139 |
| GuardLogStatement | Logger calls should be surrounded by log level guards. | 140 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 65 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 68 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 68 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 55 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 55 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 117 |
| Rule | Violation | Line |
|---|---|---|
| LoggerIsNotStaticFinal | The Logger variable declaration does not contain the static and final modifiers | 87 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–152 |
| ImmutableField | Private field '_persistentData' could be made final; it is only initialized in the declaration or constructor. | 50 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 50 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 50–436 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 150–157 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 185–193 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 273–281 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setInsertOrUpdateValues' should not return any type except void linguistically | 356–363 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 397–404 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 50 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 49–434 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 149–156 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 185–193 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 271–279 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setInsertOrUpdateValues' should not return any type except void linguistically | 354–361 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 395–402 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 50 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 52–54 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 3–36 |
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 3–36 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 5–42 |
| ImmutableField | Private field '_type' could be made final; it is only initialized in the declaration or constructor. | 20 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 53–55 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 71–78 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 168–175 |
| Rule | Violation | Line |
|---|---|---|
| AssignmentInOperand | Avoid assignments in operands | 255 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 255 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 115–132 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 128 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 149 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 231 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listFilters' could be made final; it is only initialized in the declaration or constructor. | 54 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–67 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 47–366 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 65–67 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 285 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 58–68 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 79–83 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 46–203 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–636 |
| TooManyFields | Too many fields | 52–636 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 139–142 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the setOrigParentPageId method if you want a default access modifier | 139–142 |
| MethodReturnsInternalArray | Returning '_strImageContent' may expose an internal array. | 162 |
| ArrayIsStoredDirectly | The user-supplied array 'strImageContent' is stored directly. | 171 |
| AddEmptyString | Do not add empty strings | 470 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 579 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 580 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 581 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 582 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 583 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 584 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 585 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=58, ATFD=218, TCC=0.000%) | 52–812 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 53–812 |
| MissingOverride | The method 'insert(Page)' is missing an @Override annotation. | 106–164 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 146–153 |
| MissingOverride | The method 'load(int, boolean)' is missing an @Override annotation. | 169–219 |
| MissingOverride | The method 'loadWithoutImageContent(int, boolean)' is missing an @Override annotation. | 224–269 |
| MissingOverride | The method 'loadPageByIdPortlet(int)' is missing an @Override annotation. | 274–306 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 311–319 |
| MissingOverride | The method 'store(Page)' is missing an @Override annotation. | 324–376 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 360–367 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the checkPrimaryKey method if you want a default access modifier | 385–400 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 385–400 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 408–435 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the loadPortlets method if you want a default access modifier | 408–435 |
| MissingOverride | The method 'selectChildPages(int)' is missing an @Override annotation. | 440–481 |
| MissingOverride | The method 'selectChildPagesMinimalData(int)' is missing an @Override annotation. | 486–510 |
| MissingOverride | The method 'selectAllPages()' is missing an @Override annotation. | 515–554 |
| MissingOverride | The method 'invalidatePage(int)' is missing an @Override annotation. | 559–569 |
| MissingOverride | The method 'getPagesList()' is missing an @Override annotation. | 574–592 |
| MissingOverride | The method 'getPagesByRoleKey(String)' is missing an @Override annotation. | 601–643 |
| MissingOverride | The method 'selectNewChildPageOrder(int)' is missing an @Override annotation. | 648–667 |
| MissingOverride | The method 'loadImageResource(int)' is missing an @Override annotation. | 672–690 |
| MissingOverride | The method 'checkPageExist(int)' is missing an @Override annotation. | 699–716 |
| MissingOverride | The method 'loadLastModifiedPage()' is missing an @Override annotation. | 721–762 |
| MissingOverride | The method 'updateAutorisationNode(int, Integer)' is missing an @Override annotation. | 767–788 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 775–782 |
| MissingOverride | The method 'selectPageForChangeAutorisationNode(int)' is missing an @Override annotation. | 793–811 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 58–68 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 79–83 |
| Rule | Violation | Line |
|---|---|---|
| MethodReturnsInternalArray | Returning '_byValue' may expose an internal array. | 74 |
| ArrayIsStoredDirectly | The user-supplied array 'value' is stored directly. | 83 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(PortalComponent)' is missing an @Override annotation. | 60–70 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 60–70 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 75–95 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 100–108 |
| MissingOverride | The method 'store(PortalComponent)' is missing an @Override annotation. | 113–124 |
| MissingOverride | The method 'selectXslFile(int, int)' is missing an @Override annotation. | 129–151 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 55–58 |
| MissingOverride | The method 'getXml(HttpServletRequest)' is missing an @Override annotation. | 114–131 |
| MissingOverride | The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. | 142–145 |
| MissingOverride | The method 'remove()' is missing an @Override annotation. | 173–176 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 64–76 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 64–76 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 81–89 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 94–110 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 115–126 |
| ShortVariable | Avoid variables with short names like r | 117 |
| MissingOverride | The method 'selectPortletsByTypeList(String)' is missing an @Override annotation. | 131–147 |
| MissingOverride | The method 'selectAliasId(int)' is missing an @Override annotation. | 152–168 |
| MissingOverride | The method 'selectAcceptAliasPortletRefList()' is missing an @Override annotation. | 173–188 |
| MissingOverride | The method 'selectAcceptAliasPortletList()' is missing an @Override annotation. | 193–212 |
| Rule | Violation | Line |
|---|---|---|
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 52 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 57–63 |
| MissingOverride | The method 'getPortletTypeId()' is missing an @Override annotation. | 70–74 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 81–88 |
| MissingOverride | The method 'getDAO()' is missing an @Override annotation. | 95–98 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 52 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 60 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 69 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 77 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 47–203 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–676 |
| TooManyFields | Too many fields | 51–676 |
| GodClass | Possible God Class (WMC=57, ATFD=21, TCC=2.029%) | 51–676 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 531 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 534 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 537 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 540 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 51–546 |
| MissingOverride | The method 'insert(Portlet)' is missing an @Override annotation. | 98–124 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 129–151 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 156–189 |
| MissingOverride | The method 'store(Portlet)' is missing an @Override annotation. | 194–213 |
| MissingOverride | The method 'updateStatus(Portlet, int)' is missing an @Override annotation. | 218–229 |
| MissingOverride | The method 'updatePosition(Portlet, int, int)' is missing an @Override annotation. | 234–244 |
| MissingOverride | The method 'selectXslFile(int, int)' is missing an @Override annotation. | 249–269 |
| MissingOverride | The method 'selectPortletsListbyName(String)' is missing an @Override annotation. | 274–295 |
| MissingOverride | The method 'selectAliasesForPortlet(int)' is missing an @Override annotation. | 300–321 |
| MissingOverride | The method 'selectPortletsByType(String)' is missing an @Override annotation. | 326–358 |
| MissingOverride | The method 'selectStylesList(String)' is missing an @Override annotation. | 363–379 |
| MissingOverride | The method 'hasAlias(int)' is missing an @Override annotation. | 384–401 |
| MissingOverride | The method 'selectPortletType(String)' is missing an @Override annotation. | 406–427 |
| MissingOverride | The method 'selectPortletListByStyle(int)' is missing an @Override annotation. | 432–455 |
| MissingOverride | The method 'selectPortletsByRole(String)' is missing an @Override annotation. | 460–481 |
| MissingOverride | The method 'loadLastModifiedPortlet()' is missing an @Override annotation. | 486–521 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 51–360 |
| ShortVariable | Avoid variables with short names like p | 72 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 121–124 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getXsl method if you want a default access modifier | 121–124 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 157–171 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 179–189 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 58–68 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 79–83 |
| Rule | Violation | Line |
|---|---|---|
| TooManyFields | Too many fields | 45–426 |
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 233–236 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 243–246 |
| AddEmptyString | Do not add empty strings | 245 |
| MissingOverride | The method 'setLocale(Locale)' is missing an @Override annotation. | 422–425 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(PortletType)' is missing an @Override annotation. | 70–92 |
| MissingOverride | The method 'load(String)' is missing an @Override annotation. | 101–131 |
| MissingOverride | The method 'delete(String)' is missing an @Override annotation. | 139–147 |
| MissingOverride | The method 'selectPortletTypeId(String)' is missing an @Override annotation. | 156–172 |
| MissingOverride | The method 'selectNbPortletTypeByPortlet(String)' is missing an @Override annotation. | 181–197 |
| MissingOverride | The method 'selectPortletsTypesList(Locale)' is missing an @Override annotation. | 206–226 |
| MissingOverride | The method 'selectPortletTypesList()' is missing an @Override annotation. | 233–254 |
| Rule | Violation | Line |
|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPreferencesTable method if you want a default access modifier | 63 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 63 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 46–50 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPreferencesTable method if you want a default access modifier | 47–50 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 46–50 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getPreferencesTable method if you want a default access modifier | 47–50 |
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for '_nNbItemTotal' | 51 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_nNbItemSuccess' | 53 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_nNbItemFailure' | 55 |
| ImmutableField | Private field '_report' could be made final; it is only initialized in the declaration or constructor. | 57 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 179 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 42–45 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 42–146 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'deleteForResourceTypeAndId': the method is declared in an interface type | 144 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'setLocale(Locale)' is missing an @Override annotation. | 67–70 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 47–344 |
| MissingOverride | The method 'insert(RBAC)' is missing an @Override annotation. | 72–90 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 99–120 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 128–136 |
| MissingOverride | The method 'store(RBAC)' is missing an @Override annotation. | 144–157 |
| MissingOverride | The method 'selectRBACList()' is missing an @Override annotation. | 164–186 |
| MissingOverride | The method 'selectRBACListByRoleKey(String)' is missing an @Override annotation. | 195–218 |
| MissingOverride | The method 'updateRoleKey(String, String)' is missing an @Override annotation. | 267–276 |
| MissingOverride | The method 'deleteForRoleKey(String)' is missing an @Override annotation. | 284–292 |
| MissingOverride | The method 'selectRoleKeys(String, String, String)' is missing an @Override annotation. | 303–327 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 45–216 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 51–53 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(RBACRole)' is missing an @Override annotation. | 59–68 |
| MissingOverride | The method 'load(String)' is missing an @Override annotation. | 77–95 |
| MissingOverride | The method 'delete(String)' is missing an @Override annotation. | 103–111 |
| MissingOverride | The method 'store(String, RBACRole)' is missing an @Override annotation. | 121–131 |
| MissingOverride | The method 'selectRoleList()' is missing an @Override annotation. | 138–157 |
| MissingOverride | The method 'checkExistRole(String)' is missing an @Override annotation. | 166–181 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'equals(Object)' is missing an @Override annotation. | 182–185 |
| MissingOverride | The method 'hashCode()' is missing an @Override annotation. | 190–193 |
| Rule | Violation | Line |
|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The getter 'getXmlAddOn' should not return void linguistically | 57 |
| Rule | Violation | Line |
|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The getter 'getCreateResourceModelAddOn' should not return void linguistically | 53 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getModifyResourceModelAddOn' should not return void linguistically | 77 |
| Rule | Violation | Line |
|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The getter 'getXmlAddOn' should not return void linguistically | 68–76 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getCreateResourceModelAddOn' should not return void linguistically | 110–118 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getModifyResourceModelAddOn' should not return void linguistically | 150–158 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_aFeaturesList' could be made final; it is only initialized in the declaration or constructor. | 59 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 112–119 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 172–179 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(FeatureGroup)' is missing an @Override annotation. | 66–79 |
| MissingOverride | The method 'load(String)' is missing an @Override annotation. | 88–110 |
| MissingOverride | The method 'delete(String)' is missing an @Override annotation. | 118–125 |
| MissingOverride | The method 'store(FeatureGroup)' is missing an @Override annotation. | 133–146 |
| MissingOverride | The method 'selectFeatureGroupsList()' is missing an @Override annotation. | 153–176 |
| MissingOverride | The method 'selectFeatureGroupsCount()' is missing an @Override annotation. | 183–198 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'changeRightOrder(FeatureGroup, int)' has a cyclomatic complexity of 10. | 199–235 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'selectExternalRightsList': the method is declared in an interface type | 90 |
| Rule | Violation | Line |
|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the newPrimaryKey method if you want a default access modifier | 62–80 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 62–80 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 88–99 |
| MissingOverride | The method 'insert(Level)' is missing an @Override annotation. | 88–99 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 108–126 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 134–142 |
| MissingOverride | The method 'store(Level)' is missing an @Override annotation. | 150–161 |
| MissingOverride | The method 'selectLevelsList()' is missing an @Override annotation. | 168–186 |
| Rule | Violation | Line |
|---|---|---|
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 117 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 195 |
| ShortVariable | Avoid variables with short names like o | 349 |
| ShortVariable | Avoid variables with short names like o | 370 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDuplicateLiterals | The String literal " SELECT id_right, name, level_right, admin_url, description, plugin_name, id_feature_group, icon_url, documentation_url, id_order, is_external_feature " appears 4 times in this file; the first occurrence is on line 55 | 55 |
| MissingOverride | The method 'insert(Right)' is missing an @Override annotation. | 75–94 |
| MissingOverride | The method 'load(String)' is missing an @Override annotation. | 103–131 |
| MissingOverride | The method 'delete(String)' is missing an @Override annotation. | 139–154 |
| MissingOverride | The method 'store(Right)' is missing an @Override annotation. | 162–181 |
| MissingOverride | The method 'selectRightsList()' is missing an @Override annotation. | 188–191 |
| MissingOverride | The method 'selectRightsList(int)' is missing an @Override annotation. | 200–230 |
| MissingOverride | The method 'selectRightsList(String)' is missing an @Override annotation. | 289–331 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'changeRightOrder(Right, int)' has a cyclomatic complexity of 10. | 188–224 |
| CommentRequired | Public method and constructor comments are required | 299–302 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 67 |
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 96–99 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 106–109 |
| MissingOverride | The method 'getWorkgroup()' is missing an @Override annotation. | 116–119 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(Role)' is missing an @Override annotation. | 63–74 |
| MissingOverride | The method 'load(String)' is missing an @Override annotation. | 83–103 |
| MissingOverride | The method 'delete(String)' is missing an @Override annotation. | 111–118 |
| MissingOverride | The method 'store(Role)' is missing an @Override annotation. | 126–137 |
| MissingOverride | The method 'selectRolesList()' is missing an @Override annotation. | 144–163 |
| MissingOverride | The method 'selectAll()' is missing an @Override annotation. | 170–190 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getDescription()' is missing an @Override annotation. | 57–60 |
| MissingOverride | The method 'setDescription(String)' is missing an @Override annotation. | 66–69 |
| MissingOverride | The method 'getTitle()' is missing an @Override annotation. | 75–78 |
| MissingOverride | The method 'setTitle(String)' is missing an @Override annotation. | 84–87 |
| MissingOverride | The method 'getImage()' is missing an @Override annotation. | 93–96 |
| MissingOverride | The method 'setImage(IFeedResourceImage)' is missing an @Override annotation. | 104–107 |
| MissingOverride | The method 'getItems()' is missing an @Override annotation. | 113–116 |
| MissingOverride | The method 'setItems(List)' is missing an @Override annotation. | 124–127 |
| MissingOverride | The method 'getLanguage()' is missing an @Override annotation. | 133–136 |
| MissingOverride | The method 'setLanguage(String)' is missing an @Override annotation. | 144–147 |
| MissingOverride | The method 'getLink()' is missing an @Override annotation. | 153–156 |
| MissingOverride | The method 'setLink(String)' is missing an @Override annotation. | 164–167 |
| MissingOverride | The method 'getDate()' is missing an @Override annotation. | 173–176 |
| MissingOverride | The method 'setDate(Date)' is missing an @Override annotation. | 182–185 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getUrl()' is missing an @Override annotation. | 50–53 |
| MissingOverride | The method 'setUrl(String)' is missing an @Override annotation. | 59–62 |
| MissingOverride | The method 'getTitle()' is missing an @Override annotation. | 68–71 |
| MissingOverride | The method 'setTitle(String)' is missing an @Override annotation. | 77–80 |
| MissingOverride | The method 'getLink()' is missing an @Override annotation. | 86–89 |
| MissingOverride | The method 'setLink(String)' is missing an @Override annotation. | 95–98 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getTitle()' is missing an @Override annotation. | 54–57 |
| MissingOverride | The method 'setTitle(String)' is missing an @Override annotation. | 63–66 |
| MissingOverride | The method 'getLink()' is missing an @Override annotation. | 72–75 |
| MissingOverride | The method 'setLink(String)' is missing an @Override annotation. | 81–84 |
| MissingOverride | The method 'getDescription()' is missing an @Override annotation. | 90–93 |
| MissingOverride | The method 'setDescription(String)' is missing an @Override annotation. | 99–102 |
| MissingOverride | The method 'getGUID()' is missing an @Override annotation. | 108–111 |
| MissingOverride | The method 'setGUID(String)' is missing an @Override annotation. | 117–120 |
| MissingOverride | The method 'getDate()' is missing an @Override annotation. | 126–129 |
| MissingOverride | The method 'setDate(Date)' is missing an @Override annotation. | 135–138 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getKey()' is missing an @Override annotation. | 53–56 |
| MissingOverride | The method 'setKey(String)' is missing an @Override annotation. | 64–67 |
| MissingOverride | The method 'getTitleI18nKey()' is missing an @Override annotation. | 74–77 |
| MissingOverride | The method 'setTitleI18nKey(String)' is missing an @Override annotation. | 85–88 |
| MissingOverride | The method 'getClassName()' is missing an @Override annotation. | 95–98 |
| MissingOverride | The method 'setClassName(String)' is missing an @Override annotation. | 106–109 |
| MissingOverride | The method 'getTitle()' is missing an @Override annotation. | 116–119 |
| MissingOverride | The method 'setTitle(String)' is missing an @Override annotation. | 127–130 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'load(String)' is missing an @Override annotation. | 55–73 |
| MissingOverride | The method 'store(ReferenceItem)' is missing an @Override annotation. | 76–84 |
| MissingOverride | The method 'findAll()' is missing an @Override annotation. | 87–103 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 89 |
| MissingOverride | The method 'selectParametersList()' is missing an @Override annotation. | 106–122 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 69–87 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the newPrimaryKey method if you want a default access modifier | 69–87 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 95–115 |
| MissingOverride | The method 'insert(Mode)' is missing an @Override annotation. | 95–115 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 124–151 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 159–166 |
| MissingOverride | The method 'store(Mode)' is missing an @Override annotation. | 174–192 |
| MissingOverride | The method 'selectModesList()' is missing an @Override annotation. | 199–227 |
| MissingOverride | The method 'getModesList()' is missing an @Override annotation. | 234–250 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'getOuputXslProperties(int)' has a cyclomatic complexity of 15. | 140–195 |
| NPathComplexity | The method 'getOuputXslProperties(int)' has an NPath complexity of 2187 | 140–195 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(PageTemplate)' is missing an @Override annotation. | 65–81 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 90–111 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 119–126 |
| MissingOverride | The method 'store(PageTemplate)' is missing an @Override annotation. | 134–147 |
| MissingOverride | The method 'selectPageTemplatesList()' is missing an @Override annotation. | 154–175 |
| MissingOverride | The method 'checkPageTemplateIsUsed(int)' is missing an @Override annotation. | 184–201 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(Style)' is missing an @Override annotation. | 74–86 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 95–118 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 126–133 |
| MissingOverride | The method 'store(Style)' is missing an @Override annotation. | 141–153 |
| MissingOverride | The method 'selectStylesList()' is missing an @Override annotation. | 160–184 |
| MissingOverride | The method 'selectPortalComponentList()' is missing an @Override annotation. | 191–206 |
| MissingOverride | The method 'selectStyleSheetList(int)' is missing an @Override annotation. | 215–238 |
| MissingOverride | The method 'checkStylePortalComponent(int)' is missing an @Override annotation. | 247–264 |
| Rule | Violation | Line |
|---|---|---|
| MethodReturnsInternalArray | Returning '_strSource' may expose an internal array. | 162 |
| ArrayIsStoredDirectly | The user-supplied array 'strSource' is stored directly. | 171 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'insert(StyleSheet)' is missing an @Override annotation. | 72–92 |
| MissingOverride | The method 'load(int)' is missing an @Override annotation. | 101–123 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 131–141 |
| MissingOverride | The method 'selectStyleSheetList(int)' is missing an @Override annotation. | 150–189 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 162 |
| MissingOverride | The method 'store(StyleSheet)' is missing an @Override annotation. | 197–212 |
| MissingOverride | The method 'selectStyleSheetNbPerStyleMode(int, int)' is missing an @Override annotation. | 276–298 |
| MissingOverride | The method 'selectModeId(int)' is missing an @Override annotation. | 307–327 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 51–53 |
| Rule | Violation | Line |
|---|---|---|
| RedundantFieldInitializer | Avoid using redundant field initializer for '_bDefault' | 47 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–739 |
| TooManyFields | Too many fields | 63–739 |
| GodClass | Possible God Class (WMC=57, ATFD=9, TCC=3.098%) | 63–739 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 88 |
| ImmutableField | Private field '_userInfo' could be made final; it is only initialized in the declaration or constructor. | 88 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 90 |
| ImmutableField | Private field '_rights' could be made final; it is only initialized in the declaration or constructor. | 95 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 95 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 100 |
| ImmutableField | Private field '_roles' could be made final; it is only initialized in the declaration or constructor. | 100 |
| UncommentedEmptyConstructor | Document empty constructor | 114–116 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 135–142 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setUserInfo' should not return any type except void linguistically | 684–687 |
| CommentRequired | Public method and constructor comments are required | 705–708 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–1326 |
| ExcessiveClassLength | Avoid really long classes. | 59–1326 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 60–1326 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 358 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 420 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 849 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 854 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 857 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1049 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 83–86 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setAdminUserFilter' should not return any type except void linguistically | 230–270 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 235–267 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–647 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 54–647 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 18 characters appended. | 625 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–473 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 51–473 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 74–76 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 74–76 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 271 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 290 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 310 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 346 |
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'AdminUserField' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=10, WMC=12) | 44–178 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 54–568 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 141–148 |
| NPathComplexity | The method 'selectUsersByFilter(AdminUserFieldFilter)' has an NPath complexity of 220 | 327–398 |
| CyclomaticComplexity | The method 'selectUsersByFilter(AdminUserFieldFilter)' has a cyclomatic complexity of 11. | 327–398 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 341 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 350–358 |
| NPathComplexity | The method 'selectByFilter(AdminUserFieldFilter)' has an NPath complexity of 544 | 408–480 |
| CyclomaticComplexity | The method 'selectByFilter(AdminUserFieldFilter)' has a cyclomatic complexity of 11. | 408–480 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 48–220 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 84–87 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 84–87 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 177 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 245–288 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 84–87 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 84–87 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 177 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 254–297 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'load(int, Locale)' is missing an @Override annotation. | 111–152 |
| MissingOverride | The method 'insert(IAttribute)' is missing an @Override annotation. | 161–184 |
| MissingOverride | The method 'store(IAttribute)' is missing an @Override annotation. | 192–208 |
| MissingOverride | The method 'delete(int)' is missing an @Override annotation. | 216–224 |
| MissingOverride | The method 'selectAll(Locale)' is missing an @Override annotation. | 233–277 |
| MissingOverride | The method 'selectPluginAttributes(String, Locale)' is missing an @Override annotation. | 288–334 |
| MissingOverride | The method 'selectCoreAttributes(Locale)' is missing an @Override annotation. | 343–383 |
| MissingOverride | The method 'updateAttributeAnonymization(int, boolean)' is missing an @Override annotation. | 393–401 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 105–108 |
| CyclomaticComplexity | The method 'setAttributeData(HttpServletRequest)' has a cyclomatic complexity of 11. | 195–251 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 198 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 199 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 200 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 201 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 202 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 84–87 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 84–87 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 177 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 90–93 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 90–93 |
| CyclomaticComplexity | The method 'setAttributeData(HttpServletRequest)' has a cyclomatic complexity of 10. | 180–238 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 183 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 183 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 184 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 185 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 186 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 188 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 189 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 201 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'strValue' | 295 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 46–142 |
| Rule | Violation | Line |
|---|---|---|
| LinguisticNaming | Linguistics Antipattern - The setter 'setAttributeData' should not return any type except void linguistically | 304 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'doRemoveUserFields(AdminUser, HttpServletRequest, Locale)' is missing an @Override annotation. | 166–169 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'login(String, String, HttpServletRequest)' has a cyclomatic complexity of 10. | 97–143 |
| Rule | Violation | Line |
|---|---|---|
| DataClass | The class 'LuteceDefaultAdminUser' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=4, WMC=8) | 44–135 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'load(String, AdminAuthentication)' is missing an @Override annotation. | 71–102 |
| MissingOverride | The method 'updateResetPassword(LuteceDefaultAdminUser, boolean)' is missing an @Override annotation. | 112–120 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The constructor 'PBKDF2Password(String, PASSWORD_REPRESENTATION)' has a cyclomatic complexity of 11. | 172–213 |
| UseUnderscoresInNumericLiterals | Number 40000 should separate every third digit with an underscore | 177 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 207 |
| ShortVariable | Avoid variables with short names like sb | 248 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 249 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 250 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the DummyPassword constructor if you want a default access modifier | 362–366 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 429–432 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 460–473 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'selectLoginErrors(UserLog, int)' is missing an @Override annotation. | 58–81 |
| MissingOverride | The method 'insertLog(UserLog)' is missing an @Override annotation. | 89–100 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 66 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 70 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'canBeRemoved(String)' is missing an @Override annotation. | 60–81 |
| MissingOverride | The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. | 92–96 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getWorkgroup()' is missing an @Override annotation. | 93–96 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 48–334 |
| MissingOverride | The method 'insert(AdminWorkgroup)' is missing an @Override annotation. | 71–80 |
| MissingOverride | The method 'load(String)' is missing an @Override annotation. | 85–103 |
| MissingOverride | The method 'delete(String)' is missing an @Override annotation. | 108–116 |
| MissingOverride | The method 'store(AdminWorkgroup)' is missing an @Override annotation. | 121–130 |
| MissingOverride | The method 'selectWorkgroupList()' is missing an @Override annotation. | 135–154 |
| MissingOverride | The method 'checkExistWorkgroup(String)' is missing an @Override annotation. | 159–173 |
| MissingOverride | The method 'isUserInWorkgroup(int, String)' is missing an @Override annotation. | 178–195 |
| MissingOverride | The method 'checkUserHasWorkgroup(int)' is missing an @Override annotation. | 200–214 |
| MissingOverride | The method 'getUserWorkgroups(int)' is missing an @Override annotation. | 219–235 |
| MissingOverride | The method 'getUsersListForWorkgroup(String)' is missing an @Override annotation. | 240–263 |
| MissingOverride | The method 'deleteAllUsersForWorkgroup(String)' is missing an @Override annotation. | 268–275 |
| MissingOverride | The method 'insertUserForWorkgroup(AdminUser, String)' is missing an @Override annotation. | 280–288 |
| MissingOverride | The method 'deleteUserFromWorkgroup(int, String)' is missing an @Override annotation. | 293–301 |
| MissingOverride | The method 'selectWorkgroupsByFilter(AdminWorkgroupFilter)' is missing an @Override annotation. | 310–333 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 68–71 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setAdminWorkgroupFilter' should not return any type except void linguistically | 141–158 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 146–155 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 46–231 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 45–170 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 71–78 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 154–161 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 221 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_bServiceAvailable' could be made final; it is only initialized in the declaration or constructor. | 57 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 95–102 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 162–165 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 166–169 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 89–98 |
| CyclomaticComplexity | The method 'getRemoteUser(HttpServletRequest)' has a cyclomatic complexity of 10. | 131–179 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 205 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1529 |
| ExcessiveClassLength | Avoid really long classes. | 104–1529 |
| GodClass | Possible God Class (WMC=144, ATFD=173, TCC=6.410%) | 104–1529 |
| CyclomaticComplexity | The class 'AdminUserService' has a total cyclomatic complexity of 144 (highest 11). | 104–1529 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 105–1529 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 278–289 |
| CyclomaticComplexity | The method 'getFilteredUsersInterface(Collection, HttpServletRequest, Map, UrlItem)' has a cyclomatic complexity of 10. | 307–386 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 345–354 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 356 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 397 |
| CyclomaticComplexity | The method 'checkEmail(String)' has a cyclomatic complexity of 11. | 475–519 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 603–610 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1290 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 1350 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1358 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–473 |
| ExcessiveMethodLength | Avoid really long methods. | 95–207 |
| NcssCount | The method 'readLineOfCSVFile(String, int, Locale, String)' has a NCSS line count of 68. | 95–207 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 171 |
| AvoidReassigningLoopVariables | Avoid reassigning the loop control variable 'strValue' | 327 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 367 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 427 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 55–372 |
| ImmutableField | Private field '_logger' could be made final; it is only initialized in the declaration or constructor. | 58 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 193 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 180 characters appended. | 272 |
| CloneMethodReturnTypeMustMatchClassName | The return type of the clone() method must be the class name when implements Cloneable | 292–295 |
| CloneThrowsCloneNotSupportedException | clone() method should throw CloneNotSupportedException | 292–295 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 61–479 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 120–132 |
| ShortVariable | Avoid variables with short names like cs | 207 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getInfos method if you want a default access modifier | 244–258 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 244–258 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 27 characters appended. | 246 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 247 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 247 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 247 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 248 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 248 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 248 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 249 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 249 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 249 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 250 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 250 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 250 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 251 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 251 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 251 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 252 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 252 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 252 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 253 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 253 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 253 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 254 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 254 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 254 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 255 |
| UseUnderscoresInNumericLiterals | Number 10000 should separate every third digit with an underscore | 265 |
| UseUnderscoresInNumericLiterals | Number 10000L should separate every third digit with an underscore | 267 |
| UseUnderscoresInNumericLiterals | Number 10000L should separate every third digit with an underscore | 268 |
| UseUnderscoresInNumericLiterals | Number 10000 should separate every third digit with an underscore | 272 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 305 |
| ShortVariable | Avoid variables with short names like cs | 317 |
| ShortVariable | Avoid variables with short names like cs | 330 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getKey(Map, int, LuteceUser)' is missing an @Override annotation. | 62–83 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 73 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 73 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 73 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 77 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 79 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 79 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 79 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 80 |
| MissingOverride | The method 'setAllowedParametersList(List)' is missing an @Override annotation. | 88–91 |
| MissingOverride | The method 'setIgnoredParametersList(List)' is missing an @Override annotation. | 96–99 |
| Rule | Violation | Line |
|---|---|---|
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 56 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 56 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 56 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 56 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_logger' could be made final; it is only initialized in the declaration or constructor. | 69 |
| MissingOverride | The method 'parseBlockingCacheTimeoutMillis(FilterConfig)' is missing an @Override annotation. | 152–164 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 180 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 180 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 180 |
| AvoidUncheckedExceptionsInSignatures | A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause | 180 |
| Rule | Violation | Line |
|---|---|---|
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PathCacheService constructor if you want a default access modifier | 54–58 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 54–58 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 21 characters appended. | 79 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 80 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 80 |
| Rule | Violation | Line |
|---|---|---|
| TooManyFields | Too many fields | 41–465 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 80 |
| CyclomaticComplexity | The method 'getPage(HttpServletRequest, int)' has a cyclomatic complexity of 11. | 190–265 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 336 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 50–52 |
| ShortVariable | Avoid variables with short names like o | 151 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 162–165 |
| ShortVariable | Avoid variables with short names like o | 190 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=67, ATFD=48, TCC=3.297%) | 64–727 |
| CyclomaticComplexity | The method 'readCSVFile(Reader, CSVReader, int, boolean, boolean, boolean, Locale, String)' has a cyclomatic complexity of 31. | 340–572 |
| NcssCount | The method 'readCSVFile(Reader, CSVReader, int, boolean, boolean, boolean, Locale, String)' has a NCSS line count of 103. | 340–572 |
| NPathComplexity | The method 'readCSVFile(Reader, CSVReader, int, boolean, boolean, boolean, Locale, String)' has an NPath complexity of 233024 | 340–572 |
| ExcessiveMethodLength | Avoid really long methods. | 340–572 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 442–474 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 450 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 462 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 476–549 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 532 |
| Rule | Violation | Line |
|---|---|---|
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 24 characters appended. | 136 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 137 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 138 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 142 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 30 characters appended. | 181 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 182 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 183 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 187 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 29 characters appended. | 230 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 231 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 232 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. | 264 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 265 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 266 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 270 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 285 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 296 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 303 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–385 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 58 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 74–120 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 84 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 325–328 |
| Rule | Violation | Line |
|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 39 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_formatterDateTime' could be made final; it is only initialized in the declaration or constructor. | 47 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 176–179 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 285 |
| Rule | Violation | Line |
|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 59 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 65 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 86 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 96 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 189 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 221–231 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 225 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 290 |
| CommentRequired | Public method and constructor comments are required | 306–309 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 328 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 330 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 339 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 358–361 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 366 |
| Rule | Violation | Line |
|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 44 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 46 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the DEAMON_THREAD_BEAN_NAME field if you want a default access modifier | 46 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 85 |
| AvoidCatchingThrowable | A catch statement should never catch throwable since it includes errors. | 106 |
| Rule | Violation | Line |
|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 61 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 61 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 63 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 73–76 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'run()' is missing an @Override annotation. | 50–54 |
| Rule | Violation | Line |
|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 42 |
| ImmutableField | Private field '_runnable' could be made final; it is only initialized in the declaration or constructor. | 44 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 44 |
| ImmutableField | Private field '_strKey' could be made final; it is only initialized in the declaration or constructor. | 45 |
| ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 46 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 59 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 76 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 87 |
| Rule | Violation | Line |
|---|---|---|
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 59 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 61 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 69 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 91 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 92 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 93 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 93 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 93 |
| ImmutableField | Private field '_mapThreadByKey' could be made final; it is only initialized in the declaration or constructor. | 93 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 94 |
| ImmutableField | Private field '_listThread' could be made final; it is only initialized in the declaration or constructor. | 94 |
| FieldDeclarationsShouldBeAtStartOfClass | Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. | 94 |
| AssignmentInOperand | Avoid assignments in operands | 112 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 116–150 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 118 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 120–142 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 147 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 166 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 168 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 168 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 176 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 189 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 191 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 204 |
| DoNotUseThreads | To be compliant to J2EE, a webapp should not use any thread. | 221 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 239–242 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 249–257 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 264–267 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like o | 185 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 252 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listRegisteredListeners' could be made final; it is only initialized in the declaration or constructor. | 51 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getDashboardComponents' should not return void linguistically | 74–80 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=56, ATFD=45, TCC=3.268%) | 60–530 |
| ShortVariable | Avoid variables with short names like dc | 136 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 291 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 433 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 495 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 41–71 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like dc | 136 |
| CyclomaticComplexity | The method 'updateDashboardComponents(IAdminDashboardComponent, List, int)' has a cyclomatic complexity of 11. | 224–254 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 286 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 358 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like is | 82 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 87 |
| LinguisticNaming | Linguistics Antipattern - The getter 'getPoolList' should not return void linguistically | 148–154 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 69–72 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 114 |
| MissingOverride | The method 'getParentLogger()' is missing an @Override annotation. | 226–229 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 107–122 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 46–49 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=49, ATFD=9, TCC=18.382%) | 52–456 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the VALUE_MISSING field if you want a default access modifier | 58 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 58 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 103–106 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 108–111 |
| ShortVariable | Avoid variables with short names like p | 155 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 158–170 |
| ShortVariable | Avoid variables with short names like sb | 337 |
| ShortVariable | Avoid variables with short names like e | 431 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 449 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–47 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 90 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 107 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 120–132 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 148–155 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 174–197 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'parseAndClean': the method is declared in an interface type | 63 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 65–68 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 83 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 10–40 |
| AbstractClassWithoutAbstractMethod | This abstract class does not have any abstract methods | 10–40 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 13 |
| ImmutableField | Private field '_listeners' could be made final; it is only initialized in the declaration or constructor. | 13 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 5–25 |
| RedundantFieldInitializer | Avoid using redundant field initializer for '_instance' | 8 |
| NonThreadSafeSingleton | Singleton is not thread safe | 16–19 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–51 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'static final' on field 'LINK_VALIDITY_TIME': the field is declared in an interface type | 50 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'checkAccessRights': the method is declared in an interface type | 60 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type | 58 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'isDefault': the method is declared in an interface type | 65 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 80 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 107 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 137 |
| ShortVariable | Avoid variables with short names like sb | 194 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 195 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 196 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 197 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'MESSAGE_ACCESS_DENIED_KEY'. | 49 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 228 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 229 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 266 |
| CommentRequired | Public method and constructor comments are required | 300–303 |
| CommentRequired | Public method and constructor comments are required | 305–308 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–159 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 57–60 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 68–71 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 108–123 |
| MissingOverride | The method 'addImageResource(FileItem)' is missing an @Override annotation. | 135–138 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 76–79 |
| MissingOverride | The method 'getImageResource(int)' is missing an @Override annotation. | 106–125 |
| ControlStatementBraces | This statement should have braces | 109 |
| MissingOverride | The method 'getResourceTypeId()' is missing an @Override annotation. | 132–135 |
| MissingOverride | The method 'addImageResource(FileItem)' is missing an @Override annotation. | 156–159 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 60–72 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 71 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. | 48 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 48 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listFilters' could be made final; it is only initialized in the declaration or constructor. | 54 |
| ShortVariable | Avoid variables with short names like f | 86 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 139 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. | 53 |
| ShortVariable | Avoid variables with short names like o | 224 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'doFilter(ServletRequest, ServletResponse)' is missing an @Override annotation. | 122–129 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strName' could be made final; it is only initialized in the declaration or constructor. | 48 |
| ImmutableField | Private field '_context' could be made final; it is only initialized in the declaration or constructor. | 49 |
| ImmutableField | Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. | 50 |
| MissingOverride | The method 'getFilterName()' is missing an @Override annotation. | 72–75 |
| MissingOverride | The method 'getServletContext()' is missing an @Override annotation. | 80–83 |
| MissingOverride | The method 'getInitParameter(String)' is missing an @Override annotation. | 88–91 |
| MissingOverride | The method 'getInitParameterNames()' is missing an @Override annotation. | 98–101 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'init(FilterConfig)' is missing an @Override annotation. | 58–61 |
| MissingOverride | The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' is missing an @Override annotation. | 66–109 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 99 |
| MissingOverride | The method 'destroy()' is missing an @Override annotation. | 114–132 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 127 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 143–146 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the matchMapping method if you want a default access modifier | 143–146 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the matchFilterUrl method if you want a default access modifier | 159–202 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 159–202 |
| NPathComplexity | The method 'matchFilterUrl(String, String)' has an NPath complexity of 240 | 159–202 |
| CyclomaticComplexity | The method 'matchFilterUrl(String, String)' has a cyclomatic complexity of 13. | 159–202 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 171 |
| SimplifyBooleanReturns | Avoid unnecessary if..then..else statements when returning booleans | 178–182 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 61–66 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 75–80 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyMethodBody | Document empty method body | 58–60 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 164 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 198 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–76 |
| CommentRequired | Public method and constructor comments are required | 45–49 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 45–49 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 80 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 81 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 82 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 85 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 117–124 |
| ShortVariable | Avoid variables with short names like sb | 155 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 204 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 204–234 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 206 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 247 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 253 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–47 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 51–55 |
| UncommentedEmptyConstructor | Document empty constructor | 57–60 |
| CommentRequired | Public method and constructor comments are required | 57–60 |
| MethodReturnsInternalArray | Returning '_strImage' may expose an internal array. | 69 |
| ArrayIsStoredDirectly | The user-supplied array 'strImage' is stored directly. | 78 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 50 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like sc | 107 |
| ShortVariable | Avoid variables with short names like in | 115 |
| AssignmentInOperand | Avoid assignments in operands | 120 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 200 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 51 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 75 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 43–45 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the LUTECE_BANNER_VERSION field if you want a default access modifier | 43–45 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the LUTECE_BANNER_SERVER field if you want a default access modifier | 47–50 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 47–50 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–360 |
| ExcessiveMethodLength | Avoid really long methods. | 125–245 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 71 characters appended. | 227 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 228 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 230 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 313 |
| ShortVariable | Avoid variables with short names like p | 314 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 320 |
| ShortVariable | Avoid variables with short names like fw | 341 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 345 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like e | 56 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 69 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 69 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 81 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 103 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'register()' is missing an @Override annotation. | 57–70 |
| ShortVariable | Avoid variables with short names like rt | 59 |
| ShortVariable | Avoid variables with short names like p | 64 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 79–89 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 100–105 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getResourceTypeCode()' is missing an @Override annotation. | 257–260 |
| MissingOverride | The method 'getResourceId()' is missing an @Override annotation. | 267–270 |
| AddEmptyString | Do not add empty strings | 269 |
| MissingOverride | The method 'setLocale(Locale)' is missing an @Override annotation. | 278–281 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 53 |
| ShortVariable | Avoid variables with short names like is | 71 |
| ShortVariable | Avoid variables with short names like is | 83 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getEntityManagerFactory()' is missing an @Override annotation. | 69–82 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'process()' is missing an @Override annotation. | 79–159 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 84 |
| ShortVariable | Avoid variables with short names like ds | 94 |
| ShortVariable | Avoid variables with short names like tm | 141 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 166–169 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 51–56 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 64–76 |
| Rule | Violation | Line |
|---|---|---|
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 60 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 53–56 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 71–79 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 79–142 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 92–141 |
| AvoidDuplicateLiterals | The String literal "{} {} " appears 4 times in this file; the first occurrence is on line 122 | 122 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 124 |
| CyclomaticComplexity | The method 'sendMail(MailItem, Transport, Session, StringBuilder)' has a cyclomatic complexity of 12. | 219–271 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 224 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 226 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 228 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 52–628 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 88 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 111–112 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 137–138 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 171–172 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 200–201 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 232–234 |
| ExcessiveParameterList | Avoid long parameter lists. | 232–234 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 270–271 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 298–299 |
| ExcessiveParameterList | Avoid long parameter lists. | 329–330 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 329–330 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 362 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 385–386 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 411–412 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 444–445 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 470–471 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 499–500 |
| ShortVariable | Avoid variables with short names like sb | 595 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–707 |
| GodClass | Possible God Class (WMC=47, ATFD=86, TCC=16.190%) | 82–707 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 154 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 181–188 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 206–216 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 234–288 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 306–340 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 358–381 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 397–405 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 420–429 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 452–485 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 465 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 500–538 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 530 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 549–552 |
| ShortVariable | Avoid variables with short names like st | 587 |
| AvoidProtectedMethodInFinalClassNotExtending | Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. | 605–625 |
| AssignmentInOperand | Avoid assignments in operands | 617 |
| CyclomaticComplexity | The method 'convertUrlAttachmentDataSourceToByteArrayDataSource(UrlAttachment)' has a cyclomatic complexity of 11. | 634–706 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 637 |
| ShortVariable | Avoid variables with short names like bo | 645 |
| ShortVariable | Avoid variables with short names like o | 651 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listMails' could be made final; it is only initialized in the declaration or constructor. | 46 |
| MissingOverride | The method 'send(MailItem)' is missing an @Override annotation. | 54–60 |
| MissingOverride | The method 'consume()' is missing an @Override annotation. | 67–81 |
| MissingOverride | The method 'size()' is missing an @Override annotation. | 88–91 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 186–193 |
| Rule | Violation | Line |
|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 166–167 |
| ArrayIsStoredDirectly | The user-supplied array 'messageArgs' is stored directly. | 166 |
| Rule | Violation | Line |
|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 242–243 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 269–270 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 333–334 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 336 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 480 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 501 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 523 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 38–63 |
| ImmutableField | Private field '_strText' could be made final; it is only initialized in the declaration or constructor. | 42 |
| ImmutableField | Private field '_strTitle' could be made final; it is only initialized in the declaration or constructor. | 43 |
| CommentRequired | Public method and constructor comments are required | 45–50 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strTextKey' could be made final; it is only initialized in the declaration or constructor. | 62 |
| ImmutableField | Private field '_strTitleKey' could be made final; it is only initialized in the declaration or constructor. | 63 |
| ImmutableField | Private field '_strUrl' could be made final; it is only initialized in the declaration or constructor. | 64 |
| ImmutableField | Private field '_strTarget' could be made final; it is only initialized in the declaration or constructor. | 65 |
| ImmutableField | Private field '_nType' could be made final; it is only initialized in the declaration or constructor. | 67 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 111 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 122 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 91 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 157 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 164 |
| Rule | Violation | Line |
|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 267–268 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 295–296 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 325–326 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 328 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 353 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 356 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setSiteMessageUrl' should not return any type except void linguistically | 444–450 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 516–535 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 56–59 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 68–78 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the getKey method if you want a default access modifier | 68–78 |
| CloneThrowsCloneNotSupportedException | clone() method should throw CloneNotSupportedException | 144–147 |
| CloneMethodReturnTypeMustMatchClassName | The return type of the clone() method must be the class name when implements Cloneable | 144–147 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_pageService' could be made final; it is only initialized in the declaration or constructor. | 53 |
| MissingOverride | The method 'isInvoked(HttpServletRequest)' is missing an @Override annotation. | 67–71 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 76–79 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_page' could be made final; it is only initialized in the declaration or constructor. | 50 |
| ImmutableField | Private field '_nType' could be made final; it is only initialized in the declaration or constructor. | 51 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'register()' is missing an @Override annotation. | 60–78 |
| ShortVariable | Avoid variables with short names like rt | 62 |
| ShortVariable | Avoid variables with short names like p | 67 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 87–90 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 101–106 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1157 |
| ExcessiveClassLength | Avoid really long classes. | 97–1157 |
| CyclomaticComplexity | The class 'PageService' has a total cyclomatic complexity of 86 (highest 19). | 97–1157 |
| GodClass | Possible God Class (WMC=86, ATFD=104, TCC=6.907%) | 97–1157 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 98–1157 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 263 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 361 |
| CyclomaticComplexity | The method 'buildPageContent(String, int, HttpServletRequest)' has a cyclomatic complexity of 11. | 401–492 |
| NPathComplexity | The method 'getPageContent(int, int, HttpServletRequest)' has an NPath complexity of 360 | 508–573 |
| CyclomaticComplexity | The method 'getPageContent(int, int, HttpServletRequest)' has a cyclomatic complexity of 12. | 508–573 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 534 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 555 |
| ShortVariable | Avoid variables with short names like t | 570 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 588 |
| CyclomaticComplexity | The method 'getPortletContent(HttpServletRequest, Portlet, Map, int)' has a cyclomatic complexity of 19. | 612–710 |
| NPathComplexity | The method 'getPortletContent(HttpServletRequest, Portlet, Map, int)' has an NPath complexity of 4608 | 612–710 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 643 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 650–660 |
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 676 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 679 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 696 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 706 |
| SimplifiedTernary | Ternary operators that can be simplified with || or && | 720 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1006 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1032 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1052–1066 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 1059 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 55–58 |
| MissingOverride | The method 'processPortletEvent(PortletEvent)' is missing an @Override annotation. | 63–74 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 94–108 |
| ShortVariable | Avoid variables with short names like p1 | 153 |
| ShortVariable | Avoid variables with short names like p2 | 153 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–1322 |
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1322 |
| TooManyFields | Too many fields | 84–1322 |
| ExcessiveClassLength | Avoid really long classes. | 84–1322 |
| GodClass | Possible God Class (WMC=128, ATFD=75, TCC=4.023%) | 84–1322 |
| CyclomaticComplexity | The class 'Plugin' has a total cyclomatic complexity of 128 (highest 7). | 84–1322 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 85–1322 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 138 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 155–214 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the load method if you want a default access modifier | 155–214 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 190 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 192 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 210 |
| ShortVariable | Avoid variables with short names like cs | 436 |
| ShortVariable | Avoid variables with short names like o | 1107 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 1320 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'init()' is missing an @Override annotation. | 45–48 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 46 |
| ImmutableField | Private field '_nType' could be made final; it is only initialized in the declaration or constructor. | 47 |
| Rule | Violation | Line |
|---|---|---|
| ExcessivePublicCount | This class has a bunch of public methods and attributes | 34–1028 |
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1028 |
| GodClass | Possible God Class (WMC=79, ATFD=8, TCC=1.461%) | 74–1028 |
| TooManyFields | Too many fields | 74–1028 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 75–1028 |
| ImmutableField | Private field '_listCssStyleSheets' could be made final; it is only initialized in the declaration or constructor. | 92 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 92 |
| ImmutableField | Private field '_listJavascriptFiles' could be made final; it is only initialized in the declaration or constructor. | 93 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 93 |
| ImmutableField | Private field '_listAdminCssStyleSheets' could be made final; it is only initialized in the declaration or constructor. | 94 |
| ImmutableField | Private field '_listAdminJavascriptFiles' could be made final; it is only initialized in the declaration or constructor. | 95 |
| ImmutableField | Private field '_listFreemarkerMacrosFiles' could be made final; it is only initialized in the declaration or constructor. | 96 |
| ImmutableField | Private field '_listRights' could be made final; it is only initialized in the declaration or constructor. | 97 |
| ImmutableField | Private field '_listPortletTypes' could be made final; it is only initialized in the declaration or constructor. | 98 |
| ImmutableField | Private field '_listDaemons' could be made final; it is only initialized in the declaration or constructor. | 99 |
| ImmutableField | Private field '_listApplications' could be made final; it is only initialized in the declaration or constructor. | 100 |
| ImmutableField | Private field '_listFilters' could be made final; it is only initialized in the declaration or constructor. | 101 |
| ImmutableField | Private field '_listServlets' could be made final; it is only initialized in the declaration or constructor. | 102 |
| ImmutableField | Private field '_listListeners' could be made final; it is only initialized in the declaration or constructor. | 103 |
| ImmutableField | Private field '_listContentServices' could be made final; it is only initialized in the declaration or constructor. | 104 |
| ImmutableField | Private field '_listSearchIndexers' could be made final; it is only initialized in the declaration or constructor. | 105 |
| ImmutableField | Private field '_listInsertServices' could be made final; it is only initialized in the declaration or constructor. | 106 |
| ImmutableField | Private field '_listRBACResourceTypes' could be made final; it is only initialized in the declaration or constructor. | 107 |
| ImmutableField | Private field '_listPageIncludes' could be made final; it is only initialized in the declaration or constructor. | 108 |
| ImmutableField | Private field '_listDashboardComponents' could be made final; it is only initialized in the declaration or constructor. | 109 |
| ImmutableField | Private field '_listAdminDashboardComponents' could be made final; it is only initialized in the declaration or constructor. | 110 |
| ImmutableField | Private field '_mapParams' could be made final; it is only initialized in the declaration or constructor. | 111 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 111 |
| ShortVariable | Avoid variables with short names like is | 753 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 72 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 173–214 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 206 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 237–240 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 308 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 78–82 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 89–97 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 104–107 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 185 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 19 characters appended. | 297 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–784 |
| GodClass | Possible God Class (WMC=63, ATFD=111, TCC=5.238%) | 82–784 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 129 |
| ShortVariable | Avoid variables with short names like cs | 167 |
| CyclomaticComplexity | The method 'buildPageContent(int, PageData, int, HttpServletRequest)' has a cyclomatic complexity of 13. | 266–356 |
| NPathComplexity | The method 'buildPageContent(int, PageData, int, HttpServletRequest)' has an NPath complexity of 2304 | 266–356 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 321 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 344 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 408 |
| CyclomaticComplexity | The method 'getXPagePathContent(String, int, HttpServletRequest)' has a cyclomatic complexity of 10. | 428–504 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 493 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 710 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 733–741 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 312 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 325 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'register()' is missing an @Override annotation. | 61–79 |
| ShortVariable | Avoid variables with short names like rt | 63 |
| ShortVariable | Avoid variables with short names like p | 68 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 88–91 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 102–108 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 68–76 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 56–64 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 57–59 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 56–64 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 71–79 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 88 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 142–148 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 156–162 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 290–298 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'setLocale(Locale)' is missing an @Override annotation. | 56–59 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 252 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_mapPermissions' could be made final; it is only initialized in the declaration or constructor. | 53 |
| MissingOverride | The method 'setLocale(Locale)' is missing an @Override annotation. | 72–75 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 51 |
| ShortVariable | Avoid variables with short names like rt | 69 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_bServiceAvailable' could be made final; it is only initialized in the declaration or constructor. | 54 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 78–85 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 103–106 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the isPatternValide method if you want a default access modifier | 103–106 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the isPatternValide method if you want a default access modifier | 115–118 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 115–118 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 122 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 57–60 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listLoaders' could be made final; it is only initialized in the declaration or constructor. | 59 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 64–76 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 68–75 |
| ShortVariable | Avoid variables with short names like st | 95 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 120–123 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 146 |
| ShortVariable | Avoid variables with short names like i | 214 |
| ShortVariable | Avoid variables with short names like i | 233 |
| ShortVariable | Avoid variables with short names like j | 239 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 67–75 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–668 |
| GodClass | Possible God Class (WMC=59, ATFD=82, TCC=18.182%) | 74–668 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 75–668 |
| AvoidStringBufferField | StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). | 88 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 133 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 182–261 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 186 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 229 |
| AvoidDuplicateLiterals | The String literal "</strong>\r\n" appears 4 times in this file; the first occurrence is on line 281 | 281 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 287 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 322 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 373–383 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 410–418 |
| ShortVariable | Avoid variables with short names like e | 469 |
| ShortVariable | Avoid variables with short names like e | 485 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 488 |
| ShortVariable | Avoid variables with short names like e | 502 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 504 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 507 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 514 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 522 |
| ConsecutiveLiteralAppends | StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. | 528 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–327 |
| UseUnderscoresInNumericLiterals | Number 1000000 should separate every third digit with an underscore | 78 |
| MissingOverride | The method 'getSearchResults(String, HttpServletRequest)' is missing an @Override annotation. | 95–148 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 106–128 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 110–123 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 182–186 |
| CyclomaticComplexity | The method 'search(String, String, Query, HttpServletRequest, boolean)' has a cyclomatic complexity of 11. | 221–291 |
| ShortVariable | Avoid variables with short names like ir | 224 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 234 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 273–284 |
| ShortVariable | Avoid variables with short names like si | 277 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 286 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 105 |
| ShortVariable | Avoid variables with short names like ft | 197 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 233 |
| ShortVariable | Avoid variables with short names like sb | 238 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 244 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 249 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 257 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 267 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 92 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strMetadata' could be made final; it is only initialized in the declaration or constructor. | 59 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 156 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 177 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 219 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like rt | 59 |
| ShortVariable | Avoid variables with short names like p | 64 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 77 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 93 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'info': the method is declared in an interface type | 58 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'info': the method is declared in an interface type | 72–75 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'debug': the method is declared in an interface type | 91 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'debug': the method is declared in an interface type | 105–108 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'trace': the method is declared in an interface type | 124 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'trace': the method is declared in an interface type | 138–141 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'warn': the method is declared in an interface type | 157 |
| UnnecessaryModifier | Unnecessary modifier 'public' on method 'warn': the method is declared in an interface type | 171–174 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_mapUserInfo' could be made final; it is only initialized in the declaration or constructor. | 141 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 141 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 161 |
| ImmutableField | Private field '_workgroups' could be made final; it is only initialized in the declaration or constructor. | 161 |
| MethodReturnsInternalArray | Returning '_roles' may expose an internal array. | 286 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 295 |
| MethodReturnsInternalArray | Returning '_groups' may expose an internal array. | 332 |
| ShortVariable | Avoid variables with short names like j | 370 |
| ShortVariable | Avoid variables with short names like j | 401 |
| CloneMethodReturnTypeMustMatchClassName | The return type of the clone() method must be the class name when implements Cloneable | 481–484 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 49–52 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 59–66 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'encryptRsa': the method is already in a final class | 64–67 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'encryptRsa': the method is already in a final class | 76–81 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'decryptRsa': the method is already in a final class | 91–94 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'decryptRsa': the method is already in a final class | 103–109 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 94–114 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 100 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 112 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 198 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 389 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 501 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 568–571 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the isUsersListAvailable method if you want a default access modifier | 568–571 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 72–80 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDuplicateLiterals | The String literal "null" appears 4 times in this file; the first occurrence is on line 97 | 97 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 97 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 115 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 133 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 151 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 167 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 198–199 |
| ShortVariable | Avoid variables with short names like md | 228 |
| ShortVariable | Avoid variables with short names like sb | 232 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strName' could be made final; it is only initialized in the declaration or constructor. | 47 |
| ImmutableField | Private field '_servlet' could be made final; it is only initialized in the declaration or constructor. | 48 |
| ImmutableField | Private field '_strMapping' could be made final; it is only initialized in the declaration or constructor. | 49 |
| ImmutableField | Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. | 50 |
| ImmutableField | Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. | 51 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strName' could be made final; it is only initialized in the declaration or constructor. | 48 |
| ImmutableField | Private field '_context' could be made final; it is only initialized in the declaration or constructor. | 49 |
| ImmutableField | Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. | 50 |
| MissingOverride | The method 'getServletName()' is missing an @Override annotation. | 72–75 |
| MissingOverride | The method 'getServletContext()' is missing an @Override annotation. | 80–83 |
| MissingOverride | The method 'getInitParameter(String)' is missing an @Override annotation. | 88–91 |
| MissingOverride | The method 'getInitParameterNames()' is missing an @Override annotation. | 98–101 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 87 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 111 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 49 |
| ImmutableField | Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. | 49 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listServlets' could be made final; it is only initialized in the declaration or constructor. | 53 |
| ShortVariable | Avoid variables with short names like s | 85 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 137 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like se | 49 |
| MissingOverride | The method 'sessionCreated(HttpSessionEvent)' is missing an @Override annotation. | 49–55 |
| ShortVariable | Avoid variables with short names like se | 60 |
| MissingOverride | The method 'sessionDestroyed(HttpSessionEvent)' is missing an @Override annotation. | 60–66 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 75 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 208 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 270 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the ContextFileFilter nested class if you want a default access modifier | 392–408 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 50–101 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 57 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 65 |
| CommentRequired | Protected method constructor comments are required | 100 |
| Rule | Violation | Line |
|---|---|---|
| NonThreadSafeSingleton | Singleton is not thread safe | 304–308 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 73 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 134–141 |
| UseCollectionIsEmpty | Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() | 180 |
| ShortVariable | Avoid variables with short names like ci | 199 |
| ShortVariable | Avoid variables with short names like ci | 206 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 207–215 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 61–71 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'register()' is missing an @Override annotation. | 59–77 |
| ShortVariable | Avoid variables with short names like rt | 61 |
| ShortVariable | Avoid variables with short names like p | 66 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 86–89 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 100–103 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listRegisteredListeners' could be made final; it is only initialized in the declaration or constructor. | 54 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'checkUserFields(HttpServletRequest, Locale)' has a cyclomatic complexity of 10. | 91–121 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 174 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 282 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 60–68 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 65–73 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 78–93 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 73–95 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 78–95 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like t | 69 |
| ShortVariable | Avoid variables with short names like e | 83 |
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 91–94 |
| ShortVariable | Avoid variables with short names like t | 108 |
| ShortVariable | Avoid variables with short names like sb | 123 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like t | 150 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=68, ATFD=40, TCC=5.846%) | 62–640 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 194 |
| NPathComplexity | The method 'getBaseUrl(HttpServletRequest)' has an NPath complexity of 240 | 218–273 |
| CyclomaticComplexity | The method 'getBaseUrl(HttpServletRequest)' has a cyclomatic complexity of 12. | 218–273 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 239–242 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 261 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 264 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 269 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 303 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 328 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 352 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 78 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 223 |
| UseDiamondOperator | Explicit type arguments can be replaced by Diamond Operator | 223 |
| Rule | Violation | Line |
|---|---|---|
| DefaultPackage | Use explicit scoping instead of the default package private level | 59 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the PROPERTY_CRYPTO_KEY field if you want a default access modifier | 59 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 60 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the DSKEY_CRYPTO_KEY field if you want a default access modifier | 60 |
| ShortVariable | Avoid variables with short names like md | 81 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 224–234 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 226 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 229 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 41–53 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like id | 50 |
| ShortVariable | Avoid variables with short names like id | 61 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listRegisteredListeners' could be made final; it is only initialized in the declaration or constructor. | 45 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=68, ATFD=37, TCC=24.878%) | 67–1069 |
| ExcessiveClassLength | Avoid really long classes. | 67–1069 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 68–1069 |
| ImmutableField | Private field '_bServiceAvailable' could be made final; it is only initialized in the declaration or constructor. | 72 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 98–105 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 294 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 535 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 564 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 836 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 894 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 1047 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'register()' is missing an @Override annotation. | 62–85 |
| ShortVariable | Avoid variables with short names like rt | 64 |
| ShortVariable | Avoid variables with short names like p | 69 |
| MissingOverride | The method 'getResourceIdList(Locale)' is missing an @Override annotation. | 94–97 |
| MissingOverride | The method 'getTitle(String, Locale)' is missing an @Override annotation. | 108–124 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 116 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 123 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–583 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 76–583 |
| UnusedPrivateField | Avoid unused private fields such as 'PROPERTY_SITE_CODE'. | 85 |
| ImmutableField | Private field '_listErrors' could be made final; it is only initialized in the declaration or constructor. | 89 |
| ImmutableField | Private field '_listInfos' could be made final; it is only initialized in the declaration or constructor. | 90 |
| ImmutableField | Private field '_listWarnings' could be made final; it is only initialized in the declaration or constructor. | 91 |
| ImmutableField | Private field '_controller' could be made final; it is only initialized in the declaration or constructor. | 92 |
| ShortVariable | Avoid variables with short names like m | 116 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 260 |
| ShortVariable | Avoid variables with short names like os | 569 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 52–54 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 274 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 275 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 276 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 277 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–912 |
| GodClass | Possible God Class (WMC=69, ATFD=72, TCC=3.104%) | 85–912 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 86–912 |
| ImmutableField | Private field '_listErrors' could be made final; it is only initialized in the declaration or constructor. | 104 |
| ImmutableField | Private field '_listInfos' could be made final; it is only initialized in the declaration or constructor. | 105 |
| ImmutableField | Private field '_listWarnings' could be made final; it is only initialized in the declaration or constructor. | 106 |
| ImmutableField | Private field '_controller' could be made final; it is only initialized in the declaration or constructor. | 108 |
| CyclomaticComplexity | The method 'processController(HttpServletRequest)' has a cyclomatic complexity of 14. | 145–208 |
| ShortVariable | Avoid variables with short names like m | 159 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 199 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 229–237 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 251–259 |
| ShortVariable | Avoid variables with short names like t | 293 |
| ShortVariable | Avoid variables with short names like t | 329 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 344 |
| ShortVariable | Avoid variables with short names like os | 759 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–612 |
| GodClass | Possible God Class (WMC=47, ATFD=95, TCC=3.922%) | 86–612 |
| CyclomaticComplexity | The method 'getContent(HttpServletRequest, int)' has a cyclomatic complexity of 10. | 162–213 |
| EmptyCatchBlock | Avoid empty catch blocks | 195–199 |
| ShortVariable | Avoid variables with short names like cs | 203 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 205 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 240 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 367 |
| LooseCoupling | Avoid using implementation types like 'HashMap'; use the interface instead | 403 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 528 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 550 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 557 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 588–589 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 85 |
| ShortVariable | Avoid variables with short names like t | 100 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like p1 | 141 |
| ShortVariable | Avoid variables with short names like p2 | 142 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 159 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 235 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 240 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 110 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 115 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 120 |
| ShortVariable | Avoid variables with short names like t | 126 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 204 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–632 |
| GodClass | Possible God Class (WMC=57, ATFD=117, TCC=7.500%) | 88–632 |
| ImmutableField | Private field '_bAdminAvatar' could be made final; it is only initialized in the declaration or constructor. | 144 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 156 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 197 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 201 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 224 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 401–414 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 430 |
| CyclomaticComplexity | The method 'doModifyDefaultAdminUserPassword(HttpServletRequest)' has a cyclomatic complexity of 10. | 447–504 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 457 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 552–566 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 560 |
| CommentRequired | Public method and constructor comments are required | 568–571 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 579–606 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 594 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 620 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 626 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 77 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–900 |
| GodClass | Possible God Class (WMC=78, ATFD=181, TCC=9.357%) | 90–900 |
| ShortVariable | Avoid variables with short names like cs | 194 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 199–206 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 287 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 308–316 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setParentPageId' should not return any type except void linguistically | 332–346 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 368 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 455–463 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 514 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 525 |
| CyclomaticComplexity | The method 'getPageData(HttpServletRequest, Page)' has a cyclomatic complexity of 11. | 662–762 |
| ExcessiveMethodLength | Avoid really long methods. | 662–762 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 664 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 667 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 668 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 669 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 671 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 672 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 673 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 674 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 675 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 676 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 680 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 704 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 748 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 809 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 850 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 872–881 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 884–892 |
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'JSP_DO_MODIFY_POSITION'. | 79 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 160 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 160 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 177 |
| CyclomaticComplexity | The method 'doRemovePortlet(HttpServletRequest)' has a cyclomatic complexity of 10. | 215–256 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 228 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 228 |
| CyclomaticComplexity | The method 'getModifyPortletStatus(HttpServletRequest)' has a cyclomatic complexity of 10. | 267–312 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 281 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 281 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 306 |
| NPathComplexity | The method 'doModifyPortletStatus(HttpServletRequest)' has an NPath complexity of 216 | 323–367 |
| CyclomaticComplexity | The method 'doModifyPortletStatus(HttpServletRequest)' has a cyclomatic complexity of 12. | 323–367 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 341 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 341 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 389 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 390 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 396 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 396 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 111 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 137 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 287 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_service' could be made final; it is only initialized in the declaration or constructor. | 67 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 75 |
| Rule | Violation | Line |
|---|---|---|
| MissingSerialVersionUID | Classes implementing Serializable should set a serialVersionUID | 57–190 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 156 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 167 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 201 |
| CyclomaticComplexity | The method 'getFeatureGroupsList(AdminUser)' has a cyclomatic complexity of 16. | 218–307 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 261–304 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 55–122 |
| CommentRequired | Protected method constructor comments are required | 121 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–47 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 36–47 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 64 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'init(FilterConfig)' is missing an @Override annotation. | 60–65 |
| MissingOverride | The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' is missing an @Override annotation. | 81–94 |
| MissingOverride | The method 'destroy()' is missing an @Override annotation. | 99–102 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 78–94 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Public method and constructor comments are required | 97–124 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 101 |
| CommentRequired | Public method and constructor comments are required | 126–140 |
| CommentRequired | Public method and constructor comments are required | 142–160 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 154 |
| CommentRequired | Public method and constructor comments are required | 162–171 |
| CommentRequired | Public method and constructor comments are required | 173–204 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 177 |
| CommentRequired | Public method and constructor comments are required | 206–234 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 82 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 130 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 111 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 111 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 193 |
| ShortVariable | Avoid variables with short names like t | 198 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 221 |
| ShortVariable | Avoid variables with short names like t | 226 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 245 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 246 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 249 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 249 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 249 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 285 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 286 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 289 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 289 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 289 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 340 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 88 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 109 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 165 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 169 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–357 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 129 |
| ExcessiveMethodLength | Avoid really long methods. | 144–244 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 146 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 146 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 150 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 355 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 101–139 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 108 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 207 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 235 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 286–289 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 50–54 |
| CommentRequired | Public method and constructor comments are required | 50–54 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 64–83 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 75 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 76–77 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 74–116 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 79–112 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 89 |
| ShortVariable | Avoid variables with short names like t | 97 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 64–71 |
| Rule | Violation | Line |
|---|---|---|
| MissingOverride | The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. | 84–104 |
| CyclomaticComplexity | The method 'buildTreeMenuContent(int, int, HttpServletRequest)' has a cyclomatic complexity of 10. | 117–208 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 127 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 202 |
| Rule | Violation | Line |
|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 131 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 106 |
| ShortVariable | Avoid variables with short names like t | 111 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 135–144 |
| ShortVariable | Avoid variables with short names like is | 137 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 167 |
| Rule | Violation | Line |
|---|---|---|
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 110–140 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 112–139 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 161–164 |
| CollapsibleIfStatements | These nested if statements could be combined | 161–164 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 210–223 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–541 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 138 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 260 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 281 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 344 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 389–399 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 432 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 525 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 528 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 82 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 141 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 146 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 148 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 186 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 208 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'setPortletCommonData(HttpServletRequest, Portlet)' has a cyclomatic complexity of 12. | 190–283 |
| LinguisticNaming | Linguistics Antipattern - The setter 'setPortletCommonData' should not return any type except void linguistically | 190–283 |
| NPathComplexity | The method 'setPortletCommonData(HttpServletRequest, Portlet)' has an NPath complexity of 768 | 190–283 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 192 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 196 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 201 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 202 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 203 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 204 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 205 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 206 |
| Rule | Violation | Line |
|---|---|---|
| UselessOverridingMethod | Overriding method merely calls super | 81–84 |
| MissingOverride | The method 'init(ServletConfig)' is missing an @Override annotation. | 81–84 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 125–157 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 133–157 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 145 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–1105 |
| CyclomaticComplexity | The class 'RoleManagementJspBean' has a total cyclomatic complexity of 98 (highest 16). | 89–1105 |
| ExcessiveClassLength | Avoid really long classes. | 89–1105 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 90–1105 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 240 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 261 |
| CyclomaticComplexity | The method 'doCreateRole(HttpServletRequest)' has a cyclomatic complexity of 11. | 279–319 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 283 |
| CyclomaticComplexity | The method 'doModifyRole(HttpServletRequest)' has a cyclomatic complexity of 16. | 331–401 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 333 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 336 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 415 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 433 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 440–462 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 491 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 519 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 569 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 652 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 707 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 707 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 708 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 709 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 709 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 710 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 711 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 711 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 712 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 713 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 713 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 714 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 715 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 715 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 716 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 717 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 717 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 720–726 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 722 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 724 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 735 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 735 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 736 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 737 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 737 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 738 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 739 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 739 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 740 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 741 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 741 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 742 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 743 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 743 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 744 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 745 |
| AppendCharacterWithChar | Avoid appending characters as strings in StringBuffer.append. | 745 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 781 |
| CyclomaticComplexity | The method 'doSelectPermissions(HttpServletRequest)' has a cyclomatic complexity of 12. | 821–889 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 823 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 824 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 875–886 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 877–885 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 900 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 1015–1024 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 1103 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 87 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 117–120 |
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 117–120 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 133 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 157 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 225 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 225 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 256 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 304 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–287 |
| NPathComplexity | The method 'getPage(HttpServletRequest, int, Plugin)' has an NPath complexity of 672 | 131–242 |
| ExcessiveMethodLength | Avoid really long methods. | 131–242 |
| CyclomaticComplexity | The method 'getPage(HttpServletRequest, int, Plugin)' has a cyclomatic complexity of 13. | 131–242 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 210 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 257 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 104–111 |
| Rule | Violation | Line |
|---|---|---|
| CyclomaticComplexity | The method 'doModifyAdvancedParameters(HttpServletRequest)' has a cyclomatic complexity of 11. | 91–146 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 108 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 167 |
| CyclomaticComplexity | The method 'doModifyPageTemplate(HttpServletRequest)' has a cyclomatic complexity of 14. | 250–332 |
| NPathComplexity | The method 'doModifyPageTemplate(HttpServletRequest)' has an NPath complexity of 480 | 250–332 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 255 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 256 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 259 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 262 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 266 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 360 |
| Rule | Violation | Line |
|---|---|---|
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 150 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 155 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 161 |
| AddEmptyString | Do not add empty strings | 162 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 180 |
| CyclomaticComplexity | The method 'doCreateStyle(HttpServletRequest)' has a cyclomatic complexity of 10. | 199–251 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 201 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 246 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 265 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 287 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 291 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 293 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 334 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 349 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 358 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 86 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–525 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 143 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 173 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 178 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 184 |
| AddEmptyString | Do not add empty strings | 186 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 207 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 263 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 265 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 266 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 269 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 320 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 349 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 413 |
| LinguisticNaming | Linguistics Antipattern - The method 'isValid' indicates linguistically it returns a boolean, but it returns 'String' | 462–479 |
| ShortVariable | Avoid variables with short names like is | 470 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 473 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 117–128 |
| ShortVariable | Avoid variables with short names like cs | 120 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 164–174 |
| ShortVariable | Avoid variables with short names like cs | 167 |
| ShortVariable | Avoid variables with short names like cs | 197 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 204 |
| ShortVariable | Avoid variables with short names like cs | 234 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=51, ATFD=81, TCC=16.667%) | 66–512 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 117 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 158 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 191 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 212 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 255 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 309 |
| CyclomaticComplexity | The method 'verifyCoreCompatibility(Plugin)' has a cyclomatic complexity of 10. | 411–457 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like t | 69 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 132 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 171 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 191 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 203–219 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 211–218 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 239 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 16, but has at least 55 characters appended. | 312 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 66 |
| Rule | Violation | Line |
|---|---|---|
| LooseCoupling | Avoid using implementation types like 'LinkedList'; use the interface instead | 73 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 143–201 |
| ImmutableField | Private field '_strRemoteAddr' could be made final; it is only initialized in the declaration or constructor. | 247 |
| ImmutableField | Private field '_lRequestTime' could be made final; it is only initialized in the declaration or constructor. | 248 |
| Rule | Violation | Line |
|---|---|---|
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 95 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_item' could be made final; it is only initialized in the declaration or constructor. | 54 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 143–170 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 77 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 85 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 97–109 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–745 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 180 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 195–198 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 246 |
| CommentRequired | Public method and constructor comments are required | 279–312 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 289 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 323 |
| CyclomaticComplexity | The method 'doLogin(HttpServletRequest)' has a cyclomatic complexity of 11. | 392–465 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 480 |
| CommentRequired | Public method and constructor comments are required | 526–606 |
| NPathComplexity | The method 'doResetPassword(HttpServletRequest)' has an NPath complexity of 3456 | 526–606 |
| CyclomaticComplexity | The method 'doResetPassword(HttpServletRequest)' has a cyclomatic complexity of 15. | 526–606 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 528 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 620 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–2716 |
| GodClass | Possible God Class (WMC=272, ATFD=571, TCC=31.212%) | 121–2716 |
| CyclomaticComplexity | The class 'AdminUserJspBean' has a total cyclomatic complexity of 272 (highest 11). | 121–2716 |
| ExcessiveClassLength | Avoid really long classes. | 121–2716 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 122–2716 |
| ImmutableField | Private field '_bAdminAvatar' could be made final; it is only initialized in the declaration or constructor. | 380 |
| CyclomaticComplexity | The method 'getManageAdminUsers(HttpServletRequest)' has a cyclomatic complexity of 10. | 393–492 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 403 |
| AddEmptyString | Do not add empty strings | 479 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 511 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 591 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 625 |
| NcssCount | The method 'doCreateAdminUser(HttpServletRequest)' has a NCSS line count of 64. | 659–775 |
| ExcessiveMethodLength | Avoid really long methods. | 659–775 |
| NPathComplexity | The method 'doCreateAdminUser(HttpServletRequest)' has an NPath complexity of 408 | 659–775 |
| CyclomaticComplexity | The method 'doCreateAdminUser(HttpServletRequest)' has a cyclomatic complexity of 11. | 659–775 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 661 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 662 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 663 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 664 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 665 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 666 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 667 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 668 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 669 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 702 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 704 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 780 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 781 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 782 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 841 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 841 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 842 |
| ExcessiveMethodLength | Avoid really long methods. | 905–1009 |
| CyclomaticComplexity | The method 'doModifyAdminUser(HttpServletRequest)' has a cyclomatic complexity of 11. | 905–1009 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 908 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 909 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 910 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 911 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 912 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 913 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 914 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1028 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1028 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1029 |
| CyclomaticComplexity | The method 'doModifyAdminUserPassword(HttpServletRequest)' has a cyclomatic complexity of 11. | 1080–1143 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1107 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1110 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1163 |
| CyclomaticComplexity | The method 'doImportUsersFromFile(HttpServletRequest)' has a cyclomatic complexity of 11. | 1190–1258 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1206 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1277 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1316 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1317 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1318 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1319 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1418 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1543 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1574 |
| OptimizableToArrayCall | This call to Collection.toArray() may be optimizable | 1596 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1601 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1628 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1636 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1674 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1707 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1774 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1797 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 1804 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 1843 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2004 |
| ExcessiveMethodLength | Avoid really long methods. | 2024–2128 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2037 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2257 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2325 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2422 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 2483–2498 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 2514 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 2695 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like t | 72 |
| Rule | Violation | Line |
|---|---|---|
| ShortVariable | Avoid variables with short names like t | 76 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 118 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 194 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 220 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 266 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 286 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 287 |
| CyclomaticComplexity | The method 'doMoveUpAttributeField(HttpServletRequest)' has a cyclomatic complexity of 10. | 313–356 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 322 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 325 |
| ShortVariable | Avoid variables with short names like it | 336 |
| CyclomaticComplexity | The method 'doMoveDownAttributeField(HttpServletRequest)' has a cyclomatic complexity of 10. | 367–410 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 376 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 379 |
| ShortVariable | Avoid variables with short names like it | 389 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 125 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 211 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 281 |
| ShortVariable | Avoid variables with short names like it | 340 |
| ShortVariable | Avoid variables with short names like it | 387 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_locale' could be made final; it is only initialized in the declaration or constructor. | 58 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–637 |
| AddEmptyString | Do not add empty strings | 219 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 242 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 262 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 310 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 329 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 394 |
| CyclomaticComplexity | The method 'getAssignUsers(HttpServletRequest)' has a cyclomatic complexity of 10. | 421–523 |
| ExcessiveMethodLength | Avoid really long methods. | 421–523 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 423 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 423 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 427 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 547–556 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 635 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 87–90 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 222 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 224–232 |
| AvoidLiteralsInIfCondition | Avoid using Literals in Conditional Statements | 276 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 52–56 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listRoles' could be made final; it is only initialized in the declaration or constructor. | 52 |
| Rule | Violation | Line |
|---|---|---|
| ExcessiveImports | A high number of imports can indicate a high degree of coupling within an object. | 34–573 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 195 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 309–326 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 351 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 413 |
| CyclomaticComplexity | The method 'getXslExportData(HttpServletRequest, XslExport)' has a cyclomatic complexity of 12. | 434–504 |
| LinguisticNaming | Linguistics Antipattern - The method 'isValid' indicates linguistically it returns a boolean, but it returns 'String' | 513–530 |
| ShortVariable | Avoid variables with short names like is | 521 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 524 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 139 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 6–31 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strRootPath' could be made final; it is only initialized in the declaration or constructor. | 56 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 58 |
| ImmutableField | Private field '_mapPropertiesFiles' could be made final; it is only initialized in the declaration or constructor. | 58 |
| FinalFieldCouldBeStatic | This final field could be made static | 60 |
| FinalFieldCouldBeStatic | This final field could be made static | 61 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 107–112 |
| PositionLiteralsFirstInCaseInsensitiveComparisons | Position literals first in String comparisons for EqualsIgnoreCase | 293 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 145 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 184 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 205–214 |
| Rule | Violation | Line |
|---|---|---|
| UselessStringValueOf | No need to call String.valueOf to append to a string. | 66 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 134 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 145–152 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 171 |
| ShortVariable | Avoid variables with short names like sb | 190 |
| Rule | Violation | Line |
|---|---|---|
| MethodReturnsInternalArray | Returning 'VARIABLES_PREFIX' may expose an internal array. | 74 |
| Rule | Violation | Line |
|---|---|---|
| AssignmentToNonFinalStatic | Possible unsafe assignment to a non-final static field in a constructor. | 52 |
| ImmutableField | Private field '_interpolator' could be made final; it is only initialized in the declaration or constructor. | 53 |
| ShortVariable | Avoid variables with short names like sb | 111 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_locale' could be made final; it is only initialized in the declaration or constructor. | 49 |
| ImmutableField | Private field '_constraintViolation' could be made final; it is only initialized in the declaration or constructor. | 50 |
| ImmutableField | Private field '_config' could be made final; it is only initialized in the declaration or constructor. | 51 |
| ShortVariable | Avoid variables with short names like cv | 63 |
| Rule | Violation | Line |
|---|---|---|
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 103–106 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 109 |
| PositionLiteralsFirstInComparisons | Position literals first in String comparisons | 116 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 122 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 214–217 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 220 |
| Rule | Violation | Line |
|---|---|---|
| GodClass | Possible God Class (WMC=71, ATFD=71, TCC=15.402%) | 70–738 |
| TooManyMethods | This class has too many methods, consider refactoring it. | 71–738 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 181 |
| ExcessiveMethodLength | Avoid really long methods. | 259–393 |
| CyclomaticComplexity | The method 'filterSortAndPaginate(HttpServletRequest, List)' has a cyclomatic complexity of 24. | 259–393 |
| NPathComplexity | The method 'filterSortAndPaginate(HttpServletRequest, List)' has an NPath complexity of 14832 | 259–393 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 329 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 371–378 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 498 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 499 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 589 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 637 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 703 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 711 |
| Rule | Violation | Line |
|---|---|---|
| UncommentedEmptyConstructor | Document empty constructor | 47–49 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listFilter' could be made final; it is only initialized in the declaration or constructor. | 53 |
| LooseCoupling | Avoid using implementation types like 'ArrayList'; use the interface instead | 53 |
| UncommentedEmptyConstructor | Document empty constructor | 58–60 |
| Rule | Violation | Line |
|---|---|---|
| UseUnderscoresInNumericLiterals | Number 86400000 should separate every third digit with an underscore | 55 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 169–185 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 173–180 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 175 |
| ShortVariable | Avoid variables with short names like df | 253 |
| ShortVariable | Avoid variables with short names like df | 263 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 297–313 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 303 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 332 |
| SimpleDateFormatNeedsLocale | When instantiating a SimpleDateFormat object, specify a Locale | 357 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 85 |
| DefaultPackage | Use explicit scoping instead of the default package private level | 111–114 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the setMockMapEnv method if you want a default access modifier | 111–114 |
| Rule | Violation | Line |
|---|---|---|
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 135–138 |
| AssignmentInOperand | Avoid assignments in operands | 180 |
| UnnecessaryModifier | Unnecessary modifier 'final' on method 'normalizeFileName': the method is already in a final class | 197–200 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 199 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strName' could be made final; it is only initialized in the declaration or constructor. | 44 |
| ImmutableField | Private field '_strExtension' could be made final; it is only initialized in the declaration or constructor. | 45 |
| MissingOverride | The method 'accept(File, String)' is missing an @Override annotation. | 69–84 |
| Rule | Violation | Line |
|---|---|---|
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 82 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 101–109 |
| PrematureDeclaration | Avoid declaring a variable if it is unreferenced before a possible exit point. | 128 |
| ForLoopCanBeForeach | This for loop can be replaced by a foreach loop | 147–155 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 174 |
| Rule | Violation | Line |
|---|---|---|
| AddEmptyString | Do not add empty strings | 100 |
| AddEmptyString | Do not add empty strings | 113 |
| AddEmptyString | Do not add empty strings | 125 |
| AddEmptyString | Do not add empty strings | 148 |
| AddEmptyString | Do not add empty strings | 210 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 309 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 348–362 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 354–361 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 381 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 64–87 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_listItems' could be made final; it is only initialized in the declaration or constructor. | 52 |
| ImmutableField | Private field '_strParameterName' could be made final; it is only initialized in the declaration or constructor. | 55 |
| CyclomaticComplexity | The method 'setCurrentItemId(String)' has a cyclomatic complexity of 11. | 83–119 |
| Rule | Violation | Line |
|---|---|---|
| CallSuperInConstructor | It is a good practice to call super() in a constructor | 63–86 |
| Rule | Violation | Line |
|---|---|---|
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 123 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 124 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 184–193 |
| Rule | Violation | Line |
|---|---|---|
| TooManyMethods | This class has too many methods, consider refactoring it. | 56–480 |
| ShortVariable | Avoid variables with short names like e | 103 |
| InsufficientStringBufferDeclaration | StringBuffer constructor is initialized with size 40, but has at least 44 characters appended. | 215 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 216–228 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 244–265 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 377 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 378 |
| ShortVariable | Avoid variables with short names like sb | 390 |
| ShortVariable | Avoid variables with short names like sb | 416 |
| ShortVariable | Avoid variables with short names like sb | 442 |
| ShortVariable | Avoid variables with short names like e | 447 |
| ShortVariable | Avoid variables with short names like sb | 473 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 475 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 476 |
| ConsecutiveAppendsShouldReuse | StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. | 477 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_entityClass' could be made final; it is only initialized in the declaration or constructor. | 63 |
| ShortVariable | Avoid variables with short names like em | 115 |
| ShortVariable | Avoid variables with short names like em | 151 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 153 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 158 |
| ShortVariable | Avoid variables with short names like em | 172 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 180 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 185 |
| ShortVariable | Avoid variables with short names like em | 200 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 201 |
| CompareObjectsWithEquals | Use equals() to compare object references. | 206 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryConstructor | Avoid unnecessary constructors - the compiler will generate these for you | 63–66 |
| MissingOverride | The method 'getTransaction(TransactionDefinition)' is missing an @Override annotation. | 71–97 |
| MissingOverride | The method 'commit(TransactionStatus)' is missing an @Override annotation. | 103–129 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 114 |
| MissingOverride | The method 'rollback(TransactionStatus)' is missing an @Override annotation. | 135–153 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 143 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_mainPTM' could be made final; it is only initialized in the declaration or constructor. | 48 |
| MissingOverride | The method 'flush()' is missing an @Override annotation. | 97–103 |
| MissingOverride | The method 'hasSavepoint()' is missing an @Override annotation. | 119–122 |
| MissingOverride | The method 'isCompleted()' is missing an @Override annotation. | 128–131 |
| MissingOverride | The method 'isNewTransaction()' is missing an @Override annotation. | 137–140 |
| MissingOverride | The method 'isRollbackOnly()' is missing an @Override annotation. | 146–149 |
| MissingOverride | The method 'setRollbackOnly()' is missing an @Override annotation. | 155–161 |
| MissingOverride | The method 'createSavepoint()' is missing an @Override annotation. | 167–170 |
| MissingOverride | The method 'releaseSavepoint(Object)' is missing an @Override annotation. | 176–182 |
| MissingOverride | The method 'rollbackToSavepoint(Object)' is missing an @Override annotation. | 188–194 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strStatus' could be made final; it is only initialized in the declaration or constructor. | 48 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strErrorCode' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_result' could be made final; it is only initialized in the declaration or constructor. | 44 |
| Rule | Violation | Line |
|---|---|---|
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 74 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 76 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 116 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 120 |
| ShortVariable | Avoid variables with short names like sc | 148 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_type' could be made final; it is only initialized in the declaration or constructor. | 59 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 80 |
| ArrayIsStoredDirectly | The user-supplied array 'data' is stored directly. | 94 |
| MissingOverride | The method 'getInputStream()' is missing an @Override annotation. | 109–117 |
| MissingOverride | The method 'getOutputStream()' is missing an @Override annotation. | 125–128 |
| MissingOverride | The method 'getContentType()' is missing an @Override annotation. | 134–137 |
| MissingOverride | The method 'getName()' is missing an @Override annotation. | 143–146 |
| Rule | Violation | Line |
|---|---|---|
| ArrayIsStoredDirectly | The user-supplied array 'data' is stored directly. | 60 |
| MethodReturnsInternalArray | Returning '_data' may expose an internal array. | 73 |
| ArrayIsStoredDirectly | The user-supplied array 'data' is stored directly. | 82 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_content' could be made final; it is only initialized in the declaration or constructor. | 99 |
| ImmutableField | Private field '_strBaseUrl' could be made final; it is only initialized in the declaration or constructor. | 100 |
| ImmutableField | Private field '_useAbsoluteUrl' could be made final; it is only initialized in the declaration or constructor. | 101 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 134 |
| ImmutableField | Private field '_strTagName' could be made final; it is only initialized in the declaration or constructor. | 268 |
| ImmutableField | Private field '_strAttributeName' could be made final; it is only initialized in the declaration or constructor. | 269 |
| ImmutableField | Private field '_strTestedAttributeName' could be made final; it is only initialized in the declaration or constructor. | 270 |
| ImmutableField | Private field '_strTestedAttributeValue' could be made final; it is only initialized in the declaration or constructor. | 271 |
| Rule | Violation | Line |
|---|---|---|
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 94–101 |
| UseLocaleWithCaseConversions | When doing a String.toLowerCase()/toUpperCase() call, use a Locale | 130 |
| CyclomaticComplexity | The method 'getPrimitiveMethod(String, A, Class)' has a cyclomatic complexity of 10. | 161–204 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'processNestedTags(StringBuilder, String, String, String, String, String, String, boolean, boolean, boolean)' has an NPath complexity of 396 | 130–274 |
| ExcessiveMethodLength | Avoid really long methods. | 130–274 |
| ExcessiveParameterList | Avoid long parameter lists. | 130–132 |
| UseObjectForClearerAPI | Rather than using a lot of String arguments, consider using a container object for those values. | 130–132 |
| CyclomaticComplexity | The method 'processNestedTags(StringBuilder, String, String, String, String, String, String, boolean, boolean, boolean)' has a cyclomatic complexity of 21. | 130–274 |
| NcssCount | The method 'processNestedTags(StringBuilder, String, String, String, String, String, String, boolean, boolean, boolean)' has a NCSS line count of 73. | 130–274 |
| UseStringBufferForStringAppends | Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings | 149 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 181–211 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 185 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 193–211 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 199 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 199 |
| ShortVariable | Avoid variables with short names like s1 | 220 |
| ShortVariable | Avoid variables with short names like s2 | 221 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 223 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 223 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 233 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 237–244 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 237 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 254 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 254 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 254 |
| ShortVariable | Avoid variables with short names like m | 254 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 258 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 261 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 270 |
| AccessorMethodGeneration | Avoid autogenerated methods to access private fields and methods of inner / outer classes | 270 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the MutableCharSequence nested class if you want a default access modifier | 281–384 |
| UncommentedEmptyConstructor | Document empty constructor | 298–300 |
| ShortVariable | Avoid variables with short names like sb | 375 |
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryModifier | Unnecessary modifiers 'public static final' on field 'BEAN_NAME': the field is declared in an interface type | 41 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'makePassword(int, boolean, boolean, boolean)' has an NPath complexity of 256 | 107–163 |
| ShortVariable | Avoid variables with short names like r | 110 |
| ShortVariable | Avoid variables with short names like c1 | 131 |
| ShortVariable | Avoid variables with short names like c1 | 137 |
| ShortVariable | Avoid variables with short names like c1 | 143 |
| ShortVariable | Avoid variables with short names like c1 | 149 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_pools' could be made final; it is only initialized in the declaration or constructor. | 66 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 66 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 91–99 |
| ShortVariable | Avoid variables with short names like is | 109 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 119 |
| UseConcurrentHashMap | If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation | 156 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 167 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 174 |
| ReplaceHashtableWithMap | Consider replacing this Hashtable with the newer java.util.Map | 185 |
| ShortVariable | Avoid variables with short names like cs | 186 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 196 |
| ShortVariable | Avoid variables with short names like cs | 205 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 213 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 213 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 217 |
| ShortVariable | Avoid variables with short names like cs | 254 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 265–271 |
| AddEmptyString | Do not add empty strings | 295 |
| AddEmptyString | Do not add empty strings | 296 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 104 |
| AvoidDeeplyNestedIfStmts | Deeply nested if..then statements are hard to read | 129–133 |
| CollapsibleIfStatements | These nested if statements could be combined | 129–133 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 137 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 166 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_strUrl' could be made final; it is only initialized in the declaration or constructor. | 63 |
| ImmutableField | Private field '_strUser' could be made final; it is only initialized in the declaration or constructor. | 64 |
| ImmutableField | Private field '_strPassword' could be made final; it is only initialized in the declaration or constructor. | 65 |
| ImmutableField | Private field '_nMaxConns' could be made final; it is only initialized in the declaration or constructor. | 66 |
| ImmutableField | Private field '_nTimeOut' could be made final; it is only initialized in the declaration or constructor. | 67 |
| ImmutableField | Private field '_logger' could be made final; it is only initialized in the declaration or constructor. | 68 |
| ImmutableField | Private field '_freeConnections' could be made final; it is only initialized in the declaration or constructor. | 70 |
| ImmutableField | Private field '_strCheckValidConnectionSql' could be made final; it is only initialized in the declaration or constructor. | 71 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 108–109 |
| ShortVariable | Avoid variables with short names like lf | 111 |
| CloseResource | Ensure that resources like this Connection object are closed after use | 129 |
| ShortVariable | Avoid variables with short names like pc | 129 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 171–217 |
| AssignmentInOperand | Avoid assignments in operands | 180 |
| CloseResource | Ensure that resources like this Statement object are closed after use | 228 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 232–242 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 254 |
| PreserveStackTrace | New exception is thrown in catch block, original stack trace may be lost | 254 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 326–334 |
| AvoidSynchronizedAtMethodLevel | Use block level rather than method level synchronization | 339–363 |
| CloseResource | Ensure that resources like this Connection object are closed after use | 341 |
| MissingOverride | The method 'getParentLogger()' is missing an @Override annotation. | 526–529 |
| Rule | Violation | Line |
|---|---|---|
| UseProperClassLoader | In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. | 72 |
| Rule | Violation | Line |
|---|---|---|
| ImmutableField | Private field '_pool' could be made final; it is only initialized in the declaration or constructor. | 58 |
| ImmutableField | Private field '_connection' could be made final; it is only initialized in the declaration or constructor. | 59 |
| CommentDefaultAccessModifier | To avoid mistakes add a comment at the beginning of the LuteceConnectionProxy constructor if you want a default access modifier | 69–73 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 96 |
| NullAssignment | Assigning an Object to null is a code smell. Consider refactoring. | 102 |
| Rule | Violation | Line |
|---|---|---|
| NPathComplexity | The method 'init(Map)' has an NPath complexity of 384 | 111–177 |
| CyclomaticComplexity | The method 'init(Map)' has a cyclomatic complexity of 10. | 111–177 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 155 |
| AvoidCatchingNPE | Avoid catching NullPointerException; consider removing the cause of the NPE. | 155 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 159 |
| Rule | Violation | Line |
|---|---|---|
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 74 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 96 |
| AvoidCatchingGenericException | Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block | 115 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 40–55 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 49–106 |
| Rule | Violation | Line |
|---|---|---|
| CommentRequired | Header comments are required | 48–91 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 58–70 |
| ConfusingTernary | Avoid if (x != y) ..; else ..; | 76–88 |
| Rule | Violation | Line |
|---|---|---|
