Fork me on GitHub

PMD Results

The following document contains the results of PMD 6.13.0.

Violations By Priority

Priority 1

fr/paris/lutece/portal/business/accesscontrol/AccessControlSessionData.java

Rule Violation Line
FieldNamingConventions The final field name '_nIdResource' doesn't match '[a-z][a-zA-Z0-9]*' 46
FieldNamingConventions The final field name '_strTypeResource' doesn't match '[a-z][a-zA-Z0-9]*' 47

fr/paris/lutece/portal/business/dashboard/AdminDashboardFactory.java

Rule Violation Line
ClassNamingConventions The utility class name 'AdminDashboardFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 48105

fr/paris/lutece/portal/business/dashboard/DashboardFactory.java

Rule Violation Line
ClassNamingConventions The utility class name 'DashboardFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 48105

fr/paris/lutece/portal/business/portlet/Portlet.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 615618
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 644647

fr/paris/lutece/portal/business/portlet/PortletHtmlContent.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 5558
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 6467

fr/paris/lutece/portal/business/prefs/AbstractUserPreferencesDAO.java

Rule Violation Line
FieldNamingConventions The final field name '_strSqlSelect' doesn't match '[a-z][a-zA-Z0-9]*' 47
FieldNamingConventions The final field name '_strSqlInsert' doesn't match '[a-z][a-zA-Z0-9]*' 48
FieldNamingConventions The final field name '_strSqlUpdate' doesn't match '[a-z][a-zA-Z0-9]*' 49
FieldNamingConventions The final field name '_strSqlDelete' doesn't match '[a-z][a-zA-Z0-9]*' 50
FieldNamingConventions The final field name '_strSqlSelectAll' doesn't match '[a-z][a-zA-Z0-9]*' 51
FieldNamingConventions The final field name '_strSqlSelectByValue' doesn't match '[a-z][a-zA-Z0-9]*' 52
FieldNamingConventions The final field name '_strSqlDeleteKey' doesn't match '[a-z][a-zA-Z0-9]*' 53
FieldNamingConventions The final field name '_strSqlDeleteKeyPrefix' doesn't match '[a-z][a-zA-Z0-9]*' 54
FieldNamingConventions The final field name '_strSqlSelectCount' doesn't match '[a-z][a-zA-Z0-9]*' 55
FieldNamingConventions The final field name '_strSqlSelectCountPrefValue' doesn't match '[a-z][a-zA-Z0-9]*' 56

fr/paris/lutece/portal/business/resourceenhancer/ResourceEnhancer.java

Rule Violation Line
ClassNamingConventions The utility class name 'ResourceEnhancer' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 46219

fr/paris/lutece/portal/business/rss/ResourceRss.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 207210

fr/paris/lutece/portal/business/template/CommonsInclude.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_bDefault' doesn't match '[a-z][a-zA-Z0-9]*' 149

fr/paris/lutece/portal/business/user/authentication/PasswordFactory.java

Rule Violation Line
ClassNamingConventions The enum name 'PASSWORD_REPRESENTATION' doesn't match '[A-Z][a-zA-Z0-9]*' 117121
FieldNamingConventions The final field name '_iterations' doesn't match '[a-z][a-zA-Z0-9]*' 147
FieldNamingConventions The final field name '_salt' doesn't match '[a-z][a-zA-Z0-9]*' 149
FieldNamingConventions The final field name '_hash' doesn't match '[a-z][a-zA-Z0-9]*' 151
FieldNamingConventions The final field name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' 421
FieldNamingConventions The final field name '_strPassword' doesn't match '[a-z][a-zA-Z0-9]*' 448
FieldNamingConventions The final field name '_strAlgorithm' doesn't match '[a-z][a-zA-Z0-9]*' 450

fr/paris/lutece/portal/business/user/menu/AdminUserMenuItem.java

Rule Violation Line
FieldNamingConventions The final field name '_strClass' doesn't match '[a-z][a-zA-Z0-9]*' 43
FieldNamingConventions The final field name '_strContent' doesn't match '[a-z][a-zA-Z0-9]*' 44

fr/paris/lutece/portal/business/user/menu/DividerAdminUserMenuItemProvider.java

Rule Violation Line
FieldNamingConventions The constant name '_item' doesn't match '[A-Z][A-Z_0-9]*' 44

fr/paris/lutece/portal/service/admin/DefaultImportAdminUserService.java

Rule Violation Line
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 89

fr/paris/lutece/portal/service/cache/AbstractCacheableService.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 282285
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 291294
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 300303
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 309312
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 318321
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 327330

fr/paris/lutece/portal/service/cache/CacheService.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 284

fr/paris/lutece/portal/service/csv/CSVReaderService.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 220

fr/paris/lutece/portal/service/daemon/AppDaemonService.java

Rule Violation Line
FieldNamingConventions The constant name '_mapDaemonEntries' doesn't match '[A-Z][A-Z_0-9]*' 58
FieldNamingConventions The constant name '_random' doesn't match '[A-Z][A-Z_0-9]*' 59

fr/paris/lutece/portal/service/daemon/Daemon.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 127130

fr/paris/lutece/portal/service/daemon/DaemonEntry.java

Rule Violation Line
FieldNamingConventions The final field name '_thread' doesn't match '[a-z][a-zA-Z0-9]*' 58

fr/paris/lutece/portal/service/daemon/DaemonScheduler.java

Rule Violation Line
FieldNamingConventions The final field name '_queue' doesn't match '[a-z][a-zA-Z0-9]*' 63
FieldNamingConventions The final field name '_executor' doesn't match '[a-z][a-zA-Z0-9]*' 64
FieldNamingConventions The final field name '_coordinatorThread' doesn't match '[a-z][a-zA-Z0-9]*' 65
FieldNamingConventions The final field name '_scheduledDaemonsTimer' doesn't match '[a-z][a-zA-Z0-9]*' 66
FieldNamingConventions The final field name '_executingDaemons' doesn't match '[a-z][a-zA-Z0-9]*' 67
FieldNamingConventions The final field name '_scheduledDaemons' doesn't match '[a-z][a-zA-Z0-9]*' 68
FieldNamingConventions The final field name '_entry' doesn't match '[a-z][a-zA-Z0-9]*' 293
FieldNamingConventions The final field name '_entry' doesn't match '[a-z][a-zA-Z0-9]*' 352

fr/paris/lutece/portal/service/daemon/DaemonThreadFactory.java

Rule Violation Line
FieldNamingConventions The constant name '_defaultThreadFactory' doesn't match '[A-Z][A-Z_0-9]*' 49

fr/paris/lutece/portal/service/daemon/ThreadLauncherDaemon.java

Rule Violation Line
FieldNamingConventions The final field name '_wrapped' doesn't match '[a-z][a-zA-Z0-9]*' 61

fr/paris/lutece/portal/service/dashboard/IPublicDashboardComponent.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name 'user_id' doesn't match '[a-z][a-zA-Z0-9]*' 72

fr/paris/lutece/portal/service/dashboard/admin/AdminDashboardComponent.java

Rule Violation Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 4345

fr/paris/lutece/portal/service/datastore/CoreDataKeys.java

Rule Violation Line
ClassNamingConventions The utility class name 'CoreDataKeys' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3949

fr/paris/lutece/portal/service/event/ResourceEventManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'ResourceEventManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 48112

fr/paris/lutece/portal/service/file/FileService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 44172

fr/paris/lutece/portal/service/file/implementation/LocalDatabaseFileService.java

Rule Violation Line
FormalParameterNamingConventions The method parameter name '_fileDownloadUrlService' doesn't match '[a-z][a-zA-Z0-9]*' 83
FormalParameterNamingConventions The method parameter name '_fileRBACService' doesn't match '[a-z][a-zA-Z0-9]*' 83

fr/paris/lutece/portal/service/fileimage/FileImagePublicService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 48159
FieldNamingConventions The constant name '_fileStoreService' doesn't match '[A-Z][A-Z_0-9]*' 52

fr/paris/lutece/portal/service/fileimage/FileImageService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 58160

fr/paris/lutece/portal/service/html/XmlTransformerService.java

Rule Violation Line
FieldNamingConventions The constant name '_log' doesn't match '[A-Z][A-Z_0-9]*' 59

fr/paris/lutece/portal/service/i18n/CombinedResourceBundle.java

Rule Violation Line
FieldNamingConventions The final field name '_override' doesn't match '[a-z][a-zA-Z0-9]*' 42
FieldNamingConventions The final field name '_defaults' doesn't match '[a-z][a-zA-Z0-9]*' 43

fr/paris/lutece/portal/service/i18n/I18nService.java

Rule Violation Line
FieldNamingConventions The constant name '_overrideLoader' doesn't match '[A-Z][A-Z_0-9]*' 84
FieldNamingConventions The constant name '_resourceBundleCache' doesn't match '[A-Z][A-Z_0-9]*' 85

fr/paris/lutece/portal/service/image/ImageResource.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setImage' called during object construction 53
ConstructorCallsOverridableMethod Overridable method 'setMimeType' called during object construction 54

fr/paris/lutece/portal/service/image/ImageResourceManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'ImageResourceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 47123
FieldNamingConventions The static field name 'IMAGE_SERVLET_BASE_URL' doesn't match '_[a-z][a-zA-Z0-9]*' 51

fr/paris/lutece/portal/service/image/ImageServlet.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 115

fr/paris/lutece/portal/service/init/AppInfo.java

Rule Violation Line
ClassNamingConventions The utility class name 'AppInfo' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3968

fr/paris/lutece/portal/service/init/AppInit.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 314
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 339

fr/paris/lutece/portal/service/init/PostStartUpServiceManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'PostStartUpServiceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 4475

fr/paris/lutece/portal/service/init/ShutdownServiceManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'ShutdownServiceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 4475

fr/paris/lutece/portal/service/init/StartUpServiceManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'StartUpServiceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 4475

fr/paris/lutece/portal/service/insert/InsertServiceManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'InsertServiceManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 47137

fr/paris/lutece/portal/service/plugin/Plugin.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 11611164

fr/paris/lutece/portal/service/plugin/PluginFile.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 151

fr/paris/lutece/portal/service/plugin/PluginService.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 304

fr/paris/lutece/portal/service/prefs/PrefsConstants.java

Rule Violation Line
ClassNamingConventions The utility class name 'PrefsConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3948

fr/paris/lutece/portal/service/rbac/ResourceTypeManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'ResourceTypeManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 48148

fr/paris/lutece/portal/service/resource/ResourceService.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'initLoaders' called during object construction 70

fr/paris/lutece/portal/service/security/AccessLogService.java

Rule Violation Line
FieldNamingConventions The final field name '_accessLoggerList' doesn't match '[a-z][a-zA-Z0-9]*' 67

fr/paris/lutece/portal/service/security/AccessLoggerConstants.java

Rule Violation Line
ClassNamingConventions The utility class name 'AccessLoggerConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3964

fr/paris/lutece/portal/service/security/FailedLoginCaptchaException.java

Rule Violation Line
FieldNamingConventions The final field name '_bEnableCaptcha' doesn't match '[a-z][a-zA-Z0-9]*' 44

fr/paris/lutece/portal/service/security/LoginRedirectException.java

Rule Violation Line
FieldNamingConventions The final field name '_strRedirectUrl' doesn't match '[a-z][a-zA-Z0-9]*' 42

fr/paris/lutece/portal/service/security/LuteceUser.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 492495

fr/paris/lutece/portal/service/security/SecurityModel.java

Rule Violation Line
ClassNamingConventions The utility class name 'SecurityModel' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3970

fr/paris/lutece/portal/service/security/SecurityTokenService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 52141

fr/paris/lutece/portal/service/security/impl/DefaultAccessLogger.java

Rule Violation Line
FieldNamingConventions The final field name '_bAddHashToLogs' doesn't match '[a-z][a-zA-Z0-9]*' 78
FieldNamingConventions The final field name '_messageFormat' doesn't match '[a-z][a-zA-Z0-9]*' 79
FieldNamingConventions The final field name '_messageFormatSeparator' doesn't match '[a-z][a-zA-Z0-9]*' 80

fr/paris/lutece/portal/service/template/CommonsService.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 46230

fr/paris/lutece/portal/service/user/attribute/AdminUserFieldService.java

Rule Violation Line
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 73

fr/paris/lutece/portal/service/user/menu/AdminUserMenuItemProviderRegistrar.java

Rule Violation Line
FieldNamingConventions The final field name '_service' doesn't match '[a-z][a-zA-Z0-9]*' 55

fr/paris/lutece/portal/service/user/menu/AdminUserMenuService.java

Rule Violation Line
FieldNamingConventions The final field name '_itemProviders' doesn't match '[a-z][a-zA-Z0-9]*' 57

fr/paris/lutece/portal/service/util/AppPathService.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 187

fr/paris/lutece/portal/web/LocalVariables.java

Rule Violation Line
ClassNamingConventions The utility class name 'LocalVariables' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 43102

fr/paris/lutece/portal/web/constants/Markers.java

Rule Violation Line
ClassNamingConventions The utility class name 'Markers' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3966

fr/paris/lutece/portal/web/constants/Messages.java

Rule Violation Line
ClassNamingConventions The utility class name 'Messages' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3964

fr/paris/lutece/portal/web/constants/Parameters.java

Rule Violation Line
ClassNamingConventions The utility class name 'Parameters' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 39139

fr/paris/lutece/portal/web/pluginaction/AbstractPluginAction.java

Rule Violation Line
AbstractClassWithoutAnyMethod No abstract method which means that the keyword is most likely used to prevent instantiation. Use a private or protected constructor instead. 4245

fr/paris/lutece/portal/web/pluginaction/PluginActionManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'PluginActionManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 57133

fr/paris/lutece/portal/web/resource/ExtendableResourcePluginActionManager.java

Rule Violation Line
ClassNamingConventions The utility class name 'ExtendableResourcePluginActionManager' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 5296

fr/paris/lutece/portal/web/style/PageTemplatesJspBean.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 418

fr/paris/lutece/portal/web/stylesheet/StyleSheetJspBean.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 497

fr/paris/lutece/portal/web/system/SystemJspBean.java

Rule Violation Line
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 301

fr/paris/lutece/portal/web/upload/MultipartHttpServletRequest.java

Rule Violation Line
FieldNamingConventions The final field name '_multipartFiles' doesn't match '[a-z][a-zA-Z0-9]*' 52
FieldNamingConventions The final field name '_stringParameters' doesn't match '[a-z][a-zA-Z0-9]*' 53

fr/paris/lutece/portal/web/upload/UploadFilter.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 187190

fr/paris/lutece/portal/web/upload/UploadServlet.java

Rule Violation Line
FieldNamingConventions The constant name 'objectMapper' doesn't match '[A-Z][A-Z_0-9]*' 64

fr/paris/lutece/portal/web/user/UsersAdminDashboardComponent.java

Rule Violation Line
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 72
FieldNamingConventions The constant name '_attributeTypeService' doesn't match '[A-Z][A-Z_0-9]*' 73

fr/paris/lutece/portal/web/user/attribute/AttributeFieldJspBean.java

Rule Violation Line
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 98
FieldNamingConventions The constant name '_attributeFieldService' doesn't match '[A-Z][A-Z_0-9]*' 99

fr/paris/lutece/portal/web/user/attribute/AttributeJspBean.java

Rule Violation Line
FieldNamingConventions The constant name '_attributeService' doesn't match '[A-Z][A-Z_0-9]*' 91

fr/paris/lutece/portal/web/xss/SafeRequestFilter.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 8184

fr/paris/lutece/util/PropertiesService.java

Rule Violation Line
FieldNamingConventions The final field name 'RSA_KEY_PREFIX' doesn't match '[a-z][a-zA-Z0-9]*' 60
FieldNamingConventions The final field name 'MESSAGE_CIPHERED_PROPERTY_SECURITY_EXCEPTION' doesn't match '[a-z][a-zA-Z0-9]*' 61
AvoidFileStream Avoid instantiating FileInputStream, FileOutputStream, FileReader, or FileWriter 141

fr/paris/lutece/util/UniqueIDGenerator.java

Rule Violation Line
ClassNamingConventions The utility class name 'UniqueIDGenerator' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 4068

fr/paris/lutece/util/annotation/ScannotationDB.java

Rule Violation Line
FieldNamingConventions The final field name '_db' doesn't match '[a-z][a-zA-Z0-9]*' 64

fr/paris/lutece/util/datatable/DataTableManager.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'setSortUrl' called during object construction 120

fr/paris/lutece/util/html/AbstractPaginator.java

Rule Violation Line
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 262265
EmptyMethodInAbstractClassShouldBeAbstract An empty method in an abstract class should be abstract instead 271274

fr/paris/lutece/util/http/SecurityUtil.java

Rule Violation Line
FieldNamingConventions The public constant name '_log' doesn't match '[A-Z][A-Z_0-9]*' 69

fr/paris/lutece/util/jpa/JPAConstants.java

Rule Violation Line
ClassNamingConventions The utility class name 'JPAConstants' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 3949

fr/paris/lutece/util/jpa/JPAPersistenceUnitPostProcessor.java

Rule Violation Line
FieldNamingConventions The constant name '_Log' doesn't match '[A-Z][A-Z_0-9]*' 62

fr/paris/lutece/util/jpa/transaction/ChainedTransactionManager.java

Rule Violation Line
FieldNamingConventions The constant name '_log' doesn't match '[A-Z][A-Z_0-9]*' 57

fr/paris/lutece/util/json/JsonUtil.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 4678
FieldNamingConventions The constant name '_mapper' doesn't match '[A-Z][A-Z_0-9]*' 49

fr/paris/lutece/util/pool/service/LuteceConnectionFactory.java

Rule Violation Line
ClassNamingConventions The utility class name 'LuteceConnectionFactory' doesn't match '[A-Z][a-zA-Z0-9]+(Utils?|Helper|Home|Service)' 4475

fr/paris/lutece/util/rsa/RSAKeyPairUtil.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 4399
FieldNamingConventions The static field name 'RSA_KEY_PROVIDER_BEAN_NAME' doesn't match '_[a-z][a-zA-Z0-9]*' 46

fr/paris/lutece/util/sql/DAOUtil.java

Rule Violation Line
AvoidUsingShortType Do not use the short type 1724
AvoidUsingShortType Do not use the short type 3029
AvoidUsingShortType Do not use the short type 3052
AvoidUsingShortType Do not use the short type 3074

fr/paris/lutece/util/sql/Transaction.java

Rule Violation Line
ConstructorCallsOverridableMethod Overridable method 'beginTransaction' called during object construction 108

fr/paris/lutece/util/stream/StreamUtil.java

Rule Violation Line
ClassWithOnlyPrivateConstructorsShouldBeFinal A class which only has private constructors should be final 4371

fr/paris/lutece/util/xml/XmlTransformer.java

Rule Violation Line
FieldNamingConventions The constant name 'transformersPoolList' doesn't match '[A-Z][A-Z_0-9]*' 68

Priority 2

fr/paris/lutece/portal/service/admin/DefaultImportAdminUserService.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'listAttributes' 296

fr/paris/lutece/portal/service/cache/AbstractCacheableService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 57

fr/paris/lutece/portal/service/cache/HeadersPageCachingFilter.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 69

fr/paris/lutece/portal/service/daemon/DaemonScheduler.java

Rule Violation Line
AvoidUsingVolatile Use of modifier volatile is not recommended. 69
AvoidUsingVolatile Use of modifier volatile is not recommended. 294
AvoidUsingVolatile Use of modifier volatile is not recommended. 295

fr/paris/lutece/portal/service/database/DAOUtilTransactionManager.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 62

fr/paris/lutece/portal/service/file/implementation/DefaultFileDownloadService.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'additionnalData' 103
AvoidReassigningParameters Avoid reassigning parameters such as 'additionnalData' 132

fr/paris/lutece/portal/service/jpa/EntityManagerService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 50

fr/paris/lutece/portal/service/jpa/JPAStartupService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 74
GuardLogStatement Logger calls should be surrounded by log level guards. 96
GuardLogStatement Logger calls should be surrounded by log level guards. 109
GuardLogStatement Logger calls should be surrounded by log level guards. 130
GuardLogStatement Logger calls should be surrounded by log level guards. 139
GuardLogStatement Logger calls should be surrounded by log level guards. 144
GuardLogStatement Logger calls should be surrounded by log level guards. 147

fr/paris/lutece/portal/service/page/PageService.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'strPage' 260

fr/paris/lutece/portal/service/security/impl/DefaultAccessLogger.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 84

fr/paris/lutece/portal/service/util/AppLogService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 50
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 51
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 52

fr/paris/lutece/portal/util/mvc/admin/MVCAdminJspBean.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 88

fr/paris/lutece/portal/util/mvc/utils/MVCUtils.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 59

fr/paris/lutece/portal/util/mvc/xpage/MVCApplication.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 103

fr/paris/lutece/portal/web/admin/AdminMenuJspBean.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 143

fr/paris/lutece/portal/web/encoding/EncodingFilter.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'response' 81

fr/paris/lutece/portal/web/includes/LinksInclude.java

Rule Violation Line
AvoidReassigningParameters Avoid reassigning parameters such as 'resourceURI' 276

fr/paris/lutece/portal/web/style/StylesJspBean.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 353354

fr/paris/lutece/util/jpa/JPAPersistenceUnitPostProcessor.java

Rule Violation Line
GuardLogStatement Logger calls should be surrounded by log level guards. 128
GuardLogStatement Logger calls should be surrounded by log level guards. 130
GuardLogStatement Logger calls should be surrounded by log level guards. 131
GuardLogStatement Logger calls should be surrounded by log level guards. 132
GuardLogStatement Logger calls should be surrounded by log level guards. 133
GuardLogStatement Logger calls should be surrounded by log level guards. 134
GuardLogStatement Logger calls should be surrounded by log level guards. 135
GuardLogStatement Logger calls should be surrounded by log level guards. 136
GuardLogStatement Logger calls should be surrounded by log level guards. 137
GuardLogStatement Logger calls should be surrounded by log level guards. 138
GuardLogStatement Logger calls should be surrounded by log level guards. 139
GuardLogStatement Logger calls should be surrounded by log level guards. 140

fr/paris/lutece/util/pool/PoolManager.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 64

fr/paris/lutece/util/pool/service/C3p0ConnectionService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 68

fr/paris/lutece/util/pool/service/ConnectionPool.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 68

fr/paris/lutece/util/pool/service/LuteceConnectionService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 55

fr/paris/lutece/util/pool/service/TomcatConnectionService.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 55

fr/paris/lutece/util/sql/DAOUtil.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 117

fr/paris/lutece/util/sql/Transaction.java

Rule Violation Line
LoggerIsNotStaticFinal The Logger variable declaration does not contain the static and final modifiers 87

Priority 3

fr/paris/lutece/portal/business/accesscontrol/AccessControlSessionData.java

Rule Violation Line
CommentRequired Header comments are required 40152
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 50
ImmutableField Private field '_persistentData' could be made final; it is only initialized in the declaration or constructor. 50

fr/paris/lutece/portal/business/dashboard/AdminDashboardDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 50436
ConfusingTernary Avoid if (x != y) ..; else ..; 150157
ConfusingTernary Avoid if (x != y) ..; else ..; 185193
ConfusingTernary Avoid if (x != y) ..; else ..; 273281
LinguisticNaming Linguistics Antipattern - The setter 'setInsertOrUpdateValues' should not return any type except void linguistically 356363
ConfusingTernary Avoid if (x != y) ..; else ..; 397404

fr/paris/lutece/portal/business/dashboard/AdminDashboardFactory.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 50

fr/paris/lutece/portal/business/dashboard/DashboardDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 49434
ConfusingTernary Avoid if (x != y) ..; else ..; 149156
ConfusingTernary Avoid if (x != y) ..; else ..; 185193
ConfusingTernary Avoid if (x != y) ..; else ..; 271279
LinguisticNaming Linguistics Antipattern - The setter 'setInsertOrUpdateValues' should not return any type except void linguistically 354361
ConfusingTernary Avoid if (x != y) ..; else ..; 395402

fr/paris/lutece/portal/business/dashboard/DashboardFactory.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 50

fr/paris/lutece/portal/business/datastore/DataEntity.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 5254

fr/paris/lutece/portal/business/event/AbstractLuteceEvent.java

Rule Violation Line
CommentRequired Header comments are required 336
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 336

fr/paris/lutece/portal/business/event/LuteceUserEvent.java

Rule Violation Line
CommentRequired Header comments are required 542
ImmutableField Private field '_type' could be made final; it is only initialized in the declaration or constructor. 20

fr/paris/lutece/portal/business/event/ResourceEvent.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 5355

fr/paris/lutece/portal/business/file/FileDAO.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 7178
ConfusingTernary Avoid if (x != y) ..; else ..; 166173

fr/paris/lutece/portal/business/indexeraction/IndexerActionDAO.java

Rule Violation Line
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 255
AssignmentInOperand Avoid assignments in operands 255

fr/paris/lutece/portal/business/mail/MailItemQueueDAO.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 115132
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 128
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 149
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 231

fr/paris/lutece/portal/business/mailinglist/MailingList.java

Rule Violation Line
ImmutableField Private field '_listFilters' could be made final; it is only initialized in the declaration or constructor. 54
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5967

fr/paris/lutece/portal/business/mailinglist/MailingListDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 47366

fr/paris/lutece/portal/business/mailinglist/MailingListFilter.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 6567
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 285

fr/paris/lutece/portal/business/mailinglist/MailingListWorkgroupRemovalListener.java

Rule Violation Line
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 5868
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 7983

fr/paris/lutece/portal/business/page/IPageDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 46203

fr/paris/lutece/portal/business/page/Page.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 34636
TooManyFields Too many fields 52636
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the setOrigParentPageId method if you want a default access modifier 139142
DefaultPackage Use explicit scoping instead of the default package private level 139142
MethodReturnsInternalArray Returning '_strImageContent' may expose an internal array. 162
ArrayIsStoredDirectly The user-supplied array 'strImageContent' is stored directly. 171
AddEmptyString Do not add empty strings 470
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 579
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 580
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 581
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 582
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 583
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 584
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 585

fr/paris/lutece/portal/business/page/PageDAO.java

Rule Violation Line
GodClass Possible God Class (WMC=58, ATFD=218, TCC=0.000%) 52812
TooManyMethods This class has too many methods, consider refactoring it. 53812
MissingOverride The method 'insert(Page)' is missing an @Override annotation. 106164
ConfusingTernary Avoid if (x != y) ..; else ..; 146153
MissingOverride The method 'load(int, boolean)' is missing an @Override annotation. 169219
MissingOverride The method 'loadWithoutImageContent(int, boolean)' is missing an @Override annotation. 224269
MissingOverride The method 'loadPageByIdPortlet(int)' is missing an @Override annotation. 274306
MissingOverride The method 'delete(int)' is missing an @Override annotation. 311319
MissingOverride The method 'store(Page)' is missing an @Override annotation. 324376
ConfusingTernary Avoid if (x != y) ..; else ..; 360367
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the checkPrimaryKey method if you want a default access modifier 385400
DefaultPackage Use explicit scoping instead of the default package private level 385400
DefaultPackage Use explicit scoping instead of the default package private level 408435
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the loadPortlets method if you want a default access modifier 408435
MissingOverride The method 'selectChildPages(int)' is missing an @Override annotation. 440481
MissingOverride The method 'selectChildPagesMinimalData(int)' is missing an @Override annotation. 486510
MissingOverride The method 'selectAllPages()' is missing an @Override annotation. 515554
MissingOverride The method 'invalidatePage(int)' is missing an @Override annotation. 559569
MissingOverride The method 'getPagesList()' is missing an @Override annotation. 574592
MissingOverride The method 'getPagesByRoleKey(String)' is missing an @Override annotation. 601643
MissingOverride The method 'selectNewChildPageOrder(int)' is missing an @Override annotation. 648667
MissingOverride The method 'loadImageResource(int)' is missing an @Override annotation. 672690
MissingOverride The method 'checkPageExist(int)' is missing an @Override annotation. 699716
MissingOverride The method 'loadLastModifiedPage()' is missing an @Override annotation. 721762
MissingOverride The method 'updateAutorisationNode(int, Integer)' is missing an @Override annotation. 767788
ConfusingTernary Avoid if (x != y) ..; else ..; 775782
MissingOverride The method 'selectPageForChangeAutorisationNode(int)' is missing an @Override annotation. 793811

fr/paris/lutece/portal/business/page/PageRoleRemovalListener.java

Rule Violation Line
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 5868
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 7983

fr/paris/lutece/portal/business/physicalfile/PhysicalFile.java

Rule Violation Line
MethodReturnsInternalArray Returning '_byValue' may expose an internal array. 74
ArrayIsStoredDirectly The user-supplied array 'value' is stored directly. 83

fr/paris/lutece/portal/business/portalcomponent/PortalComponentDAO.java

Rule Violation Line
MissingOverride The method 'insert(PortalComponent)' is missing an @Override annotation. 6070
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6070
MissingOverride The method 'load(int)' is missing an @Override annotation. 7595
MissingOverride The method 'delete(int)' is missing an @Override annotation. 100108
MissingOverride The method 'store(PortalComponent)' is missing an @Override annotation. 113124
MissingOverride The method 'selectXslFile(int, int)' is missing an @Override annotation. 129151

fr/paris/lutece/portal/business/portlet/AliasPortlet.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 5558
MissingOverride The method 'getXml(HttpServletRequest)' is missing an @Override annotation. 114131
MissingOverride The method 'getXmlDocument(HttpServletRequest)' is missing an @Override annotation. 142145
MissingOverride The method 'remove()' is missing an @Override annotation. 173176

fr/paris/lutece/portal/business/portlet/AliasPortletDAO.java

Rule Violation Line
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 6476
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6476
MissingOverride The method 'delete(int)' is missing an @Override annotation. 8189
MissingOverride The method 'load(int)' is missing an @Override annotation. 94110
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 115126
ShortVariable Avoid variables with short names like r 117
MissingOverride The method 'selectPortletsByTypeList(String)' is missing an @Override annotation. 131147
MissingOverride The method 'selectAliasId(int)' is missing an @Override annotation. 152168
MissingOverride The method 'selectAcceptAliasPortletRefList()' is missing an @Override annotation. 173188
MissingOverride The method 'selectAcceptAliasPortletList()' is missing an @Override annotation. 193212

fr/paris/lutece/portal/business/portlet/AliasPortletHome.java

Rule Violation Line
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 52
CallSuperInConstructor It is a good practice to call super() in a constructor 5763
MissingOverride The method 'getPortletTypeId()' is missing an @Override annotation. 7074
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8188
MissingOverride The method 'getDAO()' is missing an @Override annotation. 9598

fr/paris/lutece/portal/business/portlet/IAliasPortletDAO.java

Rule Violation Line
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 52
MissingOverride The method 'delete(int)' is missing an @Override annotation. 60
MissingOverride The method 'load(int)' is missing an @Override annotation. 69
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 77

fr/paris/lutece/portal/business/portlet/IPortletDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 47191

fr/paris/lutece/portal/business/portlet/Portlet.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 34676
GodClass Possible God Class (WMC=57, ATFD=21, TCC=2.029%) 51676
TooManyFields Too many fields 51676
ConfusingTernary Avoid if (x != y) ..; else ..; 531
ConfusingTernary Avoid if (x != y) ..; else ..; 534
ConfusingTernary Avoid if (x != y) ..; else ..; 537
ConfusingTernary Avoid if (x != y) ..; else ..; 540

fr/paris/lutece/portal/business/portlet/PortletDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 51530
MissingOverride The method 'insert(Portlet)' is missing an @Override annotation. 97123
MissingOverride The method 'delete(int)' is missing an @Override annotation. 128150
MissingOverride The method 'load(int)' is missing an @Override annotation. 155188
MissingOverride The method 'store(Portlet)' is missing an @Override annotation. 193212
MissingOverride The method 'updateStatus(Portlet, int)' is missing an @Override annotation. 217228
MissingOverride The method 'selectXslFile(int, int)' is missing an @Override annotation. 233253
MissingOverride The method 'selectPortletsListbyName(String)' is missing an @Override annotation. 258279
MissingOverride The method 'selectAliasesForPortlet(int)' is missing an @Override annotation. 284305
MissingOverride The method 'selectPortletsByType(String)' is missing an @Override annotation. 310342
MissingOverride The method 'selectStylesList(String)' is missing an @Override annotation. 347363
MissingOverride The method 'hasAlias(int)' is missing an @Override annotation. 368385
MissingOverride The method 'selectPortletType(String)' is missing an @Override annotation. 390411
MissingOverride The method 'selectPortletListByStyle(int)' is missing an @Override annotation. 416439
MissingOverride The method 'selectPortletsByRole(String)' is missing an @Override annotation. 444465
MissingOverride The method 'loadLastModifiedPortlet()' is missing an @Override annotation. 470505

fr/paris/lutece/portal/business/portlet/PortletHome.java

Rule Violation Line
ShortVariable Avoid variables with short names like p 72
DefaultPackage Use explicit scoping instead of the default package private level 121124
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getXsl method if you want a default access modifier 121124
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 157171
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 179189

fr/paris/lutece/portal/business/portlet/PortletRoleRemovalListener.java

Rule Violation Line
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 5868
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 7983

fr/paris/lutece/portal/business/portlet/PortletType.java

Rule Violation Line
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 211214
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 221224
AddEmptyString Do not add empty strings 223
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 400403

fr/paris/lutece/portal/business/portlet/PortletTypeDAO.java

Rule Violation Line
MissingOverride The method 'insert(PortletType)' is missing an @Override annotation. 7091
MissingOverride The method 'load(String)' is missing an @Override annotation. 100129
MissingOverride The method 'delete(String)' is missing an @Override annotation. 137145
MissingOverride The method 'selectPortletTypeId(String)' is missing an @Override annotation. 154170
MissingOverride The method 'selectNbPortletTypeByPortlet(String)' is missing an @Override annotation. 179195
MissingOverride The method 'selectPortletsTypesList(Locale)' is missing an @Override annotation. 204224
MissingOverride The method 'selectPortletTypesList()' is missing an @Override annotation. 231251

fr/paris/lutece/portal/business/prefs/AbstractUserPreferencesDAO.java

Rule Violation Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getPreferencesTable method if you want a default access modifier 63
DefaultPackage Use explicit scoping instead of the default package private level 63

fr/paris/lutece/portal/business/prefs/AdminUserPreferencesDAO.java

Rule Violation Line
DefaultPackage Use explicit scoping instead of the default package private level 4650
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getPreferencesTable method if you want a default access modifier 4750

fr/paris/lutece/portal/business/prefs/UserPreferencesDAO.java

Rule Violation Line
DefaultPackage Use explicit scoping instead of the default package private level 4650
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getPreferencesTable method if you want a default access modifier 4750

fr/paris/lutece/portal/business/progressmanager/ProgressFeed.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_nNbItemTotal' 51
RedundantFieldInitializer Avoid using redundant field initializer for '_nNbItemSuccess' 53
RedundantFieldInitializer Avoid using redundant field initializer for '_nNbItemFailure' 55
ImmutableField Private field '_report' could be made final; it is only initialized in the declaration or constructor. 57
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 179

fr/paris/lutece/portal/business/rbac/AdminRole.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4245

fr/paris/lutece/portal/business/rbac/IRBACDAO.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'deleteForResourceTypeAndId': the method is declared in an interface type 133

fr/paris/lutece/portal/business/rbac/RBAC.java

Rule Violation Line
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 6770

fr/paris/lutece/portal/business/rbac/RBACDAO.java

Rule Violation Line
MissingOverride The method 'insert(RBAC)' is missing an @Override annotation. 6886
MissingOverride The method 'load(int)' is missing an @Override annotation. 95116
MissingOverride The method 'delete(int)' is missing an @Override annotation. 124132
MissingOverride The method 'store(RBAC)' is missing an @Override annotation. 140153
MissingOverride The method 'selectRBACList()' is missing an @Override annotation. 160182
MissingOverride The method 'selectRBACListByRoleKey(String)' is missing an @Override annotation. 191214
MissingOverride The method 'updateRoleKey(String, String)' is missing an @Override annotation. 224233
MissingOverride The method 'deleteForRoleKey(String)' is missing an @Override annotation. 241249
MissingOverride The method 'selectRoleKeys(String, String, String)' is missing an @Override annotation. 260284

fr/paris/lutece/portal/business/rbac/RBACRole.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 5153

fr/paris/lutece/portal/business/rbac/RBACRoleDAO.java

Rule Violation Line
MissingOverride The method 'insert(RBACRole)' is missing an @Override annotation. 5968
MissingOverride The method 'load(String)' is missing an @Override annotation. 7795
MissingOverride The method 'delete(String)' is missing an @Override annotation. 103111
MissingOverride The method 'store(String, RBACRole)' is missing an @Override annotation. 121131
MissingOverride The method 'selectRoleList()' is missing an @Override annotation. 138157
MissingOverride The method 'checkExistRole(String)' is missing an @Override annotation. 166181

fr/paris/lutece/portal/business/regularexpression/RegularExpression.java

Rule Violation Line
MissingOverride The method 'equals(Object)' is missing an @Override annotation. 182185
MissingOverride The method 'hashCode()' is missing an @Override annotation. 190193

fr/paris/lutece/portal/business/resourceenhancer/IResourceDisplayManager.java

Rule Violation Line
LinguisticNaming Linguistics Antipattern - The getter 'getXmlAddOn' should not return void linguistically 57

fr/paris/lutece/portal/business/resourceenhancer/IResourceManager.java

Rule Violation Line
LinguisticNaming Linguistics Antipattern - The getter 'getCreateResourceModelAddOn' should not return void linguistically 53
LinguisticNaming Linguistics Antipattern - The getter 'getModifyResourceModelAddOn' should not return void linguistically 77

fr/paris/lutece/portal/business/resourceenhancer/ResourceEnhancer.java

Rule Violation Line
LinguisticNaming Linguistics Antipattern - The getter 'getXmlAddOn' should not return void linguistically 6876
LinguisticNaming Linguistics Antipattern - The getter 'getCreateResourceModelAddOn' should not return void linguistically 110118
LinguisticNaming Linguistics Antipattern - The getter 'getModifyResourceModelAddOn' should not return void linguistically 150158

fr/paris/lutece/portal/business/right/FeatureGroup.java

Rule Violation Line
ImmutableField Private field '_aFeaturesList' could be made final; it is only initialized in the declaration or constructor. 58
ConfusingTernary Avoid if (x != y) ..; else ..; 111118
ConfusingTernary Avoid if (x != y) ..; else ..; 171178

fr/paris/lutece/portal/business/right/FeatureGroupDAO.java

Rule Violation Line
MissingOverride The method 'insert(FeatureGroup)' is missing an @Override annotation. 6678
MissingOverride The method 'load(String)' is missing an @Override annotation. 87108
MissingOverride The method 'delete(String)' is missing an @Override annotation. 116123
MissingOverride The method 'store(FeatureGroup)' is missing an @Override annotation. 131143
MissingOverride The method 'selectFeatureGroupsList()' is missing an @Override annotation. 150172
MissingOverride The method 'selectFeatureGroupsCount()' is missing an @Override annotation. 179194

fr/paris/lutece/portal/business/right/FeatureGroupHome.java

Rule Violation Line
CyclomaticComplexity The method 'changeRightOrder(FeatureGroup, int)' has a cyclomatic complexity of 10. 199235

fr/paris/lutece/portal/business/right/IRightDAO.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'selectExternalRightsList': the method is declared in an interface type 90

fr/paris/lutece/portal/business/right/LevelDAO.java

Rule Violation Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the newPrimaryKey method if you want a default access modifier 6280
DefaultPackage Use explicit scoping instead of the default package private level 6280
MissingOverride The method 'insert(Level)' is missing an @Override annotation. 8899
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8899
MissingOverride The method 'load(int)' is missing an @Override annotation. 108126
MissingOverride The method 'delete(int)' is missing an @Override annotation. 134142
MissingOverride The method 'store(Level)' is missing an @Override annotation. 150161
MissingOverride The method 'selectLevelsList()' is missing an @Override annotation. 168186

fr/paris/lutece/portal/business/right/Right.java

Rule Violation Line
PositionLiteralsFirstInComparisons Position literals first in String comparisons 117
PositionLiteralsFirstInComparisons Position literals first in String comparisons 195
ShortVariable Avoid variables with short names like o 349
ShortVariable Avoid variables with short names like o 370

fr/paris/lutece/portal/business/right/RightDAO.java

Rule Violation Line
AvoidDuplicateLiterals The String literal " SELECT id_right, name, level_right, admin_url, description, plugin_name, id_feature_group, icon_url, documentation_url, id_order, is_external_feature " appears 4 times in this file; the first occurrence is on line 55 55
MissingOverride The method 'insert(Right)' is missing an @Override annotation. 7594
MissingOverride The method 'load(String)' is missing an @Override annotation. 103131
MissingOverride The method 'delete(String)' is missing an @Override annotation. 139154
MissingOverride The method 'store(Right)' is missing an @Override annotation. 162181
MissingOverride The method 'selectRightsList()' is missing an @Override annotation. 188191
MissingOverride The method 'selectRightsList(int)' is missing an @Override annotation. 200230
MissingOverride The method 'selectRightsList(String)' is missing an @Override annotation. 289331

fr/paris/lutece/portal/business/right/RightHome.java

Rule Violation Line
CyclomaticComplexity The method 'changeRightOrder(Right, int)' has a cyclomatic complexity of 10. 188224
CommentRequired Public method and constructor comments are required 299302

fr/paris/lutece/portal/business/role/Role.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 67
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 9699
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 106109
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 116119

fr/paris/lutece/portal/business/role/RoleDAO.java

Rule Violation Line
MissingOverride The method 'insert(Role)' is missing an @Override annotation. 6374
MissingOverride The method 'load(String)' is missing an @Override annotation. 83103
MissingOverride The method 'delete(String)' is missing an @Override annotation. 111118
MissingOverride The method 'store(Role)' is missing an @Override annotation. 126137
MissingOverride The method 'selectRolesList()' is missing an @Override annotation. 144163
MissingOverride The method 'selectAll()' is missing an @Override annotation. 170190

fr/paris/lutece/portal/business/rss/FeedResource.java

Rule Violation Line
MissingOverride The method 'getDescription()' is missing an @Override annotation. 5760
MissingOverride The method 'setDescription(String)' is missing an @Override annotation. 6669
MissingOverride The method 'getTitle()' is missing an @Override annotation. 7578
MissingOverride The method 'setTitle(String)' is missing an @Override annotation. 8487
MissingOverride The method 'getImage()' is missing an @Override annotation. 9396
MissingOverride The method 'setImage(IFeedResourceImage)' is missing an @Override annotation. 104107
MissingOverride The method 'getItems()' is missing an @Override annotation. 113116
MissingOverride The method 'setItems(List)' is missing an @Override annotation. 124127
MissingOverride The method 'getLanguage()' is missing an @Override annotation. 133136
MissingOverride The method 'setLanguage(String)' is missing an @Override annotation. 144147
MissingOverride The method 'getLink()' is missing an @Override annotation. 153156
MissingOverride The method 'setLink(String)' is missing an @Override annotation. 164167
MissingOverride The method 'getDate()' is missing an @Override annotation. 173176
MissingOverride The method 'setDate(Date)' is missing an @Override annotation. 182185

fr/paris/lutece/portal/business/rss/FeedResourceImage.java

Rule Violation Line
MissingOverride The method 'getUrl()' is missing an @Override annotation. 5053
MissingOverride The method 'setUrl(String)' is missing an @Override annotation. 5962
MissingOverride The method 'getTitle()' is missing an @Override annotation. 6871
MissingOverride The method 'setTitle(String)' is missing an @Override annotation. 7780
MissingOverride The method 'getLink()' is missing an @Override annotation. 8689
MissingOverride The method 'setLink(String)' is missing an @Override annotation. 9598

fr/paris/lutece/portal/business/rss/FeedResourceItem.java

Rule Violation Line
MissingOverride The method 'getTitle()' is missing an @Override annotation. 5457
MissingOverride The method 'setTitle(String)' is missing an @Override annotation. 6366
MissingOverride The method 'getLink()' is missing an @Override annotation. 7275
MissingOverride The method 'setLink(String)' is missing an @Override annotation. 8184
MissingOverride The method 'getDescription()' is missing an @Override annotation. 9093
MissingOverride The method 'setDescription(String)' is missing an @Override annotation. 99102
MissingOverride The method 'getGUID()' is missing an @Override annotation. 108111
MissingOverride The method 'setGUID(String)' is missing an @Override annotation. 117120
MissingOverride The method 'getDate()' is missing an @Override annotation. 126129
MissingOverride The method 'setDate(Date)' is missing an @Override annotation. 135138

fr/paris/lutece/portal/business/rss/ResourceRssType.java

Rule Violation Line
MissingOverride The method 'getKey()' is missing an @Override annotation. 5356
MissingOverride The method 'setKey(String)' is missing an @Override annotation. 6467
MissingOverride The method 'getTitleI18nKey()' is missing an @Override annotation. 7477
MissingOverride The method 'setTitleI18nKey(String)' is missing an @Override annotation. 8588
MissingOverride The method 'getClassName()' is missing an @Override annotation. 9598
MissingOverride The method 'setClassName(String)' is missing an @Override annotation. 106109
MissingOverride The method 'getTitle()' is missing an @Override annotation. 116119
MissingOverride The method 'setTitle(String)' is missing an @Override annotation. 127130

fr/paris/lutece/portal/business/search/SearchParameterDAO.java

Rule Violation Line
MissingOverride The method 'load(String)' is missing an @Override annotation. 5573
MissingOverride The method 'store(ReferenceItem)' is missing an @Override annotation. 7684
MissingOverride The method 'findAll()' is missing an @Override annotation. 87103
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 89
MissingOverride The method 'selectParametersList()' is missing an @Override annotation. 106122

fr/paris/lutece/portal/business/style/ModeDAO.java

Rule Violation Line
DefaultPackage Use explicit scoping instead of the default package private level 6987
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the newPrimaryKey method if you want a default access modifier 6987
MissingOverride The method 'insert(Mode)' is missing an @Override annotation. 95115
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 95115
MissingOverride The method 'load(int)' is missing an @Override annotation. 124151
MissingOverride The method 'delete(int)' is missing an @Override annotation. 159166
MissingOverride The method 'store(Mode)' is missing an @Override annotation. 174192
MissingOverride The method 'selectModesList()' is missing an @Override annotation. 199227
MissingOverride The method 'getModesList()' is missing an @Override annotation. 234250

fr/paris/lutece/portal/business/style/ModeHome.java

Rule Violation Line
NPathComplexity The method 'getOuputXslProperties(int)' has an NPath complexity of 2187 140195
CyclomaticComplexity The method 'getOuputXslProperties(int)' has a cyclomatic complexity of 15. 140195

fr/paris/lutece/portal/business/style/PageTemplateDAO.java

Rule Violation Line
MissingOverride The method 'insert(PageTemplate)' is missing an @Override annotation. 6581
MissingOverride The method 'load(int)' is missing an @Override annotation. 90111
MissingOverride The method 'delete(int)' is missing an @Override annotation. 119126
MissingOverride The method 'store(PageTemplate)' is missing an @Override annotation. 134147
MissingOverride The method 'selectPageTemplatesList()' is missing an @Override annotation. 154175
MissingOverride The method 'checkPageTemplateIsUsed(int)' is missing an @Override annotation. 184201

fr/paris/lutece/portal/business/style/StyleDAO.java

Rule Violation Line
MissingOverride The method 'insert(Style)' is missing an @Override annotation. 7486
MissingOverride The method 'load(int)' is missing an @Override annotation. 95118
MissingOverride The method 'delete(int)' is missing an @Override annotation. 126133
MissingOverride The method 'store(Style)' is missing an @Override annotation. 141153
MissingOverride The method 'selectStylesList()' is missing an @Override annotation. 160184
MissingOverride The method 'selectPortalComponentList()' is missing an @Override annotation. 191206
MissingOverride The method 'selectStyleSheetList(int)' is missing an @Override annotation. 215238
MissingOverride The method 'checkStylePortalComponent(int)' is missing an @Override annotation. 247264

fr/paris/lutece/portal/business/stylesheet/StyleSheet.java

Rule Violation Line
MethodReturnsInternalArray Returning '_strSource' may expose an internal array. 162
ArrayIsStoredDirectly The user-supplied array 'strSource' is stored directly. 171

fr/paris/lutece/portal/business/stylesheet/StyleSheetDAO.java

Rule Violation Line
MissingOverride The method 'insert(StyleSheet)' is missing an @Override annotation. 7292
MissingOverride The method 'load(int)' is missing an @Override annotation. 101123
MissingOverride The method 'delete(int)' is missing an @Override annotation. 131141
MissingOverride The method 'selectStyleSheetList(int)' is missing an @Override annotation. 150189
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 162
MissingOverride The method 'store(StyleSheet)' is missing an @Override annotation. 197212
MissingOverride The method 'selectStyleSheetNbPerStyleMode(int, int)' is missing an @Override annotation. 276298
MissingOverride The method 'selectModeId(int)' is missing an @Override annotation. 307327

fr/paris/lutece/portal/business/template/AutoInclude.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 5153

fr/paris/lutece/portal/business/template/CommonsInclude.java

Rule Violation Line
RedundantFieldInitializer Avoid using redundant field initializer for '_bDefault' 47

fr/paris/lutece/portal/business/user/AdminUser.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 34739
GodClass Possible God Class (WMC=57, ATFD=9, TCC=3.098%) 63739
TooManyFields Too many fields 63739
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 88
ImmutableField Private field '_userInfo' could be made final; it is only initialized in the declaration or constructor. 88
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 90
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 95
ImmutableField Private field '_rights' could be made final; it is only initialized in the declaration or constructor. 95
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 100
ImmutableField Private field '_roles' could be made final; it is only initialized in the declaration or constructor. 100
UncommentedEmptyConstructor Document empty constructor 114116
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 135142
LinguisticNaming Linguistics Antipattern - The setter 'setUserInfo' should not return any type except void linguistically 684687
CommentRequired Public method and constructor comments are required 705708

fr/paris/lutece/portal/business/user/AdminUserDAO.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 341326
ExcessiveClassLength Avoid really long classes. 591326
TooManyMethods This class has too many methods, consider refactoring it. 601326
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 358
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 420
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 849
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 854
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 857
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1049

fr/paris/lutece/portal/business/user/AdminUserFilter.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8386
LinguisticNaming Linguistics Antipattern - The setter 'setAdminUserFilter' should not return any type except void linguistically 230270
ConfusingTernary Avoid if (x != y) ..; else ..; 235267

fr/paris/lutece/portal/business/user/AdminUserHome.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 34647
TooManyMethods This class has too many methods, consider refactoring it. 54647
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 18 characters appended. 625

fr/paris/lutece/portal/business/user/IAdminUserDAO.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 34473
TooManyMethods This class has too many methods, consider refactoring it. 51473

fr/paris/lutece/portal/business/user/attribute/AbstractAttribute.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 7476
UncommentedEmptyConstructor Document empty constructor 7476
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 271
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 290
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 310
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 346

fr/paris/lutece/portal/business/user/attribute/AdminUserField.java

Rule Violation Line
DataClass The class 'AdminUserField' is suspected to be a Data Class (WOC=16.667%, NOPA=0, NOAM=10, WMC=12) 44178

fr/paris/lutece/portal/business/user/attribute/AdminUserFieldDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 54568
ConfusingTernary Avoid if (x != y) ..; else ..; 141148
NPathComplexity The method 'selectUsersByFilter(AdminUserFieldFilter)' has an NPath complexity of 220 327398
CyclomaticComplexity The method 'selectUsersByFilter(AdminUserFieldFilter)' has a cyclomatic complexity of 11. 327398
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 341
ConfusingTernary Avoid if (x != y) ..; else ..; 350358
CyclomaticComplexity The method 'selectByFilter(AdminUserFieldFilter)' has a cyclomatic complexity of 11. 408480
NPathComplexity The method 'selectByFilter(AdminUserFieldFilter)' has an NPath complexity of 544 408480

fr/paris/lutece/portal/business/user/attribute/AdminUserFieldHome.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 48220

fr/paris/lutece/portal/business/user/attribute/AttributeCheckBox.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 8487
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8487
ConfusingTernary Avoid if (x != y) ..; else ..; 177
ConfusingTernary Avoid if (x != y) ..; else ..; 245288

fr/paris/lutece/portal/business/user/attribute/AttributeComboBox.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8487
CallSuperInConstructor It is a good practice to call super() in a constructor 8487
ConfusingTernary Avoid if (x != y) ..; else ..; 177
ConfusingTernary Avoid if (x != y) ..; else ..; 254297

fr/paris/lutece/portal/business/user/attribute/AttributeDAO.java

Rule Violation Line
MissingOverride The method 'load(int, Locale)' is missing an @Override annotation. 111152
MissingOverride The method 'insert(IAttribute)' is missing an @Override annotation. 161184
MissingOverride The method 'store(IAttribute)' is missing an @Override annotation. 192208
MissingOverride The method 'delete(int)' is missing an @Override annotation. 216224
MissingOverride The method 'selectAll(Locale)' is missing an @Override annotation. 233277
MissingOverride The method 'selectPluginAttributes(String, Locale)' is missing an @Override annotation. 288334
MissingOverride The method 'selectCoreAttributes(Locale)' is missing an @Override annotation. 343383
MissingOverride The method 'updateAttributeAnonymization(int, boolean)' is missing an @Override annotation. 393401

fr/paris/lutece/portal/business/user/attribute/AttributeImage.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 105108
CyclomaticComplexity The method 'setAttributeData(HttpServletRequest)' has a cyclomatic complexity of 11. 195251
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 198
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 199
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 200
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 201
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 202

fr/paris/lutece/portal/business/user/attribute/AttributeRadioButton.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 8487
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8487
ConfusingTernary Avoid if (x != y) ..; else ..; 177

fr/paris/lutece/portal/business/user/attribute/AttributeText.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 9093
CallSuperInConstructor It is a good practice to call super() in a constructor 9093
CyclomaticComplexity The method 'setAttributeData(HttpServletRequest)' has a cyclomatic complexity of 10. 180238
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 183
ConfusingTernary Avoid if (x != y) ..; else ..; 183
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 184
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 185
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 186
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 188
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 189
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 201
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'strValue' 295

fr/paris/lutece/portal/business/user/attribute/IAdminUserFieldDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 46142

fr/paris/lutece/portal/business/user/attribute/IAttribute.java

Rule Violation Line
LinguisticNaming Linguistics Antipattern - The setter 'setAttributeData' should not return any type except void linguistically 304

fr/paris/lutece/portal/business/user/attribute/SimpleAdminUserFieldListener.java

Rule Violation Line
MissingOverride The method 'doRemoveUserFields(AdminUser, HttpServletRequest, Locale)' is missing an @Override annotation. 166169

fr/paris/lutece/portal/business/user/authentication/LuteceDefaultAdminAuthentication.java

Rule Violation Line
CyclomaticComplexity The method 'login(String, String, HttpServletRequest)' has a cyclomatic complexity of 10. 97143

fr/paris/lutece/portal/business/user/authentication/LuteceDefaultAdminUser.java

Rule Violation Line
DataClass The class 'LuteceDefaultAdminUser' is suspected to be a Data Class (WOC=25.000%, NOPA=0, NOAM=4, WMC=8) 44135

fr/paris/lutece/portal/business/user/authentication/LuteceDefaultAdminUserDAO.java

Rule Violation Line
MissingOverride The method 'load(String, AdminAuthentication)' is missing an @Override annotation. 71102
MissingOverride The method 'updateResetPassword(LuteceDefaultAdminUser, boolean)' is missing an @Override annotation. 112120

fr/paris/lutece/portal/business/user/authentication/PasswordFactory.java

Rule Violation Line
CyclomaticComplexity The constructor 'PBKDF2Password(String, PASSWORD_REPRESENTATION)' has a cyclomatic complexity of 11. 172213
UseUnderscoresInNumericLiterals Number 40000 should separate every third digit with an underscore 177
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 207
ShortVariable Avoid variables with short names like sb 248
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 249
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 250
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the DummyPassword constructor if you want a default access modifier 362366
CallSuperInConstructor It is a good practice to call super() in a constructor 429432
CallSuperInConstructor It is a good practice to call super() in a constructor 460473

fr/paris/lutece/portal/business/user/log/UserLogDAO.java

Rule Violation Line
MissingOverride The method 'selectLoginErrors(UserLog, int)' is missing an @Override annotation. 5881
MissingOverride The method 'insertLog(UserLog)' is missing an @Override annotation. 89100

fr/paris/lutece/portal/business/user/menu/AccessibilityModeAdminUserMenuItemProvider.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 66

fr/paris/lutece/portal/business/user/menu/LanguageAdminUserMenuItemProvider.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 70

fr/paris/lutece/portal/business/user/parameter/EmailPatternRegularExpressionRemovalListener.java

Rule Violation Line
MissingOverride The method 'canBeRemoved(String)' is missing an @Override annotation. 6081
MissingOverride The method 'getRemovalRefusedMessage(String, Locale)' is missing an @Override annotation. 9296

fr/paris/lutece/portal/business/workgroup/AdminWorkgroup.java

Rule Violation Line
MissingOverride The method 'getWorkgroup()' is missing an @Override annotation. 9396

fr/paris/lutece/portal/business/workgroup/AdminWorkgroupDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 48334
MissingOverride The method 'insert(AdminWorkgroup)' is missing an @Override annotation. 7180
MissingOverride The method 'load(String)' is missing an @Override annotation. 85103
MissingOverride The method 'delete(String)' is missing an @Override annotation. 108116
MissingOverride The method 'store(AdminWorkgroup)' is missing an @Override annotation. 121130
MissingOverride The method 'selectWorkgroupList()' is missing an @Override annotation. 135154
MissingOverride The method 'checkExistWorkgroup(String)' is missing an @Override annotation. 159173
MissingOverride The method 'isUserInWorkgroup(int, String)' is missing an @Override annotation. 178195
MissingOverride The method 'checkUserHasWorkgroup(int)' is missing an @Override annotation. 200214
MissingOverride The method 'getUserWorkgroups(int)' is missing an @Override annotation. 219235
MissingOverride The method 'getUsersListForWorkgroup(String)' is missing an @Override annotation. 240263
MissingOverride The method 'deleteAllUsersForWorkgroup(String)' is missing an @Override annotation. 268275
MissingOverride The method 'insertUserForWorkgroup(AdminUser, String)' is missing an @Override annotation. 280288
MissingOverride The method 'deleteUserFromWorkgroup(int, String)' is missing an @Override annotation. 293301
MissingOverride The method 'selectWorkgroupsByFilter(AdminWorkgroupFilter)' is missing an @Override annotation. 310333

fr/paris/lutece/portal/business/workgroup/AdminWorkgroupFilter.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 6871
LinguisticNaming Linguistics Antipattern - The setter 'setAdminWorkgroupFilter' should not return any type except void linguistically 141158
ConfusingTernary Avoid if (x != y) ..; else ..; 146155

fr/paris/lutece/portal/business/workgroup/AdminWorkgroupHome.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 46231

fr/paris/lutece/portal/business/workgroup/IAdminWorkgroupDAO.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 45170

fr/paris/lutece/portal/business/xsl/XslExportDAO.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 7178
ConfusingTernary Avoid if (x != y) ..; else ..; 154161
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 221

fr/paris/lutece/portal/service/accesscontrol/AccessControlService.java

Rule Violation Line
ImmutableField Private field '_bServiceAvailable' could be made final; it is only initialized in the declaration or constructor. 57
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 95102
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 162165
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 166169

fr/paris/lutece/portal/service/admin/AdminAuthenticationService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8998
CyclomaticComplexity The method 'getRemoteUser(HttpServletRequest)' has a cyclomatic complexity of 10. 131179
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 205

fr/paris/lutece/portal/service/admin/AdminUserService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341529
ExcessiveClassLength Avoid really long classes. 1041529
CyclomaticComplexity The class 'AdminUserService' has a total cyclomatic complexity of 144 (highest 11). 1041529
GodClass Possible God Class (WMC=144, ATFD=173, TCC=6.410%) 1041529
TooManyMethods This class has too many methods, consider refactoring it. 1051529
ConfusingTernary Avoid if (x != y) ..; else ..; 278289
CyclomaticComplexity The method 'getFilteredUsersInterface(Collection, HttpServletRequest, Map, UrlItem)' has a cyclomatic complexity of 10. 307386
ConfusingTernary Avoid if (x != y) ..; else ..; 345354
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 356
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 397
CyclomaticComplexity The method 'checkEmail(String)' has a cyclomatic complexity of 11. 475519
ConfusingTernary Avoid if (x != y) ..; else ..; 603610
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1290
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 1350
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1358

fr/paris/lutece/portal/service/admin/DefaultImportAdminUserService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34473
NcssCount The method 'readLineOfCSVFile(String, int, Locale, String)' has a NCSS line count of 68. 95207
ExcessiveMethodLength Avoid really long methods. 95207
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 171
AvoidReassigningLoopVariables Avoid reassigning the loop control variable 'strValue' 327
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 367
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 427

fr/paris/lutece/portal/service/cache/AbstractCacheableService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 54342
ImmutableField Private field '_logger' could be made final; it is only initialized in the declaration or constructor. 57
ConfusingTernary Avoid if (x != y) ..; else ..; 192
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 262265
CloneThrowsCloneNotSupportedException clone() method should throw CloneNotSupportedException 262265

fr/paris/lutece/portal/service/cache/CacheService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 61479
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 120132
ShortVariable Avoid variables with short names like cs 207
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getInfos method if you want a default access modifier 244258
DefaultPackage Use explicit scoping instead of the default package private level 244258
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 27 characters appended. 246
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 247
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 247
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 247
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 248
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 248
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 248
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 249
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 249
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 249
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 250
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 250
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 250
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 251
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 251
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 251
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 252
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 252
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 252
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 253
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 253
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 253
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 254
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 254
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 254
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 255
UseUnderscoresInNumericLiterals Number 10000 should separate every third digit with an underscore 265
UseUnderscoresInNumericLiterals Number 10000L should separate every third digit with an underscore 267
UseUnderscoresInNumericLiterals Number 10000L should separate every third digit with an underscore 268
UseUnderscoresInNumericLiterals Number 10000 should separate every third digit with an underscore 272
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 305
ShortVariable Avoid variables with short names like cs 317
ShortVariable Avoid variables with short names like cs 330

fr/paris/lutece/portal/service/cache/DefaultCacheKeyService.java

Rule Violation Line
MissingOverride The method 'getKey(Map, int, LuteceUser)' is missing an @Override annotation. 6283
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 73
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 73
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 73
ConfusingTernary Avoid if (x != y) ..; else ..; 77
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 79
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 79
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 79
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 80
MissingOverride The method 'setAllowedParametersList(List)' is missing an @Override annotation. 8891
MissingOverride The method 'setIgnoredParametersList(List)' is missing an @Override annotation. 9699

fr/paris/lutece/portal/service/cache/FullPageCachingService.java

Rule Violation Line
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 56
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 56
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 56
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 56

fr/paris/lutece/portal/service/cache/HeadersPageCachingFilter.java

Rule Violation Line
ImmutableField Private field '_logger' could be made final; it is only initialized in the declaration or constructor. 69
MissingOverride The method 'parseBlockingCacheTimeoutMillis(FilterConfig)' is missing an @Override annotation. 152164
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 180
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 180
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 180
AvoidUncheckedExceptionsInSignatures A method or constructor should not explicitly declare unchecked exceptions in its 'throws' clause 180

fr/paris/lutece/portal/service/cache/PathCacheService.java

Rule Violation Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the PathCacheService constructor if you want a default access modifier 5458
CallSuperInConstructor It is a good practice to call super() in a constructor 5458
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 21 characters appended. 79
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 80
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 80

fr/paris/lutece/portal/service/content/PageData.java

Rule Violation Line
TooManyFields Too many fields 41465

fr/paris/lutece/portal/service/content/XPageAppService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 80
CyclomaticComplexity The method 'getPage(HttpServletRequest, int)' has a cyclomatic complexity of 10. 190265
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 336

fr/paris/lutece/portal/service/csv/CSVMessageDescriptor.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 5052
ShortVariable Avoid variables with short names like o 151
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 162165
ShortVariable Avoid variables with short names like o 190

fr/paris/lutece/portal/service/csv/CSVReaderService.java

Rule Violation Line
GodClass Possible God Class (WMC=67, ATFD=48, TCC=3.297%) 64727
NcssCount The method 'readCSVFile(Reader, CSVReader, int, boolean, boolean, boolean, Locale, String)' has a NCSS line count of 103. 340572
CyclomaticComplexity The method 'readCSVFile(Reader, CSVReader, int, boolean, boolean, boolean, Locale, String)' has a cyclomatic complexity of 31. 340572
NPathComplexity The method 'readCSVFile(Reader, CSVReader, int, boolean, boolean, boolean, Locale, String)' has an NPath complexity of 233024 340572
ExcessiveMethodLength Avoid really long methods. 340572
ConfusingTernary Avoid if (x != y) ..; else ..; 442474
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 450
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 462
ConfusingTernary Avoid if (x != y) ..; else ..; 476549
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 532

fr/paris/lutece/portal/service/daemon/AccountLifeTimeDaemon.java

Rule Violation Line
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 24 characters appended. 136
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 137
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 138
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 142
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 30 characters appended. 181
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 182
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 183
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 187
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 29 characters appended. 230
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 231
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 232
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 54 characters appended. 264
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 265
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 266
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 270
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 285
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 296
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 303

fr/paris/lutece/portal/service/daemon/AppDaemonService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 52385
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 58
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 74120
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 84
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 325328

fr/paris/lutece/portal/service/daemon/Daemon.java

Rule Violation Line
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 39

fr/paris/lutece/portal/service/daemon/DaemonEntry.java

Rule Violation Line
ImmutableField Private field '_formatterDateTime' could be made final; it is only initialized in the declaration or constructor. 47
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 176179
ConfusingTernary Avoid if (x != y) ..; else ..; 285

fr/paris/lutece/portal/service/daemon/DaemonScheduler.java

Rule Violation Line
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 59
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 65
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 86
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 96
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 189
ConfusingTernary Avoid if (x != y) ..; else ..; 221231
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 225
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 290
CommentRequired Public method and constructor comments are required 306309
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 328
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 330
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 339
CallSuperInConstructor It is a good practice to call super() in a constructor 358361
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 366

fr/paris/lutece/portal/service/daemon/DaemonThread.java

Rule Violation Line
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 44
DefaultPackage Use explicit scoping instead of the default package private level 46
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the DEAMON_THREAD_BEAN_NAME field if you want a default access modifier 46
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 85
AvoidCatchingThrowable A catch statement should never catch throwable since it includes errors. 106

fr/paris/lutece/portal/service/daemon/DaemonThreadFactory.java

Rule Violation Line
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 61
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 61
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 63
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 7376

fr/paris/lutece/portal/service/daemon/IndexerDaemon.java

Rule Violation Line
MissingOverride The method 'run()' is missing an @Override annotation. 5054

fr/paris/lutece/portal/service/daemon/RunnableQueueItem.java

Rule Violation Line
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 42
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 44
ImmutableField Private field '_runnable' could be made final; it is only initialized in the declaration or constructor. 44
ImmutableField Private field '_strKey' could be made final; it is only initialized in the declaration or constructor. 45
ImmutableField Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. 46
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 59
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 76
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 87

fr/paris/lutece/portal/service/daemon/ThreadLauncherDaemon.java

Rule Violation Line
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 59
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 61
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 69
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 91
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 92
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 93
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 93
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 93
ImmutableField Private field '_mapThreadByKey' could be made final; it is only initialized in the declaration or constructor. 93
ImmutableField Private field '_listThread' could be made final; it is only initialized in the declaration or constructor. 94
FieldDeclarationsShouldBeAtStartOfClass Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 94
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 94
AssignmentInOperand Avoid assignments in operands 112
ConfusingTernary Avoid if (x != y) ..; else ..; 116150
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 118
ConfusingTernary Avoid if (x != y) ..; else ..; 120142
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 147
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 166
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 168
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 168
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 176
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 189
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 191
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 204
DoNotUseThreads To be compliant to J2EE, a webapp should not use any thread. 221
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 239242
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 249257
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 264267

fr/paris/lutece/portal/service/dashboard/DashboardComponent.java

Rule Violation Line
ShortVariable Avoid variables with short names like o 185
ConfusingTernary Avoid if (x != y) ..; else ..; 252

fr/paris/lutece/portal/service/dashboard/DashboardListenerService.java

Rule Violation Line
ImmutableField Private field '_listRegisteredListeners' could be made final; it is only initialized in the declaration or constructor. 51
LinguisticNaming Linguistics Antipattern - The getter 'getDashboardComponents' should not return void linguistically 7480

fr/paris/lutece/portal/service/dashboard/DashboardService.java

Rule Violation Line
GodClass Possible God Class (WMC=56, ATFD=45, TCC=3.268%) 60530
ShortVariable Avoid variables with short names like dc 136
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 291
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 433
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 495

fr/paris/lutece/portal/service/dashboard/IMyDashboardComponent.java

Rule Violation Line
CommentRequired Header comments are required 4171

fr/paris/lutece/portal/service/dashboard/admin/AdminDashboardService.java

Rule Violation Line
ShortVariable Avoid variables with short names like dc 136
CyclomaticComplexity The method 'updateDashboardComponents(IAdminDashboardComponent, List, int)' has a cyclomatic complexity of 11. 224254
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 286
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 358

fr/paris/lutece/portal/service/database/AppConnectionService.java

Rule Violation Line
ShortVariable Avoid variables with short names like is 82
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 87
LinguisticNaming Linguistics Antipattern - The getter 'getPoolList' should not return void linguistically 148154

fr/paris/lutece/portal/service/database/DAOUtilTransactionManager.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 6972
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 114
MissingOverride The method 'getParentLogger()' is missing an @Override annotation. 226229

fr/paris/lutece/portal/service/database/LuteceTransactionManager.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 107122

fr/paris/lutece/portal/service/datastore/DatastoreCacheService.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 4649

fr/paris/lutece/portal/service/datastore/DatastoreService.java

Rule Violation Line
GodClass Possible God Class (WMC=49, ATFD=9, TCC=18.382%) 52456
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the VALUE_MISSING field if you want a default access modifier 58
DefaultPackage Use explicit scoping instead of the default package private level 58
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 103106
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 108111
ShortVariable Avoid variables with short names like p 155
ConfusingTernary Avoid if (x != y) ..; else ..; 158170
ShortVariable Avoid variables with short names like sb 337
ShortVariable Avoid variables with short names like e 431
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 449

fr/paris/lutece/portal/service/datastore/DatastoreTemplateMethod.java

Rule Violation Line
CommentRequired Header comments are required 4047

fr/paris/lutece/portal/service/editor/EditorBbcodeService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 90102
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 118125
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 144167

fr/paris/lutece/portal/service/editor/ParserBbcodeServlet.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 6467
ConfusingTernary Avoid if (x != y) ..; else ..; 82

fr/paris/lutece/portal/service/event/AbstractEventManager.java

Rule Violation Line
CommentRequired Header comments are required 1040
AbstractClassWithoutAbstractMethod This abstract class does not have any abstract methods 1040
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 13
ImmutableField Private field '_listeners' could be made final; it is only initialized in the declaration or constructor. 13

fr/paris/lutece/portal/service/event/LuteceUserEventManager.java

Rule Violation Line
CommentRequired Header comments are required 525
RedundantFieldInitializer Avoid using redundant field initializer for '_instance' 8
NonThreadSafeSingleton Singleton is not thread safe 1619

fr/paris/lutece/portal/service/file/ExpiredLinkException.java

Rule Violation Line
CommentRequired Header comments are required 3651

fr/paris/lutece/portal/service/file/IFileDownloadUrlService.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'static final' on field 'LINK_VALIDITY_TIME': the field is declared in an interface type 50

fr/paris/lutece/portal/service/file/IFileRBACService.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'checkAccessRights': the method is declared in an interface type 60

fr/paris/lutece/portal/service/file/IFileStoreServiceProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getName': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'isDefault': the method is declared in an interface type 65

fr/paris/lutece/portal/service/file/implementation/DefaultFileDownloadService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 80
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 107
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 137
ShortVariable Avoid variables with short names like sb 194
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 195
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 196
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 197

fr/paris/lutece/portal/service/file/implementation/DefaultFileNoRBACService.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'MESSAGE_ACCESS_DENIED_KEY'. 49

fr/paris/lutece/portal/service/file/implementation/LocalDatabaseFileService.java

Rule Violation Line
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 187191
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 222
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 223
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 256
CommentRequired Public method and constructor comments are required 288291
CommentRequired Public method and constructor comments are required 293296

fr/paris/lutece/portal/service/fileimage/FileImagePublicService.java

Rule Violation Line
CommentRequired Header comments are required 48159
CallSuperInConstructor It is a good practice to call super() in a constructor 5760
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6871
ConfusingTernary Avoid if (x != y) ..; else ..; 108123
MissingOverride The method 'addImageResource(FileItem)' is missing an @Override annotation. 135138

fr/paris/lutece/portal/service/fileimage/FileImageService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 7679
MissingOverride The method 'getImageResource(int)' is missing an @Override annotation. 106125
ControlStatementBraces This statement should have braces 109
MissingOverride The method 'getResourceTypeId()' is missing an @Override annotation. 132135
MissingOverride The method 'addImageResource(FileItem)' is missing an @Override annotation. 156159

fr/paris/lutece/portal/service/fileupload/FileUploadService.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 6072
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 71

fr/paris/lutece/portal/service/filter/FilterEntry.java

Rule Violation Line
ImmutableField Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. 48
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 48

fr/paris/lutece/portal/service/filter/FilterService.java

Rule Violation Line
ImmutableField Private field '_listFilters' could be made final; it is only initialized in the declaration or constructor. 54
ShortVariable Avoid variables with short names like f 86
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 139

fr/paris/lutece/portal/service/filter/LuteceFilter.java

Rule Violation Line
ImmutableField Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. 53
ShortVariable Avoid variables with short names like o 224

fr/paris/lutece/portal/service/filter/LuteceFilterChain.java

Rule Violation Line
MissingOverride The method 'doFilter(ServletRequest, ServletResponse)' is missing an @Override annotation. 122129

fr/paris/lutece/portal/service/filter/LuteceFilterConfig.java

Rule Violation Line
ImmutableField Private field '_strName' could be made final; it is only initialized in the declaration or constructor. 48
ImmutableField Private field '_context' could be made final; it is only initialized in the declaration or constructor. 49
ImmutableField Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. 50
MissingOverride The method 'getFilterName()' is missing an @Override annotation. 7275
MissingOverride The method 'getServletContext()' is missing an @Override annotation. 8083
MissingOverride The method 'getInitParameter(String)' is missing an @Override annotation. 8891
MissingOverride The method 'getInitParameterNames()' is missing an @Override annotation. 98101

fr/paris/lutece/portal/service/filter/MainFilter.java

Rule Violation Line
MissingOverride The method 'init(FilterConfig)' is missing an @Override annotation. 5861
MissingOverride The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' is missing an @Override annotation. 66109
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 99
MissingOverride The method 'destroy()' is missing an @Override annotation. 114132
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 127
DefaultPackage Use explicit scoping instead of the default package private level 143146
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the matchMapping method if you want a default access modifier 143146
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the matchFilterUrl method if you want a default access modifier 159202
NPathComplexity The method 'matchFilterUrl(String, String)' has an NPath complexity of 240 159202
DefaultPackage Use explicit scoping instead of the default package private level 159202
CyclomaticComplexity The method 'matchFilterUrl(String, String)' has a cyclomatic complexity of 13. 159202
PositionLiteralsFirstInComparisons Position literals first in String comparisons 171
SimplifyBooleanReturns Avoid unnecessary if..then..else statements when returning booleans 178182

fr/paris/lutece/portal/service/html/HtmlCleanerService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6166
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 7580

fr/paris/lutece/portal/service/html/IHtmlCleaner.java

Rule Violation Line
UncommentedEmptyMethodBody Document empty method body 5860

fr/paris/lutece/portal/service/html/XmlTransformerService.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 164
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 198

fr/paris/lutece/portal/service/i18n/CombinedResourceBundle.java

Rule Violation Line
CommentRequired Header comments are required 4076
CommentRequired Public method and constructor comments are required 4549
CallSuperInConstructor It is a good practice to call super() in a constructor 4549

fr/paris/lutece/portal/service/i18n/I18nService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 80
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 81
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 82
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85
ConfusingTernary Avoid if (x != y) ..; else ..; 117124
ShortVariable Avoid variables with short names like sb 155
PositionLiteralsFirstInComparisons Position literals first in String comparisons 204
ConfusingTernary Avoid if (x != y) ..; else ..; 204234
PositionLiteralsFirstInComparisons Position literals first in String comparisons 206
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 247
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 253

fr/paris/lutece/portal/service/i18n/I18nTemplateMethod.java

Rule Violation Line
CommentRequired Header comments are required 4047

fr/paris/lutece/portal/service/image/ImageResource.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 5155
UncommentedEmptyConstructor Document empty constructor 5760
CommentRequired Public method and constructor comments are required 5760
MethodReturnsInternalArray Returning '_strImage' may expose an internal array. 69
ArrayIsStoredDirectly The user-supplied array 'strImage' is stored directly. 78

fr/paris/lutece/portal/service/image/ImageResourceManager.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 50

fr/paris/lutece/portal/service/image/ImageServlet.java

Rule Violation Line
ShortVariable Avoid variables with short names like sc 107
ShortVariable Avoid variables with short names like in 115
AssignmentInOperand Avoid assignments in operands 120
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 200

fr/paris/lutece/portal/service/includes/PageIncludeService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 51
ConfusingTernary Avoid if (x != y) ..; else ..; 75

fr/paris/lutece/portal/service/init/AppInfo.java

Rule Violation Line
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the LUTECE_BANNER_VERSION field if you want a default access modifier 4345
DefaultPackage Use explicit scoping instead of the default package private level 4345
DefaultPackage Use explicit scoping instead of the default package private level 4750
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the LUTECE_BANNER_SERVER field if you want a default access modifier 4750

fr/paris/lutece/portal/service/init/AppInit.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34358
ExcessiveMethodLength Avoid really long methods. 125243
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 71 characters appended. 225
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 226
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 228
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 311
ShortVariable Avoid variables with short names like p 312
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 318
ShortVariable Avoid variables with short names like fw 339
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 343

fr/paris/lutece/portal/service/init/LuteceInitException.java

Rule Violation Line
ShortVariable Avoid variables with short names like e 56

fr/paris/lutece/portal/service/init/PostStartUpServiceManager.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 69

fr/paris/lutece/portal/service/init/ShutdownServiceManager.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 69

fr/paris/lutece/portal/service/init/StartUpServiceManager.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 69

fr/paris/lutece/portal/service/insert/InsertResourceIdService.java

Rule Violation Line
MissingOverride The method 'register()' is missing an @Override annotation. 5770
ShortVariable Avoid variables with short names like rt 59
ShortVariable Avoid variables with short names like p 64
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 7989
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 100105

fr/paris/lutece/portal/service/insert/InsertService.java

Rule Violation Line
MissingOverride The method 'getResourceTypeCode()' is missing an @Override annotation. 257260
MissingOverride The method 'getResourceId()' is missing an @Override annotation. 267270
AddEmptyString Do not add empty strings 269
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 278281

fr/paris/lutece/portal/service/insert/InsertServiceManager.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 53
ShortVariable Avoid variables with short names like is 71
ShortVariable Avoid variables with short names like is 83

fr/paris/lutece/portal/service/jpa/JPALuteceDAO.java

Rule Violation Line
MissingOverride The method 'getEntityManagerFactory()' is missing an @Override annotation. 6982

fr/paris/lutece/portal/service/jpa/JPAStartupService.java

Rule Violation Line
MissingOverride The method 'process()' is missing an @Override annotation. 79159
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 84
ShortVariable Avoid variables with short names like ds 94
ShortVariable Avoid variables with short names like tm 141
MissingOverride The method 'getName()' is missing an @Override annotation. 166169

fr/paris/lutece/portal/service/mail/DatabaseQueue.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5156
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6476

fr/paris/lutece/portal/service/mail/MailAttachmentCacheKeyService.java

Rule Violation Line
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 60

fr/paris/lutece/portal/service/mail/MailAttachmentCacheService.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 5356
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 7179

fr/paris/lutece/portal/service/mail/MailSenderDaemon.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 79142
ConfusingTernary Avoid if (x != y) ..; else ..; 92141
AvoidDuplicateLiterals The String literal "{} {} " appears 4 times in this file; the first occurrence is on line 122 122
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 124
CyclomaticComplexity The method 'sendMail(MailItem, Transport, Session, StringBuilder)' has a cyclomatic complexity of 12. 219271
ConfusingTernary Avoid if (x != y) ..; else ..; 224
ConfusingTernary Avoid if (x != y) ..; else ..; 226
ConfusingTernary Avoid if (x != y) ..; else ..; 228

fr/paris/lutece/portal/service/mail/MailService.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 52628
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 88
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 111112
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 137138
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 171172
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 200201
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 232234
ExcessiveParameterList Avoid long parameter lists. 232234
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 270271
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 298299
ExcessiveParameterList Avoid long parameter lists. 329330
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 329330
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 362
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 385386
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 411412
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 444445
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 470471
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 499500
ShortVariable Avoid variables with short names like sb 595

fr/paris/lutece/portal/service/mail/MailUtil.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34707
GodClass Possible God Class (WMC=47, ATFD=86, TCC=16.190%) 82707
ConfusingTernary Avoid if (x != y) ..; else ..; 154
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 181188
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 206216
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 234288
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 306340
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 358381
ConfusingTernary Avoid if (x != y) ..; else ..; 397405
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 420429
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 452485
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 465
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 500538
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 530
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 549552
ShortVariable Avoid variables with short names like st 587
AvoidProtectedMethodInFinalClassNotExtending Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 605625
AssignmentInOperand Avoid assignments in operands 617
CyclomaticComplexity The method 'convertUrlAttachmentDataSourceToByteArrayDataSource(UrlAttachment)' has a cyclomatic complexity of 11. 634706
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 637
ShortVariable Avoid variables with short names like bo 645
ShortVariable Avoid variables with short names like o 651

fr/paris/lutece/portal/service/mail/MemoryQueue.java

Rule Violation Line
ImmutableField Private field '_listMails' could be made final; it is only initialized in the declaration or constructor. 46
MissingOverride The method 'send(MailItem)' is missing an @Override annotation. 5460
MissingOverride The method 'consume()' is missing an @Override annotation. 6781
MissingOverride The method 'size()' is missing an @Override annotation. 8891

fr/paris/lutece/portal/service/mailinglist/AdminMailingListService.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 186193

fr/paris/lutece/portal/service/message/AdminMessage.java

Rule Violation Line
ArrayIsStoredDirectly The user-supplied array 'messageArgs' is stored directly. 166
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 166167

fr/paris/lutece/portal/service/message/AdminMessageService.java

Rule Violation Line
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 242243
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 269270
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 333334
ConfusingTernary Avoid if (x != y) ..; else ..; 336
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 480
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 501
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 523

fr/paris/lutece/portal/service/message/CustomSiteMessage.java

Rule Violation Line
CommentRequired Header comments are required 3863
ImmutableField Private field '_strText' could be made final; it is only initialized in the declaration or constructor. 42
ImmutableField Private field '_strTitle' could be made final; it is only initialized in the declaration or constructor. 43
CommentRequired Public method and constructor comments are required 4550

fr/paris/lutece/portal/service/message/SiteMessage.java

Rule Violation Line
ImmutableField Private field '_strTextKey' could be made final; it is only initialized in the declaration or constructor. 62
ImmutableField Private field '_strTitleKey' could be made final; it is only initialized in the declaration or constructor. 63
ImmutableField Private field '_strUrl' could be made final; it is only initialized in the declaration or constructor. 64
ImmutableField Private field '_strTarget' could be made final; it is only initialized in the declaration or constructor. 65
ImmutableField Private field '_nType' could be made final; it is only initialized in the declaration or constructor. 67
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 111
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 122

fr/paris/lutece/portal/service/message/SiteMessageHandler.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 91
ConfusingTernary Avoid if (x != y) ..; else ..; 157
ConfusingTernary Avoid if (x != y) ..; else ..; 164

fr/paris/lutece/portal/service/message/SiteMessageService.java

Rule Violation Line
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 267268
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 295296
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 325326
ConfusingTernary Avoid if (x != y) ..; else ..; 328
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 353
ConfusingTernary Avoid if (x != y) ..; else ..; 356
LinguisticNaming Linguistics Antipattern - The setter 'setSiteMessageUrl' should not return any type except void linguistically 444450
ConfusingTernary Avoid if (x != y) ..; else ..; 516535

fr/paris/lutece/portal/service/page/PageCacheService.java

Rule Violation Line
MissingOverride The method 'getName()' is missing an @Override annotation. 5659
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the getKey method if you want a default access modifier 6878
DefaultPackage Use explicit scoping instead of the default package private level 6878
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 144147
CloneThrowsCloneNotSupportedException clone() method should throw CloneNotSupportedException 144147

fr/paris/lutece/portal/service/page/PageContentService.java

Rule Violation Line
ImmutableField Private field '_pageService' could be made final; it is only initialized in the declaration or constructor. 53
MissingOverride The method 'isInvoked(HttpServletRequest)' is missing an @Override annotation. 6771
MissingOverride The method 'getName()' is missing an @Override annotation. 7679

fr/paris/lutece/portal/service/page/PageEvent.java

Rule Violation Line
ImmutableField Private field '_page' could be made final; it is only initialized in the declaration or constructor. 50
ImmutableField Private field '_nType' could be made final; it is only initialized in the declaration or constructor. 51

fr/paris/lutece/portal/service/page/PageResourceIdService.java

Rule Violation Line
MissingOverride The method 'register()' is missing an @Override annotation. 6078
ShortVariable Avoid variables with short names like rt 62
ShortVariable Avoid variables with short names like p 67
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 8790
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 101106

fr/paris/lutece/portal/service/page/PageService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341145
CyclomaticComplexity The class 'PageService' has a total cyclomatic complexity of 85 (highest 18). 971145
ExcessiveClassLength Avoid really long classes. 971145
GodClass Possible God Class (WMC=85, ATFD=104, TCC=6.907%) 971145
TooManyMethods This class has too many methods, consider refactoring it. 981145
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 256
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 354
CyclomaticComplexity The method 'buildPageContent(String, int, HttpServletRequest)' has a cyclomatic complexity of 11. 394485
CyclomaticComplexity The method 'getPageContent(int, int, HttpServletRequest)' has a cyclomatic complexity of 12. 501566
NPathComplexity The method 'getPageContent(int, int, HttpServletRequest)' has an NPath complexity of 360 501566
ConfusingTernary Avoid if (x != y) ..; else ..; 527
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 548
ShortVariable Avoid variables with short names like t 563
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 581
NPathComplexity The method 'getPortletContent(HttpServletRequest, Portlet, Map, int)' has an NPath complexity of 2304 605699
CyclomaticComplexity The method 'getPortletContent(HttpServletRequest, Portlet, Map, int)' has a cyclomatic complexity of 18. 605699
ConfusingTernary Avoid if (x != y) ..; else ..; 636
ConfusingTernary Avoid if (x != y) ..; else ..; 643653
UselessStringValueOf No need to call String.valueOf to append to a string. 669
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 672
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 690
SimplifiedTernary Ternary operators that can be simplified with || or && 709
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 995
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1020
ConfusingTernary Avoid if (x != y) ..; else ..; 10401054
ConfusingTernary Avoid if (x != y) ..; else ..; 1047

fr/paris/lutece/portal/service/page/PortletCacheService.java

Rule Violation Line
MissingOverride The method 'getName()' is missing an @Override annotation. 5558
MissingOverride The method 'processPortletEvent(PortletEvent)' is missing an @Override annotation. 6374

fr/paris/lutece/portal/service/panel/LutecePanelService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 94108
ShortVariable Avoid variables with short names like p2 153
ShortVariable Avoid variables with short names like p1 153

fr/paris/lutece/portal/service/plugin/Plugin.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341322
ExcessivePublicCount This class has a bunch of public methods and attributes 341322
CyclomaticComplexity The class 'Plugin' has a total cyclomatic complexity of 128 (highest 7). 841322
GodClass Possible God Class (WMC=128, ATFD=75, TCC=4.023%) 841322
TooManyFields Too many fields 841322
ExcessiveClassLength Avoid really long classes. 841322
TooManyMethods This class has too many methods, consider refactoring it. 851322
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 138
DefaultPackage Use explicit scoping instead of the default package private level 155214
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the load method if you want a default access modifier 155214
ConfusingTernary Avoid if (x != y) ..; else ..; 190
ConfusingTernary Avoid if (x != y) ..; else ..; 192
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 210
ShortVariable Avoid variables with short names like cs 436
ShortVariable Avoid variables with short names like o 1107
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 1320

fr/paris/lutece/portal/service/plugin/PluginDefaultImplementation.java

Rule Violation Line
MissingOverride The method 'init()' is missing an @Override annotation. 4548

fr/paris/lutece/portal/service/plugin/PluginEvent.java

Rule Violation Line
ImmutableField Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. 46
ImmutableField Private field '_nType' could be made final; it is only initialized in the declaration or constructor. 47

fr/paris/lutece/portal/service/plugin/PluginFile.java

Rule Violation Line
ExcessivePublicCount This class has a bunch of public methods and attributes 341028
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341028
GodClass Possible God Class (WMC=79, ATFD=8, TCC=1.461%) 741028
TooManyFields Too many fields 741028
TooManyMethods This class has too many methods, consider refactoring it. 751028
ImmutableField Private field '_listCssStyleSheets' could be made final; it is only initialized in the declaration or constructor. 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 92
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 93
ImmutableField Private field '_listJavascriptFiles' could be made final; it is only initialized in the declaration or constructor. 93
ImmutableField Private field '_listAdminCssStyleSheets' could be made final; it is only initialized in the declaration or constructor. 94
ImmutableField Private field '_listAdminJavascriptFiles' could be made final; it is only initialized in the declaration or constructor. 95
ImmutableField Private field '_listFreemarkerMacrosFiles' could be made final; it is only initialized in the declaration or constructor. 96
ImmutableField Private field '_listRights' could be made final; it is only initialized in the declaration or constructor. 97
ImmutableField Private field '_listPortletTypes' could be made final; it is only initialized in the declaration or constructor. 98
ImmutableField Private field '_listDaemons' could be made final; it is only initialized in the declaration or constructor. 99
ImmutableField Private field '_listApplications' could be made final; it is only initialized in the declaration or constructor. 100
ImmutableField Private field '_listFilters' could be made final; it is only initialized in the declaration or constructor. 101
ImmutableField Private field '_listServlets' could be made final; it is only initialized in the declaration or constructor. 102
ImmutableField Private field '_listListeners' could be made final; it is only initialized in the declaration or constructor. 103
ImmutableField Private field '_listContentServices' could be made final; it is only initialized in the declaration or constructor. 104
ImmutableField Private field '_listSearchIndexers' could be made final; it is only initialized in the declaration or constructor. 105
ImmutableField Private field '_listInsertServices' could be made final; it is only initialized in the declaration or constructor. 106
ImmutableField Private field '_listRBACResourceTypes' could be made final; it is only initialized in the declaration or constructor. 107
ImmutableField Private field '_listPageIncludes' could be made final; it is only initialized in the declaration or constructor. 108
ImmutableField Private field '_listDashboardComponents' could be made final; it is only initialized in the declaration or constructor. 109
ImmutableField Private field '_listAdminDashboardComponents' could be made final; it is only initialized in the declaration or constructor. 110
ImmutableField Private field '_mapParams' could be made final; it is only initialized in the declaration or constructor. 111
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 111
ShortVariable Avoid variables with short names like is 753

fr/paris/lutece/portal/service/plugin/PluginService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 72
ConfusingTernary Avoid if (x != y) ..; else ..; 173214
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 206
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 237240
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 308

fr/paris/lutece/portal/service/portal/PortalMenuService.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 7882
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 8997
MissingOverride The method 'getName()' is missing an @Override annotation. 104107
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 185
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 19 characters appended. 297

fr/paris/lutece/portal/service/portal/PortalService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34784
GodClass Possible God Class (WMC=63, ATFD=111, TCC=5.238%) 82784
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 129
ShortVariable Avoid variables with short names like cs 167
NPathComplexity The method 'buildPageContent(int, PageData, int, HttpServletRequest)' has an NPath complexity of 2304 266356
CyclomaticComplexity The method 'buildPageContent(int, PageData, int, HttpServletRequest)' has a cyclomatic complexity of 13. 266356
ConfusingTernary Avoid if (x != y) ..; else ..; 321
ConfusingTernary Avoid if (x != y) ..; else ..; 344
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 408
CyclomaticComplexity The method 'getXPagePathContent(String, int, HttpServletRequest)' has a cyclomatic complexity of 10. 428504
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 493
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 710
ConfusingTernary Avoid if (x != y) ..; else ..; 733741

fr/paris/lutece/portal/service/portal/ThemesService.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 312
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 325

fr/paris/lutece/portal/service/portlet/PortletResourceIdService.java

Rule Violation Line
MissingOverride The method 'register()' is missing an @Override annotation. 6179
ShortVariable Avoid variables with short names like rt 63
ShortVariable Avoid variables with short names like p 68
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 8891
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 102108

fr/paris/lutece/portal/service/portlet/PortletService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6876

fr/paris/lutece/portal/service/prefs/AdminUserPreferencesService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5664

fr/paris/lutece/portal/service/prefs/BaseUserPreferencesServiceImpl.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 5759

fr/paris/lutece/portal/service/prefs/UserPreferencesService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5664

fr/paris/lutece/portal/service/progressmanager/ProgressManagerService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 7179
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 88
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 142148
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 156162
ConfusingTernary Avoid if (x != y) ..; else ..; 290298

fr/paris/lutece/portal/service/rbac/Permission.java

Rule Violation Line
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 5659

fr/paris/lutece/portal/service/rbac/ResourceType.java

Rule Violation Line
ImmutableField Private field '_mapPermissions' could be made final; it is only initialized in the declaration or constructor. 53
MissingOverride The method 'setLocale(Locale)' is missing an @Override annotation. 7275

fr/paris/lutece/portal/service/rbac/ResourceTypeManager.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 51
ShortVariable Avoid variables with short names like rt 69

fr/paris/lutece/portal/service/regularexpression/RegularExpressionService.java

Rule Violation Line
ImmutableField Private field '_bServiceAvailable' could be made final; it is only initialized in the declaration or constructor. 54
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 7885
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the isPatternValide method if you want a default access modifier 103106
DefaultPackage Use explicit scoping instead of the default package private level 103106
DefaultPackage Use explicit scoping instead of the default package private level 115118
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the isPatternValide method if you want a default access modifier 115118

fr/paris/lutece/portal/service/resource/ExtendableResourceActionHit.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 122

fr/paris/lutece/portal/service/resource/ExtendableResourceRemovalListenerService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5760

fr/paris/lutece/portal/service/resource/ResourceService.java

Rule Violation Line
ImmutableField Private field '_listLoaders' could be made final; it is only initialized in the declaration or constructor. 59
CallSuperInConstructor It is a good practice to call super() in a constructor 6476
ConfusingTernary Avoid if (x != y) ..; else ..; 6875
ShortVariable Avoid variables with short names like st 95
MissingOverride The method 'getName()' is missing an @Override annotation. 120123
PositionLiteralsFirstInComparisons Position literals first in String comparisons 146
ShortVariable Avoid variables with short names like i 214
ShortVariable Avoid variables with short names like i 233
ShortVariable Avoid variables with short names like j 239

fr/paris/lutece/portal/service/scheduler/JobSchedulerService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6775

fr/paris/lutece/portal/service/search/IndexationService.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34668
GodClass Possible God Class (WMC=59, ATFD=82, TCC=18.182%) 74668
TooManyMethods This class has too many methods, consider refactoring it. 75668
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 88
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 133
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 182261
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 186
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 229
AvoidDuplicateLiterals The String literal "</strong>\r\n" appears 4 times in this file; the first occurrence is on line 281 281
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 287
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 322
ConfusingTernary Avoid if (x != y) ..; else ..; 373383
ConfusingTernary Avoid if (x != y) ..; else ..; 410418
ShortVariable Avoid variables with short names like e 469
ShortVariable Avoid variables with short names like e 485
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 488
ShortVariable Avoid variables with short names like e 502
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 504
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 507
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 514
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 522
ConsecutiveLiteralAppends StringBuffer (or StringBuilder).append is called 2 consecutive times with literals. Use a single append with a single combined String. 528

fr/paris/lutece/portal/service/search/LuceneSearchEngine.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34327
UseUnderscoresInNumericLiterals Number 1000000 should separate every third digit with an underscore 78
MissingOverride The method 'getSearchResults(String, HttpServletRequest)' is missing an @Override annotation. 95148
ConfusingTernary Avoid if (x != y) ..; else ..; 106128
ConfusingTernary Avoid if (x != y) ..; else ..; 110123
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 182186
CyclomaticComplexity The method 'search(String, String, Query, HttpServletRequest, boolean)' has a cyclomatic complexity of 11. 221291
ShortVariable Avoid variables with short names like ir 224
ConfusingTernary Avoid if (x != y) ..; else ..; 234
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 273284
ShortVariable Avoid variables with short names like si 277
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 286

fr/paris/lutece/portal/service/search/PageIndexer.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 105
ShortVariable Avoid variables with short names like ft 197
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 233
ShortVariable Avoid variables with short names like sb 238
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 244
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 249
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 257
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 267

fr/paris/lutece/portal/service/search/QueryListenersService.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 92

fr/paris/lutece/portal/service/search/SearchItem.java

Rule Violation Line
ImmutableField Private field '_strMetadata' could be made final; it is only initialized in the declaration or constructor. 59
ConfusingTernary Avoid if (x != y) ..; else ..; 156
ConfusingTernary Avoid if (x != y) ..; else ..; 177
ConfusingTernary Avoid if (x != y) ..; else ..; 219

fr/paris/lutece/portal/service/search/SearchResourceIdService.java

Rule Violation Line
ShortVariable Avoid variables with short names like rt 59
ShortVariable Avoid variables with short names like p 64

fr/paris/lutece/portal/service/search/SearchService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 77
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 93

fr/paris/lutece/portal/service/security/IAccessLogger.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'info': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'info': the method is declared in an interface type 7275
UnnecessaryModifier Unnecessary modifier 'public' on method 'debug': the method is declared in an interface type 91
UnnecessaryModifier Unnecessary modifier 'public' on method 'debug': the method is declared in an interface type 105108
UnnecessaryModifier Unnecessary modifier 'public' on method 'trace': the method is declared in an interface type 124
UnnecessaryModifier Unnecessary modifier 'public' on method 'trace': the method is declared in an interface type 138141
UnnecessaryModifier Unnecessary modifier 'public' on method 'warn': the method is declared in an interface type 157
UnnecessaryModifier Unnecessary modifier 'public' on method 'warn': the method is declared in an interface type 171174

fr/paris/lutece/portal/service/security/LuteceUser.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 141
ImmutableField Private field '_mapUserInfo' could be made final; it is only initialized in the declaration or constructor. 141
UseDiamondOperator Explicit type arguments can be replaced by Diamond Operator 161
ImmutableField Private field '_workgroups' could be made final; it is only initialized in the declaration or constructor. 161
MethodReturnsInternalArray Returning '_roles' may expose an internal array. 286
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 295
MethodReturnsInternalArray Returning '_groups' may expose an internal array. 332
ShortVariable Avoid variables with short names like j 370
ShortVariable Avoid variables with short names like j 401
CloneMethodReturnTypeMustMatchClassName The return type of the clone() method must be the class name when implements Cloneable 481484

fr/paris/lutece/portal/service/security/LuteceUserCacheService.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 4952
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 5966

fr/paris/lutece/portal/service/security/RsaService.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'encryptRsa': the method is already in a final class 6467
UnnecessaryModifier Unnecessary modifier 'final' on method 'encryptRsa': the method is already in a final class 7681
UnnecessaryModifier Unnecessary modifier 'final' on method 'decryptRsa': the method is already in a final class 9194
UnnecessaryModifier Unnecessary modifier 'final' on method 'decryptRsa': the method is already in a final class 103109

fr/paris/lutece/portal/service/security/SecurityService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 94114
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 100
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 112
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 198
ConfusingTernary Avoid if (x != y) ..; else ..; 387
PositionLiteralsFirstInComparisons Position literals first in String comparisons 499
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the isUsersListAvailable method if you want a default access modifier 566569
DefaultPackage Use explicit scoping instead of the default package private level 566569

fr/paris/lutece/portal/service/security/SecurityTokenService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 7280

fr/paris/lutece/portal/service/security/impl/DefaultAccessLogger.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 97
AvoidDuplicateLiterals The String literal "null" appears 4 times in this file; the first occurrence is on line 97 97
ConfusingTernary Avoid if (x != y) ..; else ..; 115
ConfusingTernary Avoid if (x != y) ..; else ..; 133
ConfusingTernary Avoid if (x != y) ..; else ..; 151
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 167
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 198199
ShortVariable Avoid variables with short names like md 228
ShortVariable Avoid variables with short names like sb 232

fr/paris/lutece/portal/service/servlet/LuteceServlet.java

Rule Violation Line
ImmutableField Private field '_strName' could be made final; it is only initialized in the declaration or constructor. 47
ImmutableField Private field '_servlet' could be made final; it is only initialized in the declaration or constructor. 48
ImmutableField Private field '_strMapping' could be made final; it is only initialized in the declaration or constructor. 49
ImmutableField Private field '_plugin' could be made final; it is only initialized in the declaration or constructor. 50
ImmutableField Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. 51

fr/paris/lutece/portal/service/servlet/LuteceServletConfig.java

Rule Violation Line
ImmutableField Private field '_strName' could be made final; it is only initialized in the declaration or constructor. 48
ImmutableField Private field '_context' could be made final; it is only initialized in the declaration or constructor. 49
ImmutableField Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. 50
MissingOverride The method 'getServletName()' is missing an @Override annotation. 7275
MissingOverride The method 'getServletContext()' is missing an @Override annotation. 8083
MissingOverride The method 'getInitParameter(String)' is missing an @Override annotation. 8891
MissingOverride The method 'getInitParameterNames()' is missing an @Override annotation. 98101

fr/paris/lutece/portal/service/servlet/MainServlet.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 87
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 111

fr/paris/lutece/portal/service/servlet/ServletEntry.java

Rule Violation Line
ImmutableField Private field '_mapInitParameters' could be made final; it is only initialized in the declaration or constructor. 49
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 49

fr/paris/lutece/portal/service/servlet/ServletService.java

Rule Violation Line
ImmutableField Private field '_listServlets' could be made final; it is only initialized in the declaration or constructor. 53
ShortVariable Avoid variables with short names like s 85
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 137

fr/paris/lutece/portal/service/sessionlistener/MainHttpSessionListener.java

Rule Violation Line
MissingOverride The method 'sessionCreated(HttpSessionEvent)' is missing an @Override annotation. 4955
ShortVariable Avoid variables with short names like se 49
ShortVariable Avoid variables with short names like se 60
MissingOverride The method 'sessionDestroyed(HttpSessionEvent)' is missing an @Override annotation. 6066

fr/paris/lutece/portal/service/spring/SpringContextService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 75
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 208
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 270
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the ContextFileFilter nested class if you want a default access modifier 392408

fr/paris/lutece/portal/service/template/AbstractMessageFormatTemplateMethod.java

Rule Violation Line
CommentRequired Header comments are required 50101
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 57
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 65
CommentRequired Protected method constructor comments are required 100

fr/paris/lutece/portal/service/template/AppTemplateService.java

Rule Violation Line
NonThreadSafeSingleton Singleton is not thread safe 304308

fr/paris/lutece/portal/service/template/CommonsService.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 73
ConfusingTernary Avoid if (x != y) ..; else ..; 134141
UseCollectionIsEmpty Substitute calls to size() == 0 (or size() != 0, size() > 0, size() < 1) with calls to isEmpty() 180
ShortVariable Avoid variables with short names like ci 199
ShortVariable Avoid variables with short names like ci 206
ConfusingTernary Avoid if (x != y) ..; else ..; 207215

fr/paris/lutece/portal/service/template/FreeMarkerTemplateService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6171

fr/paris/lutece/portal/service/user/AdminUserResourceIdService.java

Rule Violation Line
MissingOverride The method 'register()' is missing an @Override annotation. 5977
ShortVariable Avoid variables with short names like rt 61
ShortVariable Avoid variables with short names like p 66
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 8689
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 100103

fr/paris/lutece/portal/service/user/attribute/AdminUserFieldListenerService.java

Rule Violation Line
ImmutableField Private field '_listRegisteredListeners' could be made final; it is only initialized in the declaration or constructor. 54

fr/paris/lutece/portal/service/user/attribute/AdminUserFieldService.java

Rule Violation Line
CyclomaticComplexity The method 'checkUserFields(HttpServletRequest, Locale)' has a cyclomatic complexity of 10. 91121
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 174
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 282

fr/paris/lutece/portal/service/user/attribute/AttributeFieldService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6068

fr/paris/lutece/portal/service/user/attribute/AttributeService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 6573

fr/paris/lutece/portal/service/user/attribute/AttributeTypeService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 7893

fr/paris/lutece/portal/service/user/menu/AdminUserMenuService.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 7395
ConfusingTernary Avoid if (x != y) ..; else ..; 7895

fr/paris/lutece/portal/service/util/AppException.java

Rule Violation Line
ShortVariable Avoid variables with short names like t 69
ShortVariable Avoid variables with short names like e 83
CallSuperInConstructor It is a good practice to call super() in a constructor 9194
ShortVariable Avoid variables with short names like t 108
ShortVariable Avoid variables with short names like sb 123

fr/paris/lutece/portal/service/util/AppLogService.java

Rule Violation Line
ShortVariable Avoid variables with short names like t 147

fr/paris/lutece/portal/service/util/AppPathService.java

Rule Violation Line
GodClass Possible God Class (WMC=68, ATFD=40, TCC=5.846%) 62640
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 194
CyclomaticComplexity The method 'getBaseUrl(HttpServletRequest)' has a cyclomatic complexity of 12. 218273
NPathComplexity The method 'getBaseUrl(HttpServletRequest)' has an NPath complexity of 240 218273
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 239242
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 261
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 264
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 269
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 303
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 328
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 352

fr/paris/lutece/portal/service/util/AppPropertiesService.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 199

fr/paris/lutece/portal/service/util/CryptoService.java

Rule Violation Line
DefaultPackage Use explicit scoping instead of the default package private level 59
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the PROPERTY_CRYPTO_KEY field if you want a default access modifier 59
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the DSKEY_CRYPTO_KEY field if you want a default access modifier 60
DefaultPackage Use explicit scoping instead of the default package private level 60
ShortVariable Avoid variables with short names like md 81
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 224234
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 226
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 229

fr/paris/lutece/portal/service/util/NoDatabaseException.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 4153

fr/paris/lutece/portal/service/util/RemovalListener.java

Rule Violation Line
ShortVariable Avoid variables with short names like id 50
ShortVariable Avoid variables with short names like id 61

fr/paris/lutece/portal/service/util/RemovalListenerService.java

Rule Violation Line
ImmutableField Private field '_listRegisteredListeners' could be made final; it is only initialized in the declaration or constructor. 45

fr/paris/lutece/portal/service/workflow/WorkflowService.java

Rule Violation Line
GodClass Possible God Class (WMC=66, ATFD=36, TCC=24.231%) 671047
TooManyMethods This class has too many methods, consider refactoring it. 681047
ImmutableField Private field '_bServiceAvailable' could be made final; it is only initialized in the declaration or constructor. 72
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 98105
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 294
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 513
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 542
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 814
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 872
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1025

fr/paris/lutece/portal/service/xsl/XslExportResourceIdService.java

Rule Violation Line
MissingOverride The method 'register()' is missing an @Override annotation. 6285
ShortVariable Avoid variables with short names like rt 64
ShortVariable Avoid variables with short names like p 69
MissingOverride The method 'getResourceIdList(Locale)' is missing an @Override annotation. 9497
MissingOverride The method 'getTitle(String, Locale)' is missing an @Override annotation. 108124
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 116
ConfusingTernary Avoid if (x != y) ..; else ..; 123

fr/paris/lutece/portal/util/mvc/admin/MVCAdminJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34583
TooManyMethods This class has too many methods, consider refactoring it. 76583
UnusedPrivateField Avoid unused private fields such as 'PROPERTY_SITE_CODE'. 85
ImmutableField Private field '_listErrors' could be made final; it is only initialized in the declaration or constructor. 89
ImmutableField Private field '_listInfos' could be made final; it is only initialized in the declaration or constructor. 90
ImmutableField Private field '_listWarnings' could be made final; it is only initialized in the declaration or constructor. 91
ImmutableField Private field '_controller' could be made final; it is only initialized in the declaration or constructor. 92
ShortVariable Avoid variables with short names like m 116
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 260
ShortVariable Avoid variables with short names like os 569

fr/paris/lutece/portal/util/mvc/utils/MVCMessage.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 5254

fr/paris/lutece/portal/util/mvc/utils/MVCMessageBox.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 274
ConfusingTernary Avoid if (x != y) ..; else ..; 275
ConfusingTernary Avoid if (x != y) ..; else ..; 276
ConfusingTernary Avoid if (x != y) ..; else ..; 277

fr/paris/lutece/portal/util/mvc/xpage/MVCApplication.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34911
GodClass Possible God Class (WMC=69, ATFD=71, TCC=3.104%) 85911
TooManyMethods This class has too many methods, consider refactoring it. 86911
ImmutableField Private field '_listErrors' could be made final; it is only initialized in the declaration or constructor. 104
ImmutableField Private field '_listInfos' could be made final; it is only initialized in the declaration or constructor. 105
ImmutableField Private field '_listWarnings' could be made final; it is only initialized in the declaration or constructor. 106
ImmutableField Private field '_controller' could be made final; it is only initialized in the declaration or constructor. 108
CyclomaticComplexity The method 'processController(HttpServletRequest)' has a cyclomatic complexity of 14. 145208
ShortVariable Avoid variables with short names like m 159
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 199
ConfusingTernary Avoid if (x != y) ..; else ..; 229237
ConfusingTernary Avoid if (x != y) ..; else ..; 251259
ShortVariable Avoid variables with short names like t 293
ShortVariable Avoid variables with short names like t 329
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 344
ShortVariable Avoid variables with short names like os 758

fr/paris/lutece/portal/web/PortalJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34612
GodClass Possible God Class (WMC=47, ATFD=95, TCC=3.922%) 86612
CyclomaticComplexity The method 'getContent(HttpServletRequest, int)' has a cyclomatic complexity of 10. 162213
EmptyCatchBlock Avoid empty catch blocks 195199
ShortVariable Avoid variables with short names like cs 203
ConfusingTernary Avoid if (x != y) ..; else ..; 205
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 240
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 367
LooseCoupling Avoid using implementation types like 'HashMap'; use the interface instead 403
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 528
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 550
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 557
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 588589

fr/paris/lutece/portal/web/SiteDashboardComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85
ShortVariable Avoid variables with short names like t 100

fr/paris/lutece/portal/web/StandaloneAppJspBean.java

Rule Violation Line
ShortVariable Avoid variables with short names like p1 141
ShortVariable Avoid variables with short names like p2 142

fr/paris/lutece/portal/web/admin/AdminFeaturesPageJspBean.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 159
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 235
ConfusingTernary Avoid if (x != y) ..; else ..; 240

fr/paris/lutece/portal/web/admin/AdminMapJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 110
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 115
ConfusingTernary Avoid if (x != y) ..; else ..; 120
ShortVariable Avoid variables with short names like t 126
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 204

fr/paris/lutece/portal/web/admin/AdminMenuJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34626
GodClass Possible God Class (WMC=56, ATFD=115, TCC=7.500%) 87626
ImmutableField Private field '_bAdminAvatar' could be made final; it is only initialized in the declaration or constructor. 142
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 154
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 191
ConfusingTernary Avoid if (x != y) ..; else ..; 195
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 218
ConfusingTernary Avoid if (x != y) ..; else ..; 395408
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 424
CyclomaticComplexity The method 'doModifyDefaultAdminUserPassword(HttpServletRequest)' has a cyclomatic complexity of 10. 441498
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 451
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 546560
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 554
CommentRequired Public method and constructor comments are required 562565
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 573600
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 588
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 614
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 620

fr/paris/lutece/portal/web/admin/AdminMessageJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 77

fr/paris/lutece/portal/web/admin/AdminPageJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34900
GodClass Possible God Class (WMC=78, ATFD=181, TCC=9.357%) 90900
ShortVariable Avoid variables with short names like cs 194
ConfusingTernary Avoid if (x != y) ..; else ..; 199206
PositionLiteralsFirstInComparisons Position literals first in String comparisons 287
ConfusingTernary Avoid if (x != y) ..; else ..; 308316
LinguisticNaming Linguistics Antipattern - The setter 'setParentPageId' should not return any type except void linguistically 332346
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 368
ConfusingTernary Avoid if (x != y) ..; else ..; 455463
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 514
ConfusingTernary Avoid if (x != y) ..; else ..; 525
ExcessiveMethodLength Avoid really long methods. 662762
CyclomaticComplexity The method 'getPageData(HttpServletRequest, Page)' has a cyclomatic complexity of 11. 662762
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 664
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 667
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 668
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 669
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 671
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 672
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 673
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 674
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 675
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 676
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 680
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 704
ConfusingTernary Avoid if (x != y) ..; else ..; 748
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 809
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 850
ConfusingTernary Avoid if (x != y) ..; else ..; 872881
ConfusingTernary Avoid if (x != y) ..; else ..; 884892

fr/paris/lutece/portal/web/admin/AdminPagePortletJspBean.java

Rule Violation Line
GodClass Possible God Class (WMC=48, ATFD=106, TCC=28.571%) 66372
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 159
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 159
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 176
CyclomaticComplexity The method 'doRemovePortlet(HttpServletRequest)' has a cyclomatic complexity of 10. 214255
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 227
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 227
CyclomaticComplexity The method 'getModifyPortletStatus(HttpServletRequest)' has a cyclomatic complexity of 10. 266311
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 280
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 280
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 305
CyclomaticComplexity The method 'doModifyPortletStatus(HttpServletRequest)' has a cyclomatic complexity of 12. 322366
NPathComplexity The method 'doModifyPortletStatus(HttpServletRequest)' has an NPath complexity of 216 322366
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 340
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 340

fr/paris/lutece/portal/web/dashboard/AdminDashboardJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 111
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 137
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 287

fr/paris/lutece/portal/web/dashboard/AdminHomePageManagementComponent.java

Rule Violation Line
ImmutableField Private field '_service' could be made final; it is only initialized in the declaration or constructor. 67
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 75

fr/paris/lutece/portal/web/dashboard/DashboardJspBean.java

Rule Violation Line
MissingSerialVersionUID Classes implementing Serializable should set a serialVersionUID 57190

fr/paris/lutece/portal/web/documentation/AdminDocumentationJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 156
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 167
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 201
CyclomaticComplexity The method 'getFeatureGroupsList(AdminUser)' has a cyclomatic complexity of 16. 218307
ConfusingTernary Avoid if (x != y) ..; else ..; 261304

fr/paris/lutece/portal/web/download/AbstractDownloadServlet.java

Rule Violation Line
CommentRequired Header comments are required 55122
CommentRequired Protected method constructor comments are required 121

fr/paris/lutece/portal/web/download/DownloadServletBo.java

Rule Violation Line
CommentRequired Header comments are required 3647

fr/paris/lutece/portal/web/download/DownloadServletFo.java

Rule Violation Line
CommentRequired Header comments are required 3647

fr/paris/lutece/portal/web/editor/EditorAdminDashboardComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 64

fr/paris/lutece/portal/web/encoding/EncodingFilter.java

Rule Violation Line
MissingOverride The method 'init(FilterConfig)' is missing an @Override annotation. 6065
MissingOverride The method 'doFilter(ServletRequest, ServletResponse, FilterChain)' is missing an @Override annotation. 8194
MissingOverride The method 'destroy()' is missing an @Override annotation. 99102

fr/paris/lutece/portal/web/encoding/EncodingServletResponse.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 7894

fr/paris/lutece/portal/web/features/ExternalFeaturesJspBean.java

Rule Violation Line
CommentRequired Public method and constructor comments are required 97124
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 101
CommentRequired Public method and constructor comments are required 126140
CommentRequired Public method and constructor comments are required 142160
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 154
CommentRequired Public method and constructor comments are required 162171
CommentRequired Public method and constructor comments are required 173204
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 177
CommentRequired Public method and constructor comments are required 206234

fr/paris/lutece/portal/web/features/FeaturesAdminDashboardComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 82
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 130

fr/paris/lutece/portal/web/features/FeaturesGroupJspBean.java

Rule Violation Line
PositionLiteralsFirstInComparisons Position literals first in String comparisons 110
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 110
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 192
ShortVariable Avoid variables with short names like t 197
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 220
ShortVariable Avoid variables with short names like t 225
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 244
PositionLiteralsFirstInComparisons Position literals first in String comparisons 247
PositionLiteralsFirstInComparisons Position literals first in String comparisons 247
PositionLiteralsFirstInComparisons Position literals first in String comparisons 247
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 282
PositionLiteralsFirstInComparisons Position literals first in String comparisons 285
PositionLiteralsFirstInComparisons Position literals first in String comparisons 285
PositionLiteralsFirstInComparisons Position literals first in String comparisons 285
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 334

fr/paris/lutece/portal/web/features/LevelsJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 88
PositionLiteralsFirstInComparisons Position literals first in String comparisons 109
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 165
PositionLiteralsFirstInComparisons Position literals first in String comparisons 169

fr/paris/lutece/portal/web/features/RightJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34357
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 129
ExcessiveMethodLength Avoid really long methods. 144244
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 146
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 146
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 150
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 355

fr/paris/lutece/portal/web/includes/LinksInclude.java

Rule Violation Line
MissingOverride The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. 101139
ConfusingTernary Avoid if (x != y) ..; else ..; 108
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 207
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 235
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 286289

fr/paris/lutece/portal/web/includes/LinksIncludeCacheService.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 5054
CommentRequired Public method and constructor comments are required 5054

fr/paris/lutece/portal/web/includes/MainMenuInclude.java

Rule Violation Line
MissingOverride The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. 6483

fr/paris/lutece/portal/web/includes/MetasInclude.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 75
ConfusingTernary Avoid if (x != y) ..; else ..; 7677

fr/paris/lutece/portal/web/includes/StatisticsInclude.java

Rule Violation Line
MissingOverride The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. 74116
ConfusingTernary Avoid if (x != y) ..; else ..; 79112
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 89
ShortVariable Avoid variables with short names like t 97

fr/paris/lutece/portal/web/includes/ThemesInclude.java

Rule Violation Line
MissingOverride The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. 6471

fr/paris/lutece/portal/web/includes/TreeMenuInclude.java

Rule Violation Line
MissingOverride The method 'fillTemplate(Map, PageData, int, HttpServletRequest)' is missing an @Override annotation. 84104
CyclomaticComplexity The method 'buildTreeMenuContent(int, int, HttpServletRequest)' has a cyclomatic complexity of 10. 117208
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 127
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 202

fr/paris/lutece/portal/web/insert/InsertServiceJspBean.java

Rule Violation Line
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 131

fr/paris/lutece/portal/web/insert/InsertServiceSelectorJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 104
ShortVariable Avoid variables with short names like t 109
ConfusingTernary Avoid if (x != y) ..; else ..; 125134
ShortVariable Avoid variables with short names like is 127
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 157

fr/paris/lutece/portal/web/l10n/LocaleService.java

Rule Violation Line
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 110140
ConfusingTernary Avoid if (x != y) ..; else ..; 112139
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 161164
CollapsibleIfStatements These nested if statements could be combined 161164
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 210223

fr/paris/lutece/portal/web/mailinglist/MailingListJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34541
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 138
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 260
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 281
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 344
ConfusingTernary Avoid if (x != y) ..; else ..; 389399
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 432
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 525
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 528

fr/paris/lutece/portal/web/portlet/AliasPortletJspBean.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 82
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 141
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 146
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 148
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 186
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 208

fr/paris/lutece/portal/web/portlet/PortletJspBean.java

Rule Violation Line
LinguisticNaming Linguistics Antipattern - The setter 'setPortletCommonData' should not return any type except void linguistically 190283
NPathComplexity The method 'setPortletCommonData(HttpServletRequest, Portlet)' has an NPath complexity of 768 190283
CyclomaticComplexity The method 'setPortletCommonData(HttpServletRequest, Portlet)' has a cyclomatic complexity of 12. 190283
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 192
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 196
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 201
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 202
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 203
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 204
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 205
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 206

fr/paris/lutece/portal/web/progressmanager/ProgressManagerServlet.java

Rule Violation Line
UselessOverridingMethod Overriding method merely calls super 8184
MissingOverride The method 'init(ServletConfig)' is missing an @Override annotation. 8184
ConfusingTernary Avoid if (x != y) ..; else ..; 125157
ConfusingTernary Avoid if (x != y) ..; else ..; 133157
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 145

fr/paris/lutece/portal/web/rbac/RoleManagementJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 341096
CyclomaticComplexity The class 'RoleManagementJspBean' has a total cyclomatic complexity of 98 (highest 16). 891096
ExcessiveClassLength Avoid really long classes. 891096
TooManyMethods This class has too many methods, consider refactoring it. 901096
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 239
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 260
CyclomaticComplexity The method 'doCreateRole(HttpServletRequest)' has a cyclomatic complexity of 11. 278318
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 282
CyclomaticComplexity The method 'doModifyRole(HttpServletRequest)' has a cyclomatic complexity of 16. 330400
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 332
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 335
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 414
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 432
ConfusingTernary Avoid if (x != y) ..; else ..; 439461
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 490
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 515
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 562
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 644
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 698
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 698
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 699
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 700
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 700
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 701
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 702
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 702
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 703
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 704
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 704
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 705
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 706
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 706
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 707
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 708
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 708
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 711717
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 713
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 715
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 726
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 726
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 727
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 728
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 728
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 729
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 730
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 730
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 731
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 732
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 732
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 733
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 734
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 734
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 735
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 736
AppendCharacterWithChar Avoid appending characters as strings in StringBuffer.append. 736
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 772
CyclomaticComplexity The method 'doSelectPermissions(HttpServletRequest)' has a cyclomatic complexity of 12. 812880
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 814
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 815
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 866877
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 868876
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 891
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 10061015
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 1094

fr/paris/lutece/portal/web/resource/ExtendableResourcePluginActionManager.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 87

fr/paris/lutece/portal/web/role/RoleJspBean.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 117120
CallSuperInConstructor It is a good practice to call super() in a constructor 117120
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 133
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 157
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 225
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 225
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 256
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 304

fr/paris/lutece/portal/web/search/SearchApp.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34287
CyclomaticComplexity The method 'getPage(HttpServletRequest, int, Plugin)' has a cyclomatic complexity of 13. 131242
ExcessiveMethodLength Avoid really long methods. 131242
NPathComplexity The method 'getPage(HttpServletRequest, int, Plugin)' has an NPath complexity of 672 131242
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 210
ConfusingTernary Avoid if (x != y) ..; else ..; 257

fr/paris/lutece/portal/web/search/SearchIndexationJspBean.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 104111

fr/paris/lutece/portal/web/search/SearchJspBean.java

Rule Violation Line
CyclomaticComplexity The method 'doModifyAdvancedParameters(HttpServletRequest)' has a cyclomatic complexity of 11. 91146
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 108

fr/paris/lutece/portal/web/style/PageTemplatesJspBean.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 167
CyclomaticComplexity The method 'doModifyPageTemplate(HttpServletRequest)' has a cyclomatic complexity of 14. 250332
NPathComplexity The method 'doModifyPageTemplate(HttpServletRequest)' has an NPath complexity of 480 250332
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 255
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 256
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 259
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 262
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 266
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 360

fr/paris/lutece/portal/web/style/StylesJspBean.java

Rule Violation Line
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 150
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 155
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 161
AddEmptyString Do not add empty strings 162
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 180
CyclomaticComplexity The method 'doCreateStyle(HttpServletRequest)' has a cyclomatic complexity of 10. 199251
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 201
ConfusingTernary Avoid if (x != y) ..; else ..; 246
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 265
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 287
ConfusingTernary Avoid if (x != y) ..; else ..; 291
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 293
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 334
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 349
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 358

fr/paris/lutece/portal/web/stylesheet/StyleSheetFileServlet.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 86

fr/paris/lutece/portal/web/stylesheet/StyleSheetJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34525
ConfusingTernary Avoid if (x != y) ..; else ..; 143
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 173
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 178
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 184
AddEmptyString Do not add empty strings 186
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 207
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 263
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 265
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 266
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 269
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 320
ConfusingTernary Avoid if (x != y) ..; else ..; 349
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 413
LinguisticNaming Linguistics Antipattern - The method 'isValid' indicates linguistically it returns a boolean, but it returns 'String' 462479
ShortVariable Avoid variables with short names like is 470
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 473

fr/paris/lutece/portal/web/system/CacheJspBean.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 117128
ShortVariable Avoid variables with short names like cs 120
ConfusingTernary Avoid if (x != y) ..; else ..; 164174
ShortVariable Avoid variables with short names like cs 167
ShortVariable Avoid variables with short names like cs 197
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 204
ShortVariable Avoid variables with short names like cs 234

fr/paris/lutece/portal/web/system/PluginJspBean.java

Rule Violation Line
GodClass Possible God Class (WMC=51, ATFD=81, TCC=16.667%) 66512
ConfusingTernary Avoid if (x != y) ..; else ..; 117
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 158
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 191
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 212
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 255
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 309
CyclomaticComplexity The method 'verifyCoreCompatibility(Plugin)' has a cyclomatic complexity of 10. 411457

fr/paris/lutece/portal/web/system/SystemDashboardComponent.java

Rule Violation Line
ShortVariable Avoid variables with short names like t 69

fr/paris/lutece/portal/web/system/SystemJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 132
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 171
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 191
ConfusingTernary Avoid if (x != y) ..; else ..; 203219
ConfusingTernary Avoid if (x != y) ..; else ..; 211218
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 239
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 16, but has at least 55 characters appended. 312

fr/paris/lutece/portal/web/template/AutoIncludeAdminDashboardComponent.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 66

fr/paris/lutece/portal/web/upload/DosGuardFilter.java

Rule Violation Line
LooseCoupling Avoid using implementation types like 'LinkedList'; use the interface instead 73
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 143201
ImmutableField Private field '_strRemoteAddr' could be made final; it is only initialized in the declaration or constructor. 247
ImmutableField Private field '_lRequestTime' could be made final; it is only initialized in the declaration or constructor. 248

fr/paris/lutece/portal/web/upload/MultipartHttpServletRequest.java

Rule Violation Line
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 95

fr/paris/lutece/portal/web/upload/NormalizeFileItem.java

Rule Violation Line
ImmutableField Private field '_item' could be made final; it is only initialized in the declaration or constructor. 54

fr/paris/lutece/portal/web/upload/UploadFilter.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 143170

fr/paris/lutece/portal/web/upload/UploadServlet.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 77
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 85
ConfusingTernary Avoid if (x != y) ..; else ..; 97109

fr/paris/lutece/portal/web/user/AdminLoginJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34745
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 180
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 195198
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 246
CommentRequired Public method and constructor comments are required 279312
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 289
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 323
CyclomaticComplexity The method 'doLogin(HttpServletRequest)' has a cyclomatic complexity of 11. 392465
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 480
CyclomaticComplexity The method 'doResetPassword(HttpServletRequest)' has a cyclomatic complexity of 15. 526606
NPathComplexity The method 'doResetPassword(HttpServletRequest)' has an NPath complexity of 3456 526606
CommentRequired Public method and constructor comments are required 526606
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 528
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 620

fr/paris/lutece/portal/web/user/AdminUserJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 342712
ExcessiveClassLength Avoid really long classes. 1212712
CyclomaticComplexity The class 'AdminUserJspBean' has a total cyclomatic complexity of 272 (highest 11). 1212712
GodClass Possible God Class (WMC=272, ATFD=571, TCC=32.727%) 1212712
TooManyMethods This class has too many methods, consider refactoring it. 1222712
ImmutableField Private field '_bAdminAvatar' could be made final; it is only initialized in the declaration or constructor. 376
CyclomaticComplexity The method 'getManageAdminUsers(HttpServletRequest)' has a cyclomatic complexity of 10. 389488
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 399
AddEmptyString Do not add empty strings 475
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 507
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 587
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 621
ExcessiveMethodLength Avoid really long methods. 655771
CyclomaticComplexity The method 'doCreateAdminUser(HttpServletRequest)' has a cyclomatic complexity of 11. 655771
NPathComplexity The method 'doCreateAdminUser(HttpServletRequest)' has an NPath complexity of 408 655771
NcssCount The method 'doCreateAdminUser(HttpServletRequest)' has a NCSS line count of 64. 655771
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 657
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 658
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 659
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 660
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 661
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 662
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 663
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 664
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 665
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 698
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 700
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 776
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 777
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 778
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 837
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 837
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 838
CyclomaticComplexity The method 'doModifyAdminUser(HttpServletRequest)' has a cyclomatic complexity of 11. 9011005
ExcessiveMethodLength Avoid really long methods. 9011005
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 904
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 905
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 906
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 907
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 908
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 909
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 910
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1024
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1024
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1025
CyclomaticComplexity The method 'doModifyAdminUserPassword(HttpServletRequest)' has a cyclomatic complexity of 11. 10761139
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1103
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1106
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1159
CyclomaticComplexity The method 'doImportUsersFromFile(HttpServletRequest)' has a cyclomatic complexity of 11. 11861254
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1202
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1273
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1312
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1313
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1314
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1315
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1414
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1539
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1570
OptimizableToArrayCall This call to Collection.toArray() may be optimizable 1592
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1597
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1624
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1632
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1670
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1703
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1770
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1793
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 1800
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 1839
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 2000
ExcessiveMethodLength Avoid really long methods. 20202124
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 2033
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 2253
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 2321
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 2418
ConfusingTernary Avoid if (x != y) ..; else ..; 24792494
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 2510
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 2691

fr/paris/lutece/portal/web/user/UserHeaderDashboardComponent.java

Rule Violation Line
ShortVariable Avoid variables with short names like t 72

fr/paris/lutece/portal/web/user/UsersDashboardComponent.java

Rule Violation Line
ShortVariable Avoid variables with short names like t 76

fr/paris/lutece/portal/web/user/attribute/AttributeFieldJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 118
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 194
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 220
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 266
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 286
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 287
CyclomaticComplexity The method 'doMoveUpAttributeField(HttpServletRequest)' has a cyclomatic complexity of 10. 313356
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 322
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 325
ShortVariable Avoid variables with short names like it 336
CyclomaticComplexity The method 'doMoveDownAttributeField(HttpServletRequest)' has a cyclomatic complexity of 10. 367410
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 376
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 379
ShortVariable Avoid variables with short names like it 389

fr/paris/lutece/portal/web/user/attribute/AttributeJspBean.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 125
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 211
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 281
ShortVariable Avoid variables with short names like it 340
ShortVariable Avoid variables with short names like it 387

fr/paris/lutece/portal/web/util/LocalizedDelegatePaginator.java

Rule Violation Line
ImmutableField Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 58

fr/paris/lutece/portal/web/workgroup/AdminWorkgroupJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34637
AddEmptyString Do not add empty strings 219
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 242
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 262
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 310
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 329
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 394
ExcessiveMethodLength Avoid really long methods. 421523
CyclomaticComplexity The method 'getAssignUsers(HttpServletRequest)' has a cyclomatic complexity of 10. 421523
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 423
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 423
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 427
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 547556
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 635

fr/paris/lutece/portal/web/xpages/SiteMapApp.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 8790
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 222
ConfusingTernary Avoid if (x != y) ..; else ..; 224232
AvoidLiteralsInIfCondition Avoid using Literals in Conditional Statements 276

fr/paris/lutece/portal/web/xpages/SiteMapCacheService.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 5256

fr/paris/lutece/portal/web/xpages/XPageApplicationEntry.java

Rule Violation Line
ImmutableField Private field '_listRoles' could be made final; it is only initialized in the declaration or constructor. 52

fr/paris/lutece/portal/web/xsl/XslExportJspBean.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 34573
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 195
ConfusingTernary Avoid if (x != y) ..; else ..; 309326
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 351
ConfusingTernary Avoid if (x != y) ..; else ..; 413
CyclomaticComplexity The method 'getXslExportData(HttpServletRequest, XslExport)' has a cyclomatic complexity of 12. 434504
LinguisticNaming Linguistics Antipattern - The method 'isValid' indicates linguistically it returns a boolean, but it returns 'String' 513530
ShortVariable Avoid variables with short names like is 521
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 524

fr/paris/lutece/util/PropertiesService.java

Rule Violation Line
ImmutableField Private field '_strRootPath' could be made final; it is only initialized in the declaration or constructor. 56
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 58
ImmutableField Private field '_mapPropertiesFiles' could be made final; it is only initialized in the declaration or constructor. 58
FinalFieldCouldBeStatic This final field could be made static 60
FinalFieldCouldBeStatic This final field could be made static 61
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 107112
PositionLiteralsFirstInCaseInsensitiveComparisons Position literals first in String comparisons for EqualsIgnoreCase 293

fr/paris/lutece/util/ReferenceList.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 145
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 184
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 205214

fr/paris/lutece/util/UniqueIDGenerator.java

Rule Violation Line
UselessStringValueOf No need to call String.valueOf to append to a string. 66

fr/paris/lutece/util/bean/BeanUtil.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 134
ConfusingTernary Avoid if (x != y) ..; else ..; 145152
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 171
ShortVariable Avoid variables with short names like sb 190

fr/paris/lutece/util/beanvalidation/DefaultValidationErrorConfig.java

Rule Violation Line
MethodReturnsInternalArray Returning 'VARIABLES_PREFIX' may expose an internal array. 74

fr/paris/lutece/util/beanvalidation/LuteceMessageInterpolator.java

Rule Violation Line
AssignmentToNonFinalStatic Possible unsafe assignment to a non-final static field in a constructor. 52
ImmutableField Private field '_interpolator' could be made final; it is only initialized in the declaration or constructor. 53
ShortVariable Avoid variables with short names like sb 111

fr/paris/lutece/util/beanvalidation/ValidationError.java

Rule Violation Line
ImmutableField Private field '_locale' could be made final; it is only initialized in the declaration or constructor. 49
ImmutableField Private field '_constraintViolation' could be made final; it is only initialized in the declaration or constructor. 50
ImmutableField Private field '_config' could be made final; it is only initialized in the declaration or constructor. 51
ShortVariable Avoid variables with short names like cv 63

fr/paris/lutece/util/beanvalidation/ValidationErrorUtil.java

Rule Violation Line
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 103106
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 109
PositionLiteralsFirstInComparisons Position literals first in String comparisons 116
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 122
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 214217
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 220

fr/paris/lutece/util/datatable/DataTableManager.java

Rule Violation Line
GodClass Possible God Class (WMC=71, ATFD=71, TCC=15.402%) 70738
TooManyMethods This class has too many methods, consider refactoring it. 71738
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 181
ExcessiveMethodLength Avoid really long methods. 259393
NPathComplexity The method 'filterSortAndPaginate(HttpServletRequest, List)' has an NPath complexity of 14832 259393
CyclomaticComplexity The method 'filterSortAndPaginate(HttpServletRequest, List)' has a cyclomatic complexity of 24. 259393
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 329
ConfusingTernary Avoid if (x != y) ..; else ..; 371378
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 498
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 499
ConfusingTernary Avoid if (x != y) ..; else ..; 589
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 637
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 703
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 711

fr/paris/lutece/util/datatable/DataTableSort.java

Rule Violation Line
UncommentedEmptyConstructor Document empty constructor 4749

fr/paris/lutece/util/datatable/FilterPanel.java

Rule Violation Line
ImmutableField Private field '_listFilter' could be made final; it is only initialized in the declaration or constructor. 53
LooseCoupling Avoid using implementation types like 'ArrayList'; use the interface instead 53
UncommentedEmptyConstructor Document empty constructor 5860

fr/paris/lutece/util/date/DateUtil.java

Rule Violation Line
UseUnderscoresInNumericLiterals Number 86400000 should separate every third digit with an underscore 55
ConfusingTernary Avoid if (x != y) ..; else ..; 169185
ConfusingTernary Avoid if (x != y) ..; else ..; 173180
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 175
ShortVariable Avoid variables with short names like df 253
ShortVariable Avoid variables with short names like df 263
ConfusingTernary Avoid if (x != y) ..; else ..; 297313
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 303
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 332
SimpleDateFormatNeedsLocale When instantiating a SimpleDateFormat object, specify a Locale 357

fr/paris/lutece/util/env/EnvUtil.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 85
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the setMockMapEnv method if you want a default access modifier 111114
DefaultPackage Use explicit scoping instead of the default package private level 111114

fr/paris/lutece/util/file/FileUtil.java

Rule Violation Line
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 135138
AssignmentInOperand Avoid assignments in operands 180
UnnecessaryModifier Unnecessary modifier 'final' on method 'normalizeFileName': the method is already in a final class 197200
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 199

fr/paris/lutece/util/filesystem/FileListFilter.java

Rule Violation Line
ImmutableField Private field '_strName' could be made final; it is only initialized in the declaration or constructor. 44
ImmutableField Private field '_strExtension' could be made final; it is only initialized in the declaration or constructor. 45
MissingOverride The method 'accept(File, String)' is missing an @Override annotation. 6984

fr/paris/lutece/util/filesystem/FileSystemUtil.java

Rule Violation Line
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 82
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 101109
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 128
ForLoopCanBeForeach This for loop can be replaced by a foreach loop 147155
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 174

fr/paris/lutece/util/html/AbstractPaginator.java

Rule Violation Line
AddEmptyString Do not add empty strings 100
AddEmptyString Do not add empty strings 113
AddEmptyString Do not add empty strings 125
AddEmptyString Do not add empty strings 148
AddEmptyString Do not add empty strings 210
ConfusingTernary Avoid if (x != y) ..; else ..; 309
ConfusingTernary Avoid if (x != y) ..; else ..; 348362
ConfusingTernary Avoid if (x != y) ..; else ..; 354361
ConfusingTernary Avoid if (x != y) ..; else ..; 381

fr/paris/lutece/util/html/DelegatePaginator.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 6487

fr/paris/lutece/util/html/ItemNavigator.java

Rule Violation Line
ImmutableField Private field '_listItems' could be made final; it is only initialized in the declaration or constructor. 52
ImmutableField Private field '_strParameterName' could be made final; it is only initialized in the declaration or constructor. 55
CyclomaticComplexity The method 'setCurrentItemId(String)' has a cyclomatic complexity of 11. 83119

fr/paris/lutece/util/html/Paginator.java

Rule Violation Line
CallSuperInConstructor It is a good practice to call super() in a constructor 6386

fr/paris/lutece/util/http/MultipartUtil.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 123
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 124
ConfusingTernary Avoid if (x != y) ..; else ..; 184193

fr/paris/lutece/util/http/SecurityUtil.java

Rule Violation Line
TooManyMethods This class has too many methods, consider refactoring it. 56480
ShortVariable Avoid variables with short names like e 103
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 40, but has at least 44 characters appended. 215
ConfusingTernary Avoid if (x != y) ..; else ..; 216228
ConfusingTernary Avoid if (x != y) ..; else ..; 244265
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 377
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 378
ShortVariable Avoid variables with short names like sb 390
ShortVariable Avoid variables with short names like sb 416
ShortVariable Avoid variables with short names like sb 442
ShortVariable Avoid variables with short names like e 447
ShortVariable Avoid variables with short names like sb 473
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 475
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 476
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 477

fr/paris/lutece/util/jpa/JPAGenericDAO.java

Rule Violation Line
ImmutableField Private field '_entityClass' could be made final; it is only initialized in the declaration or constructor. 63
ShortVariable Avoid variables with short names like em 115
ShortVariable Avoid variables with short names like em 151
CompareObjectsWithEquals Use equals() to compare object references. 153
CompareObjectsWithEquals Use equals() to compare object references. 158
ShortVariable Avoid variables with short names like em 172
CompareObjectsWithEquals Use equals() to compare object references. 180
CompareObjectsWithEquals Use equals() to compare object references. 185
ShortVariable Avoid variables with short names like em 200
CompareObjectsWithEquals Use equals() to compare object references. 201
CompareObjectsWithEquals Use equals() to compare object references. 206

fr/paris/lutece/util/jpa/transaction/ChainedTransactionManager.java

Rule Violation Line
UnnecessaryConstructor Avoid unnecessary constructors - the compiler will generate these for you 6366
MissingOverride The method 'getTransaction(TransactionDefinition)' is missing an @Override annotation. 7197
MissingOverride The method 'commit(TransactionStatus)' is missing an @Override annotation. 103129
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 114
MissingOverride The method 'rollback(TransactionStatus)' is missing an @Override annotation. 135153
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 143

fr/paris/lutece/util/jpa/transaction/MultiTransactionStatus.java

Rule Violation Line
ImmutableField Private field '_mainPTM' could be made final; it is only initialized in the declaration or constructor. 48
MissingOverride The method 'flush()' is missing an @Override annotation. 97103
MissingOverride The method 'hasSavepoint()' is missing an @Override annotation. 119122
MissingOverride The method 'isCompleted()' is missing an @Override annotation. 128131
MissingOverride The method 'isNewTransaction()' is missing an @Override annotation. 137140
MissingOverride The method 'isRollbackOnly()' is missing an @Override annotation. 146149
MissingOverride The method 'setRollbackOnly()' is missing an @Override annotation. 155161
MissingOverride The method 'createSavepoint()' is missing an @Override annotation. 167170
MissingOverride The method 'releaseSavepoint(Object)' is missing an @Override annotation. 176182
MissingOverride The method 'rollbackToSavepoint(Object)' is missing an @Override annotation. 188194

fr/paris/lutece/util/json/AbstractJsonResponse.java

Rule Violation Line
ImmutableField Private field '_strStatus' could be made final; it is only initialized in the declaration or constructor. 48

fr/paris/lutece/util/json/ErrorJsonResponse.java

Rule Violation Line
ImmutableField Private field '_strErrorCode' could be made final; it is only initialized in the declaration or constructor. 44

fr/paris/lutece/util/json/JsonResponse.java

Rule Violation Line
ImmutableField Private field '_result' could be made final; it is only initialized in the declaration or constructor. 44

fr/paris/lutece/util/ldap/LdapUtil.java

Rule Violation Line
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 74
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 76
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 116
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 120
ShortVariable Avoid variables with short names like sc 148

fr/paris/lutece/util/mail/ByteArrayDataSource.java

Rule Violation Line
ImmutableField Private field '_type' could be made final; it is only initialized in the declaration or constructor. 59
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 80
ArrayIsStoredDirectly The user-supplied array 'data' is stored directly. 94
MissingOverride The method 'getInputStream()' is missing an @Override annotation. 109117
MissingOverride The method 'getOutputStream()' is missing an @Override annotation. 125128
MissingOverride The method 'getContentType()' is missing an @Override annotation. 134137
MissingOverride The method 'getName()' is missing an @Override annotation. 143146

fr/paris/lutece/util/mail/FileAttachment.java

Rule Violation Line
ArrayIsStoredDirectly The user-supplied array 'data' is stored directly. 60
MethodReturnsInternalArray Returning '_data' may expose an internal array. 73
ArrayIsStoredDirectly The user-supplied array 'data' is stored directly. 82

fr/paris/lutece/util/mail/HtmlDocument.java

Rule Violation Line
ImmutableField Private field '_content' could be made final; it is only initialized in the declaration or constructor. 99
ImmutableField Private field '_strBaseUrl' could be made final; it is only initialized in the declaration or constructor. 100
ImmutableField Private field '_useAbsoluteUrl' could be made final; it is only initialized in the declaration or constructor. 101
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 134
ImmutableField Private field '_strTagName' could be made final; it is only initialized in the declaration or constructor. 268
ImmutableField Private field '_strAttributeName' could be made final; it is only initialized in the declaration or constructor. 269
ImmutableField Private field '_strTestedAttributeName' could be made final; it is only initialized in the declaration or constructor. 270
ImmutableField Private field '_strTestedAttributeValue' could be made final; it is only initialized in the declaration or constructor. 271

fr/paris/lutece/util/method/MethodUtil.java

Rule Violation Line
ConfusingTernary Avoid if (x != y) ..; else ..; 94101
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 130
CyclomaticComplexity The method 'getPrimitiveMethod(String, A, Class)' has a cyclomatic complexity of 10. 161204

fr/paris/lutece/util/parser/BbcodeUtil.java

Rule Violation Line
ExcessiveMethodLength Avoid really long methods. 130274
CyclomaticComplexity The method 'processNestedTags(StringBuilder, String, String, String, String, String, String, boolean, boolean, boolean)' has a cyclomatic complexity of 21. 130274
NcssCount The method 'processNestedTags(StringBuilder, String, String, String, String, String, String, boolean, boolean, boolean)' has a NCSS line count of 73. 130274
ExcessiveParameterList Avoid long parameter lists. 130132
NPathComplexity The method 'processNestedTags(StringBuilder, String, String, String, String, String, String, boolean, boolean, boolean)' has an NPath complexity of 396 130274
UseObjectForClearerAPI Rather than using a lot of String arguments, consider using a container object for those values. 130132
UseStringBufferForStringAppends Prefer StringBuilder (non-synchronized) or StringBuffer (synchronized) over += for concatenating strings 149
ConfusingTernary Avoid if (x != y) ..; else ..; 181211
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 185
ConfusingTernary Avoid if (x != y) ..; else ..; 193211
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 199
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 199
ShortVariable Avoid variables with short names like s1 220
ShortVariable Avoid variables with short names like s2 221
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 223
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 223
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 233
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 237
ConfusingTernary Avoid if (x != y) ..; else ..; 237244
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 254
ShortVariable Avoid variables with short names like m 254
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 254
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 254
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 258
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 261
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 270
AccessorMethodGeneration Avoid autogenerated methods to access private fields and methods of inner / outer classes 270
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the MutableCharSequence nested class if you want a default access modifier 281384
UncommentedEmptyConstructor Document empty constructor 298300
ShortVariable Avoid variables with short names like sb 375

fr/paris/lutece/util/password/IPasswordFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'BEAN_NAME': the field is declared in an interface type 41

fr/paris/lutece/util/password/PasswordUtil.java

Rule Violation Line
NPathComplexity The method 'makePassword(int, boolean, boolean, boolean)' has an NPath complexity of 256 107163
ShortVariable Avoid variables with short names like r 110
ShortVariable Avoid variables with short names like c1 131
ShortVariable Avoid variables with short names like c1 137
ShortVariable Avoid variables with short names like c1 143
ShortVariable Avoid variables with short names like c1 149

fr/paris/lutece/util/pool/PoolManager.java

Rule Violation Line
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 65
ImmutableField Private field '_pools' could be made final; it is only initialized in the declaration or constructor. 65
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 9098
ShortVariable Avoid variables with short names like is 108
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 118
UseConcurrentHashMap If you run in Java5 or newer and have concurrent access, you should use the ConcurrentHashMap implementation 139
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 150
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 157
ReplaceHashtableWithMap Consider replacing this Hashtable with the newer java.util.Map 168
ShortVariable Avoid variables with short names like cs 169
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 179
ShortVariable Avoid variables with short names like cs 188
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 196
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 196
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 200
ShortVariable Avoid variables with short names like cs 237
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 248254
AddEmptyString Do not add empty strings 278
AddEmptyString Do not add empty strings 279

fr/paris/lutece/util/pool/service/C3p0ConnectionService.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 104
CollapsibleIfStatements These nested if statements could be combined 129133
AvoidDeeplyNestedIfStmts Deeply nested if..then statements are hard to read 129133
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 137
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 166

fr/paris/lutece/util/pool/service/ConnectionPool.java

Rule Violation Line
ImmutableField Private field '_strUrl' could be made final; it is only initialized in the declaration or constructor. 63
ImmutableField Private field '_strUser' could be made final; it is only initialized in the declaration or constructor. 64
ImmutableField Private field '_strPassword' could be made final; it is only initialized in the declaration or constructor. 65
ImmutableField Private field '_nMaxConns' could be made final; it is only initialized in the declaration or constructor. 66
ImmutableField Private field '_nTimeOut' could be made final; it is only initialized in the declaration or constructor. 67
ImmutableField Private field '_logger' could be made final; it is only initialized in the declaration or constructor. 68
ImmutableField Private field '_freeConnections' could be made final; it is only initialized in the declaration or constructor. 70
ImmutableField Private field '_strCheckValidConnectionSql' could be made final; it is only initialized in the declaration or constructor. 71
ConfusingTernary Avoid if (x != y) ..; else ..; 108109
ShortVariable Avoid variables with short names like lf 111
ShortVariable Avoid variables with short names like pc 129
CloseResource Ensure that resources like this Connection object are closed after use 129
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 171217
AssignmentInOperand Avoid assignments in operands 180
CloseResource Ensure that resources like this Statement object are closed after use 228
ConfusingTernary Avoid if (x != y) ..; else ..; 232242
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 254
PreserveStackTrace New exception is thrown in catch block, original stack trace may be lost 254
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 326334
AvoidSynchronizedAtMethodLevel Use block level rather than method level synchronization 339363
CloseResource Ensure that resources like this Connection object are closed after use 341
MissingOverride The method 'getParentLogger()' is missing an @Override annotation. 526529

fr/paris/lutece/util/pool/service/LuteceConnectionFactory.java

Rule Violation Line
UseProperClassLoader In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 72

fr/paris/lutece/util/pool/service/LuteceConnectionProxy.java

Rule Violation Line
ImmutableField Private field '_pool' could be made final; it is only initialized in the declaration or constructor. 58
ImmutableField Private field '_connection' could be made final; it is only initialized in the declaration or constructor. 59
CommentDefaultAccessModifier To avoid mistakes add a comment at the beginning of the LuteceConnectionProxy constructor if you want a default access modifier 6973
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 96
NullAssignment Assigning an Object to null is a code smell. Consider refactoring. 102

fr/paris/lutece/util/pool/service/LuteceConnectionService.java

Rule Violation Line
CyclomaticComplexity The method 'init(Map)' has a cyclomatic complexity of 10. 111177
NPathComplexity The method 'init(Map)' has an NPath complexity of 384 111177
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 155
AvoidCatchingNPE Avoid catching NullPointerException; consider removing the cause of the NPE. 155
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 159

fr/paris/lutece/util/pool/service/TomcatConnectionService.java

Rule Violation Line
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 74
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 96
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 115

fr/paris/lutece/util/rsa/IRSAKeyProvider.java

Rule Violation Line
CommentRequired Header comments are required 4055

fr/paris/lutece/util/rsa/RSAKeyDatastoreProvider.java

Rule Violation Line
CommentRequired Header comments are required 49106

fr/paris/lutece/util/rsa/RSAKeyEnvironmentProvider.java

Rule Violation Line
CommentRequired Header comments are required 4891
ConfusingTernary Avoid if (x != y) ..; else ..; 5870
ConfusingTernary Avoid if (x != y) ..; else ..; 7688

fr/paris/lutece/util/rsa/RSAKeyPairUtil.java

Rule Violation Line
CommentRequired Header comments are required 4399
CommentRequired Public method and constructor comments are required 5562
NonThreadSafeSingleton Singleton is not thread safe 5760

fr/paris/lutece/util/sort/AttributeComparator.java

Rule Violation Line
ImmutableField Private field '_strSortedAttribute' could be made final; it is only initialized in the declaration or constructor. 52
ImmutableField Private field '_bIsASC' could be made final; it is only initialized in the declaration or constructor. 53
ShortVariable Avoid variables with short names like o1 91
ShortVariable Avoid variables with short names like o2 91
PrematureDeclaration Avoid declaring a variable if it is unreferenced before a possible exit point. 93
ShortVariable Avoid variables with short names like o1 120
ShortVariable Avoid variables with short names like o2 120
PositionLiteralsFirstInComparisons Position literals first in String comparisons 148
UseLocaleWithCaseConversions When doing a String.toLowerCase()/toUpperCase() call, use a Locale 178
AvoidCatchingGenericException Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 186

fr/paris/lutece/util/sql/DAOUtil.java

Rule Violation Line
ExcessiveImports A high number of imports can indicate a high degree of coupling within an object. 343355
ExcessivePublicCount This class has a bunch of public methods and attributes 343355
ExcessiveClassLength Avoid really long classes. 823355
CyclomaticComplexity The class 'DAOUtil' has a total cyclomatic complexity of 429 (highest 9). 823355
TooManyMethods This class has too many methods, consider refactoring it. 833355
ImmutableField Private field '_sbLogs' could be made final; it is only initialized in the declaration or constructor. 118
AvoidStringBufferField StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time). 118
ConfusingTernary Avoid if (x != y) ..; else ..; 235260
ShortVariable Avoid variables with short names like ds 247
ConfusingTernary Avoid if (x != y) ..; else ..; 273299
ConfusingTernary Avoid if (x != y) ..; else ..; 275282
ConfusingTernary Avoid if (x != y) ..; else ..; 285299
ConfusingTernary Avoid if (x != y) ..; else ..; 287294
ConfusingTernary Avoid if (x != y) ..; else ..; 304313
ShortVariable Avoid variables with short names like e 328
InsufficientStringBufferDeclaration StringBuffer constructor is initialized with size 32, but has at least 47 characters appended. 330
ConsecutiveAppendsShouldReuse StringBuffer (or StringBuilder).append is called consecutively without reusing the target variable. 331